| Age | Commit message (Collapse) | Author |
|---|
|
Limit the number of orphan blocks in memory
|
|
|
|
In case the total number of orphan blocks in memory exceeds a limit
(currently set to 750), a random orphan block (which is not
depended on by another orphan block) is dropped. This means it will
need to be downloaded again, but it won't consume memory until then.
|
|
c117d9e Support for error messages and a few more rejection reasons (Luke Dashjr)
14e7ffc Use standard BIP 22 rejection reasons where applicable (Luke Dashjr)
|
|
c32a486 Add more data-driven tests. (Matt Corallo)
|
|
Just for completeness. Only a few messages changed or moved since last time.
Don't change any translatable messages until 0.9 final unless really necessary.
|
|
|
|
df966d1 log parameter interactions to debug.log (Philip Kaufmann)
|
|
Prepare block connection logic for headers-first
|
|
|
|
|
|
Commit a22eed6a got reverted in a RPC documentation update, redo it.
|
|
`bitcoin-qt --help` was missing a final newline.
|
|
|
|
.rc's should be linked into the executable directly,
not through a helper library.
|
|
|
|
The getaddednodeinfo RPC call, when invoked with the dns flag set to
false, returns a malformed JSON object with duplicate keys.
Change this to return an array of objects with one key as
shown in the help message.
Fixes #3581.
|
|
|
|
|
|
3cf1f43 Mention `*` value for account in documentation for `getbalance` RPC (Wladimir J. van der Laan)
|
|
- remove btc address length from address validator
- add an optional btc address check in validated line edit that defaults
to off and is used in GUIUtil::setupAddressWidget()
- an isAcceptable() check is added to validated line edit on focus out
which only kicks in, when a validator is used with that widget
- remove an isAcceptable() check from sendcoinsentry.cpp
- remove obsolete attributes from ui files, which are set by calling
GUIUtil::setupAddressWidget()
- move some more things to GUIUtil::setupAddressWidget() and remove them
from normal code e.g. placeholder text
|
|
|
|
4c0b2cd Win32: use a more modern API call in FileCommit() (Philip Kaufmann)
|
|
As reported by @Subo1978, error messages don't have a trailing newline
anymore after commit b77dfdc9. Add back this newline.
|
|
e5aadb2 Updated fallback seed nodes from sipa's DNS seeds (Gavin Andresen)
|
|
c7f9332 Add check for valid keys in `importprivkey` (Wladimir J. van der Laan)
|
|
edd735d [Qt] Fix coin control labels update (Cozz Lovan)
|
|
d7aa1ec [Qt] fix bitcoin: URI strings (spelling fixes) (Philip Kaufmann)
|
|
|
|
The base58 armoring was checked, but not the resulting private key,
which could be out of range. Fix this by adding a check.
|
|
6986861 build: use -mwindows for gui targets when linking with mingw (Cory Fields)
|
|
|
|
|
|
This changes the block processing logic from "try to atomically switch
to a new block" to a continuous "(dis)connect a block, aiming for the
assumed best chain".
This means the smallest atomic operations on the chainstate become
individual block connections or disconnections, instead of entire
reorganizations. It may mean that we try to reorganize to one block,
fail, and rereorganize again to the old block. This is slower, but
doesn't require unbounded RAM.
It also means that a ConnectBlock which fails may be no longer called
from the ProcessBlock which knows which node sent it. To deal with that,
a mapBlockSource is kept, and invalid blocks cause asynchronous "reject"
messages and banning (if necessary).
|
|
|
|
|
|
|
|
665bdd3 Fix off-by-one errors in use of IsFinalTx() (Peter Todd)
|
|
Update English .ts file from source as well as pull changes from transifex
to current translation.
|
|
f3005c8 [Qt] harmonize strings used when exporting in addressbookpage (Philip Kaufmann)
|
|
|
|
Previously CreateNewBlock() didn't take into account the fact that
IsFinalTx() without any arguments tests if the transaction is considered
final in the *current* block, when both those functions really needed to
know if the transaction would be final in the *next* block.
Additionally the UI had a similar misunderstanding.
Also adds some basic tests to check that CreateNewBlock() is in fact
mining nLockTime-using transactions correctly.
Thanks to Wladimir J. van der Laan for rebase.
|
|
|
|
Unit tests would fail if compiled with -DDEBUG_LOCKORDER (AssertLockHeld()
would fail; AssertLockHeld() relies on the DEBUG_LOCKORDER code to keep
track of locks held).
Fixed by LOCK'ing the wallet mutex in the unit tests that manipulate the
wallet.
|
|
57feb1b ui: Clarify help messages for 'message' fields (Wladimir J. van der Laan)
|
|
Add or amend tooltips to clarify what the message is for and that it
doesn't go over the network.
|
|
After the tinyformat switch sprintf() family functions support passing
actual std::string objects.
Remove unnecessary c_str calls (236 of them) in logging and formatting.
|
|
Switch to tinyformat-based formatting.
Tinyformat is a typesafe drop-in replacement for C99 printf functions:
https://github.com/c42f/tinyformat
|
|
--with-qt-libdir etc, not --with-gui-libdir.
The typo was introduced in a9dbcf036bc866c2e413b1d068541e35eafdfcd0.
|
|
Alternative implementation. Thanks to @awoland for the original.
Fixes #3486.
|
