aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2016-11-25Merge #9189: Always add default_witness_commitment with GBT client supportWladimir J. van der Laan
95f4a03 [qa] Test getblocktemplate default_witness_commitment (Suhas Daftuar) ad04d1c Always add default_witness_commitment with GBT client support (Pieter Wuille)
2016-11-24Merge #9216: Doc: Fix copypasted commentMarcoFalke
f26da35 Fix copypasted comment. (Pavel Janík)
2016-11-24Correct help output for waitfor RPC commandsfanquake
2016-11-24Merge #9190: qt: Plug many memory leaksWladimir J. van der Laan
ed998ea qt: Avoid OpenSSL certstore-related memory leak (Wladimir J. van der Laan) 5204598 qt: Avoid shutdownwindow-related memory leak (Wladimir J. van der Laan) e4f126a qt: Avoid splash-screen related memory leak (Wladimir J. van der Laan) 693384e qt: Prevent thread/memory leak on exiting RPCConsole (Wladimir J. van der Laan) 47db075 qt: Plug many memory leaks (Wladimir J. van der Laan)
2016-11-24Fix copypasted comment.Pavel Janík
2016-11-23Merge #8930: Move orphan processing to ActivateBestChainPieter Wuille
d2b88f9 Move orphan-conflict removal from main logic into a callback (Matt Corallo) 97e2802 Erase orphans per-transaction instead of per-block (Matt Corallo) ec4525c Move orphan processing to ActivateBestChain (Matt Corallo)
2016-11-23Merge #9199: Always drop the least preferred HB peer when adding a new one.Pieter Wuille
ca8549d Always drop the least preferred HB peer when adding a new one. (Gregory Maxwell)
2016-11-23Move orphan-conflict removal from main logic into a callbackMatt Corallo
This makes the orphan map a part of net-processing logic instead of main logic.
2016-11-23qt: Avoid OpenSSL certstore-related memory leakWladimir J. van der Laan
- Correctly manage the X509 and X509_STORE objects lifetime.
2016-11-23qt: Avoid shutdownwindow-related memory leakWladimir J. van der Laan
Store a reference to the shutdown window on BitcoinApplication, so that it will be deleted when exiting the main loop.
2016-11-23qt: Avoid splash-screen related memory leakWladimir J. van der Laan
Make splash screen queue its own deletion when it receives the finished command, instead of relying on WA_DeleteOnClose which doesn't work under these circumstances.
2016-11-23qt: Prevent thread/memory leak on exiting RPCConsoleWladimir J. van der Laan
Make ownership of the QThread object clear, so that the RPCConsole can wait for the executor thread to quit before shutdown is called. This increases overall thread safety, and prevents some objects from leaking on exit.
2016-11-23qt: Plug many memory leaksWladimir J. van der Laan
None of these are very serious, and are leaks in objects that are created at most one time. In most cases this means properly using the QObject parent hierarchy, except for BanTablePriv/PeerTablePriv which are not QObject, so use a std::unique_ptr instead.
2016-11-23Merge #9204: Clarify CreateTransaction error messagesWladimir J. van der Laan
918b126 fix CreateTransaction error messages (instagibbs)
2016-11-23Merge #9205: Minor change to comment for consistency.Wladimir J. van der Laan
f004e67 Minor change to comment above new NODE_WITNESS service flag to keep it consitent with existing comment structure. Helps with readability. (Greg Walker)
2016-11-23Merge #9196: Send tip change notification from invalidateblockWladimir J. van der Laan
67c6326 Send tip change notification from invalidateblock (Russell Yanofsky)
2016-11-23Merge #8690: Do not fully sort all nodes for addr relayWladimir J. van der Laan
a33b169 Do not fully sort all nodes for addr relay (Pieter Wuille)
2016-11-23Merge #9141: Remove unnecessary calls to CheckFinalTxWladimir J. van der Laan
4512550 Remove unnecessary calls to CheckFinalTx (Jonas Schnelli)
2016-11-23Merge #9142: Move -salvagewallet, -zap(wtx) to where they belongWladimir J. van der Laan
2e44893 Move -salvagewallet, -zap(wtx) to where they belong (Jonas Schnelli)
2016-11-23Merge #9025: getrawtransaction should take a bool for verboseWladimir J. van der Laan
240189b add testcases for getrawtransaction (John Newbery) ce2bb23 getrawtransaction should take a bool for verbose (jnewbery)
2016-11-22Minor change to comment above new NODE_WITNESS service flag to keep it ↵Greg Walker
consitent with existing comment structure. Helps with readability.
2016-11-22fix CreateTransaction error messagesinstagibbs
2016-11-22getrawtransaction should take a bool for verbosejnewbery
2016-11-22Merge #9130: Mention the new network toggle functionality in the tooltip.Jonas Schnelli
1260c11 Mention the new network toggle functionality in the tooltip. (Pavel Janík)
2016-11-22bench: Fix subtle counting issue when rescaling iteration countWladimir J. van der Laan
Make sure that the count is a zero modulo the new mask before scaling, otherwise the next time until a measure triggers will take only 1/2 as long as accounted for. This caused the 'min time' to be potentially off by as much as 100%.
2016-11-22Merge #9185: [Qt] fix coincontrol sort issueJonas Schnelli
4231032 [Qt] Clean up and fix coincontrol tree widget handling (Wladimir J. van der Laan) 76af4eb [Qt] fix coincontrol sort issue (Jonas Schnelli)
2016-11-22Always drop the least preferred HB peer when adding a new one.Gregory Maxwell
When a BIP152 HB-mode peer is in the least preferred position and disconnects, they will not be by ForNode on the next loop. They will continue to sit in that position and prevent deactivating HB mode for peers that are still connected. There is no reason for them to stay in the list if already gone, so drop the first element unconditionally if there are too many. Fixes issue #9163.
2016-11-21Always add default_witness_commitment with GBT client supportPieter Wuille
2016-11-21Merge #8872: Remove block-request logic from INV message processingWladimir J. van der Laan
037159c Remove block-request logic from INV message processing (Matt Corallo) 3451203 [qa] Respond to getheaders and do not assume a getdata on inv (Matt Corallo) d768f15 [qa] Make comptool push blocks instead of relying on inv-fetch (mrbandrews)
2016-11-21Merge #8837: allow bitcoin-tx to parse partial transactionsWladimir J. van der Laan
7451cf5 Allow bitcoin-tx to parse partial transactions (jnewbery)
2016-11-21Merge #9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minuteWladimir J. van der Laan
fa7cc5a Set DEFAULT_LIMITFREERELAY = 0 kB/minute (MarcoFalke)
2016-11-21Merge #9117: net: don't send feefilter messages before the version handshake ↵Wladimir J. van der Laan
is complete 4662553 net: don't send feefilter messages before the version handshake is complete (Cory Fields)
2016-11-20[Qt] Clean up and fix coincontrol tree widget handlingWladimir J. van der Laan
- Do sorting for date, amount and confirmations column as longlong, not unsigned longlong. - Use `UserRole` to store our own data. This makes it treated as ancillary data prevents it from being displayed. - Get rid of `getMappedColumn` `strPad` - these are no longer necessary. - Get rid of hidden `_INT64` columns. - Start enumeration from 0 (otherwise values are undefined).
2016-11-19Introduce convenience type CTransactionRefPieter Wuille
2016-11-19Make CBlock::vtx a vector of shared_ptr<CTransaction>Pieter Wuille
2016-11-19Add deserializing constructors to CTransaction and CMutableTransactionPieter Wuille
2016-11-19Add serialization for unique_ptr and shared_ptrPieter Wuille
2016-11-19Merge #9186: test: Fix use-after-free in scheduler testsWladimir J. van der Laan
12519bf test: Fix use-after-free in scheduler tests (Wladimir J. van der Laan)
2016-11-18test: Fix use-after-free in scheduler testsWladimir J. van der Laan
Make a copy of the boost time-point to wait for, otherwise the head of the queue may be deleted by another thread while this one is waiting, while the boost function still has a reference to it. Although this problem is in non-test code, this is not an actual problem outside of the tests because we use the thread scheduler with only one service thread, so there will never be threads fighting at the head of the queue. The old boost fallback escapes this problem because it passes a scalar value to wait_until instead of a const object reference. Found by running the tests in LLVM-4.0-master asan.
2016-11-18[Qt] fix coincontrol sort issueJonas Schnelli
2016-11-17Erase orphans per-transaction instead of per-blockMatt Corallo
2016-11-17Move orphan processing to ActivateBestChainMatt Corallo
This further decouples "main" and "net" processing logic by moving orphan processing out of the chain-connecting cs_main lock and into its own cs_main lock, beside all of the other chain callbacks. Once further decoupling of net and main processing logic occurs, orphan handing should move to its own lock, out of cs_main. Note that this will introduce a race if there are any cases where we assume the orphan map to be consistent with the current chain tip, however I am confident there is no such case (ATMP will fail without DoS score in all such cases).
2016-11-18Set DEFAULT_LIMITFREERELAY = 0 kB/minuteMarcoFalke
2016-11-17Merge #9075: Decouple peer-processing-logic from block-connection-logic (#3)Pieter Wuille
ae22357 Replace CValidationState param in ProcessNewBlock with BlockChecked (Matt Corallo) 7c98ce5 Remove pfrom parameter from ProcessNewBlock (Matt Corallo) e2e069d Revert "RPC: Give more details when "generate" fails" (Matt Corallo)
2016-11-17Merge #8838: Calculate size and weight of block correctly in CreateNewBlock()Wladimir J. van der Laan
5f274a1 log block size and weight correctly. (jnewbery)
2016-11-16Merge #9155: [trivial] update comments for tx weightMarcoFalke
07ede5d update comments for tx weight (Brian Deery)
2016-11-16Merge #9133: Unset fImporting for loading mempoolWladimir J. van der Laan
79f755d Unset fImporting for loading mempool (Alex Morcos)
2016-11-16Merge #9131: fNetworkActive is not protected by a lock, use an atomicWladimir J. van der Laan
079142b fNetworkActive is not protected by a lock, use an atomic (Jonas Schnelli)
2016-11-15Merge #9164: [trivial] credit values are CAmountPieter Wuille
20c3215 credit values are CAmount (Gregory Sanders)
2016-11-15credit values are CAmountGregory Sanders