Age | Commit message (Collapse) | Author |
|
39c77b0 Add documentation for CWalletTx::fFromMe member. (Russell Yanofsky)
|
|
6dbfe08 [qa] test signrawtransaction merge with missing inputs (Matt Corallo)
ec4f7e4 [qa] Add second input to signrawtransaction test case (Matt Corallo)
691710a [qa] Test that decoderawtransaction throws with extra data appended (Matt Corallo)
922bea9 Better handle invalid parameters to signrawtransaction (Matt Corallo)
7ea0ad5 Fail in DecodeHexTx if there is extra data at the end (Matt Corallo)
|
|
0729102 Net: pass interruptMsgProc as const where possible (Jorge Timón)
fc7f2ff Net: Make CNetMsgMaker more const (Jorge Timón)
d45955f Net: CConnman: Make some methods const (Jorge Timón)
|
|
5f62e3e Fix typos (practicalswift)
|
|
4ec057d [wallet] Set correct metadata on bumpfee wallet transactions (Russell Yanofsky)
|
|
ac719c9 Init ECC context for test_bitcoin_fuzzy. (Gregory Maxwell)
|
|
003cd60 Add missing mempool lock for CalculateMemPoolAncestors (Matt Corallo)
|
|
This avoids calling things like pubkey_parse with a null context argument.
|
|
885cfdd Fix super-unlikely race introduced in 236618061a445d2cb11e72 (Matt Corallo)
|
|
08bb6f4 net: log an error rather than asserting if send version is misused (Cory Fields)
7a8c251 net: Disallow sending messages until the version handshake is complete (Cory Fields)
12752af net: don't run callbacks on nodes that haven't completed the version handshake (Cory Fields)
2046617 net: deserialize the entire version message locally (Cory Fields)
80ff034 Dont deserialize nVersion into CNode, should fix #9212 (Matt Corallo)
|
|
This removes a "race" between Interrupt() and Run(), though it
should not effect any of our supported platforms.
|
|
Preserve comment, order form, and account strings from the original wallet
transaction. Also set fTimeReceivedIsTxTime and fFromMe fields for consistency
with CWallet::CreateTransaction. The latter two fields don't influence current
wallet behavior, but do record that the transaction originated in the wallet
instead of coming from the network or sendrawtransaction.
|
|
This silently skips trying to merge signatures from inputs which
do not exist from transactions provided to signrawtransaction,
instead of hitting an assert.
|
|
|
|
Also cleaned up the comments and moved from the header to the .cpp so that
logging headers aren't needed from net.h
|
|
This is a change in behavior, though it's much more sane now than before.
|
|
Since ForEach* are can be used to send messages to all nodes, the caller may
end up sending a message before the version handshake is complete. To limit
this, filter out these nodes. While we're at it, may as well filter out
disconnected nodes as well.
Delete unused methods rather than updating them.
|
|
This avoids having some vars set if the version negotiation fails.
Also copy it all into CNode at the same site. nVersion and
fSuccessfullyConnected are set last, as they are the gates for the other vars.
Make them atomic for that reason.
|
|
|
|
Once the CNode has been added to vNodes, it is possible that it is
disconnected+deleted in the socket handler thread. However, after
that we now call InitializeNode, which accesses the pnode.
helgrind managed to tickle this case (somehow), but I suspect it
requires in immensely braindead scheduler.
|
|
8fc6989 Remove redundant semicolons (practicalswift)
|
|
3eba88d clarify listunspent amount description (Gregory Sanders)
|
|
|
|
29fb311 Increase minimum debug.log size to 10MB after shrink. (Alex Morcos)
|
|
|
|
More accurate than simply adding one byte per input, and properly handles the
case where the original transaction happened to have very small signatures
|
|
|
|
|
|
|
|
|
|
event_set_mem_functions
95f97f4 Skip RAII event tests if libevent is built without event_set_mem_functions (Luke Dashjr)
|
|
fa5137c [doc] Remove unused clang format dev script (MarcoFalke)
|
|
|
|
b7b48c8 Refactor: Remove using namespace <xxx> from src/*.cpp. (Karl-Johan Alm)
|
|
2366180 Do not add to vNodes until fOneShot/fFeeler/fAddNode have been set (Matt Corallo)
3c37dc4 Ensure cs_vNodes is held when using the return value from FindNode (Matt Corallo)
5be0190 Delete some unused (and broken) functions in CConnman (Matt Corallo)
|
|
4b189c1 Change bumpfee result value from 'oldfee' to 'origfee'. (Alex Morcos)
0c0c63f Introduce WALLET_INCREMENTAL_RELAY_FEE (Alex Morcos)
e8021ec Use CWallet::GetMinimumFee in bumpfee (Alex Morcos)
ae9719a Refactor GetMinimumFee to give option of providing targetFee (Alex Morcos)
fe8e8ef [rpc] Add incremental relay fee to getnetworkinfo (Alex Morcos)
6b331e6 Fix to have miner test aware of new separate block min tx fee (Alex Morcos)
de6400d Fix missing use of dustRelayFee (Alex Morcos)
5b15870 Use incrementalRelayFee for BIP 125 replacement (Alex Morcos)
|
|
|
|
Also, update the clang format file to reflect the current coding
style mentioned in the developer notes.
|
|
|
|
|
|
|
|
The result value indicates the actual fee on the transaction that was replaced. But there is an error message which uses the description 'oldfee' to refer to the original fee rate applied to the new transaction's estimated max size. It was confusing that two different uses of 'oldfee' had two different numeric values.
|
|
Have wallet's default bump value be higher than the default incrementalRelayFee to future proof against changes to incremental relay fee. Only applies when not setting the fee rate directly.
|
|
Use the wallet's fee calculation logic to properly clamp fee against minimums and maximums when calculating the fee for a bumpfee transaction. Unless totalFee is explictly given, in which case, manually check against min, but do nothing to adjust given fee.
In all cases do a final check against maxTxFee (after adding any incremental amount).
|
|
|
|
de1ae32 Exclude RBF txs from fee estimation (Alex Morcos)
|
|
8ff8d21 Send final alert message to older peers after connecting. (Gregory Maxwell)
|
|
44f2baa Do not shadow local variable named `tx`. (Pavel Janík)
|
|
with bumpfee
5a00659 [wallet] Clarify getbalance help string to explain interaction with bumpfee (Russell Yanofsky)
|
|
99464bc net: Consistently use GetTimeMicros() for inactivity checks (Suhas Daftuar)
|