aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-10-30Merge pull request #3176 from Diapolo/keyGavin Andresen
fix wrong memcmp() usage in CKey::operator==
2013-10-30Merge pull request #3173 from gavinandresen/fuzzmessagesGavin Andresen
-fuzzmessagestest=N : randomly corrupt 1-of-N sent messages
2013-10-29Merge pull request #3115 from sipa/walletmainGavin Andresen
Interaction cleanups between main and wallet
2013-10-29Merge pull request #3162 from sipa/saninsertWladimir J. van der Laan
Remove redundant insert method in serialize
2013-10-29-fuzzmessagestest=N : randomly corrupt 1-of-N sent messagesGavin Andresen
I needed this to test the new "reject" p2p message, but it should be generally useful for fuzz-testing network message handling code.
2013-10-29Bug fix: CDataStream::GetAndClear() when nReadPos > 0Gavin Andresen
Changed CDataStream::GetAndClear() to use the most obvious get get and clear instead of a tricky swap(). Added a unit test for CDataStream insert/erase/GetAndClear. Note: GetAndClear() is not performance critical, it is used only by the send-a-message-to-the-network code. Bug was not noticed before now because the send-a-message code never erased from the stream.
2013-10-28fix wrong memcmp() usage in CKey::operator==Philip Kaufmann
- add a check for CKey::size() of a and b (size can be 0 or 32) - change the fixed value in memcmp() to use a.size() instead - fixes #3090
2013-10-28Generalize the remove-outputs check for fully-prunable transactions.Pieter Wuille
Instead of explicitly testing for the presence of any output, and dealing with this case specially, just interpret it as an empty CCoins. The case previously caught using the HaveCoins check, is now handled by the generic outs != outsBlock test.
2013-10-28qt: make receive coins tab look more consistent with send coins tabWladimir J. van der Laan
Use a GridLayout instead of a FormLayout. This makes the alignment of the labels consistent between the tabs.
2013-10-27Merge pull request #3164 from TheBlueMatt/masterGavin Andresen
Re-enable BitcoindComparisonTool on pull-tester
2013-10-27Merge pull request #3158 from Diapolo/guiutilWladimir J. van der Laan
GUIUtil: make getSaveFileName() use native OS path separators
2013-10-27qt: english language updateWladimir J. van der Laan
2013-10-27Merge pull request #3150 from Diapolo/miscWladimir J. van der Laan
[Qt] additional small fixes for #3099 (new receive flow)
2013-10-27Merge pull request #3151 from laanwj/2013_10_walletviewWladimir J. van der Laan
qt: clean up signal handling in walletframe/walletview
2013-10-27qt: clean up signal handling in walletframe/walletviewWladimir J. van der Laan
Use proper signals everywhere. Removes the need to store a pointer to the BitcoinGUI object in the walletview. Also removes the interdependence between setWalletModel / setBitcoinGUI.
2013-10-27Fix comparison tool by asking for blocks more aggressivelyMatt Corallo
2013-10-26[Qt] additional small fixes for #3099 (new receive flow)Philip Kaufmann
- remove 2 unneeded windowTitle attributes, which bloat our translations - cleanup some unneeded .cpp/.h includes and class usages - use a more generic string for clearing sendcoinsdialog and requestpaymentdialog - edit 2 strings in BitcoinGUI and replace "edit" with "show" as this seems more clear in the context where it is used
2013-10-26Remove redundant insert method in serialize.Pieter Wuille
This seems to cause problems on recent clang, and looks totally redundant and unused. The const_iterator version is identical to the vector::const_iterator one (which is a typedef thereof). Marking it private (instead of removing) compiles fine, so this version is effectively unused even.
2013-10-26GUIUtil: make getSaveFileName() use native OS path separatorsPhilip Kaufmann
2013-10-26Break dependency of init on wallet.Pieter Wuille
This required some code movement (what was CWalletTx::AcceptToMemoryPool doing in main?), and adding a few explicit includes that used to be implicit through init.h.
2013-10-26Use boost signals for callbacks from main to walletPieter Wuille
2013-10-26Remove broken PrintWallet functionalityPieter Wuille
2013-10-26Do not treat fFromMe transaction differently when broadcastingPieter Wuille
2013-10-26Send multiple inv messages if mempool.size > MAX_INV_SZGavin Andresen
Changes the response to the 'mempool' command so that if the memory pool has more than MAX_INV_SZ transactions (50,000) it will respond with multiple 'inv' messages.
2013-10-25Merge pull request #3144 from Diapolo/message_sendcoinsdialogWladimir J. van der Laan
allow emit message() in sendcoinsdialog and walletview
2013-10-25qt: ReceiveCoinsDialog and SendCoinsDialog should not take a gui objectWladimir J. van der Laan
They're supposed to be children of the walletview, and are added with addWidget later on. Inconsequential change because the object passed was already 0.
2013-10-25[Qt] additional small fix for #3099 (new receive flow)Philip Kaufmann
- remove an obsolete connection to a signMessage() signal
2013-10-25[Qt] misc small fixes for #3099 (new receive flow)Philip Kaufmann
- changes some strings that were forgotton or made no sense in the conext they are used - remove an orphan file from the qt project file - revert a small change in signverifymessagedialog.ui - guard #include "bitcoin-config.h" with #if defined(HAVE_CONFIG_H) - remove windowTitle from addressbookpage.ui
2013-10-25allow emit message() in sendcoinsdialog and walletviewPhilip Kaufmann
- this allows us to use emit message() over MessageBox:: or gui->message() calls in sendcoinsdialog and walletview - move main handlePaymentRequest() functionality back to BitcoinGUI - move a showNormalIfMinimized() before gotoSendCoinsPage()
2013-10-25Merge pull request #3099 from laanwj/2013_10_new_receive_flowWladimir J. van der Laan
qt: improve "receive coins" workflow
2013-10-25qt: general polish after adding new receive flowWladimir J. van der Laan
- We no longer have an address book, but "address lists", update message accordingly - Add tooltips here and there - Clarify text on buttons - add Copy Address button to receive request dialog
2013-10-25Merge pull request #3130 from Diapolo/paymentACK_via_messageWladimir J. van der Laan
Qt: move paymentACK handling to paymentserver
2013-10-24paymentserver: init all class members in constructorPhilip Kaufmann
2013-10-24Qt: move paymentACK handling to paymentserverPhilip Kaufmann
- add new slot handlePaymentACK() to paymentserver, which handles paymentACK messages (currently we just display them) - make paymentACK message a modal information dialog - change some QObject::tr() to just tr() - clarify the processPaymentRequest() error, when IsDust() - small string change to prevent a tripple + usage with QString
2013-10-24Merge pull request #3135 from Diapolo/bitcoinguiWladimir J. van der Laan
bitcoingui: show main window (if hidden) on modal messages
2013-10-24Merge pull request #3139 from Diapolo/maturityWladimir J. van der Laan
[Qt]: fix num Blocks to maturity in Tx description
2013-10-24[Qt]: fix num Blocks to maturity in Tx descriptionPhilip Kaufmann
- as we have main.h included in transactiondesc.cpp, we now also use COINBASE_MATURITY + 1 for the descriptive string - fixes #3131
2013-10-24RPC: error code changes and prevent crash with walletpassphrasePhilip Kaufmann
- fix crash with walletpassphrase by checking if RPC server is running and give a friendly error message how to fix this (fixes #3100) - add 3 new RPCErrorCodes RPC_SERVER_NOT_STARTED, RPC_NODE_ALREADY_ADDED and RCP_NODE_NOT_ADDED (I checked the source to not use a number already in use for RPC_SERVER_NOT_STARTED) - use the new codes where needed / missing - add missing use of RPC_INVALID_PARAMETER
2013-10-23bitcoingui: show main window (if hidden) on modal messagesPhilip Kaufmann
2013-10-23Add test for monetary value parsingWladimir J. van der Laan
Just-in-case sanity test for JSON spirit and AmountFromValue. Also update rpc_format_monetary_values test to use ValueFromAmount, so that ValueFromAmount is also tested.
2013-10-23Add test for monetary value formattingWladimir J. van der Laan
Tests for issue #3126. This problem pops up after upgrading json-spirit.
2013-10-23qt: show payment information in one text areaWladimir J. van der Laan
Simplifies the dialog (makes it look less crowded) as well as the code and makes it possible to copy multiple fields at once. Also format bitcoin URI as URI, add copy button for URI.
2013-10-23qt: move bitcoin URI formatting to guiutilWladimir J. van der Laan
Follow the same pattern as the parseBitcoinURI function.
2013-10-23qt: use SendCoinsRecipient for payment request informationWladimir J. van der Laan
This brings some symmetry into the design by using the same object both for incoming URIs that are parsed as for outgoing URIs that are formatted.
2013-10-23qt: add message field to SendCoinsRecipientWladimir J. van der Laan
Also update URI parsing to fill in this field. Note that the message is not currently used in any way with the client. It should be stored with the transaction.
2013-10-23qt: allow dragging, copying and saving QR codeWladimir J. van der Laan
Add context menu and drag handling to QR code widget.
2013-10-23qt: remove verify/send message and send coins from address bookWladimir J. van der Laan
These no longer make sense in the new workflow. It's less clicks to reach sign/verify message from the menu. And sending from the address book is one kind of automatic address reuse we're trying to avoid.
2013-10-23qt: rework "receive coins" workflowWladimir J. van der Laan
2013-10-22remove duplicate -rpcsslciphers help message from initPhilip Kaufmann
2013-10-22Merge pull request #3127 from jgarzik/smells-like-json-spiritJeff Garzik
Revert recent json-spirit changes