aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2018-09-17Fix crash bug with duplicate inputs within a transactionSuhas Daftuar
Introduced by #9049
2018-08-08Merge #13852: [0.16] doc: correct the help output for -pruneWladimir J. van der Laan
11b9dbb439a15ed275cba673fdc743c612ea374f -prune option -help output aligned with code (Hennadii Stepanov) Pull request description: Backports #13844 to the 0.16 branch. Tree-SHA512: 84cac57ca3b1ef34892e73f131b5f3cc50d3f9e268a4123092cf6cdf519fc20616b5b084f9e9343505c15a2cf663a2c94d18c4587bcb7c261cbe32eeac8afe9b
2018-08-08Merge #13796: [0.16] Make signrawtransaction give an error when amount is ↵Wladimir J. van der Laan
needed but missing 212ef1f9547e27295a94eaa9d5ae552d858e2d9f [tests] Check signrawtransaction* errors on missing prevtx info (Anthony Towns) 1825e37075aa7885930cb48c5452ba3e8952b78a Error on missing amount in signrawtransaction* (Anthony Towns) Pull request description: Backport of #13547 to 0.16 Tree-SHA512: 7a660023b6948632a1f949443c18fa45add75ec8c36df1ebbaccd181dd1560c1bef460f061f8dab36b6a5df295eb4967effaa2cf55ea06b41d8f7562842a39ec
2018-08-02-prune option -help output aligned with codeHennadii Stepanov
see: .../src/init.cpp#L1063 Github-Pull: #13844 Rebased-From: 312ff01
2018-07-30Merge #13797: [0.16] bitcoinconsensus: invalid flags should be set to ↵Wladimir J. van der Laan
bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes 1cdbea7f742fa128062009ea8ca22383bceacd1e bitcoinconsensus: invalid flags should be set to bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes (Thomas Kerin) Pull request description: Backport of #13655 to 0.16 Tree-SHA512: b62e185f2aa957f09255090e59f96c039f47a5623d68b6fef8d1dd831c6d3135b039be5cfad0f823687ff2a5143d24e34bd83fefcc9ba5b68f43054cbd9d909d
2018-07-29bitcoinconsensus: invalid flags should be set to bitcoinconsensus_error ↵Thomas Kerin
type, add test cases covering bitcoinconsensus error codes Github-Pull: #13655 Rebased-From: 417b6c1d2990ffc78c029442e027797d724a101f
2018-07-29Error on missing amount in signrawtransaction*Anthony Towns
Signatures using segregated witness commit to the amount being spent, so that value must be passed into signrawtransactionwithkey and signrawtransactionwithwallet. This ensures an error is issued if that doesn't happen, rather than just assuming the value is 0 and producing a signature that is almost certainly invalid. Github-Pull: #13547 Rebased-From: a3b065b51fb333d976108a1fe34b7f663fd67285
2018-07-16Fix that CWallet::AbandonTransaction would only traverse one levelBen Woosley
Prior to this change, it would mark only the first layer of child transactions abandoned, due to always following the input hashTx rather than the current now tx. Github-Pull: #13652 Rebased-From: 89e70f9d7fe384ef9de4fa3828d4c80523290186 Tree-SHA512: 403da0cc400a807e5a30038bd505881a68208c3f9e96ad5a7755e763666982bc3c19564ac13a5757612c8b6efc331fb2ad0edbaf7e830993b84bc64624423e54
2018-07-14qa: Initialize lockstack to prevent null pointer derefMarcoFalke
Github-Pull: #13300 Rebased-From: fa9da85b7cc759d06bc24854be2bad0ea87b6006
2018-07-13gui: Show messages as text not htmlWladimir J. van der Laan
Currently, error messages (such as InitError) are displayed as-is, which means Qt does auto detection on the format. This means that it's possible to inject HTML from the command line though e.g. specifying a wallet name with HTML in it. This isn't a direct security risk because fetching content from internet is disabled (and as far as I know we never report strings received from the network this way). However, it can be confusing. So explicitly force the format as text. Github-Pull: #12617 Rebased-From: 6fbc0986fa2d49a1cb65b60eca71c25c84842a54
2018-07-13[qt] send: Clear All also resets coin control optionsSjors Provoost
Github-Pull: #12432 Rebased-From: f506c0a7f8ea6bae089177884e44e38cd2bfeb23
2018-07-13Fix csBestBlock/cvBlockChange waiting in rpc/miningPieter Wuille
Github-Pull: #12743 Rebased-From: 45dd13503918e75a45ce33eb5c934b998790fdc8
2018-07-13Consensus: Fix bug when compiler do not support __builtin_clz*532479301
#ifdef is not correct since defination is defined to 0 or 1. Should change to #if Github-Pull: #12573 Rebased-From: 18307849b405f9e2067eaa8091b105838f413707
2018-07-13have verifytxoutproof check the number of txns in proof structureGregory Sanders
Github-Pull: #13452 Rebased-From: ed82f1700006830b6fe34572b66245c1487ccd29
2018-07-13wallet: Erase wtxOrderd wtx pointer on removeprunedfundsMarcoFalke
Github-Pull: #13437 Rebased-From: faa18ca046e9043b2cf68cb1bd17cc8c60fe26d9
2018-07-13Remove boost dependency (boost/assign/std/vector.hpp)practicalswift
Github-Pull: #13545 Rebased-From: 962d8eed5bdbe62b9926f01cb85bdce9d435d3d6
2018-07-13Fix incorrect testspracticalswift
Github-Pull: #13545 Rebased-From: c6fd0df4efcd9f75c43ff527fd57fe43bc47a474
2018-07-12Make tests pass after 2020Bernhard M. Wiedemann
also test that 64 bit integers are properly handled Github-Pull: #13061 Rebased-From: 3ee4be10500710fc8e9b03acf974fd81224c05c4
2018-07-12[rpcwallet] Clamp walletpassphrase value at 100M secondsSuhas Daftuar
Larger values seem to trigger a bug on macos+libevent (resulting in the rpc server stopping). Github-Pull: #12905 Rebased-From: 662d19ff7217d0e6c7975ca311933f640955a53e
2018-07-12rpc: fix type mistmatch in listreceivedbyaddressjoemphilips
Github-Pull: #12837 Rebased-From: 05c03d1249c6fe30dbfcea9f3f3a3bd02106035b
2018-07-12[trivial] Add newlines to end of log messages.John Newbery
Log messages should terminate with a '\n', or the following log will be written to the same line without a timestamp. Fix a couple of cases where the message is not terminated with a \n. Github-Pull: #12887 Rebased-From: 5b10ab0116245ee73b493e2248ad2f8bb8e34f21
2018-07-12qt: Avoid resetting on resetguisettigs=0MarcoFalke
Github-Pull: #12793 Rebased-From: 342fb8034640d4393771899dc132c9e3b170b369
2018-07-12Remove useless mapRequest tracking that just effects Qt display.Matt Corallo
I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Github-Pull: #13622 Rebased-From: beef7ec4be725beea870a2da510d2817487601ec
2018-06-26Fix parameter count check for importpubkey.Kristaps Kaupe
Github-Pull: #13507 Rebased-From: 3f72d04
2018-06-15expose CBlockIndex::nTx in getblock(header)Gregory Sanders
GitHub-Pull: #13451 Rebased-From: 86edf4a
2018-06-13Add Windows shutdown handlerChun Kuan Lee
GitHub-Pull: #13131 Rebased-From: ddebde7
2018-06-13Bugfix: Include <memory> for std::unique_ptrLuke Dashjr
GitHub-Pull: #12859 Rebased-From: a5bca13
2018-06-01qt: Periodic translations updatev0.16.1rc2Wladimir J. van der Laan
Tree-SHA512: eb84c69adcf1547f6bfcfd2d54ef7201c7147c26aa95e07a67be9ac12eeb31b173c847bd5f27b973c911c287ef3654413bdb201d70e4b9414f784e2d58a0071a
2018-05-28qt: Pre-rc1 transifex pullWladimir J. van der Laan
Tree-SHA512: 91372301f876e3813ebac68d466941ba488b8c74f7525ea9686945d50c2b2e29290c84722c96eebed40a246eca343981feaf2f51b836ba2b3923e4ddc15aef30
2018-05-28Merge #13319: [0.16.1] gui: Backport bech32 checkboxWladimir J. van der Laan
dcb13a0ab687b23465a046e35ca75a432427b833 qt: Update translations pre-rc1 (MarcoFalke) 0eda98d01b6fef1309cdaf8365b752fed39d39a5 GUI: Allow generating Bech32 addresses with a legacy-address default (Luke Dashjr) ea487f9f905b5971e686458b4687157c001b1119 GUI: Rephrase Bech32 checkbox text/tooltip (Luke Dashjr) Pull request description: Tree-SHA512: 1298fa92579bcbdc80537a3a5b2f8aae460c7ebcb46fbade4305d45c883e1717587e24711792b5f65fd25b7a5999d7b9c82e63f5b4d18240f9ec4a0041efdb9a
2018-05-24qt: Update translations pre-rc1MarcoFalke
2018-05-24GUI: Allow generating Bech32 addresses with a legacy-address defaultLuke Dashjr
Github-Pull: #13251 Rebased-From: 82dda6bed971c5638962442b4927845fe5eb6600
2018-05-24GUI: Rephrase Bech32 checkbox text/tooltipLuke Dashjr
- "Bech32" isn't very user-friendly - You don't spend from addresses Github-Pull: #13251 Rebased-From: 7ab1c6f6a736fc7762b8dd513d8634754319d227
2018-05-24Policy to reject extremely small transactionsJohnson Lau
A transaction with 1 segwit input and 1 P2WPHK output has non-witness size of 82 bytes. Anything smaller than this have unnecessary malloc overhead and are not relayed/mined. Github-Pull: #11423 Rebased-From: 7485488e907e236133a016ba7064c89bf9ab6da3
2018-05-24Add transaction tests for constant scriptCodeJohnson Lau
Tests showing that CONST_SCRIPTCODE is applied only to non-segwit transactions Github-Pull: #11423 Rebased-From: 0f8719bb035187076eeac025e2c786feb0f452d7
2018-05-24Add constant scriptCode policy in non-segwit scriptsJohnson Lau
This disables OP_CODESEPARATOR in non-segwit scripts (even in an unexecuted branch), and makes a positive FindAndDelete result invalid. This ensures that the scriptCode serialized in SignatureHash() is always the same as the script passing to the EvalScript. Github-Pull: #11423 Rebased-From: 9dabfe49c066301ef75bcfcb089fd308366127c4
2018-05-24Add unit tests for signals generated by ProcessNewBlock()Jesse Cohen
After a recent bug discovered in callback ordering in MainSignals, this test checks invariants in ordering of BlockConnected / BlockDisconnected / UpdatedChainTip signals Github-Pull: #13023 Rebased-From: dd435ad40267f5c50ff17533c696f9302829a6a6
2018-05-24Fix concurrency-related bugs in ActivateBestChainJesse Cohen
If multiple threads are invoking ActivateBestChain, it was possible to have them working towards different tips, and we could arrive at a less work tip than we should. Fix this by introducing a ChainState lock which must be held for the entire duration of ActivateBestChain to enforce exclusion in ABC. Github-Pull: #13023 Rebased-From: a3ae8e68739023e5dba9e5cb190e707ed4603316
2018-05-24Do not unlock cs_main in ABC unless we've actually made progress.Matt Corallo
Technically, some internal datastructures may be in an inconsistent state if we do this, though there are no known bugs there. Still, for future safety, its much better to only unlock cs_main if we've made progress (not just tried a reorg which may make progress). Github-Pull: #13023 Rebased-From: ecc3c4a019e6db30e208b8554b1a3658dcb9a80a
2018-05-24Bugfix: ensure consistency of m_failed_blocks after reconsiderblockSuhas Daftuar
Github-Pull: #13199 Rebased-From: 11fa6bb66e8c1562305d034903a0dc6aee6eea20
2018-05-24Merge #13253: [0.16] Further BackportsWladimir J. van der Laan
acdf4338221e35d5ec7b299bb18ccd953e28c985 Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip (Jesse Cohen) 5ff571e90c9fa71e189863e9cb21d15d5991f7da [wallet] [tests] Test disallowed multiwallet params (John Newbery) 4c14e7b67cd411b501e4a77385389da0afc9dd16 [wallet] Fix zapwallettxes/multiwallet interaction. (John Newbery) 4087dd08e7df5beedc335f4518b64eeab6a382c1 RPC Docs: gettxout*: clarify bestblock and unspent counts (David A. Harding) b8aacd660eb9460b6a86d4402d886f0bb32af2b4 [qa] Handle disconnect_node race (Suhas Daftuar) Pull request description: Backports: - #13201 [qa] Handle disconnect_node race - #13184 RPC Docs: gettxout*: clarify bestblock and unspent counts - #13030 [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. - #12988 Hold cs_main while calling UpdatedBlockTip() signal to the 0.16 branch. Tree-SHA512: 8f65002bbafaf9c436f89051b2d79bf6a668fbd07bd317c64af238ed4a7c8efe776864b739a7f2869f1e3daa16f2f4366a85f41b188f9c454879d2c7b309be50
2018-05-18wallet: Exit SyncMetaData if there are no transactions to syncWladimir J. van der Laan
Instead of crash with an assertion error, simply exit the function `SyncMetaData` if there is no metadata to sync. Fixes #13110. Github-Pull: #13265 Rebased-From: b0d2ca9fb66d793e3c0f2e6ede811f1b16c33a9f Tree-SHA512: 67e446e9ced901e37003a9661b6abea268e2ea648ac3b076d91c8d996de96bed389839a09d579a6562d930bcf501a091eb67454f474aae1174108a8650502072
2018-05-18Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTipJesse Cohen
Ensures that callbacks are invoked in the order in which the chain is updated Resolves #12978 GitHub-Pull: #12988 Rebased-From: d86edd3
2018-05-17[wallet] Fix zapwallettxes/multiwallet interaction.John Newbery
-zapwallettxes should be disallowed when starting bitcoin in multiwallet mode. GitHub-Pull: #13030 Rebased-From: 3476e3c
2018-05-17RPC Docs: gettxout*: clarify bestblock and unspent countsDavid A. Harding
GitHub-Pull: #13184 Rebased-From: f30e9be
2018-05-01Remove blockmaxsize option from init.cppfanquake
2018-04-26Default to defining endian-conversion DECLs in compat w/o configMatt Corallo
While this isn't a supported build configuration, some build systems need to build without going through our autotools steps, so defaulting to something sane may make it easier to build. Specifically, this fixes the inability to build rust-bitcoinconsensus on some non-x86 platforms. It needs to build without our autotools/configure steps to ensure correct compile args are passed from the rust build system to gcc. Converting the args from the rust build system to gcc would be a lot of unmaintainable work. GitHub-Pull: #12998 Rebased-From: 150b2f0
2018-04-26qt:Show the entire Window when double clicking on taskbarChun Kuan Lee
GitHub-Pull: #12999 Rebased-From: 67bf2aa
2018-04-26[config] Remove blockmaxsize optionJohn Newbery
The blockmaxsize option was marked as deprecated in V0.15.1, and code was added to convert provided blockmaxsize into blockmaxweight. However, this code was incorrectly implemented, and blockmaxsize was silently ignored. No users have complained about blockmaxsize being ignored, so just remove it in V0.17. GitHub-Pull: #12756 Rebased-From: 4757c04
2018-04-26Fix illegal default `addProxy` and `addrSeparateProxyTor` settings.251
GitHub-Pull: #12650 Rebased-From: 40c5886
generated by cgit v1.2.3 (git 2.26.2) at 2025-02-16 05:42:38 +0000