aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2016-12-07qt: Remove on_toggleNetworkActiveButton_clicked from RPCConsoleWladimir J. van der Laan
There is no network toggle button (anymore?) in the RPC console. Removes another warning (#9250).
2016-12-01qt: layoutAboutToChange signal is called layoutAboutToBeChangedWladimir J. van der Laan
This was misnamed, resulting in a warning message and missing functionality. I'm not sure what the change in behavior will be here, this needs testing. Also remove connection to non-existing slot "test". This was used for testing if the signal arrived. It is no longer necessary. Fixes: 2016-12-01 10:04:06 GUI: QObject::connect: No such signal PeerTableModel::layoutAboutToChange() in qt/rpcconsole.cpp:518 2016-12-01 10:04:06 GUI: QObject::connect: (receiver name: 'RPCConsole') 2016-12-01 10:04:06 GUI: QObject::connect: No such slot RPCConsole::test() in qt/rpcconsole.cpp:781 2016-12-01 10:04:06 GUI: QObject::connect: (receiver name: 'RPCConsole')
2016-11-30Merge #9226: Remove fNetworkNode and pnodeLocalHost.Pieter Wuille
bdb922b Remove pnodeLocalHost. (Gregory Maxwell) 083f203 Remove fNetworkNode. (Gregory Maxwell)
2016-11-30Merge #9244: Trivial refactor: Remove extern keyword from function declarationsPieter Wuille
446a8f9 Trivial refactor: Remove extern keyword from function declarations, as they are extern by default. (Karl-Johan Alm)
2016-11-30Merge #9010: Split up AppInit2 into multiple phases, daemonize after datadir ↵Pieter Wuille
lock errors deec83f init: Get rid of fServer flag (Wladimir J. van der Laan) 16ca0bf init: Try to aquire datadir lock before and after daemonization (Wladimir J. van der Laan) 0cc8b6b init: Split up AppInit2 into multiple phases (Wladimir J. van der Laan)
2016-11-30Merge #9234: torcontrol: Explicitly request RSA1024 private keyWladimir J. van der Laan
7d3b627 torcontrol: Explicitly request RSA1024 private key (Wladimir J. van der Laan)
2016-11-30Trivial refactor: Remove extern keyword from function declarations, as they ↵Karl-Johan Alm
are extern by default.
2016-11-29init: Get rid of fServer flagWladimir J. van der Laan
There is no need to store this flag globally, the variable is only used inside the initialization process. Thanks to Alex Morcos for the idea.
2016-11-29init: Try to aquire datadir lock before and after daemonizationWladimir J. van der Laan
Before daemonization, just probe the data directory lock and print an early error message if possible. After daemonization get the data directory lock again and hold on to it until exit This creates a slight window for a race condition to happen, however this condition is harmless: it will at most make us exit without printing a message to console. $ src/bitcoind -testnet -daemon Bitcoin server starting $ src/bitcoind -testnet -daemon Error: Cannot obtain a lock on data directory /home/orion/.bitcoin/testnet3. Bitcoin Core is probably already running.
2016-11-29init: Split up AppInit2 into multiple phasesWladimir J. van der Laan
This allows doing some of the steps before e.g. daemonization and some fater.
2016-11-29Merge #9202: bench: Add support for measuring CPU cyclesWladimir J. van der Laan
3532818 bench: Add support for measuring CPU cycles (Wladimir J. van der Laan)
2016-11-29Merge #9225: Fix some benign racesWladimir J. van der Laan
dfed983 Fix unlocked access to vNodes.size() (Matt Corallo) 3033522 Remove double brackets in addrman (Matt Corallo) dbfaade Fix AddrMan locking (Matt Corallo) 047ea10 Make fImporting an std::atomic (Matt Corallo) 42071ca Make fDisconnect an std::atomic (Matt Corallo)
2016-11-29Merge #9224: Prevent FD_SETSIZE error building on OpenBSDWladimir J. van der Laan
498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)
2016-11-29Include select.h when WIN32 is not definedIvo van der Sangen
2016-11-28torcontrol: Explicitly request RSA1024 private keyWladimir J. van der Laan
When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See #9214.
2016-11-28Fix some typosfsb4000
2016-11-27Remove pnodeLocalHost.Gregory Maxwell
Mostly a legacy of the long removed pub/sub system.
2016-11-27Remove fNetworkNode.Gregory Maxwell
Matt pointed out to me that this appeared to be doing nothing (except involving itself in data races).
2016-11-26Fix unlocked access to vNodes.size()Matt Corallo
2016-11-26Remove double brackets in addrmanMatt Corallo
2016-11-26Fix AddrMan lockingMatt Corallo
2016-11-26Make fImporting an std::atomicMatt Corallo
2016-11-25Make fDisconnect an std::atomicMatt Corallo
2016-11-25Merge #9128: net: Decouple CConnman and message serializationPieter Wuille
c7be56d net: push only raw data into CConnman (Cory Fields) 2ec935d net: add CVectorWriter and CNetMsgMaker (Cory Fields) b7695c2 net: No need to check individually for disconnection anymore (Cory Fields) fedea8a net: don't send any messages before handshake or after requested disconnect (Cory Fields) d74e352 net: Set feelers to disconnect at the end of the version message (Cory Fields)
2016-11-25net: push only raw data into CConnmanCory Fields
This fixes one of the last major layer violations in the networking stack. The network side is no longer in charge of message serialization, so it is now decoupled from Bitcoin structures. Only the header is serialized and attached to the payload.
2016-11-25net: add CVectorWriter and CNetMsgMakerCory Fields
CVectorWriter is useful for overwriting or appending an existing byte vector. CNetMsgMaker is a shortcut for creating messages on-the-fly which are suitable for pushing to CConnman.
2016-11-25net: No need to check individually for disconnection anymoreCory Fields
2016-11-25Merge #9220: Refactor: Stop using namespace std (bitcoin-cli/-tx).MarcoFalke
2f2625a Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. (Karl-Johan Alm)
2016-11-25Merge #9100: tx_valid: re-order inputs to how they are encodedMarcoFalke
5262a15 tx_valid: re-order inputs to how they are encoded (Daniel Cousens)
2016-11-25Removed using namespace std from bitcoin-cli/-tx and added std:: in ↵Karl-Johan Alm
appropriate places.
2016-11-25Merge #9189: Always add default_witness_commitment with GBT client supportWladimir J. van der Laan
95f4a03 [qa] Test getblocktemplate default_witness_commitment (Suhas Daftuar) ad04d1c Always add default_witness_commitment with GBT client support (Pieter Wuille)
2016-11-24Merge #9216: Doc: Fix copypasted commentMarcoFalke
f26da35 Fix copypasted comment. (Pavel Janík)
2016-11-24Correct help output for waitfor RPC commandsfanquake
2016-11-24Merge #9190: qt: Plug many memory leaksWladimir J. van der Laan
ed998ea qt: Avoid OpenSSL certstore-related memory leak (Wladimir J. van der Laan) 5204598 qt: Avoid shutdownwindow-related memory leak (Wladimir J. van der Laan) e4f126a qt: Avoid splash-screen related memory leak (Wladimir J. van der Laan) 693384e qt: Prevent thread/memory leak on exiting RPCConsole (Wladimir J. van der Laan) 47db075 qt: Plug many memory leaks (Wladimir J. van der Laan)
2016-11-24Fix copypasted comment.Pavel Janík
2016-11-23net: don't send any messages before handshake or after requested disconnectCory Fields
Also, send reject messages earlier in SendMessages(), so that disconnections are processed earlier. These changes combined should ensure that no message is ever sent after fDisconnect is set.
2016-11-23net: Set feelers to disconnect at the end of the version messageCory Fields
This way we're not relying on messages going out after fDisconnect has been set. This should not cause any real behavioral changes, though feelers should arguably disconnect earlier in the process. That can be addressed in a later functional change.
2016-11-23Merge #8930: Move orphan processing to ActivateBestChainPieter Wuille
d2b88f9 Move orphan-conflict removal from main logic into a callback (Matt Corallo) 97e2802 Erase orphans per-transaction instead of per-block (Matt Corallo) ec4525c Move orphan processing to ActivateBestChain (Matt Corallo)
2016-11-23Merge #9199: Always drop the least preferred HB peer when adding a new one.Pieter Wuille
ca8549d Always drop the least preferred HB peer when adding a new one. (Gregory Maxwell)
2016-11-23Move orphan-conflict removal from main logic into a callbackMatt Corallo
This makes the orphan map a part of net-processing logic instead of main logic.
2016-11-23qt: Avoid OpenSSL certstore-related memory leakWladimir J. van der Laan
- Correctly manage the X509 and X509_STORE objects lifetime.
2016-11-23qt: Avoid shutdownwindow-related memory leakWladimir J. van der Laan
Store a reference to the shutdown window on BitcoinApplication, so that it will be deleted when exiting the main loop.
2016-11-23qt: Avoid splash-screen related memory leakWladimir J. van der Laan
Make splash screen queue its own deletion when it receives the finished command, instead of relying on WA_DeleteOnClose which doesn't work under these circumstances.
2016-11-23qt: Prevent thread/memory leak on exiting RPCConsoleWladimir J. van der Laan
Make ownership of the QThread object clear, so that the RPCConsole can wait for the executor thread to quit before shutdown is called. This increases overall thread safety, and prevents some objects from leaking on exit.
2016-11-23qt: Plug many memory leaksWladimir J. van der Laan
None of these are very serious, and are leaks in objects that are created at most one time. In most cases this means properly using the QObject parent hierarchy, except for BanTablePriv/PeerTablePriv which are not QObject, so use a std::unique_ptr instead.
2016-11-23Merge #9204: Clarify CreateTransaction error messagesWladimir J. van der Laan
918b126 fix CreateTransaction error messages (instagibbs)
2016-11-23Merge #9205: Minor change to comment for consistency.Wladimir J. van der Laan
f004e67 Minor change to comment above new NODE_WITNESS service flag to keep it consitent with existing comment structure. Helps with readability. (Greg Walker)
2016-11-23Merge #9196: Send tip change notification from invalidateblockWladimir J. van der Laan
67c6326 Send tip change notification from invalidateblock (Russell Yanofsky)
2016-11-23Merge #8690: Do not fully sort all nodes for addr relayWladimir J. van der Laan
a33b169 Do not fully sort all nodes for addr relay (Pieter Wuille)
2016-11-23Merge #9141: Remove unnecessary calls to CheckFinalTxWladimir J. van der Laan
4512550 Remove unnecessary calls to CheckFinalTx (Jonas Schnelli)
generated by cgit v1.2.3 (git 2.26.2) at 2024-11-07 19:26:28 +0000