Age | Commit message (Collapse) | Author |
|
Should not be T minus, as this indicate duration to future event.
|
|
|
|
Move signature cache from CKey::Verify to CheckSig in script.cpp
|
|
Conflicts:
src/db.cpp
|
|
Prevent crashes due to missing or corrupted database records
|
|
Reorder AppInit2
|
|
|
|
In LoadExternalBlockFile(), errors are already caught... silently.
Add a warning message, even though we do not abort the program due to
load error.
|
|
Any problems seen during deserialization will throw an uncaught
exception, crashing the entire bitcoin process. Properly return an
error instead, so that we may at least log the error and gracefully
shutdown other portions of the app.
|
|
More than doubles the speed of verifying already-cached signatures
that use compressed pubkeys:
Before: ~200 microseconds
After: ~80 microseconds
(no caching at all: ~3,300 microseconds per signature)
Also encapsulates the signature cache code in a class
and fixes a signed/unsigned comparison warning.
|
|
Remove duplicate behavior on MacOSX
|
|
Dock icon on macosx already has show/hide functionality. This results in erratic behavior.
|
|
|
|
|
|
Correct debug.log output to show correct function the debug is coming from.
|
|
|
|
rather than at each include site.
Fixes #1371
|
|
Reopen log file on SIGHUP
|
|
Filter out whitespace and zero-width non-breaking spaces in address field validator
|
|
|
|
- Fixes issues with copy/pasting from web or html emails (#1325)
|
|
This reorders AppInit2 into 10 sections:
1) basic setup (OS stuff, signal handlers)
2) parameter interactions (softset)
3) interpreting options without side effects (just setting internal variables)
4) application initialization (datadir lock, daemonize, pidfile, log file)
5) network initialization (network params, proxy, binding)
6) load blockchain
7) load wallet
8) import blocks (-loadblock=)
9) load peers
10) start node/rpc threads
11) finished
This means invalid configurations will be detected as soon as possible
(in particular, before loading the block chain).
|
|
GUI: start rows in askpassphrasedialog.ui at 0 (not 1)
|
|
Satoshi's commits fdbf76d and c8ad9b8 (SVN import) removed the
DB_PRIVATE flag from the environment. In part, this enables processes
other than bitcoind to examine the active database environment.
However, this incurs a slight performance penalty versus working
entirely within application memory (DB_PRIVATE). Because bitcointools
and other direct-BDB-accessing tools are not used by the vast
majority of users, prefer to default with DB_PRIVATE with the option
of disabling it if needed via -privdb=0.
|
|
Update Header Licenses
|
|
remove strncasecmp() + strnicmp() calls use boost::algorithm::istarts_with()
|
|
|
|
|
|
- No longer invalidates selection model, thus retains selection on address book changes
- Fixes selection of new address when added
|
|
- Signals now go directly from the core to WalletModel/ClientModel.
- WalletModel subscribes to signals on CWallet: Prepares for multi-wallet support, by no longer assuming an implicit global wallet.
- Gets rid of noui.cpp, the few lines that were left are merged into init.cpp
- Rename wxXXX message flags to MF_XXX, to make them UI indifferent.
- ThreadSafeMessageBox no longer returns the value `4` which was never used, converted to void.
|
|
Gets rid of `MainFrameRepaint` in favor of specific update functions that tell the UI exactly what changed.
This improves the efficiency of various handlers. Also fixes problems with mined transactions not showing up until restart.
The following notifications were added:
- `NotifyBlocksChanged`: Block chain changed
- `NotifyKeyStoreStatusChanged`: Wallet status (encrypted, locked) changed.
- `NotifyAddressBookChanged`: Address book entry changed.
- `NotifyTransactionChanged`: Wallet transaction added, removed or updated.
- `NotifyNumConnectionsChanged`: Number of connections changed.
- `NotifyAlertChanged`: New, updated or cancelled alert. As this finally makes it possible for the UI to know when a new alert arrived, it can be shown as OS notification.
These notifications could also be useful for RPC clients. However, currently, they are ignored in bitcoind (in noui.cpp).
Also brings back polling with timer for numBlocks in ClientModel. This value updates so frequently during initial download that the number of signals clogs the UI thread and causes heavy CPU usage. And after initial block download, the value changes so rarely that a delay of half a second until the UI updates is unnoticable.
|
|
translation updates / string updates
|
|
GUI: add an icon for Debug logfile -> Open in the RPC console
|
|
Get rid of snprintf (except one) with fixed buffers, shorten code
|
|
|
|
|
|
|
|
|
|
Cleans up and organizes several scattered functions and variables related to
the BDB env. Class CDBInit() existed to provide a
guaranteed-via-C++-destructor cleanup of the db environment.
A formal CDBEnv class provides all of this inside a single wrapper.
|
|
If Reorganize() fails, then its caller, CBlock::SetBestChain(),
will call TxnAbort().
Redundant TxnAbort() calls are harmless. The second will return an
error return value, with no other side effects. TxnAbort() return
values are generally never checked. The impact is nil.
|
|
boost::algorithm::istarts_with() / do not call ipcInit() on Mac and Windows as this is unneeded currently
|
|
Default to DB_TXN_WRITE_NOSYNC for all transactional operations
|
|
Shared code for wallet lock help and check
|
|
make CheckDiskSpace() use 50 * 1024 * 1024 Bytes
|
|
change strings to Bitcoin (uppercase), where it is used as a noun and up...
|
|
Replace debug window icon with LGPL-licensed one (fixes #1348)
|
|
|
|
* This is safer than DB_TXN_NOSYNC, and does not appear to impact
performance.
* Applying this to the dbenv is necessary to avoid many fdatasync(2)
calls on db 5.x
* We carefully and thoroughly flush databases upon shutdown and
other important events already.
|
|
|
|
The best log rotation method formerly available was to configure
logrotate with the copytruncate option. As described in the logrotate
documentation, "there is a very small time slice between copying the
file and truncating it, so some logging data might be lost".
By sending SIGHUP to the server process, one can now reopen the debug
log file without losing any data.
|