aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2016-12-07qt: Remove on_toggleNetworkActiveButton_clicked from RPCConsoleWladimir J. van der Laan
There is no network toggle button (anymore?) in the RPC console. Removes another warning (#9250).
2016-12-06Merge #9268: Fix rounding privacy leak introduced in #9260Pieter Wuille
9b9324e Fix rounding privacy leak introduced in #9260 (Matt Corallo)
2016-12-06Fix missed change to WalletTx structureAlex Morcos
2016-12-06[Wallet] Bugfix: FRT: don't terminate when keypool is emptyJonas Schnelli
2016-12-06Merge #9280: [Qt] Show ModalOverlay by pressing the progress bar, allow hidingJonas Schnelli
89a3723 [Qt] Show ModalOverlay by pressing the progress bar, disabled show() in sync mode (Jonas Schnelli)
2016-12-06Make RelayWalletTransaction attempt to AcceptToMemoryPool.Gregory Maxwell
This resolves an issue where a wallet transaction which failed to relay previously because it couldn't make it into the mempool will not try again until restart, even though mempool conditions may have changed. Abandoned and known-conflicted transactions are skipped. Some concern was expressed that there may be users with many unknown conflicts would waste a lot of CPU time trying to add them to their memory pools over and over again. But I am doubtful these users exist in any number, if they do exist they have worse problems, and they can mitigate any performance issue this might have by abandoning the transactions in question.
2016-12-05Complain when unknown rpcserialversion is specifiedPieter Wuille
2016-12-05Remove mapOrphanTransactionsByPrev from DoS_testsPieter Wuille
This is another violation of the one definition rule, as the type for mapOrphanTransactionsByPrev did not match the one in net_processing.cpp anymore. As it now depends on a custom Iterator, it seems too much hassle to correctly expose it to the tests. Instead, this commit just removes the one test it was referenced in.
2016-12-05[test] Add CCoinsViewCache Access/Modify/Write testsRussell Yanofsky
Add more comprehensive unit tests for CCoinsViewCache. Right now it is hard to refactor caching code or fix bugs in the caching logic because you have to try to mentally enumerate all the different states the cache might be in to make sure a change doesn't cause unintended consequences. The new tests explicitly enumerate relevant cache states, documenting and verifying the behavior in each state, so it will be safer and easier to make changes to the caching code in the future.
2016-12-05remove internal tracking of mempool conflicts for reporting to walletAlex Morcos
2016-12-05remove external usage of mempool conflict trackingAlex Morcos
2016-12-05[Qt] Show ModalOverlay by pressing the progress bar, disabled show() in sync ↵Jonas Schnelli
mode
2016-12-05Adapt ZMQ/rest serialization to take rpcserialversion arginstagibbs
2016-12-05Add option to return non-segwit serialization via rpcGregory Sanders
2016-12-05Merge #9282: CMutableTransaction is defined as structWladimir J. van der Laan
c4b6fa8 CMutableTransaction is defined as struct. (Pavel Janík)
2016-12-05Merge #9165: SendMoney: use already-calculated balanceWladimir J. van der Laan
ea83d00 SendMoney: use already-calculated balance (instagibbs)
2016-12-05CMutableTransaction is defined as struct.Pavel Janík
2016-12-05Merge #9269: Align struct COrphan definitionWladimir J. van der Laan
2efc438 Align struct COrphan definition (Pieter Wuille)
2016-12-05Merge #8613: LevelDB 1.19Wladimir J. van der Laan
634ad51 Squashed 'src/leveldb/' changes from 20ca81f..a31c8aa (Pieter Wuille)
2016-12-05Align struct COrphan definitionPieter Wuille
2016-12-04Move CTxInWitness inside CTxInPieter Wuille
2016-12-05Merge #9014: Fix block-connection performance regressionWladimir J. van der Laan
dd0df81 Document ConnectBlock connectTrace postconditions (Matt Corallo) 2d6e561 Switch pblock in ProcessNewBlock to a shared_ptr (Matt Corallo) 2736c44 Make the optional pblock in ActivateBestChain a shared_ptr (Matt Corallo) ae4db44 Create a shared_ptr for the block we're connecting in ActivateBCS (Matt Corallo) fd9d890 Keep blocks as shared_ptrs, instead of copying txn in ConnectTip (Matt Corallo) 6fdd43b Add struct to track block-connect-time-generated info for callbacks (Matt Corallo)
2016-12-05Merge #8580: Make CTransaction actually immutableWladimir J. van der Laan
81e3228 Make CTransaction actually immutable (Pieter Wuille) 42fd8de Make DecodeHexTx return a CMutableTransaction (Pieter Wuille) c3f5673 Make CWalletTx store a CTransactionRef instead of inheriting (Pieter Wuille) a188353 Switch GetTransaction to returning a CTransactionRef (Pieter Wuille)
2016-12-04Merge #9218: qt: Show progress overlay when clicking spinner iconJonas Schnelli
042f9fa qt: Show progress overlay when clicking spinner icon (Wladimir J. van der Laan) 827d9a3 qt: Replace NetworkToggleStatusBarControl with generic ClickableLabel (Wladimir J. van der Laan)
2016-12-04Remove unused CDiskBlockPos* argument from ProcessNewBlockMatt Corallo
2016-12-04Document ConnectBlock connectTrace postconditionsMatt Corallo
2016-12-04Switch pblock in ProcessNewBlock to a shared_ptrMatt Corallo
This (finally) fixes a performance regression in b3b3c2a5623d5c942d2b3565cc2d833c65105555
2016-12-04Make the optional pblock in ActivateBestChain a shared_ptrMatt Corallo
2016-12-04Create a shared_ptr for the block we're connecting in ActivateBCSMatt Corallo
2016-12-04Keep blocks as shared_ptrs, instead of copying txn in ConnectTipMatt Corallo
2016-12-04Add struct to track block-connect-time-generated info for callbacksMatt Corallo
2016-12-03Add unstored orphans with rejected parents to recentRejectsAlex Morcos
2016-12-03Move GetWarnings() into its own file.Gregory Maxwell
2016-12-03Eliminate data races for strMiscWarning and fLargeWork*Found.Gregory Maxwell
This moves all access to these datastructures through accessor functions and protects them with a lock.
2016-12-03Make QT runawayException call GetWarnings instead of directly access ↵Gregory Maxwell
strMiscWarning. This is a first step in avoiding racy accesses to strMiscWarning. The change required moving GetWarnings and related globals to util.
2016-12-02Fix rounding privacy leak introduced in #9260Matt Corallo
2016-12-02Make CTransaction actually immutablePieter Wuille
2016-12-02Make DecodeHexTx return a CMutableTransactionPieter Wuille
2016-12-02Make CWalletTx store a CTransactionRef instead of inheritingPieter Wuille
2016-12-02Switch GetTransaction to returning a CTransactionRefPieter Wuille
2016-12-02Merge #9260: Mrs Peacock in The Library with The Candlestick (killed ↵Pieter Wuille
main.{h,cpp}) 76faa3c Rename the remaining main.{h,cpp} to validation.{h,cpp} (Matt Corallo) e736772 Move network-msg-processing code out of main to its own file (Matt Corallo) 87c35f5 Remove orphan state wipe from UnloadBlockIndex. (Matt Corallo)
2016-12-02Merge #9251: Improvement of documentation of command line parameter 'whitelist'MarcoFalke
8a70a9d Improvement of documentation of command line parameter 'whitelist' (wodry)
2016-12-02Rename the remaining main.{h,cpp} to validation.{h,cpp}Matt Corallo
2016-12-02Move network-msg-processing code out of main to its own fileMatt Corallo
2016-12-02Merge #9223: unification of Bloom filter representationMarcoFalke
b7aa290 unification of Bloom filter representation (S. Matthew English)
2016-12-02Bugfix: Qt/RPCConsole: Put column enum in the right placesLuke Dashjr
QModelIndex::data argument is a role, not a column
2016-12-02bitcoin-cli: Make error message less confusingWladimir J. van der Laan
Sorry for the churn on this, but the current message (introduced in #9073) isn't acceptable: $ src/bitcoin-cli getinfo rpc: couldn't connect to server (make sure server is running and you are connecting to the correct RPC port: -1 unknown) Putting the error code after the words "RPC port" made me wonder whether there was a port configuration issue. This changes it to: $ src/bitcoin-cli getinfo error: couldn't connect to server: unknown (code -1) (make sure server is running and you are connecting to the correct RPC port)
2016-12-02Merge #9239: Disable fee estimates for 1 block targetWladimir J. van der Laan
e878689 Make GUI incapable of setting tx confirm target of 1 (Alex Morcos) d824ad0 Disable fee estimates for a confirm target of 1 block (Alex Morcos)
2016-12-02Merge #9229: Remove calls to getaddrinfo_aWladimir J. van der Laan
10ae7a7 Revert "Use async name resolving to improve net thread responsiveness" (Matt Corallo)
2016-12-01Merge in LevelDB 1.19 changesPieter Wuille