aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2016-05-04util: switch LogPrint and error to variadic templatesWladimir J. van der Laan
2016-05-04tinyformat: force USE_VARIADIC_TEMPLATESWladimir J. van der Laan
Now that we started using c++11, force use of variadic templates. The autodetection may be wonky on some compilers, see discussion [here](https://github.com/bitcoin/bitcoin/pull/7982#issuecomment-216222357) and is unnecessary for us anyhow.
2016-05-04Merge #7982: build: No need to check for leveldb atomicsWladimir J. van der Laan
de98290 build: No need to check for leveldb atomics (Cory Fields)
2016-05-02bitcoin-cli.cpp: Use symbolic constant for exit codePuru
2016-05-02Merge #7959: fix race that could fail to persist a banWladimir J. van der Laan
f4ac02e fix race that could fail to persist a ban (Kaz Wesley)
2016-05-02Merge #7964: Minor changes for c++11 consistencyWladimir J. van der Laan
07e4edb auto_ptr → unique_ptr (Wladimir J. van der Laan) 073225c chain: define enum used as bit field as uint32_t (Wladimir J. van der Laan)
2016-04-30build: No need to check for leveldb atomicsCory Fields
They're guaranteed with c++11
2016-04-30Remove obsolete reference to CValidationState from UpdateCoins.21E14
2016-04-30[trivial] Add missing const qualifiers.Daniel Kraft
Add some const qualifiers to references that are not modified and should be marked as const.
2016-04-29More comments on the design of AttemptToEvictConnection.Gregory Maxwell
Some developers clearly don't get this and have been posting "improvements" that create clear vulnerabilities. It should have been better explained in the code, since the design is somewhat subtle and getting it right is important.
2016-04-29Merge #7807: Fixed miner test values, gave constants for less error-prone ↵MarcoFalke
values. f8536a6 Corrected values (instagibbs) 617deeb Gave miner test values constants for less error-prone values. (instagibbs)
2016-04-28[RPC] add feerate option to fundrawtransactionJonas Schnelli
2016-04-28Merge #7962: CalculateNextWorkRequired CleanupWladimir J. van der Laan
c7aac2d Deprecating the remaining LogPrintf dependencies that were made obsolete in PR #7459. (21E14)
2016-04-28More efficient bitsliced rolling Bloom filterPieter Wuille
This patch changes the implementation from one that stores 16 2-bit integers in one uint32_t's, to one that stores the first bit of 64 2-bit integers in one uint64_t and the second bit in another. This allows for 450x faster refreshing and 2.2x faster average speed.
2016-04-28Benchmark rolling bloom filterPieter Wuille
2016-04-28Merge #7926: [RPC] push back getaddednodeinfo dead valueWladimir J. van der Laan
9c0bcb6 push back getaddednodeinfo dead value (instagibbs)
2016-04-28Merge #7952: Log invalid block hash to make debugging easier.Wladimir J. van der Laan
61c0170 Log invalid block hash to make debugging easier. (Pavel Janík)
2016-04-28auto_ptr → unique_ptrWladimir J. van der Laan
Change the few occurrences of the deprecated `auto_ptr` to c++11 `unique_ptr`. Silences the deprecation warnings. Also add a missing `std::` for consistency.
2016-04-28chain: define enum used as bit field as uint32_tWladimir J. van der Laan
Bitwise logic combined with `<` with undefined signedness will potentially results in undefined behavior. Fix this by defining the type as a c++11 typed enum. Fixes #6017.
2016-04-28Merge #7514: Fix IsInitialBlockDownload for testnetWladimir J. van der Laan
8aa7226 Fix IsInitialBlockDownload to play nice with testnet (jmacwhyte)
2016-04-28Merge #7939: qt: Make it possible to show details for multiple transactionsWladimir J. van der Laan
f135e3c qt: Add transaction hash to details window title (Wladimir J. van der Laan) 17a6a21 qt: Make it possible to show details for multiple transactions (Wladimir J. van der Laan)
2016-04-27Deprecating the remaining LogPrintf dependencies that were made obsolete in ↵21E14
PR #7459.
2016-04-27fix race that could fail to persist a banKaz Wesley
DumpBanList currently does this: - with lock: take a copy of the banmap - perform I/O (write out the banmap) - with lock: mark the banmap non-dirty If a new ban is added during the I/O operation, it may never be persisted to disk. Reorder operations so that the data to be persisted cannot be older than the time at which the banmap was marked non-dirty.
2016-04-27Remove useless argument to AlertNotify.Pavel Janík
It is always 'true', so useless.
2016-04-27Only use AddInventoryKnown for transactionsSuhas Daftuar
filterInventoryKnown is only used when relaying transactions, so stop adding block hashes to the filter.
2016-04-27[bitcoin-tx] allow to set nSequence number over the in= commandJonas Schnelli
2016-04-27[RPC] createrawtransaction: add option to set the sequence number per inputJonas Schnelli
2016-04-27Create signmessagewithprivkey rpcAndrew
New rpc 'signmessagewithprivkey' which takes a private key to sign a message without using the wallet.
2016-04-27test: Add more thorough test for dbwrapper iteratorsWladimir J. van der Laan
I made a silly mistake in a database wrapper where keys were sorted by char instead of uint8_t. As x86 char is signed the sorting for the block index database was messed up, resulting in a segfault due to missing records. Add a test to catch: - Wrong sorting - Seeking errors - Iteration result not complete
2016-04-27chain: Add assertion in case of missing records in index dbWladimir J. van der Laan
2016-04-26Log invalid block hash to make debugging easier.Pavel Janík
2016-04-26qt: Add transaction hash to details window titleWladimir J. van der Laan
2016-04-26Merge #7933: Fix OOM when deserializing UTXO entries with invalid lengthWladimir J. van der Laan
1e44169 Add tests for CCoins deserialization (Pieter Wuille) 5d0434d Fix OOM bug: UTXO entries with invalid script length (Pieter Wuille) 4bf631e CDataStream::ignore Throw exception instead of assert on negative nSize. (Patrick Strateman) 4f87af6 Treat overly long scriptPubKeys as unspendable (Pieter Wuille) f8e6fb1 Introduce constant for maximum CScript length (Pieter Wuille)
2016-04-25lock cs_main for chainActiveKaz Wesley
ActivateBestChain uses chainActive after releasing the lock; reorder operations to move all access to synchronized object into existing LOCK(cs_main) block.
2016-04-25lock cs_main for State/MisbehavingKaz Wesley
ProcessMessage calls State(...) and Misbehaving(...) without holding the required lock; add LOCK(cs_main) blocks.
2016-04-25Fixing comment in script_test.json test caseChris Stewart
2016-04-25qt: Make it possible to show details for multiple transactionsWladimir J. van der Laan
A small GUI annoyance for me has always been that it's impossible to have multiple transaction detail windows open, for example to compare transactions. This patch makes the window non-modal so that it is possible to open transaction details at will.
2016-04-25Merge #7688: List solvability in listunspent output and improve helpWladimir J. van der Laan
c3932b3 List solvability in listunspent output and improve help (Pieter Wuille)
2016-04-25Add tests for CCoins deserializationPieter Wuille
2016-04-25Fix OOM bug: UTXO entries with invalid script lengthPieter Wuille
2016-04-25CDataStream::ignore Throw exception instead of assert on negative nSize.Patrick Strateman
Previously disk corruption would cause an assert instead of an exception.
2016-04-25Treat overly long scriptPubKeys as unspendablePieter Wuille
2016-04-25Introduce constant for maximum CScript lengthPieter Wuille
2016-04-25Merge #7927: Minor changes to dbwrapper to simplify support for other databasesWladimir J. van der Laan
869cf12 dbwrapper: Move `HandleError` to `dbwrapper_private` (Wladimir J. van der Laan) b69836d dbwrapper: Pass parent CDBWrapper into CDBBatch and CDBIterator (Wladimir J. van der Laan) 878bf48 dbwrapper: Remove CDBWrapper::GetObfuscateKeyHex (Wladimir J. van der Laan) 74f7b12 dbwrapper: Remove throw keywords in function signatures (Wladimir J. van der Laan)
2016-04-24CAddrMan::Deserialize handle corrupt serializations better.Patrick Strateman
2016-04-23dbwrapper: Move `HandleError` to `dbwrapper_private`Wladimir J. van der Laan
HandleError is implementation-specific.
2016-04-23dbwrapper: Pass parent CDBWrapper into CDBBatch and CDBIteratorWladimir J. van der Laan
Pass parent wrapper directly instead of obfuscation key. This makes it possible for other databases which re-use this code to use other properties from the database. Add a namespace dbwrapper_private for private functions to be used only in dbwrapper.h/cpp and dbwrapper_tests.
2016-04-23dbwrapper: Remove CDBWrapper::GetObfuscateKeyHexWladimir J. van der Laan
It is an unnecessary method as it is used only two times and only internally, and the whole implementation is HexStr(obfuscate_key).
2016-04-23dbwrapper: Remove throw keywords in function signaturesWladimir J. van der Laan
Using throw() specifications in function signatures is not only not required in C++, it is considered deprecated for [various reasons](https://stackoverflow.com/questions/1055387/throw-keyword-in-functions-signature). It is not implemented by any of the common C++ compilers. The usage is also inconsistent with the rest of the source code.
2016-04-22push back getaddednodeinfo dead valueinstagibbs