aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2014-09-25script: don't read past the endCory Fields
2014-09-25tests: don't split an empty stringCory Fields
2014-09-25Merge pull request #4969Wladimir J. van der Laan
cda45b5 Reinitializing list's begin iterator after few elements were erased from the head (ENikS)
2014-09-25Fixing C4146 warningENikS
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
2014-09-25minor variable init changes in init.cppPhilip Kaufmann
- explicit init of pcoinsdbview and pwalletMain (even if not needed, as globals are init to NULL, it seems cleaner) - remove check if (pwalletMain) in Shutdown() as delete is valid even if pwalletMain is NULL
2014-09-25SanitizeString: allow '(' and ')'Wladimir J. van der Laan
'(' and ')' are valid in user agent strings, so should be reported as such in RPC `getpeerinfo`. Fixes #4537.
2014-09-25Merge pull request #4968Wladimir J. van der Laan
219372f script: Fix reference into empty vector run time exception (ENikS)
2014-09-25script: Fix reference into empty vector run time exceptionENikS
Edit by laanwj: `begin_ptr(sourcedata) + sourcedata.size()` -> `end_ptr(sourcedata)`
2014-09-25Merge pull request #4959Wladimir J. van der Laan
bb26e2c [Qt] minor changes in splashscreen.cpp (Philip Kaufmann)
2014-09-25Merge pull request #4967Wladimir J. van der Laan
459a2d2 Avoiding referencing elements of an empty vector (ENikS)
2014-09-25Merge pull request #4782Wladimir J. van der Laan
2e5361b remove code below asserts in limitedmap.h (fixes a ToDo) (Philip Kaufmann)
2014-09-25Merge pull request #4966Wladimir J. van der Laan
c8063b5 Fixing out of bounds asses error (ENikS)
2014-09-25RPC getnetworkinfo: export local node's client sub-version stringJeff Garzik
2014-09-25[Qt] add more NULL pointer checks in bitcoinguiPhilip Kaufmann
- add missing checks for clientModel and optionsModel - small cleanups for an #ifdef on Mac - remove an unneeded else
2014-09-25Apply clang-format on crypto/* and compat/*Pieter Wuille
2014-09-24Do merkle root and txid duplicates check simultaneouslyPieter Wuille
Move the txid duplicates check into BuildMerkleTree, where it can be done much more efficiently (without needing to build a full txid set to detect duplicates). The previous version (using the std::set<uint256> to detect duplicates) was also slightly too weak. A block mined with actual duplicate transactions (which is invalid, due to the inputs of the duplicated transactions being seen as double spends) would trigger the duplicates logic, resulting in the block not being stored on disk, and rerequested. This change fixes that by only triggering in the case of duplicated transactions that can actually result in an identical merkle root.
2014-09-24Get rid of the dummy CCoinsViewCache constructor argPieter Wuille
2014-09-23Reinitializing list's begin iterator after few elements were erased from the ↵ENikS
head
2014-09-23Add coins_tests with a large randomized CCoinViewCache test.Pieter Wuille
2014-09-23Do not keep fully spent but unwritten CCoins entries cached.Pieter Wuille
Instead of storing CCoins entries directly in CCoinsMap, store a CCoinsCacheEntry which additionally keeps track of whether a particular entry is: * dirty: potentially different from its parent view. * fresh: the parent view is known to not have a non-pruned version. This allows us to skip non-dirty cache entries when pushing batches of changes up, and to remove CCoins entries about transactions that are fully spent before the parent cache learns about them.
2014-09-23Get rid of CCoinsView's SetCoins and SetBestBlock.Pieter Wuille
All direct modifications are now done through ModifyCoins, and BatchWrite is used for pushing batches of queued modifications up, so we don't need the low-level SetCoins and SetBestBlock anymore in the top-level CCoinsView class.
2014-09-23Use ModifyCoins instead of mutable GetCoins.Pieter Wuille
Replace the mutable non-copying GetCoins method with a ModifyCoins, which returns an encapsulated iterator, so we can keep track of concurrent modifications (as iterators can be invalidated by those) and run cleanup code after a modification is finished. This also removes the overloading of the 'GetCoins' name.
2014-09-23Merge pull request #4955Pieter Wuille
87314c1 Fixing improper input syntax and failing bounds check (ENikS)
2014-09-23Avoiding referencing elements of an empty vectorENikS
2014-09-23Fixing out of bounds asses errorENikS
2014-09-23Merge pull request #4949Wladimir J. van der Laan
c8589bf Add actual signature tests (Pieter Wuille) 76ec867 Use actually valid transactions for script tests (Pieter Wuille)
2014-09-23Fixing out of bounds error in GetKey()ENikS
2014-09-23[Qt] minor changes in splashscreen.cppPhilip Kaufmann
- guard an unused variable with Q_UNUSED() macro - remove a commented out line of code
2014-09-22Add actual signature testsPieter Wuille
2014-09-22Use actually valid transactions for script testsPieter Wuille
2014-09-22Merge pull request #4787Wladimir J. van der Laan
4b0deb3 Clean up CMerkleTx::SetMerkleBranch. (Daniel Kraft)
2014-09-22Merge pull request #4852Wladimir J. van der Laan
5e83bc4 [Qt] include and file header cleanup (Philip Kaufmann)
2014-09-22Merge pull request #4947Wladimir J. van der Laan
6134b43 Fixing condition 'sabotaging' MSVC build (ENikS)
2014-09-22Merge pull request #4951Wladimir J. van der Laan
d6712db Also create pid file in non-daemon mode (Wladimir J. van der Laan)
2014-09-22qt: Make splash and shutdown window ignore close eventsWladimir J. van der Laan
It's strange to be able to close these windows while there is work in progress. Also set Qt::WA_DeleteOnClose on both windows to make sure that they are deleted eventually, no matter what happens.
2014-09-22remove code below asserts in limitedmap.h (fixes a ToDo)Philip Kaufmann
2014-09-22Merge pull request #4941Wladimir J. van der Laan
a49f11d qt: Change splash screen to normal window (Wladimir J. van der Laan)
2014-09-22Merge pull request #4952Wladimir J. van der Laan
01c2807 Add warning about the merkle-tree algorithm duplicate txid flaw (Peter Todd)
2014-09-21Fixing improper input syntax and failing bounds checkENikS
2014-09-21Merge pull request #4950Wladimir J. van der Laan
33a2771 test: Fix DoS tests after c74332c (Wladimir J. van der Laan)
2014-09-21Remove CBaseChainParams::NetworkID()jtimon
2014-09-21Reserve only one network specific cached path per sessionjtimon
2014-09-21Merge pull request #4933Pieter Wuille
20e01b1 Apply clang-format on some infrequently-updated files (Pieter Wuille)
2014-09-20Add warning about the merkle-tree algorithm duplicate txid flawPeter Todd
Lots of people read the Bitcoin Core codebase to learn more about crypto; better to warn about flaws explicitly so they don't blindly copy the code for other uses and create broken systems.
2014-09-20Also create pid file in non-daemon modeWladimir J. van der Laan
Always make a pid file, not only when `-daemon` specified. This is useful for troubleshooting, for attaching debuggers and loggers and such. - Write the pid file only after the datadir lock was acquired - Don't create or remove a pid file on WIN32, and also don't show the option
2014-09-20test: Fix DoS tests after c74332cWladimir J. van der Laan
Fix data structure mismatch ... The mind boggles that they were still passing at all.
2014-09-20Merge pull request #4835Pieter Wuille
ab15b2e Avoid copying undo data (Pieter Wuille)
2014-09-19Fixing condition 'sabotaging' MSVC buildENikS
2014-09-19Apply clang-format on some infrequently-updated filesPieter Wuille
2014-09-18Fixing 'vector out of bounds' issue in base 32 and 64ENikS