| Age | Commit message (Collapse) | Author |
|---|
|
do not silently ignore errors on "backupwallet" RPC cmd
|
|
Change 'make' to $(MAKE) in leveldb make command line
|
|
|
|
- fix ThreadSafeMessageBox always displays error icon
- allow to specify MSG_ERROR / MSG_WARNING or MSG_INFORMATION without a
custom caption / title
- allow to specify CClientUIInterface::ICON_ERROR / ICON_WARNING and
ICON_INFORMATION (which is default) as message box icon
- remove CClientUIInterface::OK from ThreadSafeMessageBox-calls, as
the OK button will be set as default, if none is specified
- prepend "Bitcoin - " to used captions
- rename BitcoinGUI::error() -> BitcoinGUI::message() and add function
documentation
- change all style parameters and enum flags to unsigned
- update code to use that new API
- update Client- and WalletModel to use new BitcoinGUI::message() and
rename the classes error() method into message()
- include the possibility to supply the wanted icon for messages from
Client- and WalletModel via "style" parameter
|
|
Simplify CMutexLock
|
|
Split off CBlockHeader from CBlock
|
|
Do not reorganize if new branch has same amount of work
|
|
Bitcoin-Qt: fix crash on Windows caused by CDBEnv::EnvShutdown()
|
|
|
|
- can be triggerd by just adding -proxy=crashme with 0.7.1
- crash occured, when AppInit2() was left with return false; after the
first call to bitdb.open() (Step 6 in init)
- this is caused by GetDataDir() or .string() in CDBEnv::EnvShutdown()
called via the bitdb global destructor
- init fDbEnvInit and fMockDb to false in CDBEnv::CDBEnv()
|
|
fix pull #2018
|
|
- I introduced the wrong format macro with my former patch (#2018), this
needs to be signed not unsigned (thanks Luke-Jr)
|
|
update bitcoinstrings.cpp and bitcoin_en.ts
|
|
|
|
Prevent RPC 'move' from deadlocking
|
|
- fixes 2 warnings I observed while compiling on Windows with MinGW
|
|
clear history when using clear button in RPC console
|
|
Use full block hash as unique identifier in debug.log
|
|
Fixed compile error on FreeBSD 9.
|
|
RPC: Forbid RPC username == RPC password
|
|
some small fixes for main.cpp/.h
|
|
Print error for coinbase-pays-too-much case of ConnectBlock failing
|
|
Added security measure.
|
|
make enum and parameter used in Bind() unsigned
|
|
Cleaner and removes the need for the application-specific flags in
serialize.h.
|
|
These flags select features to be enabled/disabled during script
evaluation/checking, instead of several booleans passed along.
Currently these flags are defined:
* SCRIPT_VERIFY_P2SH: enable BIP16-style subscript evaluation
* SCRIPT_VERIFY_STRICTENC: enforce strict adherence to pubkey/sig encoding standards.
|
|
|
|
- it's good practise to use unsigned int for enum flags, so change this
one, as I introduced this for Bind()
|
|
o Remove unused Leave and GetLock functions
o Make Enter and TryEnter private.
o Simplify Enter and TryEnter.
boost::unique_lock doesn't really know whether the
mutex it wraps is locked or not when the defer_lock
option is used.
The boost::recursive_mutex does not expose this
information, so unique_lock only infers this
knowledge. When taking the lock is defered, it
(randomly) assumes that the lock is not taken.
boost::unique_lock has the following definition:
unique_lock(Mutex& m_,defer_lock_t):
m(&m_),is_locked(false)
{}
bool owns_lock() const
{
return is_locked;
}
Thus it is a mistake to check owns_lock() in Enter
and TryEnter - they will always return false.
|
|
It seemed to create two CWalletDB objects that both grab the
database lock.
|
|
|
|
|
|
|
|
o Removed verbose clang warning
|
|
|
|
- remove an unwanted ";" at the end of the ~CCoinsView() destructor
- in FindBlockPos() and FindUndoPos() only call fclose(), is file is open
- fix an error string in the CBlockUndo class
|
|
leveldb cannot compile with custom CFLAGS / CXXFLAGS / LDFLAGS
|
|
simplify CDBEnv::Open() / fix small glitches
|
|
fix some missing indentations in main.cpp for better readability
|
|
|
|
One-line comments for public main functions
|
|
|
|
|
|
don't use memset() in privacy/security relevant code parts
|
|
|
|
remove printf redefinition from bitcoinrpc.cpp
|
|
Qt: small header changes / fixes
|
|
- remove pathEnv from CDBEnv, as this attribute is not needed
- change path parameter in ::Open() to a reference
- make nDbCache variable an unsigned integer
- remove a missplaced ";" behin ::IsMock()
|
|
- this allows the client to listen on via -bind specified addresses
(e.g. 127.0.0.1), even when a network (IPv4 in that case) was blocked
via e.g -onlynet="Tor"
- introduce enum BindFlags to avoid passing multiple bools to Bind()
- make -bind help text clear we ALWAYS listen on the specified address
- remove an unused variable
- remove 2 unneeded IsLimited() checks before calling Bind(), which does
these checks anyway
- usage case: specify -bind=127.0.0.1 -onlynet="Tor" to allow incoming
connections to a Tor hidden service, but still don't allow other IPv4
nodes to connect / get connected
|
|
|
