aboutsummaryrefslogtreecommitdiff
path: root/src/wallet
AgeCommit message (Collapse)Author
2016-10-20RPC: importmulti: Avoid using boost::variant::operator!=, which is only in ↵Luke Dashjr
newer boost versions
2016-10-20Merge #7551: Add importmulti RPC callWladimir J. van der Laan
215caba Add consistency check to RPC call importmulti (Pedro Branco) cb08fdb Add importmulti rpc call (Pedro Branco)
2016-10-19Merge #8928: Fix init segfault where InitLoadWallet() calls ATMP before genesisWladimir J. van der Laan
37aefff Fix init segfault where InitLoadWallet() calls ATMP before genesis (Matt Corallo)
2016-10-19Add consistency check to RPC call importmultiPedro Branco
2016-10-19Add importmulti rpc callPedro Branco
2016-10-19[RPC] Give RPC commands more information about the RPC requestJonas Schnelli
2016-10-18Merge #8287: [wallet] Set fLimitFree = trueWladimir J. van der Laan
fa8b02d [rpc] rawtx: Prepare fLimitFree to make it an option (MarcoFalke) fa28bfa [wallet] Set fLimitFree = true (MarcoFalke)
2016-10-18Merge #8914: Kill insecure_random and associated global stateWladimir J. van der Laan
5eaaa83 Kill insecure_random and associated global state (Wladimir J. van der Laan)
2016-10-17Kill insecure_random and associated global stateWladimir J. van der Laan
There are only a few uses of `insecure_random` outside the tests. This PR replaces uses of insecure_random (and its accompanying global state) in the core code with an FastRandomContext that is automatically seeded on creation. This is meant to be used for inner loops. The FastRandomContext can be in the outer scope, or the class itself, then rand32() is used inside the loop. Useful e.g. for pushing addresses in CNode or the fee rounding, or randomization for coin selection. As a context is created per purpose, thus it gets rid of cross-thread unprotected shared usage of a single set of globals, this should also get rid of the potential race conditions. - I'd say TxMempool::check is not called enough to warrant using a special fast random context, this is switched to GetRand() (open for discussion...) - The use of `insecure_rand` in ConnectThroughProxy has been replaced by an atomic integer counter. The only goal here is to have a different credentials pair for each connection to go on a different Tor circuit, it does not need to be random nor unpredictable. - To avoid having a FastRandomContext on every CNode, the context is passed into PushAddress as appropriate. There remains an insecure_random for test usage in `test_random.h`.
2016-10-17Fix ismine and addwitnessaddress: no uncompressed keys in segwitPieter Wuille
2016-10-15Fix init segfault where InitLoadWallet() calls ATMP before genesisMatt Corallo
2016-09-30Move key derivation logic from GenerateNewKey to DeriveNewChildKeyPatrick Strateman
2016-09-29Merge #8658: Remove unused statements in serializationWladimir J. van der Laan
64d9507 [WIP] Remove unused statement in serialization (Pavel Janík)
2016-09-28Merge #8814: [wallet, policy] ParameterInteraction: Don't allow 0 feeWladimir J. van der Laan
fa4bfb4 [wallet, policy] ParameterInteraction: Don't allow 0 fee (MarcoFalke)
2016-09-27Do not shadow variablesPavel Janík
2016-09-26[wallet, policy] ParameterInteraction: Don't allow 0 feeMarcoFalke
2016-09-26[wallet] Add high transaction fee warningsMarcoFalke
2016-09-21Merge #8768: init: Get rid of fDisableWalletWladimir J. van der Laan
fa58edb [wallet] Introduce DEFAULT_DISABLE_WALLET (MarcoFalke) fab9107 init: Get rid of fDisableWallet (MarcoFalke)
2016-09-21[wallet] Introduce DEFAULT_DISABLE_WALLETMarcoFalke
2016-09-20init: Get rid of fDisableWalletMarcoFalke
2016-09-20[Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfundsJonas Schnelli
2016-09-20Merge #8696: [Wallet] Remove last external reference to CWalletDBWladimir J. van der Laan
2ca6b9d Remove last reference to CWalletDB from accounting_tests.cpp (Patrick Strateman) 02e2a81 Remove pwalletdb parameter from CWallet::AddAccountingEntry (Patrick Strateman) d2e678d Add CWallet::ReorderTransactions and use in accounting_tests.cpp (Patrick Strateman) 59adc86 Add CWallet::ListAccountCreditDebit (Patrick Strateman)
2016-09-19init: Get rid of some ENABLE_WALLETMarcoFalke
2016-09-15Remove last reference to CWalletDB from accounting_tests.cppPatrick Strateman
2016-09-15Remove pwalletdb parameter from CWallet::AddAccountingEntryPatrick Strateman
2016-09-15Add CWallet::ReorderTransactions and use in accounting_tests.cppPatrick Strateman
2016-09-15Add CWallet::ListAccountCreditDebitPatrick Strateman
Simple pass through for CWalletDB::ListAccountCreditDebit
2016-09-13Merge #8693: add witness address to address bookWladimir J. van der Laan
62ffbbd add witness address to address book (instagibbs)
2016-09-13Merge #8601: Add option to opt into full-RBF when sending funds (rebase, ↵Wladimir J. van der Laan
original by petertodd) 86726d8 Rename `-optintofullrbf` option to `-walletrbf` (Wladimir J. van der Laan) 05fa823 wallet: Add BIP125 comment for MAXINT-1/-2 behavior (Wladimir J. van der Laan) 152f45b Add option to opt into full-RBF when sending funds (Peter Todd)
2016-09-13Rename `-optintofullrbf` option to `-walletrbf`Wladimir J. van der Laan
This makes it clear that this is a wallet option.
2016-09-09add witness address to address bookinstagibbs
2016-09-09[WIP] Remove unused statement in serializationPavel Janík
2016-09-09Merge #8664: Fix segwit-related wallet bugWladimir J. van der Laan
c40b034 Clear witness with vin/vout in CWallet::CreateTransaction() (Suhas Daftuar)
2016-09-08Made the ForEachNode* functions in src/net.cpp more pragmatic and self ↵Jeremy Rubin
documenting
2016-09-08net: create generic functor accessors and move vNodes to CConnmanCory Fields
2016-09-08net: Pass CConnection to wallet rather than using the globalCory Fields
2016-09-04Clear witness with vin/vout in CWallet::CreateTransaction()Suhas Daftuar
2016-09-02Merge #8629: C++11: s/boost::scoped_ptr/std::unique_ptr/Wladimir J. van der Laan
cdd79eb C++11: s/boost::scoped_ptr/std::unique_ptr/ (Jorge Timón)
2016-09-01C++11: s/boost::scoped_ptr/std::unique_ptr/Jorge Timón
2016-08-31Do not shadow variables.Pavel Janík
2016-08-31Merge #8163: Do not shadow global RPC table variable (tableRPC)Wladimir J. van der Laan
de1bbe3 Do not shadow global RPC table variable (tableRPC) (Pavel Janík)
2016-08-30Berkeley DB v6 compatibility fixAlexey Vesnin
Fixes building error looking like this: CXX wallet/libbitcoin_wallet_a-db.o wallet/db.cpp: In member function ‘void CDBEnv::EnvShutdown()’: wallet/db.cpp:46:16: error: call of overloaded ‘DbEnv(int)’ is ambiguous DbEnv(0).remove(strPath.c_str(), 0); ^ wallet/db.cpp:46:16: note: candidates are: In file included from wallet/db.h:21:0, from wallet/db.cpp:6: /usr/include/db_cxx.h:916:2: note: DbEnv::DbEnv(const DbEnv&) DbEnv(const DbEnv &); ^ /usr/include/db_cxx.h:518:2: note: DbEnv::DbEnv(DB_ENV) DbEnv(DB_ENV *dbenv); ^ /usr/include/db_cxx.h:516:2: note: DbEnv::DbEnv(u_int32_t) DbEnv(u_int32_t flags); ^ Makefile:5780: recipe for target 'wallet/libbitcoin_wallet_a-db.o' failed make[2]: ** [wallet/libbitcoin_wallet_a-db.o] Error 1
2016-08-29Merge #8564: [Wallet] remove unused code/conditions in ReadAtCursorPieter Wuille
beef966 [Wallet] remove unused code/conditions in ReadAtCursor (Jonas Schnelli)
2016-08-26Merge #8590: Remove unused variablesWladimir J. van der Laan
fa6dc9f Remove unused variables (MarcoFalke)
2016-08-26wallet: Add BIP125 comment for MAXINT-1/-2 behaviorWladimir J. van der Laan
2016-08-26Add option to opt into full-RBF when sending fundsPeter Todd
2016-08-25[wallet] Set fLimitFree = trueMarcoFalke
2016-08-25Do not shadow global RPC table variable (tableRPC)Pavel Janík
2016-08-25Remove unused variablesMarcoFalke
2016-08-24[wallet] rpc: Drop misleading optionMarcoFalke