aboutsummaryrefslogtreecommitdiff
path: root/src/wallet
AgeCommit message (Collapse)Author
2016-02-10wallet: Ignore MarkConflict if block hash is not knownWladimir J. van der Laan
If number of conflict confirms cannot be determined, this means that the block is still unknown or not yet part of the main chain, for example during a reindex. Do nothing in that case, instead of crash with an assertion. Fixes #7234. Github-Pull: #7491 Rebased-From: 40e7b61835cbe5fd471d0b4b71972526bf0e523c
2016-01-20RPC: indicate which transactions are replaceableSuhas Daftuar
Add "bip125-replaceable" output field to listtransactions and gettransaction which indicates if an unconfirmed transaction, or any unconfirmed parent, is signaling opt-in RBF according to BIP 125. Github-Pull: #7286 Rebased-From: eaa8d2754b48b62cdd07255fc3028feecad0c095
2016-01-20[walletdb] Fix syntax error in key parserMarcoFalke
Github-Pull: #7381 Rebased-From: fa6d4cc09575de30386bfbc5c8c3858cd7a2f42a
2016-01-13add InMempool() functionJonas Schnelli
2016-01-13Merge pull request #7332Wladimir J. van der Laan
2016-01-13Add RPC call abandontransactionAlex Morcos
- Make wallet descendant searching more efficient - Add new rpc call: abandontransaction Unconfirmed transactions that are not in your mempool either due to eviction or other means may be unlikely to be mined. abandontransaction gives the wallet a way to no longer consider as spent the coins that are inputs to such a transaction. All dependent transactions in the wallet will also be marked as abandoned. - Add RPC test for abandoned and conflicted transactions. - [Wallet] Call notification signal when a transaction is abandoned Github-Pull: #7312 Rebased-From: 9e697172542e2b01517e4025df2c23d0ed5447f4 01e06d1fa365cedb7f5d5e17e6bdf0b526e700c5 df0e2226d998483d247c0245170f6b8ff6433b1d d11fc1695c0453ef22a633e516726f82717dd1d9
2016-01-13[wallet] Clarify rpc help message with regard to roundingMarcoFalke
2016-01-13Add sane fallback for fee estimationAlex Morcos
- Always respect GetRequiredFee for wallet txs - Add sane fallback for fee estimation - SQUASHME: Fix rpc tests that assumed fallback to minRelayTxFee Add new commandline option "-fallbackfee" to use when fee estimation does not have sufficient data. Github-Pull: #7296 Rebased-From: 995b9f3 e420a1b bebe58b
2016-01-08Make sure conflicted wallet tx's update balancesAlex Morcos
Github-Pull: #7306 Rebased-From: f61766b37beb2fecbe3915a72a814cbdb107be0a
2016-01-07[wallet] Add regression test for vValue sort orderMarcoFalke
- [wallet] Add regression test for vValue sort order - [trivial] Merge test cases and replace CENT with COIN Github-Pull: #7293 Rebased-From: fa3c7e644f427329bcffa1a5600fdbd7e97c837f faf538bfdbb4ecebde73e95c80718c2d9ecee1f5
2016-01-07[qa] wallet: Check if maintenance changes the balanceMarcoFalke
- [qa] Cleanup wallet.py test - [qa] check if wallet or blochchain maintenance changes the balance - [walletdb] Add missing LOCK() in Recover() for dummyWallet Github-Pull: #7229 Rebased-From: fa0765d433eb6d44a5cbec44f136b62814c663e5 fa14d994843fe2d700c977653cd3133d0a77cb67 fa33d9740c9b0d1071094ab6c1736f27a7090c95
2016-01-05Bump copyright headers to 2015MarcoFalke
- Bump copyright headers to 2015 - [devtools] Rewrite fix-copyright-headers.py - [devtools] Use git pretty-format for year parsing Github-Pull: #7205 Rebased-From: fa6ad855e9159b2247da4fa0054f32fa181499ab fa24439ff3d8ab5b9efaf66ef4dae6713b88cb35 fa71669452e57039e4270fd2b33a0e0e1635b813
2016-01-05[wallet] Adjust pruning testMarcoFalke
Github-Pull: #7193 Rebased-From: fafd09375eb5133abf921132643384a1ac6fa444
2015-12-14Checks for null data transaction before issuing error to debug.logaccraze
CWalletTx::GetAmounts could not find output address for null data transactions, thus issuing an error in debug.log. This change checks to see if the transaction is OP_RETURN before issuing error. resolves #6142 Github-Pull: #7200 Rebased-From: b6915b82398d2e1d1f888b3816adfaf06d9a450e c611acc38a95d336a824b632823aa1b652e570df d812daf967ba4173bfa1c37eeb4ab7a0ccc4df25
2015-12-08Coinselection prunes extraneous inputs from ApproximateBestSubsetAlSzacrel
This is a combination of 3 commits. - Coinselection prunes extraneous inputs from ApproximateBestSubset A further pass over the available inputs has been added to ApproximateBestSubset after a candidate set has been found. It will prune any extraneous inputs in the selected subset, in order to decrease the number of input and the resulting change. - Moved set reduction to the end of ApproximateBestSubset to reduce performance impact - Added a test for the pruning of extraneous inputs after ApproximateBestSet Github-Pull: #4906 Rebased-From: 5c03483e26ab414d22ef192691b2336c1bb3cb02 af9510e0374443b093d633a91c4f1f8bf5071292 fc0f52d78085b6ef97d6821fc7592326c2d9b495
2015-12-02Fix typo in wallet.cppMarcoFalke
2015-12-02Merge pull request #6216Wladimir J. van der Laan
db6047d Take the training wheels off anti-fee-sniping (Peter Todd)
2015-12-01Merge pull request #7136Wladimir J. van der Laan
fa19a58 HelpMessage: Don't hide -mintxfee behind showDebug (MarcoFalke) faffc17 rpcwallet: Clarify what settxfee does (MarcoFalke) 9999cb0 Fix url in .travis.yml (MarcoFalke) fa22a10 contrib: Del. gitian downloader config and update gitian README (MarcoFalke) fad3035 [doc] Minor markdown fixes (MarcoFalke)
2015-12-01Merge pull request #6914Wladimir J. van der Laan
114b581 Prevector type (Pieter Wuille)
2015-12-01Merge pull request #7096Wladimir J. van der Laan
ff723da [Qt] improve minimum absolute fee option - Only display the minimum absolute fee control if CoinControl is enabled (Jonas Schnelli) 31b508a [Qt] make use of the nMinimumTotalFee (absolute) in coincontrols fee calculation (Jonas Schnelli) 80462dd [Qt] use ASYMP_UTF8 (≈) whenever we show a fee that is not absolute (Jonas Schnelli) ecc7c82 Move fPayAtLeastCustomFee function to CC (Pieter Wuille)
2015-12-01Merge pull request #7105Wladimir J. van der Laan
9ac63d6 Keep track of explicit wallet conflicts instead of using mempool (Pieter Wuille)
2015-11-30rpcwallet: Clarify what settxfee doesMarcoFalke
2015-11-30Move fPayAtLeastCustomFee function to CCPieter Wuille
2015-11-29Keep track of explicit wallet conflicts instead of using mempoolPieter Wuille
2015-11-28Default fPayAtLeastCustomFee to falseRyan Havar
This allows for much finer control of the transaction fees per kilobyte as it prevent small transactions using a fee that is more appropriate for one that is of a kilobyte. This also allows controlling the fee per kilobyte over rpc such that: bitcoin-cli settxfee `bitcoin-cli estimatefee 2` would make sense, while currently it grossly fails often by a factor of x3
2015-11-28[trivial] Reuse translation and cleanup DEFAULT_* valuesMarcoFalke
* DEFAULT_DISABLE_SAFEMODE = false * Use DEFAULT_* constants for extern bools
2015-11-28Constrain constant values to a single location in codeLuke Dashjr
2015-11-27Merge pull request #6134Wladimir J. van der Laan
e304432 Pass reference to estimateSmartFee and cleanup whitespace (Suhas Daftuar) 56106a3 Expose RPC calls for estimatesmart functions (Alex Morcos) e93a236 add estimateSmartFee to the unit test (Alex Morcos) 6303051 EstimateSmart functions consider mempool min fee (Alex Morcos) f22ac4a Increase success threshold for fee estimation to 95% (Alex Morcos) 4fe2823 Change wallet and GUI code to use new smart fee estimation calls. (Alex Morcos) 22eca7d Add smart fee estimation functions (Alex Morcos)
2015-11-24Pass reference to estimateSmartFee and cleanup whitespaceSuhas Daftuar
2015-11-24Merge pull request #7066Wladimir J. van der Laan
5c2fd38 Add missing "blocktime" description to listtransactions help, fix formatting. (Pavel Janík)
2015-11-21Optimisation: Store transaction list order in memory rather than compute it ↵Luke Dashjr
every need Huge performance improvement (450%) for zapwallettxes
2015-11-20Add missing "blocktime" description to listtransactions help, fix formatting.Pavel Janík
2015-11-16Change wallet and GUI code to use new smart fee estimation calls.Alex Morcos
2015-11-16Merge pull request #6991Gregory Maxwell
9bd3f03 Clarify 'fee' field in fundrawtransaction help text (Peter Todd)
2015-11-13Better error message for fundrawtransaction w/ empty voutPeter Todd
Previously this case failed deep in Cwallet::CreateTransaction() with the error message "Transaction amounts must be positive"
2015-11-13Actually use includeWatching value in fundrawtransactionPeter Todd
Previously if you called fundrawtransaction and set includeWatching to false it'd act as through you set it to true.
2015-11-13Prevector typePieter Wuille
2015-11-11Clarify 'fee' field in fundrawtransaction help textPeter Todd
Previous text could be interpreted as the the _additional_ fee paid by the result on top of the fee the original version paid, rather than the correct interpretation: the absolute fee the resulting tx pays.
2015-11-10Merge pull request #5574Wladimir J. van der Laan
fd55571 wallet: Expose GUI labels in RPC (Luke Dashjr)
2015-11-10Merge pull request #6163Wladimir J. van der Laan
87cbdb8 Globals: Explicit Consensus::Params arg for main: (Jorge Timón)
2015-11-05Merge pull request #6887Wladimir J. van der Laan
53238ff Clarify what minrelaytxfee does (MarcoFalke) abd8b76 [qt] Properly display required fee instead of minTxFee (MarcoFalke)
2015-11-04Merge pull request #6669Wladimir J. van der Laan
6342a48 Init: Use DEFAULT_TRANSACTION_MINFEE in help message (MarcoFalke) a9c73a1 [wallet] Add comments for doxygen (MarcoFalke) 6b0e622 [wallet] Refactor to use new MIN_CHANGE (MarcoFalke)
2015-11-04Merge pull request #6905Wladimir J. van der Laan
a6efc01 Bugfix: Omit wallet-related options from -help when wallet is disabled (Luke Dashjr) 5f9260f Bugfix: If genproclimit is omitted to RPC setgenerate, don't change it; also show correct default in getmininginfo (Luke Dashjr) 420a82f Bugfix: Describe dblogsize option correctly (it refers to the wallet database, not memory pool) (Luke Dashjr) caa3d42 Bugfix: RPC: blockchain: Display correct defaults in help for verifychain method (Luke Dashjr)
2015-11-03[qt] Properly display required fee instead of minTxFeeMarcoFalke
2015-10-30Globals: Explicit Consensus::Params arg for main:Jorge Timón
-CheckBlockIndex -DisconnectTip -GetTransaction -InvalidateBlock -ProcessGetData -ReadBlockFromDisk
2015-10-29Reject invalid pubkeys when reading ckey items from the wallet.Gregory Maxwell
This makes the behavior more consistent with key objects and will reject some corrupted pubkeys (e.g. zero length).
2015-10-28[wallet] Add comments for doxygenMarcoFalke
2015-10-28[wallet] Refactor to use new MIN_CHANGEMarcoFalke
* Introduce new constant MIN_CHANGE and use it instead of the hardcoded "CENT" * Add test case for MIN_CHANGE * Introduce new constant for -mintxfee default: DEFAULT_TRANSACTION_MINFEE = 1000
2015-10-13Only call TrimToSize once per reorg/blocks disconnectMatt Corallo
2015-10-02wallet: Expose GUI labels in RPCLuke Dashjr