aboutsummaryrefslogtreecommitdiff
path: root/src/wallet/wallet.cpp
AgeCommit message (Collapse)Author
2016-10-18Merge #8287: [wallet] Set fLimitFree = trueWladimir J. van der Laan
fa8b02d [rpc] rawtx: Prepare fLimitFree to make it an option (MarcoFalke) fa28bfa [wallet] Set fLimitFree = true (MarcoFalke)
2016-10-17Kill insecure_random and associated global stateWladimir J. van der Laan
There are only a few uses of `insecure_random` outside the tests. This PR replaces uses of insecure_random (and its accompanying global state) in the core code with an FastRandomContext that is automatically seeded on creation. This is meant to be used for inner loops. The FastRandomContext can be in the outer scope, or the class itself, then rand32() is used inside the loop. Useful e.g. for pushing addresses in CNode or the fee rounding, or randomization for coin selection. As a context is created per purpose, thus it gets rid of cross-thread unprotected shared usage of a single set of globals, this should also get rid of the potential race conditions. - I'd say TxMempool::check is not called enough to warrant using a special fast random context, this is switched to GetRand() (open for discussion...) - The use of `insecure_rand` in ConnectThroughProxy has been replaced by an atomic integer counter. The only goal here is to have a different credentials pair for each connection to go on a different Tor circuit, it does not need to be random nor unpredictable. - To avoid having a FastRandomContext on every CNode, the context is passed into PushAddress as appropriate. There remains an insecure_random for test usage in `test_random.h`.
2016-09-30Move key derivation logic from GenerateNewKey to DeriveNewChildKeyPatrick Strateman
2016-09-28Merge #8814: [wallet, policy] ParameterInteraction: Don't allow 0 feeWladimir J. van der Laan
fa4bfb4 [wallet, policy] ParameterInteraction: Don't allow 0 fee (MarcoFalke)
2016-09-27Do not shadow variablesPavel Janík
2016-09-26[wallet, policy] ParameterInteraction: Don't allow 0 feeMarcoFalke
2016-09-26[wallet] Add high transaction fee warningsMarcoFalke
2016-09-21[wallet] Introduce DEFAULT_DISABLE_WALLETMarcoFalke
2016-09-20init: Get rid of fDisableWalletMarcoFalke
2016-09-20Merge #8696: [Wallet] Remove last external reference to CWalletDBWladimir J. van der Laan
2ca6b9d Remove last reference to CWalletDB from accounting_tests.cpp (Patrick Strateman) 02e2a81 Remove pwalletdb parameter from CWallet::AddAccountingEntry (Patrick Strateman) d2e678d Add CWallet::ReorderTransactions and use in accounting_tests.cpp (Patrick Strateman) 59adc86 Add CWallet::ListAccountCreditDebit (Patrick Strateman)
2016-09-19init: Get rid of some ENABLE_WALLETMarcoFalke
2016-09-15Remove pwalletdb parameter from CWallet::AddAccountingEntryPatrick Strateman
2016-09-15Add CWallet::ReorderTransactions and use in accounting_tests.cppPatrick Strateman
2016-09-15Add CWallet::ListAccountCreditDebitPatrick Strateman
Simple pass through for CWalletDB::ListAccountCreditDebit
2016-09-13Merge #8601: Add option to opt into full-RBF when sending funds (rebase, ↵Wladimir J. van der Laan
original by petertodd) 86726d8 Rename `-optintofullrbf` option to `-walletrbf` (Wladimir J. van der Laan) 05fa823 wallet: Add BIP125 comment for MAXINT-1/-2 behavior (Wladimir J. van der Laan) 152f45b Add option to opt into full-RBF when sending funds (Peter Todd)
2016-09-13Rename `-optintofullrbf` option to `-walletrbf`Wladimir J. van der Laan
This makes it clear that this is a wallet option.
2016-09-09Merge #8664: Fix segwit-related wallet bugWladimir J. van der Laan
c40b034 Clear witness with vin/vout in CWallet::CreateTransaction() (Suhas Daftuar)
2016-09-08Made the ForEachNode* functions in src/net.cpp more pragmatic and self ↵Jeremy Rubin
documenting
2016-09-08net: create generic functor accessors and move vNodes to CConnmanCory Fields
2016-09-08net: Pass CConnection to wallet rather than using the globalCory Fields
2016-09-04Clear witness with vin/vout in CWallet::CreateTransaction()Suhas Daftuar
2016-08-26wallet: Add BIP125 comment for MAXINT-1/-2 behaviorWladimir J. van der Laan
2016-08-26Add option to opt into full-RBF when sending fundsPeter Todd
2016-08-25[wallet] Set fLimitFree = trueMarcoFalke
2016-08-25Remove unused variablesMarcoFalke
2016-08-24Merge #8445: Move CWallet::setKeyPool to private section of CWallet.Wladimir J. van der Laan
8680d3a Move wallet initialization logic from AppInit2 to CWallet::InitLoadWallet (Patrick Strateman) e86eb71 Move CWallet::setKeyPool to private section of CWallet (Patrick Strateman)
2016-08-22Merge #8554: trivial: remove unused variableWladimir J. van der Laan
4207630 trivial: remove unused variable (Daniel Kraft)
2016-08-22Merge #8548: [wallet] Use __func__ to get function name for output printingWladimir J. van der Laan
fa785d1 Use __func__ to get function name for output printing (MarcoFalke)
2016-08-20Move wallet initialization logic from AppInit2 to CWallet::InitLoadWalletPatrick Strateman
2016-08-20trivial: remove unused variableDaniel Kraft
Remove the unused variable "blockTmp" in CMerkleTx::SetMerkleBranch. It was previously used to read the block from disk if not provided as argument, but is no longer needed.
2016-08-19Use __func__ to get function name for output printingMarcoFalke
2016-08-19Merge #8517: [Qt] show wallet HD state in statusbarJonas Schnelli
914154f [Qt] add HD enabled/disabled icon to the status bar (Jonas Schnelli)
2016-08-19Merge #8443: [Wallet] Trivial cleanup of HD wallet changesJonas Schnelli
7e5d94d [Wallet] Trivial cleanup of HD wallet changes (Jonas Schnelli)
2016-08-19[Wallet] Trivial cleanup of HD wallet changesJonas Schnelli
2016-08-19[Qt] add HD enabled/disabled icon to the status barJonas Schnelli
2016-08-17Merge #8505: Trivial: Fix typos in various filesWladimir J. van der Laan
1aacfc2 various typos (leijurv)
2016-08-14various typosleijurv
2016-08-12Reduce cs_main locks during ConnectTip/SyncWithWalletsJonas Schnelli
2016-07-29Remove unused pwalletdb from CWallet::AddToWalletPatrick Strateman
2016-07-29Remove CWalletDB* parameter from CWallet::AddToWalletPatrick Strateman
2016-07-29Split CWallet::AddToWallet into AddToWallet and LoadToWallet.Patrick Strateman
This removes the fFromLoadWallet flag in AddToWallet. These were already effectively two methods.
2016-07-28Port from 0.13: Create a new HD seed after encrypting the walletJonas Schnelli
Forward-ports two commits from 0.13: - [0.13] Create a new HD seed after encrypting the wallet - [Wallet] Add CKeyMetadata record for HDMasterKey(s), factor out HD key generation Github-Pull: #8389 Rebased-From: f142c11ac634df487cc4bc65a5f1c9a3e3563dd9 de45c065f0648c4c41b57cb492420ceeed29dd11
2016-07-19Move SetMinVersion for FEATURE_HD to SetHDMasterKeyPatrick Strateman
2016-07-19Merge #8367: [Wallet] Ensure <0.13 clients can't open HD walletsWladimir J. van der Laan
a4f137f [Wallet] Ensure <0.13 clients can't open HD wallets (Jonas Schnelli)
2016-07-18[Wallet] Ensure <0.13 clients can't open HD walletsJonas Schnelli
2016-07-18Rename "block cost" to "block weight"Suhas Daftuar
2016-07-18Merge #8323: Add HD keypath to CKeyMetadata, report metadata in validateaddressWladimir J. van der Laan
7945088 [Wallet] comsetic non-code changes for the HD feature (Jonas Schnelli) 68d7682 [Wallet] ensure CKeyMetadata.hdMasterKeyID will be cleared during SetNull() (Jonas Schnelli) f708085 [QA] extend wallet-hd test to cover HD metadata (Jonas Schnelli) 986c223 [Wallet] print hd masterkeyid in getwalletinfo (Jonas Schnelli) b1c7b24 [Wallet] report optional HDKeypath/HDMasterKeyId in validateaddress (Jonas Schnelli) 5b95dd2 [Wallet] extend CKeyMetadata with HD keypath (Jonas Schnelli)
2016-07-09[Wallet] keep HD seed during salvagewalletJonas Schnelli
2016-07-09[Wallet] extend CKeyMetadata with HD keypathJonas Schnelli
2016-07-01wallet: Revert input selection post-pruningWladimir J. van der Laan
This reverts PR #4906, "Coinselection prunes extraneous inputs from ApproximateBestSubset". Apparently the previous behavior of slightly over-estimating the set of inputs was useful in cleaning up UTXOs. See also #7664, #7657, as well as 2016-07-01 discussion on #bitcoin-core-dev IRC.
generated by cgit v1.2.3 (git 2.26.2) at 2024-11-14 07:10:14 +0000