slackcoder/bitcoin - Bitcoin Code integration/staging tree

Age	Commit message (Collapse)	Author
2022-07-20	refactor: move compat.h into compat/	fanquake

2022-06-28	Merge bitcoin/bitcoin#24378: refactor: make bind() and listen() ↵	laanwj
	mockable/testable b2733ab6a85b234a88b83bdc77a0d043e18385b3 net: add new method Sock::Listen() that wraps listen() (Vasil Dimov) 3ad7de225efce3e76530f56bee8a8f7a75ea0f3c net: add new method Sock::Bind() that wraps bind() (Vasil Dimov) Pull request description: _This is a piece of #21878, chopped off to ease review._ Add new methods `Sock::Bind()` and `Sock::Listen()` that wrap `bind()` and `listen()`. This will help to increase `Sock` usage and make more code mockable. ACKs for top commit: pk-b2: ACK b2733ab6a85b234a88b83bdc77a0d043e18385b3 laanwj: Code review ACK b2733ab6a85b234a88b83bdc77a0d043e18385b3 Tree-SHA512: c6e737606703e2106fe60cc000cfbbae3a7f43deadb25f70531e2cac0457e0b0581440279d14c76c492eb85c12af4adde52c30baf74542c41597e419817488e8
2022-06-28	Merge bitcoin/bitcoin#25426: net: add new method Sock::GetSockName() that ↵	laanwj
	wraps getsockname() and use it in GetBindAddress() a8d6abba5ec4ae2a3375e9be0b739f298899eca2 net: change GetBindAddress() to take Sock argument (Vasil Dimov) 748dbcd9f29dbe4110da8a06f08e3eefa95f5321 net: add new method Sock::GetSockName() that wraps getsockname() (Vasil Dimov) Pull request description: _This is a piece of #21878, chopped off to ease review._ Wrap the syscall `getsockname()` in `Sock::GetSockName()` and change `GetBindAddress()` to take a `Sock` argument so that it can use the wrapper. This further encapsulates syscalls inside the `Sock` class and makes the callers mockable. ACKs for top commit: laanwj: Code review ACK a8d6abba5ec4ae2a3375e9be0b739f298899eca2 Tree-SHA512: 3a73463258c0057487fb3fd67215816b03a1c5160f45e45930eaeef86bb3611ec385794cdb08339aa074feba8ad67cd2bfd3836f6cbd40834e15d933214a05dc
2022-06-22	net: rename Sock::Reset() to Sock::Close() and make it private	Vasil Dimov
	Outside of `Sock`, `Sock::Reset()` was used in just one place (in `i2p.cpp`) which can use the assignment operator instead. This simplifies the public `Sock` API by having one method less.
2022-06-20	net: remove CloseSocket()	Vasil Dimov
	Do the closing in `Sock::Reset()` and remove the standalone `CloseSocket()`. This reduces the exposure of low-level sockets (i.e. integer file descriptors) outside of the `Sock` class.
2022-06-20	net: remove now unused Sock::Release()	Vasil Dimov

2022-06-20	net: add new method Sock::GetSockName() that wraps getsockname()	Vasil Dimov
	This will help to increase `Sock` usage and make more code mockable.
2022-06-09	net: introduce Sock::WaitMany()	Vasil Dimov
	It allows waiting concurrently on more than one socket. Being a `virtual` `Sock` method it can be overriden by tests. Will be used to replace `CConnman::SocketEvents()`.
2022-06-09	net: also wait for exceptional events in Sock::Wait()	Vasil Dimov
	This mimics closely `CConnman::SocketEvents()` and the underlying `poll(2)`.
2022-05-18	net: add new method Sock::Listen() that wraps listen()	Vasil Dimov
	This will help to increase `Sock` usage and make more code mockable.
2022-05-18	net: add new method Sock::Bind() that wraps bind()	Vasil Dimov
	This will help to increase `Sock` usage and make more code mockable.
2022-04-28	util: Replace non-threadsafe strerror	laanwj
	Some uses of non-threadsafe `strerror` have snuck into the code since they were removed in #4152. Add a wrapper `SysErrorString` for thread-safe strerror alternatives and replace all uses of `strerror` with this.
2022-04-15	net: add new method Sock::SetSockOpt() that wraps setsockopt()	Vasil Dimov
	This will help to increase `Sock` usage and make more code mockable.
2021-12-01	net: add new method Sock::Accept() that wraps accept()	Vasil Dimov
	This will help to increase `Sock` usage and make more code mockable.
2021-09-11	Cleanup headers after #20788	Hennadii Stepanov

2021-04-13	net: flag relevant Sock methods with [[nodiscard]]	Vasil Dimov

2021-03-16	net: add connect() and getsockopt() wrappers to Sock	Vasil Dimov
	Extend the `Sock` class with wrappers to `connect()` and `getsockopt()`. This will make it possible to mock code which uses those.
2021-03-16	i2p: limit the size of incoming messages	Vasil Dimov
	Put a limit on the amount of data `Sock::RecvUntilTerminator()` can read if no terminator is received. In the case of I2P this avoids a runaway (or malicious) I2P proxy sending us tons of data without a terminator before a timeout is triggered.
2021-03-01	net: extend Sock with a method to check whether connected	Vasil Dimov
	This will be convenient in the I2P SAM implementation.
2021-03-01	net: extend Sock with methods for robust send & read until terminator	Vasil Dimov
	Introduce two high level, convenience methods in the `Sock` class: * `SendComplete()`: keep trying to send the specified data until either successfully sent all of it, timeout or interrupted. * `RecvUntilTerminator()`: read until a terminator is encountered (never after it), timeout or interrupted. These will be convenient in the I2P SAM implementation. `SendComplete()` can also be used in the SOCKS5 implementation instead of calling `send()` directly.
2021-03-01	net: extend Sock::Wait() to report a timeout	Vasil Dimov
	Previously `Sock::Wait()` would not have signaled to the caller whether a timeout or one of the requested events occurred since that was not needed by any of the callers. Such functionality will be needed in the I2P implementation, thus extend the `Sock::Wait()` method.
2021-02-10	net: add RAII socket and use it instead of bare SOCKET	Vasil Dimov
	Introduce a class to manage the lifetime of a socket - when the object that contains the socket goes out of scope, the underlying socket will be closed. In addition, the new `Sock` class has a `Send()`, `Recv()` and `Wait()` methods that can be overridden by unit tests to mock the socket operations. The `Wait()` method also hides the `#ifdef USE_POLL poll() #else select() #endif` technique from higher level code.
2021-02-10	net: move CloseSocket() from netbase to util/sock	Vasil Dimov
	Move `CloseSocket()` (and `NetworkErrorString()` which it uses) from `netbase.{h,cpp}` to newly added `src/util/sock.{h,cpp}`. This is necessary in order to use `CloseSocket()` from a newly introduced Sock class (which will live in `src/util/sock.{h,cpp}`). `sock.{h,cpp}` cannot depend on netbase because netbase will depend on it.