slackcoder/bitcoin - Bitcoin Code integration/staging tree

Age	Commit message (Collapse)	Author
2020-12-07	test: Remove no longer needed MakeChain calls	Russell Yanofsky
	These calls are no longer needed after edc316020e8270dafc5e31465d532baebdafd3dd from #19098 which started instantiating BasicTestingSetup.m_node.chain Patch from MarcoFalke <falke.marco@gmail.com> in https://github.com/bitcoin/bitcoin/pull/19425#discussion_r526701954 Co-authored-by: MarcoFalke <falke.marco@gmail.com>
2020-12-07	refactor: Replace uses ChainActive() in interfaces/chain.cpp	Russell Yanofsky
	Suggested https://github.com/bitcoin/bitcoin/pull/19425#discussion_r456236407
2020-12-07	refactor: Get rid of more redundant chain methods	Russell Yanofsky
	This just drops three interfaces::Chain methods replacing them with other calls. Motivation for removing these chain methods: - Need to get rid of findFirstBlockWithTimeAndHeight for #10102, which doesn't support overloaded methods - Followup from https://github.com/bitcoin/bitcoin/pull/16426#discussion_r412487403 - phantomcircuit comments about findNextBlock test http://www.erisian.com.au/bitcoin-core-dev/log-2020-06-06.html#l-214 Behavior is not changing in any way here. A TODO comment in ScanForWalletTransactions was removed, but just because it was invalid (see https://github.com/bitcoin/bitcoin/pull/19195#discussion_r448020762), not because it was implemented.
2020-04-15	test: Verify findCommonAncestor always initializes outputs	Russell Yanofsky
	Also add code comment to clarify surprising code noted by practicalswift https://github.com/bitcoin/bitcoin/pull/18657#issuecomment-614278450
2020-03-31	wallet: Avoid use of Chain::Lock in CWallet::ScanForWalletTransactions	Russell Yanofsky
	This is a step toward removing the Chain::Lock class and reducing cs_main locking. This change affects behavior in a few small ways. - If there's no max_height specified, percentage progress is measured ending at wallet last processed block instead of node tip - More consistent error reporting: Early check to see if start_block is on the active chain is removed, so start_block is always read and the triggers an error if it's unavailable
2020-03-31	wallet: Avoid use of Chain::Lock in rescanblockchain	Russell Yanofsky
	This is a step toward removing the Chain::Lock class and reducing cs_main locking. This change only affects behavior in the case where wallet last block processed falls behind the chain tip. The rescanblockchain error height error checking will just be stricter in this case and only accept values up to the last processed height
2020-03-31	wallet refactor: Avoid use of Chain::Lock in CWallet::RescanFromTime	Russell Yanofsky
	This is a step toward removing the Chain::Lock class and reducing cs_main locking. This change has no effect on behavior.
2020-03-31	wallet: Avoid use of Chain::Lock in listsinceblock	Russell Yanofsky
	This is a step toward removing the Chain::Lock class and reducing cs_main locking. This change only affects behavior in the case where wallet last block processed falls behind the chain tip. Previously listsinceblock might not have returned all transactions up to the claimed "lastblock" value in this case, resulting in race conditions and potentially missing transactions in cases where listsinceblock was called in a loop like https://github.com/bitcoin/bitcoin/issues/14338#issuecomment-426706574
2020-03-31	wallet: Avoid use of Chain::Lock in importprunedfunds	Russell Yanofsky
	This is a step toward removing the Chain::Lock class and reducing cs_main locking. This change only affects behavior in the case where wallet last block processed falls behind the chain tip, in which case the "Block not found in chain" error will be stricter and not allow importing data from a blocks between the wallet last processed tip and the current node tip.
2020-03-31	refactor: Add interfaces::FoundBlock class to selectively return block data	Russell Yanofsky
	FoundBlock class allows interfaces::Chain::findBlock to return more block information without having lots of optional output parameters. FoundBlock class is also used by other chain methods in upcoming commits. There is mostly no change in behavior. Only exception is CWallet::RescanFromTime now throwing NonFatalCheckError instead of std::logic_error.