Age | Commit message (Collapse) | Author | |
---|---|---|---|
2022-10-28 | rpc: fix crash in deriveaddresses when derivation index is 2147483647 | muxator | |
2147483647 is the maximum positive value of a signed int32, and - currently - the maximum value that the deriveaddresses bitcoin RPC call accepts as derivation index due to its input validation routines. Before this change, when the derivation index (and thus range_end) reached std::numeric_limits<int_32_t>::max(), the "i" variable in the for cycle (which is declared as int, and as such 32 bits in size on most platforms) would be incremented at the end of the first iteration and then warp back to -2147483648. This caused SIGABRT in bitcoind and a core dump. This change assigns "i" an explicit size of 64 bits on every platform, sidestepping the problem. Fixes #26274. Github-Pull: #26275 Rebased-From: addf9d6502db12cebcc5976df3111cac1a369b82 | |||
2022-07-18 | refactor: remove unused using directives | fanquake | |
2022-06-06 | rpc: fix inappropriate warning for address type p2sh-segwit in ↵ | brunoerg | |
createmultisig and addmultisigaddress | |||
2022-05-18 | scripted-diff: Use getInt<T> over get_int/get_int64 | MacroFake | |
-BEGIN VERIFY SCRIPT- sed -i 's|\<get_int64\>|getInt<int64_t>|g' $(git grep -l get_int ':(exclude)src/univalue') sed -i 's|\<get_int\>|getInt<int>|g' $(git grep -l get_int ':(exclude)src/univalue') -END VERIFY SCRIPT- | |||
2022-05-03 | rpc: Move output script RPCs to separate file | MacroFake | |
Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space |