slackcoder/bitcoin - Bitcoin Code integration/staging tree

Age	Commit message (Collapse)	Author
2023-05-20	refactor: Move system from util to common library	TheCharlatan
	Since the kernel library no longer depends on the system file, move it to the common library instead in accordance to the diagram in doc/design/libraries.md.
2023-05-09	scripted-diff: Remove unused chainparamsbase includes	TheCharlatan
	This is a follow-up to previous commits moving the chain constants out of chainparamsbase. The script removes the chainparamsbase header in all files where it is included, but not used. This is done by filtering against all defined symbols of the header as well as its respective .cpp file. The kernel chainparams now no longer relies on chainparamsbase. -BEGIN VERIFY SCRIPT- sed -i '/#include <chainparamsbase.h>/d' $( git grep -l 'chainparamsbase.h' \| xargs grep -L 'CBaseChainParams\\|CreateBaseChainParams\\|SetupChainParamsBaseOptions\\|BaseParams\\|SelectBaseParams\\|chainparamsbase.cpp' ) -END VERIFY SCRIPT-
2023-05-09	refactor: Replace string chain name constants with ChainTypes	TheCharlatan
	This commit effectively moves the definition of these constants out of the chainparamsbase to their own file. Using the ChainType enums provides better type safety compared to passing around strings. The commit is part of an ongoing effort to decouple the libbitcoinkernel library from the ArgsManager and other functionality that should not be part of the kernel library.
2023-04-19	move-only: Extract common/args and common/config.cpp from util/system	TheCharlatan
	This is an extraction of ArgsManager related functions from util/system into their own common file. Config file related functions are moved to common/config.cpp. The background of this commit is an ongoing effort to decouple the libbitcoinkernel library from the ArgsManager. The ArgsManager belongs into the common library, since the kernel library should not depend on it. See doc/design/libraries.md for more information on this rationale.
2022-12-24	scripted-diff: Bump copyright headers	Hennadii Stepanov
	-BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT- Commits of previous years: - 2021: f47dda2c58b5d8d623e0e7ff4e74bc352dfa83d7 - 2020: fa0074e2d82928016a43ca408717154a1c70a4db - 2019: aaaaad6ac95b402fe18d019d67897ced6b316ee0
2022-04-25	Remove not needed clang-format off comments	MarcoFalke
	Can be reviewed with --word-diff-regex=. --ignore-all-space
2022-04-04	refactor: fix clang-tidy named args usage	fanquake

2021-09-21	doc: Fix RPC result documentation	MarcoFalke

2021-04-13	external_signer: remove ExternalSignerException	fanquake
	It's not clear why this need it's own exception class, as opposed to just throwing std::runtime_error().
2021-04-13	external_signer: use const where appropriate	fanquake

2021-04-13	refactor: add missing includes to external signer code	fanquake

2021-04-08	rpc: add help for enumeratesigners and walletdisplayaddress	Sjors Provoost

2021-04-08	Move external signer out of wallet module	Sjors Provoost
	This commit moves the ExternalSigner class and RPC methods out of the wallet module. The enumeratesigners RPC can be used without a wallet since #21417. With additional modifications external signers could be used without a wallet in general, e.g. via signrawtransaction. The signerdisplayaddress RPC is ranamed to walletdisplayaddress because it requires wallet context. A future displayaddress RPC call without wallet context could take a descriptor argument. This commit fixes a rpc_help.py failure when configured with --disable-wallet.