Age | Commit message (Collapse) | Author | |
---|---|---|---|
2018-05-20 | Drop the chain argument to GetDifficulty | Ben Woosley | |
This removes the need to include rpc/blockchain.cpp in order to put GetDifficulty under test. GetDifficulty was called in two ways: * with a guaranteed non-null blockindex * with no argument Change the latter case to be provided chainActive.Tip() explicitly. | |||
2017-06-12 | Remove unnecessary forward class declarations in header files | practicalswift | |
2017-03-29 | refactor: Make rest.cpp dependency on `*toJSON` in `blockchain.cpp` explicit | Wladimir J. van der Laan | |
2017-03-27 | refactor: Move RPCNotifyBlockChange out of `rpc/server.h` | Wladimir J. van der Laan | |
2017-03-27 | refactor: Move GetDifficulty out of `rpc/server.h` | Wladimir J. van der Laan | |
It has no business in `rpcserver.h`. Define it in the interface header of the implementation unit `rpcblockchain` where it is defined. Also modernize the signature to: double GetDifficulty(const CBlockIndex* blockindex = nullptr); (remove `extern`, replace `NULL` with `nullptr`) |