Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
31e9a83 Use CSizeComputer to avoid counting sizes in SerializationOp (Pieter Wuille)
84881f8 rework overhauled serialization methods to non-static (Kamil Domanski)
5d96b4a remove fields of ser_streamplaceholder (Kamil Domanski)
3d796f8 overhaul serialization code (Kamil Domanski)
|
|
|
|
|
|
Thanks to Pieter Wuille for most of the work on this commit.
I did not fixup the overhaul commit, because a rebase conflicted
with "remove fields of ser_streamplaceholder".
I prefer not to risk making a mistake while resolving it.
|
|
The implementation of each class' serialization/deserialization is no longer
passed within a macro. The implementation now lies within a template of form:
template <typename T, typename Stream, typename Operation>
inline static size_t SerializationOp(T thisPtr, Stream& s, Operation ser_action, int nType, int nVersion) {
size_t nSerSize = 0;
/* CODE */
return nSerSize;
}
In cases when codepath should depend on whether or not we are just deserializing
(old fGetSize, fWrite, fRead flags) an additional clause can be used:
bool fRead = boost::is_same<Operation, CSerActionUnserialize>();
The IMPLEMENT_SERIALIZE macro will now be a freestanding clause added within
class' body (similiar to Qt's Q_OBJECT) to implement GetSerializeSize,
Serialize and Unserialize. These are now wrappers around
the "SerializationOp" template.
|
|
When passing a bitcoin: URI on the command line, invalid addresses do not incorrectly send the
user to the test network.
|
|
|
|
- use watch-only, not watchonly
- add back a tooltip hint when hovering addresses and attach
"(watch-only)" at the end
|
|
- also move an added space in a string where it belongs
|
|
- add colors used in TX status decoration
|
|
Needed to build breakage reported by Arnavion on IRC:
qt/splashscreen.cpp: In constructor 'SplashScreen::SplashScreen(const QPixmap&, Qt::WindowFlags, bool)':
qt/splashscreen.cpp:33:98: error: 'FormatFullVersion' was not declared in this scope
|
|
transaction
|
|
Don't clear tray icon menu if it was never created.
Necessary precaution after #4649.
|
|
1c5f0af [Qt] Add column Watch-only to transactions list (Cozz Lovan)
939ed97 Add boolean HaveWatchonly and signal NotifyWatchonlyChanged (Cozz Lovan)
|
|
b197bf3 [Qt] disable tray interactions when client model set to 0 (Philip Kaufmann)
314fbd9 [Qt] use BitcoinGUI::DEFAULT_WALLET constant in bitcoin.cpp (Philip Kaufmann)
8ca6a16 [Qt] ensure all class attributes are init to 0 (Philip Kaufmann)
|
|
Split up util.cpp/h into:
- string utilities (hex, base32, base64): no internal dependencies, no dependency on boost (apart from foreach)
- money utilities (parsesmoney, formatmoney)
- time utilities (gettime*, sleep, format date):
- and the rest (logging, argument parsing, config file parsing)
The latter is basically the environment and OS handling,
and is stripped of all utility functions, so we may want to
rename it to something else than util.cpp/h for clarity (Matt suggested
osinterface).
Breaks dependency of sha256.cpp on all the things pulled in by util.
|
|
|
|
88fe88c gui: remove redundant numTransactions tracking (Wladimir J. van der Laan)
|
|
[Qt] Revert overviewpage from QFormLayout to QVBoxLayout
|
|
`uint64_t` was causing a build error on some systems, as that type is
not known after including just the Qt headers.
|
|
This number was still tracked even though it's shown nowhere in the UI
anymore. It was originally removed because it didn't match the actual number of
records in the view (which contains outputs, not transactions) thus was
confusing people.
|
|
|
|
|
|
c4bae53 [Qt] move SubstituteFonts() above ToolTipToRichTextFilter (Philip Kaufmann)
|
|
Github-Pull: #4678
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
|
|
|
|
|
|
9297763 [Qt] Add TRY_LOCK back to peertablemodel (Cozz Lovan)
|
|
c7f3876 URLs containing a / after the address no longer cause parsing errors. (Ross Nicoll)
|
|
|
|
|
|
- this prevents the ability to fiddle around with the system tray when
already shutting down (e.g. on slow shutdowns because of a proxy delay)
- extends solution for #4360
|
|
|
|
- in BitcoinGUI and UnitDisplayStatusBarControl
|
|
- doesn't belong to the ToolTipToRichTextFilter class so move it up
|
|
- ensure normal and watch-only stuff looks consistent
- simplify UI by removing unneeded UI layout elements
- change some comments to watch-only from watchonly
|
|
|
|
|
|
a409467 more Bitcoin -> Bitcoin Core string changes (Philip Kaufmann)
|
|
ead6737 [Qt] format ping times in peers tab as ms (Philip Kaufmann)
|
|
|
|
- also align ping times to the right
|
|
bd0aa10 Replace the temporary file hack currently used to change Bitcoin-Qt's dock icon (OS X) with a buffer-based solution. (Doug)
|
|
Too spammy.
|
|
- remove starting height as table header and replace with ping time
- remove columnResizingFixer
- add local address (if available) in detailed node view (on top of the
right view below the remote address)
- remove some .c_str() by using QString::fromStdString()
- rename Address to Address/Hostname
- rename secs to just s for ping time
- use MODEL_UPDATE_DELAY from guiconstants.h for the peer refresh time
- make PeerTableModel::columnCount() return no hard-coded value
- remove and cleanup dup private: section in RPCConsole header
- add new defaults for column sizes
- remove behaviour which keeps disconnected peers selected and also remove
code which keeps track of last selected peer stats
- add sync height to detail view
- add some additional NULL pointer checks for clientModel in
rpcconsole.cpp
|
|
Github-Pull: #4619
|
|
bdba2dd qt: Remove an obscure option no-one cares about (Wladimir J. van der Laan)
|