slackcoder/bitcoin - Bitcoin Code integration/staging tree

Age	Commit message (Collapse)	Author
2022-06-21	test, qt: Add tests for `GUIUtil::extractFirstSuffixFromFilter`	w0xlt

2022-05-26	Migrate -prune setting from QSettings to settings.json	Ryan Ofsky

2022-05-26	Migrate -proxy and -onion settings from QSettings to settings.json	Ryan Ofsky

2022-05-26	Migrate -listen and -server settings from QSettings to settings.json	Ryan Ofsky

2022-05-26	Migrate -upnp and -natpmp settings from QSettings to settings.json	Ryan Ofsky
	This also effectively reverts 58e8364dcdc4e57b0caac09f8402e6535301de9b from #18077, applying upnp and natpmp settings from the optionsmodel class instead of the optionsdialog class. This makes sense because model code, not view code is responsible for applying all other settings, and because leaving these settings half-applied in optionsmodel seems error prone and could lead to bugs. (These things were discussed a little in https://github.com/bitcoin/bitcoin/pull/18077#discussion_r560381734)
2022-05-26	Migrate -par setting from QSettings to settings.json	Ryan Ofsky

2022-05-26	Migrate -dbcache setting from QSettings to settings.json	Ryan Ofsky
	This is just the first of multiple settings that will be stored in the bitcoin persistent setting file and shared with bitcoind, instead of being stored as Qt settings backed by the windows registry or platform specific config files which are ignored by bitcoind. Co-Authored-By: furszy <matiasfurszyfer@protonmail.com>
2022-05-19	refactor: Pass interfaces::Node references to OptionsModel constructor	Ryan Ofsky
	Will allow OptionsModel to read/write settings to the node settings.json file and share settings with the node, instead of storing them externally in QSettings. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
2022-04-01	test: add regression test for bitcoin-core/gui/issues/567	Vasil Dimov

2022-03-07	qt: Avoid crash on startup if int specified in settings.json	Ryan Ofsky
	Fix GUI startup crash reported by Rspigler in https://github.com/bitcoin/bitcoin/issues/24457 that happens if settings.json contains an integer value for any of the configuration options which GUI settings can currently clash with (-dbcache, -par, -spendzeroconfchange, -signer, -upnp, -natpmp, -listen, -server, -proxy, -proxy, -onion, -onion, -lang, and -prune). Fix is a one-line change in ArgsManager::GetArg.
2022-03-07	test: Add tests for GetArg methods / settings.json type coercion	Ryan Ofsky
	Just add tests. No changes to application behavior. Tests will be updated in the next commit changing & improving current behavior. Include a Qt test for GUI startup crash reported by Rspigler in https://github.com/bitcoin/bitcoin/issues/24457 caused by GetArg behavior that happens if settings.json contains an integer value for any of the configuration options which GUI settings can currently clash with (-dbcache, -par, -spendzeroconfchange, -signer, -upnp, -natpmp, -listen, -server, -proxy, -proxy, -onion, -onion, -lang, and -prune).