slackcoder/bitcoin - Bitcoin Code integration/staging tree

Age	Commit message (Collapse)	Author
2021-03-10	compat: remove memcpy -> memmove backwards compatibility alias	fanquake
	In glib 2.13 memcpy was changed such that the way it copied bytes was reversed. This caused all sorts of issues for existing software, which depended on the existing behavior (when they should have been using memmove). See: https://sourceware.org/bugzilla/show_bug.cgi?id=12518 https://bugzilla.redhat.com/show_bug.cgi?id=638477 Now that we require glibc 2.17+ (#17538), we should be well clear of having to maintain our memcpy -> memmove aliasing, which was introduced in #4339.
2020-12-31	scripted-diff: Bump copyright headers	MarcoFalke
	-BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT-
2020-05-07	test: remove glibc fdelt sanity check	fanquake
	As is, this sanity check doesn't seem to be testing fdelt_chk, because passing a value of "0" to FD_SET wont cause the compiler to insert any calls to fdelt_chk(). The documentation is a little misleading. If we actually triggered fdelt_chk at runtime, bitcoind would abort. I think this check would be better replaced (if possible) by additional checks in security-check.py. The compiler may insert a call to fdelt_warn() (aliased with fdelt_chk in glibc) at compile time if it can determine that an invalid value is being passed to FD_SET. These checks are essentially; value < 0 or value >= FD_SETSIZE along with a check for wether the value is a compile time constant. If the compiler can determine an invalid value is being passed, a call to fdelt_warn will be inserted. Passing 0 should never cause a call to be inserted. You can check this after compiling: ```bash objdump -dC bitcoind \| grep sanity_fdelt ... 0000000000399d20 <sanity_test_fdelt()>: 399d20: 48 81 ec 98 00 00 00 sub $0x98,%rsp 399d27: b9 10 00 00 00 mov $0x10,%ecx 399d2c: 64 48 8b 04 25 28 00 mov %fs:0x28,%rax 399d33: 00 00 399d35: 48 89 84 24 88 00 00 mov %rax,0x88(%rsp) 399d3c: 00 399d3d: 31 c0 xor %eax,%eax 399d3f: 48 89 e7 mov %rsp,%rdi 399d42: fc cld 399d43: f3 48 ab rep stos %rax,%es:(%rdi) 399d46: 48 8b 84 24 88 00 00 mov 0x88(%rsp),%rax 399d4d: 00 399d4e: 64 48 33 04 25 28 00 xor %fs:0x28,%rax 399d55: 00 00 399d57: 75 0d jne 399d66 <sanity_test_fdelt()+0x46> 399d59: b8 01 00 00 00 mov $0x1,%eax 399d5e: 48 81 c4 98 00 00 00 add $0x98,%rsp 399d65: c3 retq 399d66: e8 85 df c8 ff callq 27cf0 <__stack_chk_fail@plt> 399d6b: 0f 1f 44 00 00 nopl 0x0(%rax,%rax,1) ``` To test, you could modify this test to pass -1 to FD_SET, and check that a call to fdelt_warn() is inserted, and that running bitcoind fails. i.e: ```bash 0000000000399d20 <sanity_test_fdelt()>: 399d20: 48 81 ec 98 00 00 00 sub $0x98,%rsp 399d27: b9 10 00 00 00 mov $0x10,%ecx 399d2c: 64 48 8b 04 25 28 00 mov %fs:0x28,%rax 399d33: 00 00 399d35: 48 89 84 24 88 00 00 mov %rax,0x88(%rsp) 399d3c: 00 399d3d: 31 c0 xor %eax,%eax 399d3f: 48 89 e7 mov %rsp,%rdi 399d42: fc cld 399d43: f3 48 ab rep stos %rax,%es:(%rdi) 399d46: 48 c7 c7 ff ff ff ff mov $0xffffffffffffffff,%rdi 399d4d: e8 3e ff ff ff callq 399c90 <__fdelt_warn> 399d52: 0f b6 04 24 movzbl (%rsp),%eax 399d56: 83 e0 01 and $0x1,%eax 399d59: 48 8b 94 24 88 00 00 mov 0x88(%rsp),%rdx 399d60: 00 399d61: 64 48 33 14 25 28 00 xor %fs:0x28,%rdx 399d68: 00 00 399d6a: 75 08 jne 399d74 <sanity_test_fdelt()+0x54> 399d6c: 48 81 c4 98 00 00 00 add $0x98,%rsp 399d73: c3 retq 399d74: e8 77 df c8 ff callq 27cf0 <__stack_chk_fail@plt> 399d79: 0f 1f 80 00 00 00 00 nopl 0x0(%rax) ``` ```bash ./src/bitcoind * buffer overflow detected *: src/bitcoind terminated Aborted ```
2019-04-13	[moveonly] Split glibc sanity_test_fdelt out	Ben Woosley

2018-07-27	Update copyright headers to 2018	DrahtBot

2018-01-03	Increment MIT Licence copyright header year on files modified in 2017	Akira Takizawa

2017-11-16	scripted-diff: Replace #include "" with #include <> (ryanofsky)	MeshCollider
	-BEGIN VERIFY SCRIPT- for f in \ src/.cpp \ src/.h \ src/bench/.cpp \ src/bench/.h \ src/compat/.cpp \ src/compat/.h \ src/consensus/.cpp \ src/consensus/.h \ src/crypto/.cpp \ src/crypto/.h \ src/crypto/ctaes/.h \ src/policy/.cpp \ src/policy/.h \ src/primitives/.cpp \ src/primitives/.h \ src/qt/.cpp \ src/qt/.h \ src/qt/test/.cpp \ src/qt/test/.h \ src/rpc/.cpp \ src/rpc/.h \ src/script/.cpp \ src/script/.h \ src/support/.cpp \ src/support/.h \ src/support/allocators/.h \ src/test/.cpp \ src/test/.h \ src/wallet/.cpp \ src/wallet/.h \ src/wallet/test/.cpp \ src/wallet/test/.h \ src/zmq/.cpp \ src/zmq/.h do base=${f%/}/ relbase=${base#src/} sed -i "s:#include \"$.$\"$.*$:if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
2017-05-31	[trivial] Add end of namespace comments	practicalswift

2014-12-19	Added "Core" to copyright headers	sandakersmann
	Github-Pull: #5494 Rebased-From: 15de949bb9277e442302bdd8dee299a8d6deee60
2014-09-29	update license of compat and crypto	Philip Kaufmann
	- change license to be just MIT for all files in compat and crypto - also add missing header end comments - ensure default header include style
2014-09-25	Apply clang-format on crypto/* and compat/*	Pieter Wuille

2014-06-23	build: fix build weirdness after 54372482.	Cory Fields
	bitcoin-config.h moved, but the old file is likely to still exist when reconfiguring or switching branches. This would've caused files to not rebuild correctly, and other strange problems. Make the path explicit so that the old one cannot be found. Core libs use config/bitcoin-config.h. Libs (like crypto) which don't want access to bitcoin's headers continue to use -Iconfig and #include bitcoin-config.h.
2014-06-21	small cleanup in src/compat .h and .cpp	Philip Kaufmann
	- add license header - fix include guards - fix indentation
2014-06-16	sanity: add libc/stdlib sanity checks	Cory Fields
	These are meant to test our back-compat stubs, but they are enabled for all builds for the sake of consistency.