aboutsummaryrefslogtreecommitdiff
path: root/qa
AgeCommit message (Collapse)Author
2016-11-07Merge #9026: Fix handling of invalid compact blocksPieter Wuille
d4833ff Bump the protocol version to distinguish new banning behavior. (Suhas Daftuar) 88c3549 Fix compact block handling to not ban if block is invalid (Suhas Daftuar) c93beac [qa] Test that invalid compactblocks don't result in ban (Suhas Daftuar)
2016-11-07[qa] Respond to getheaders and do not assume a getdata on invMatt Corallo
2016-11-07[qa] Make comptool push blocks instead of relying on inv-fetchmrbandrews
2016-11-07[qa] test_framework: Exit when tmpdir existsMarcoFalke
2016-11-07[qa] util: Rework sync_*()MarcoFalke
* Only allow named args in sync_*() * Make sync_* fails more verbose * Add timeout to sync_chain()
2016-11-07Modify getblocktxn handler not to drop requests for old blocksRussell Yanofsky
The current getblocktxn implementation drops and ignores requests for old blocks, which causes occasional sync_block timeouts during the p2p-compactblocks.py test as reported in https://github.com/bitcoin/bitcoin/issues/8842. The p2p-compactblocks.py test setup creates many new blocks in a short period of time, which can lead to getblocktxn requests for blocks below the hardcoded depth limit of 10 blocks. This commit changes the getblocktxn handler not to ignore these requests, so the peer nodes in the test setup will reliably be able to sync. The protocol change is documented in BIP-152 update "Allow block responses to getblocktxn requests" at https://github.com/bitcoin/bips/pull/469. The protocol change is not expected to affect nodes running outside the test environment, because there shouldn't normally be lots of new blocks being rapidly added that need to be synced.
2016-11-07[qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__MarcoFalke
2016-11-07Merge #9077: [qa] Increase wallet-dump RPC timeoutMarcoFalke
e89614b [qa] Add more helpful RPC timeout message (Russell Yanofsky) 8463aaa [qa] Increase wallet-dump RPC timeout (Russell Yanofsky)
2016-11-07[qa] Add more helpful RPC timeout messageRussell Yanofsky
Replace previous timeout('timed out',) exception with more detailed error.
2016-11-07[qa] Increase wallet-dump RPC timeoutRussell Yanofsky
Increase wallet-dump RPC timeout from 30 seconds to 1 minute. This avoids a timeout error that seemed to happen regularly (around 50% of builds) on a particular jenkins server during the first getnewaddress RPC call made by the test. The failing stack trace looked like: Unexpected exception caught during testing: timeout('timed out',) File ".../bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 146, in main self.run_test() File ".../bitcoin/qa/rpc-tests/wallet-dump.py", line 73, in run_test addr = self.nodes[0].getnewaddress() File ".../bitcoin/qa/rpc-tests/test_framework/coverage.py", line 49, in __call__ return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs) File ".../bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 145, in __call__ response = self._request('POST', self.__url.path, postdata.encode('utf-8')) File ".../bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 121, in _request return self._get_response() File ".../bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 160, in _get_response http_response = self.__conn.getresponse() File "/usr/lib/python3.4/http/client.py", line 1171, in getresponse response.begin() File "/usr/lib/python3.4/http/client.py", line 351, in begin version, status, reason = self._read_status() File "/usr/lib/python3.4/http/client.py", line 313, in _read_status line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1") File "/usr/lib/python3.4/socket.py", line 374, in readinto return self._sock.recv_into(b)
2016-11-06[copyright] copyright header style uniformisle2983
Three categories of modifications: 1) 1 instance of 'The Bitcoin Core developers \n', 1 instance of 'the Bitcoin Core developers\n', 3 instances of 'Bitcoin Core Developers\n', and 12 instances of 'The Bitcoin developers\n' are made uniform with the 443 instances of 'The Bitcoin Core developers\n' 2) 3 instances of 'BitPay, Inc\.\n' are made uniform with the other 6 instances of 'BitPay Inc\.\n' 3) 4 instances where there was no '(c)' between the 'Copyright' and the year where it deviates from the style of the local directory.
2016-11-03[qa] Test that invalid compactblocks don't result in banSuhas Daftuar
2016-11-02[qa] Fix stale data bug in test_compactblocks_not_at_tipRussell Yanofsky
Clear test_node.last_block before requesting blocks in the compactblocks_not_at_tip test so comparisons won't fail if a blocks were received before the test started. The bug doesn't currently cause any problems due to the order tests run, but this will change in the next commit.
2016-11-02[qa] Fix bug in compactblocks v2 mergeRussell Yanofsky
Bug caused the wait_for_block_announcement to be called on the wrong node, leading to nondeterminism and occasional test failures. Bug was introduced in merge commit: d075479 Merge #8882: [qa] Fix race conditions in p2p-compactblocks.py and sendheaders.py Underlying commits which conflicted were: 27acfc1 [qa] Update p2p-compactblocks.py for compactblocks v2 6976db2 [qa] Another attempt to fix race condition in p2p-compactblocks.py The first commit changed the test_compactblock_construction function signature and second commit added code which wasn't updated during the merge to use the new arguments. Suhas Daftuar <sdaftuar@chaincode.com> noticed the bug and suggested the fix.
2016-10-20Merge #7551: Add importmulti RPC callWladimir J. van der Laan
215caba Add consistency check to RPC call importmulti (Pedro Branco) cb08fdb Add importmulti rpc call (Pedro Branco)
2016-10-19Add consistency check to RPC call importmultiPedro Branco
2016-10-19Add importmulti rpc callPedro Branco
2016-10-19RPC: augment getblockchaininfo bip9_softforks datamruddy
2016-10-18Merge #6996: Add preciousblock RPCWladimir J. van der Laan
5805ac8 Add preciousblock tests (Pieter Wuille) 5127c4f Add preciousblock RPC (Pieter Wuille)
2016-10-17Align constant names for maximum compact block / blocktxn depthPieter Wuille
2016-10-17More agressively filter compact block requestsMatt Corallo
Unit test adaptations by Pieter Wuille.
2016-10-17Merge #8499: Add several policy limits and disable uncompressed keys for ↵Wladimir J. van der Laan
segwit scripts 67d6ee1 remove redundant tests in p2p-segwit.py (Johnson Lau) 9260085 test segwit uncompressed key fixes (Johnson Lau) 248f3a7 Fix ismine and addwitnessaddress: no uncompressed keys in segwit (Pieter Wuille) b811124 [qa] Add tests for uncompressed pubkeys in segwit (Suhas Daftuar) 9f0397a Make test framework produce lowS signatures (Johnson Lau) 4c0c25a Require compressed keys in segwit as policy and disable signing with uncompressed keys for segwit scripts (Johnson Lau) 3ade2f6 Add standard limits for P2WSH with tests (Johnson Lau)
2016-10-17remove redundant tests in p2p-segwit.pyJohnson Lau
2016-10-17test segwit uncompressed key fixesJohnson Lau
2016-10-16[qa] Add tests for uncompressed pubkeys in segwitSuhas Daftuar
2016-10-16Make test framework produce lowS signaturesJohnson Lau
2016-10-16Add standard limits for P2WSH with testsJohnson Lau
2016-10-15[qa] Build v4 blocks in p2p-compactblocktestsMatt Corallo
This fixes an issue in backporting to 0.13 as 0.13 enforces SF activation by block version lockin instead of through a hard-coded block height.
2016-10-14[qa] Send segwit-encoded blocktxn messages in p2p-compactblocksMatt Corallo
2016-10-13Merge #8904: [qa] Fix compact block shortids for a test caseWladimir J. van der Laan
4cdece4 [qa] Fix compact block shortids for a test case (Dagur Valberg Johannsson)
2016-10-11Merge #8882: [qa] Fix race conditions in p2p-compactblocks.py and sendheaders.pyMarcoFalke
b55d941 [qa] Fix race condition in sendheaders.py (Suhas Daftuar) 6976db2 [qa] Another attempt to fix race condition in p2p-compactblocks.py (Suhas Daftuar)
2016-10-10[qa] Fix compact block shortids for a test caseDagur Valberg Johannsson
2016-10-06[qa] Fix race condition in sendheaders.pySuhas Daftuar
Also de-duplicates code that has been moved to mininode
2016-10-04[qa] Another attempt to fix race condition in p2p-compactblocks.pySuhas Daftuar
sync_with_ping() only guarantees that the node has processed messages it's received from the peer, not that block announcements from the node have made it back to the peer. Replace sync_with_ping() with an explicit check that the node's tip has been announced.
2016-10-04[qa] Update p2p-compactblocks.py for compactblocks v2Suhas Daftuar
2016-10-04[qa] Add support for compactblocks v2 to mininodeSuhas Daftuar
2016-10-04[qa] Fix bug in mininode witness deserializationSuhas Daftuar
Also improve tx printing
2016-10-04Fix overly-prescriptive p2p-segwit test for new fetch logicMatt Corallo
2016-10-03Merge #8860: [qa] util: Move wait_bitcoinds() into stop_nodes()MarcoFalke
fa7c35c [qa] util: Move wait_bitcoinds() into stop_nodes() (MarcoFalke)
2016-10-02[qa] mininode: Only allow named args in wait_untilMarcoFalke
2016-10-02[qa] util: Move wait_bitcoinds() into stop_nodes()MarcoFalke
2016-10-01Merge #8854: [qa] Fix race condition in p2p-compactblocks testMarcoFalke
b5fd666 [qa] Fix race condition in p2p-compactblocks test (Suhas Daftuar)
2016-09-30[qa] Fix race condition in p2p-compactblocks testSuhas Daftuar
Also fix a bug in the sync_with_ping() helper function
2016-09-30Merge #8839: test: Avoid ConnectionResetErrors during RPC testsWladimir J. van der Laan
1d28faf test: Avoid ConnectionResetErrors during RPC tests (Wladimir J. van der Laan)
2016-09-30Merge #8840: test: Explicitly set encoding to utf8 when opening text filesWladimir J. van der Laan
30930e8 test: Explicitly set encoding to utf8 when opening text files (Wladimir J. van der Laan)
2016-09-30Merge #8841: [qa] fix nulldummy testWladimir J. van der Laan
46a4774 Fix nulldummy.py test (Johnson Lau)
2016-09-30Fix nulldummy.py testJohnson Lau
2016-09-29test: Explicitly set encoding to utf8 when opening text filesWladimir J. van der Laan
These are text files but their encoding does not depend on the locale. Not all of them require utf8 but it is better to fix it at something to remove potential unpredictability. This is necessary on FreeBSD where no locale is set by default, and apparently Python defaults not only the terminal encoding to the locale but that of every text file. So without LOCALE environment it defaults text file encoding to ASCII. This causes problems with e.g. `bitcoin.conf`. Luckily the locale doesn't affect the default encoding for str.encode() and bytes.decode() on Python 3, so this is the only change necessary.
2016-09-29Merge #8834: [qa] blockstore: Switch to dumb dbmWladimir J. van der Laan
fa9cd25 [qa] blockstore: Switch to dumb dbm (MarcoFalke)
2016-09-29test: Avoid ConnectionResetErrors during RPC testsWladimir J. van der Laan
This is necessary on FreeBSD and MacOSX, at least. See https://github.com/bitcoin/bitcoin/pull/8834#issuecomment-250450213