| Age | Commit message (Collapse) | Author |
|---|
|
1fca9811e1331ac5dae8188f6178cc37da4929a7 lint: Skip whitespace lint for guix patches (Carl Dong)
a91c46c57d88fc399432afab7bb0fb14c3e490a7 guix: Make nsis reproducible by respecting SOURCE-DATE-EPOCH (Carl Dong)
Pull request description:
```
When building nsis, if VERSION is not specified, it defaults to
cvs_version which is non-deterministic as it includes the current date.
This patches nsis to default to SOURCE_DATE_EPOCH if it exists so that
nsis is reproducible.
Upstream change: https://github.com/kichik/nsis/pull/13
```
Sidenote: also a good demonstration of how Guix allows us to flexibly patch our tools!
Note to reviewers: if you want to compare hashes, please build after Jan 16th 2021 without my substitute server enabled!
ACKs for top commit:
fanquake:
ACK 1fca9811e1331ac5dae8188f6178cc37da4929a7
Tree-SHA512: b800e0ce5f73827ad353739effb9167ec3a6bdb362c725ae20dd3f025ce78660f85c70ce1d75cd0896facf1e8fe38a9e058459ed13dec71ab3a2fe41e20eaa5d
|
|
92370033a2606ee88f4d080193e0bf6da481dc2e contrib: embed C++11 patch in install_db4.sh (jackielove4u)
Pull request description:
This is a continuation of https://github.com/bitcoin/bitcoin/pull/20665.
Closes #20722.
ACKs for top commit:
laanwj:
ACK 92370033a2606ee88f4d080193e0bf6da481dc2e
fanquake:
ACK 92370033a2606ee88f4d080193e0bf6da481dc2e.
Tree-SHA512: ebfd16f5301158de1acc1b8eeca43b3d94f0a6d438832133a30648e5e8a88268b4af983be0bb57f3018e3af8459f32f0de676c1b4e8942e199a4497c776631c5
|
|
2c403279e2f0f7c8c27c56d4e7b0573c59571f0a gitian: Remove codesign_allocate and pagestuff from MacOS build (Andrew Chow)
f55eed251488d70d5e2e3a2965a4f8ec0c476853 gitian: use signapple to create the MacOS code signature (Andrew Chow)
95b06d21852b28712db6c710e420a58bdc1a0944 gitian: use signapple to apply the MacOS code signature (Andrew Chow)
42bb1ea363286b088257cabccb686ef1887c1d3b gitian: install signapple in gitian-osx-signer.yml (Andrew Chow)
Pull request description:
The MacOS code signing issues that were encountered during the 0.21.0 release cycle have shown that it is necessary for us to use a code signing tool for which the source code is available and modifiable by us. Given that there appears to not be such a tool available, I have written such a tool, [signapple](https://github.com/achow101/signapple), that we can use. This tool is able to create a valid MacOS code signature, detach it in a way that we were doing previously, and attach it to the unsigned binary. This tool can also verify that the signature is correct.
This PR implements the usage of that tool in the gitian build for the code signed MacOS binary. The code signer will use this tool to create the detached signature. Gitian builders will use this tool to apply the detached signature. The `gitian-osx-signer.yml` descriptor has been modified to install this tool so that the `detached-sig-apply.sh` script can use it. Additionally, the `codesign_allocate` and `pagestuff` tools are no longer necessary so they are no longer added to the tarball used in code signing. Lastly, both the `detached-sig-create.sh` and `detached-sig-apply.sh` scripts are made to be significantly less complex and to not do unexpected things such as unpacking an already unpacked tarball.
The detached code signature that signapple creates is almost identical to that which we were previously creating. The only difference is that the cpu architecture name is included in the extension (e.g. we have `bitcoin-qt.x86_64sign` instead of `bitcoin-qt.sign`). This was done in order to support signing universal binaries which we may want to do in the future. However signapple can still apply existing code signatures as it will accept the `.sign` extension. If it is desired, it can be modified to produce signatures with just the `.sign` extension. However I do not think it is necessary to maintain compatibility with the old process.
ACKs for top commit:
laanwj:
Code review ACK 2c403279e2f0f7c8c27c56d4e7b0573c59571f0a
Tree-SHA512: 2a0e01e9133f8859b9de26e7e8fe1d2610d2cbdee2845e6008b12c083c7e3622cbb2d9b83c50a269e2c3074ab95914a8225d3cd4108017f58b77a62bf10951e0
|
|
9d026546778629472574b26fa73338efc63d02da doc: Fix systemd spelling and link to doc/init.md (Hennadii Stepanov)
601778c3107adbd8d96eb0bb5c16a9d0a4b81594 script: Add Documentation key to bitcoind.service (Hennadii Stepanov)
d9392b724cae53b7a16fa5f84ebe152eea496502 script: Improve robustness of bitcoind.service on startup (Hennadii Stepanov)
Pull request description:
If network interfaces are not properly up the following happens:
```
...
2021-01-08T10:17:11Z scheduler thread start
2021-01-08T10:17:11Z libevent: getaddrinfo: address family for nodename not supported
2021-01-08T10:17:11Z Binding RPC on address 127.0.0.1 port 8332 failed.
2021-01-08T10:17:11Z HTTP: creating work queue of depth 16
2021-01-08T10:17:11Z Using random cookie authentication.
2021-01-08T10:17:11Z Generated RPC authentication cookie /var/lib/bitcoind/.cookie
2021-01-08T10:17:11Z HTTP: starting 2 worker threads
2021-01-08T10:17:11Z init message: Loading banlist...
2021-01-08T10:17:11Z SetNetworkActive: true
2021-01-08T10:17:11Z Error: Cannot resolve -externalip address: <EDITED>
2021-01-08T10:17:11Z Shutdown: In progress...
2021-01-08T10:17:11Z scheduler thread exit
2021-01-08T10:17:11Z Shutdown: done
```
This PR improves robustness on startup in such cases in documented way:
https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
Also minor doc improvements are added.
ACKs for top commit:
Sjors:
ACK 9d02654
practicalswift:
ACK 9d026546778629472574b26fa73338efc63d02da: patch looks correct
darosior:
ACK 9d026546778629472574b26fa73338efc63d02da -- been using the first patch too
Tree-SHA512: 38294f5682c09e6ea9008de7d7459098c920cf1b98ad8ef8a5d2ca01f2f781c0fec5591dc40ef36eeb19d94991b0c7fb7cb38c4e716bc7219875c9bcd0a55e1b
|
|
When building nsis, if VERSION is not specified, it defaults to
cvs_version which is non-deterministic as it includes the current date.
This patches nsis to default to SOURCE_DATE_EPOCH if it exists so that
nsis is reproducible.
Upstream change: https://github.com/kichik/nsis/pull/13
|
|
- Add `-version` option to `bitcoin-util`
- Add `bitcoin-util` call to `gen-manpages.sh`
- Add stub manual page `bitcoin-util.1`
- Add install of `bitcoin-util.1` to build system
|
|
595a34dbea01954cb0372b0210d2fd64357a1762 contrib/signet: Document miner script in README.md (Anthony Towns)
ff7dbdc08a11e999e7718b6ac7645ecceef81188 contrib/signet: Add script for generating a signet chain (Anthony Towns)
13762bcc9618138dd28b53c2031defdc9d762d26 Add bitcoin-util command line utility (Anthony Towns)
95d5d5e6257825bb385cee318d5681597f7f7646 rpc: allow getblocktemplate for test chains when unconnected or in IBD (Anthony Towns)
81c54dec20891f2627a49b2e3e785fdaf2a1e664 rpc: update getblocktemplate with signet rule, include signet_challenge (Anthony Towns)
Pull request description:
Adds `contrib/signet/miner` for mining signet blocks.
Adds `bitcoin-util` cli utility, with the idea being it can provide bitcoin related functionality that does not rely on the ability to access a running node. Only subcommand currently is "grind" which takes a hex-encoded header and grinds its nonce until its nBits is satisfied.
Updates `getblocktemplate` to include `signet_challenge` field, and makes `getblocktemplate` require the signet rule when invoked on the signet change. Removes connectivity and IBD checks from `getblocktemplate` when applied to a test chain (regtest, testnet, signet).
ACKs for top commit:
laanwj:
code review ACK 595a34dbea01954cb0372b0210d2fd64357a1762
Tree-SHA512: 8d43297710fdc1edc58acd9b53e1bd1671e5724f7097b40ab73653715dc8becc70534c4496cbba9290f4dd6538a7a3d5830eb85f83391ea31a3bb5b9d3378cc3
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
See https://www.freedesktop.org/wiki/Software/systemd/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
f2d93b229d8a95c0ff6c6cb9253d11cceec9d5d8 gitian-keys: add miketwenty1 key (Michael Tidwell)
Pull request description:
in ref to:
bitcoin-core/gitian.sigs#1427
ACKs for top commit:
laanwj:
ACK f2d93b229d8a95c0ff6c6cb9253d11cceec9d5d8
Tree-SHA512: 895935981ada0c3a094adde556b86b73dc440b599f8d6e2a7dd1e82592351c820b797c64a3e0fa1e79ab4c2f992afb3363b4a12625a54bdfbdea75b5a19d7e95
|
|
|
|
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
My key is F4FC70F07310028424EFC20A8E4256593F177720
(Oliver Gugger <gugger@gmail.com>)
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEbgHuyWVpA7BUK48QA9tjIiZ8NzsFAl/0uXEACgkQA9tjIiZ8
NzsMeQgAiuj0PqUQYRn3xyxdqAGpN/JdUgCC0HjolW44kDPvij1Tb1ZrvSQD1Amh
H0XLca+eROGmdgSMNFIBcsh4/Ikh11hRVsbDtf2v2Q3xuM6abklzCFZto47QFgf6
PZZIVUu9MespkOXOa8NK+nhsq241S6gp+dJkd39sW0q1+B7/7zVoV1v2tSCxkKeI
x8TbHfH+BGhB0I7Kwanz/tz5rX5U7GdF8ajjKg4p/Z303UP6+j+j5eT4b8WJKVKN
9N9mtx9h0sgo/i3Vk6KZ7Y74YYH3e3FL7ZVaoWxZgDPX79724F2l7K8n3q60F2X7
jhB7uMTZ2trD7A2qtrpK7HnRVYlbVA==
=AOM6
-----END PGP SIGNATURE-----
|
|
-----BEGIN PGP PUBLIC KEY BLOCK-----
mQGNBFvwGvYBDADiZ/8Vi95xgj1GX/1Bot+y+MM/OSoJaXXQRnBGUjO5WLGG79Wh
cdQR53JZ7+MN7kHk/R7ZNjtTJdQi3HYfeDUQdQpknuNJN3qLrLuZ93jIhagvKfmJ
MpXhxikz/D3O67kLmbh+qUEhyMB8SvyUxbAaA/5laLeAdxeFWuVvFmngpnRKIAoa
k2PgPEO36+ghAb72GjSHtSFFIK+zn/dimHpLIOjKvERLoWGUSaXo/M5Uy1r67gke
TA3MyMGe1TU2SyMZEZR6LLOtPs0kxf5eU4blEpWs26/UdIAfKfayTnkvqpBHI1TR
6wbH7HlQVB8I1QrDg51oFDZ6DazKyNgnIAlWiM10Q2PlUunnT7NFfPSgDkAw/tR/
xsAMFbPT5NAD4TYqnK3NBlSTVNTmvyyy7EwQv0b1kO2fM/IYZ8XsJtCVJvaNXSbW
VoueDX5ZQ5z3ja/Y/Y7SSUbdJcMiNYrQZ/GbvwiNvjkmBR9UCBi7fSeRMQgl6tIK
ctIwqb7a4UjO42cAEQEAAbQpQW50b2luZSBQb2luc290IDxkYXJvc2lvckBwcm90
b25tYWlsLmNvbT6JAdcEEwEIAEEFCQYonioFCwkIBwIGFQoJCAsCBBYCAwECHgEC
F4ACGQEWIQRZC3KSaVr/pbZyy7LhP8FFzT9DBAUCX8I0iwIbDwAKCRDhP8FFzT9D
BKOQDACedmkzuKME1kS3heZGx7fezOJF9vNUuqKiP8eSCauZrWZCe02biyB5MGF6
20nijrxIpsiOfcr2iJJGvk4FQxmuZUFwM+r3+lJZTmBiEMWk9U/G/FLHEbTgIMOT
ehSzQZmp4S98FcChvNdxdXBMZMf/xrDVVqBWk8oBTEkQipVuQp3Jx8phl2ICCkU5
ni9e5ZMVI3zkdSm2DmlhK08tW+5iMczeGt9n9LMr2w3AVRPVIfIhYTf4mwCVfoLF
ScpurBljyVNm1Rwjs63hdN01jx27pSqDIntGTS/R8hJZrxNEn1Tb5zXGHhtDDZ3i
CTb0ANw32bQoQEJOdCHjryWQnFUn81MP1uf5NoKwsWYqHU8JU5dt4egZslwGrg6w
32jGG3fonrcRMblrO3dxd2LGwFpim4cQ7vxwdqaotDs6Wo3NSGkjrDaN0p7Lt2VO
LkIMWm1IYyW9gGHYfaw7XYSA/Nj4SAqkQTX+yHBidl5rBSBNM2u6nGLOCSidWxu/
iDByidOJAjMEEAEKAB0WIQTcD5pmgKm5i5kyhYGqIUI/fgqb5gUCX7G19QAKCRCq
IUI/fgqb5s1KD/4itFySsRwQFkJkg/QTvA7oi4h/oyASvhXC1vECO5OHYaxt49ok
KdkZOJRblD3weyUbbQ54OxvPvIadgxzwWYm6qqsXmRCt7C4lY1xSgyk5ct8n2Ytb
DzzNBuYRhdu9Qti28SY6EHvvjOE1gQTx1B+bkv75ih3KZrlURvJ8Rgdbc11BJDk8
3Q6fP27peqC5WbQOufY7ncfI+Dw9ecgffOPFINKYDAg8A22bDci0LNQG5xOkp+pl
VGKTf3TJdQSUelF62gqrFrY1EcgR3wP8kh2J2S3hBKiSUzN5bX3db2r8y03MOmiD
BKIjoWqSBC1ZfRuqfqqAJgTPIp0NzSK3tOpQYPRX5PrrKW+uRmQQsqC2rrF1Wj9T
hQ0Yxn6gbpbhSP7fAAepmlE64IxeaIXRgcHQ2Jog+3TkSDXXwURstjvVzmOg0NeP
FCsSXXau9eIvvXoO1BYsbV1XN2Rvp8DxvsGiukqK7t6qOq5PZHJoBB0nzD9vmFyz
Vz6X9yeKbbx50ocWV4OC55pIZFz8sKzW0FyPn97QQftfVGAbn82bBjAEEAzRujMx
qqE7Y13r0OzVwOd4k1e5o2GbcHi6xJHHFOgcYDKm7ye5E8CDmwn4VHSh/YXSXQph
2fFCLOJxx3dAaJ+0xMZb8auHsjBRJpyKCWX8IptRoW4ZrI+KSYm4ncsGmYkB1wQT
AQgAQQIbAwUJBiieKgULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBFkLcpJpWv+l
tnLLsuE/wUXNP0MEBQJfscd7AhkBAAoJEOE/wUXNP0MEVOYMAIN8k5UOQz5/dFiC
iRLfuHVwzrKcPSeQnRSdNEgXoqOrKesvO0pWulSJwKHR2wD6jrYQKZNJH7p72pCy
dEXjyaa/yMY2Q5Nso9za5K3PyabyOHN+gRiRWaZ1xAGBfxQX+7m0PYaW9r8tHLv5
SBfjF4wpV7qHqVYqfBTO2S2NRAnRtZdv2bLNW+QuwTZbN6/jWQJ2wbevuS29aUpL
tzOXzMj/4gJ+oW4Pt4TEiu28H554z68jXjLzCh3SylpuSUp1YtvUSnbRR8KnGcpb
+BzSqhemgeWDprj18LRTgrXEkyFsyHbSlk2NxViPDHklHO1FbJL7azuuDCAwBeTS
3F6k3msSEWjdfdv55VorBBdnU+bKJMQsdUClnN/LB72qTRPnnbfqy9WIOndwOQaT
5CKLmLMPo6zSJ4J4p/uj2Dh9Xr+wD6PuXXF3qrh1x9HEYONZzIcaN95YtYcerBCp
xJaxSx94cmCzArIo/hVo5E4VATwOyUvIXcFBl6HJodLjvWnSQ4kB1AQTAQoAPhYh
BFkLcpJpWv+ltnLLsuE/wUXNP0MEBQJek0vNAhsDBQkGKJ4qBQsJCAcCBhUKCQgL
AgQWAgMBAh4BAheAAAoJEOE/wUXNP0MEMSgL/1opoJjNREeHa143GmwL/dRvjKtI
apiIpMX64OqZQKqatF0zhMTKmR+yqmmk1TBbIK2Zu/lUgEP/naidKpje7ZFgpI4t
C/Tdcb/em34aRCsAbZbLLGlNaqOZVOSAoQzKvzUx6oya3EdCJuZqNqQSvnNr+bSS
/HeKY9PhOLSLrNCBJl+9C58KwC6WpeZX576lKm5RexeF0JNWxFunE19e9Rs5QyZm
sBQbj9CsUcReI93cU4DrY9+T1sT7yXGtfsR0B8eFRREXF+I2hvJ6IJ4R3xUS7h11
Ifx9hTW+DkWhQgRbV2EeHpJExELsB1yC+luqNpWjo4Z8dT1ISAkOb3hRx4/L0jcv
lNqgZbp0FyvZnBttV6WwWNPTx+fAbVsoaM2DhTSl+EqOl6qPws/S66ETKp2OCGBt
WGYDnL9PJGdBKfCX9saH1yVsorqVRLxbhmd5tgwGRj4ZXfMz3UrSY/4ny0wU7dz+
JUtvcqdbGTiHUKCXwiCf8ybeTcPMmFccwIaiU7QhQW50b2luZSBQb2luc290IDxk
YXJvc2lvckBsbi5kZXY+iQG2BDABCAAgFiEEWQtykmla/6W2csuy4T/BRc0/QwQF
Al+81V8CHQAACgkQ4T/BRc0/QwQd7gwApliX71tXlxmKoEtplPsEZJAJmXLglwsv
JO0C5tLCUjD2ir8BGvfGehOeD9/ATOwHAhTAAs41nFEp8sw8F7eAFEhPLg0BLWZ5
eAgAofEO9qmOIvaZYivWEZx6vT84cc/yASThU9TeDoSoReczqMeATE53fIljh3Ce
ruBNN/fKjDXaDkpxZAcRzqfdj0Nu3vpA6a42VqaGS5rHPamgl+JriH966XvbCJxx
sK8U9FxsXYL5Yi2BzQRZK0Y6CVBRlG24T77lkw9PQ1SZz412X0SUFE8zYsYkJ6Cb
/ExpLY/3aiIoEKz/FLpEp8MeqB2W24vjnC2qqmNkMguIR7hUehHv0leZK4kc5WxM
l7/0NLxHYi43wfKv7FkMoEXDJlrefjJ46S3SFI3/UKnhVyXA3QZtCJHFYBbEL5Ho
zLo1HdURHPiVJ3yBDsHsCS11GlICaNyC72qpAJ+iotTOqO5dQfQyGummXmFHc/8/
8eyZVXGeXbTiyvO7gl8EhMn3bCPtWbmUiQHUBBMBCgA+FiEEWQtykmla/6W2csuy
4T/BRc0/QwQFAl6TTE0CGwMFCQYonioFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AA
CgkQ4T/BRc0/QwTJEwv/agA8Szf1JtOnPaVT3hkaeSSvRSBTcgx7RLH3QZwO8W+m
Yu402/6q5AT1+Ra9XYyk5S7QjcLwnnohpfCKRDpsIdOl5Td+S5xMGqacm85YyRl3
uAyuW+9eAEmOD14LzhK0mu4UZN8JseRg9l0uguX4k8gFJuQMhFmBA0aRcYBB/sQG
1uuyjoGGXDfPsxNTB0oFCd0cKXl9iU8WkWTQg0jjRbFJA301HCff7z5o6/W3t87p
db0KwCoa/8RPZ6+qiUZlx2K85A0dveU0K5JSs0hASLI7xhuOLMtxdzx74vkKwZis
YL2Nz5IKmrp2vO7pvYnC3YjycqJmiQSqHDyqo4j4QZm8/WxaDsSgHlvzHp/EjNHK
Bi35jfbctVjKPcRIGKfR4bcns8pFvBslQ6ar6CPtCKymkN+WuNRtZbc8HI4Yo2Xl
pXcneBsXDrVWfO8AzYEV8q0GynsXwEuTHfft0vyjV3laK2K4reMKjECh1BZ5FPUw
wrTnKsfmiddv4f7rDdTjiQIzBBABCgAdFiEE3A+aZoCpuYuZMoWBqiFCP34Km+YF
Al+xtdMACgkQqiFCP34Km+ZdvA//Wh0irz3TwANLR6tAb//CCXSTEAcKS+Dgtn92
Jd7+uKUure3PV4gVYkPK0v4fYb0cdfuGT97eXQOo2fcwbCA30Q04sN8X5grrmrkD
r4MdIsORquEnAmTqmN/mRUyoF/r1sb93LW5x/VNNlAa6gQJwEOdki6orP9xuRW9m
UKm/tNCSuK1LELR64mNfC2ETrZNCF2gxTFi4s2uleIQb5RqnAbg+HYV9dOuD64Ed
+FvNrlF/7uyDsI/8FawtyO61HEiE71maIwSboDxeaRwPGkF8OtobQg7EIJp2hG9N
cPV6+ENJCDlQwL4oTgpWFnls0E++OKW+NADyTECBYf1Pm5XZsMVV56RG1GJ5kmBJ
sPOvjvmtIqaEiEaE6Veor31uesbXT3peytWUWHldh9DCzCF9Ee6mbvTlJTywU3Mu
B4XI9jQYMbBdrPDv+dBUYgQxWJL9vkOQsYUFcrdgFhXehFiSQJ9VENcWr50zxLWN
SWn8cVnkdHHkZhLJzj2NtobNLnSjmhrsFtruNNd0ECMw6E612nw4M+W2CHurQ9VT
Nnuw+rTtH2DllckQD3rsnTM3Fc52V0qBfs8xJDjT7Z2Sg/mY7R1BuRGvy/8LYQCt
2XzwkEySNM95jnACoAD4qZPRn120lHq0vEb9MqD+HqbtgoZUjExQ98Br4C3fnO/m
4riELKu0JUFudG9pbmUgUG9pbnNvdCA8YW50b2luZUByZXZhdWx0LmRldj6JAdQE
EwEIAD4WIQRZC3KSaVr/pbZyy7LhP8FFzT9DBAUCX7HHsgIbAwUJBiieKgULCQgH
AgYVCgkICwIEFgIDAQIeAQIXgAAKCRDhP8FFzT9DBFqNC/45VPmwp4kvDxRjmI9T
X/OwLfXVJVehYFNAuKukeiw5Vnt2XC2PF1XM/qMSypr69ium/I83VeFdZbWR7nm1
MeDcPpmE7D8wX9zy53XbWElJD++72+q51RSdC5+g3HFcNQyD0rLI9lJ+MT42/Z56
+V4KnhcPrh6Jm+1JDCnBmJEW5vV4HInlapfwUEUgz0uKEigDfRQn7vRp2x1Hio8l
SBsLIp6J4pnDqSz0x5hroGFSW8DvyjBAvf+OrTLNS+DQf/p/x6JTRBPep/oIRWNL
XzN161jfBGoZtHSj+FGwed6CoTHpgr0uZtI/giYnnzPq/MWevHdo9Tc2uOGzasO6
JOBPE5p4JtSceExoCL8mNpUO5g8KfnhaRQNniyQ9LEt8n/zW5LFJ1GthKqwR++hr
Fnza3bZMMGknKP++ogrJqoPjWnVapiuZvGl+WGhfA/a+ybZ9qongEfu1DE3NnH2q
2vjYyMmFbKR+2HdISY17RuS84kOKlLHm+9+37Q1+eqOpjrG0GmRhcm9zaW9yIDxk
YXJvc2lvckBsbi5kZXY+iQHUBBMBCgA+FiEEWQtykmla/6W2csuy4T/BRc0/QwQF
Al6C+OkCGwMFCQYonioFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ4T/BRc0/
QwR2vAwA0TJI8+2fOFqrliAVEDMSXJGigPyZ7AHUljcpdVUBV7Pw4VcdwUnD759k
chsYyOBbSKk67emxQe4Sjgk9UzjpfKYaqe8jiW4X11/43qubtV/SRWRRluJ1+jq/
OBFYflpy+zQKTeymXBcw9y6/tUtGBBoo4o4LAvBo7oNyYNgBcYW/D2q/RO/GhDAu
pnEONJm6iy+r6Icdf33EC+JL2eJV7UHXrbHgcGIriPPyHYVbcv/Q5gECrkUVTpha
MYGmKCPy1z55zNh+j6b0WjanJo90I2rjJUJiujzyEc/pbIaZU8AlFaaayIIZg9z2
CXDOirzoRblINzadF6WgbZmXTjTM30Sp04znDjWGfRBQgjNCaAKO1ErE1EaytM1s
t20dE1qJMqJuL/ck5V8pHySvQVgEk1XbFsWrcLlwIlyJqo59oLL2I4PylHlIeVjS
0tFkyLgtfxK2jskfwYeQabmECLE5/iXpClmHzJplt9obgTI5v9XHptt6EtFAJYws
649S+XHOtCJkYXJvc2lvciA8ZGFyb3Npb3JAcHJvdG9ubWFpbC5jb20+iQHUBBMB
CgA+AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEWQtykmla/6W2csuy4T/B
Rc0/QwQFAl5WUiAFCQYonioACgkQ4T/BRc0/QwQ8zwv7BLPZ1feTaqgkPNcuN48q
8m0uxveoIU1aLlblAdpaCv1hz83Ui9kD8YpmtgbYHCX6dZbpclJcMD3OggnmD1PE
3c/g97iWopbUIDIDc2RZJN66CrO8v4cHBBAc6PE0Jz6ZaJ+r15jRsWvxO0ORK9wX
faq57D3DMZMt/Nh89fXXWTr4imHtcIZRUc2/eAYSJHOx89ZUTJLxuXuWSYuseh6g
jipArqvsih2Qjn62ZbCL7EAt0g/QIRU4eOZ71vB8W/t6qfDrAvPiEpa+vjm9vXf5
NpiVuKOhi02VVZYIW8udXbnuNDOE6gV/IVeAwW/1sNcjzqqaEFnnpHv8Gr8EhCLv
XiiWDzvi4zgdyprkz/lI41zQ6nz8ZGI+qwJn4qtcQKhB53Wm1Iootr5kHZbB+1T0
mAIb8uwEyeFLHUV2LKJqiNaE2K3nf3GaoxJ3g88P3YF8KmISSHgZvZ7leKz7Ox8S
1CLgqut1FmO9TyuvbxRn7fngp+B7x4H9MSjq4IKPq2DiiQHUBBMBCgA+FiEEWQty
kmla/6W2csuy4T/BRc0/QwQFAlvwGvYCGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYC
AwECHgECF4AACgkQ4T/BRc0/QwSJygv8CiL/P1lrc6Zx6pORDIGQshXvzFcAWQWW
27NRrHkBRl7YkiQTTVZx5CReH9cy86Y//LC88iPcJ2AjlSnozj6o2sW3moxRxGGO
rNBkwoglASesZmId69Yifu40Ogk35ctazOFsDYnzTsNFlcDrEMpK+OcbjchQByuo
iDnQ9Z0stQW79Qw0dPt+NtvDgOVzp4HKbW/F7ZK9i2Bir6eMbvNCOn7i4t9lQM9P
vP11y75/TFVM56HB9RijujP+WvpgchwCyo1nEGjPjnCLs+MVi2u+u5gr3Jjev2Mb
MTd4tI7O7dMhMb+JRjcSTXKDiaQAsaeAmjBC+MVU6KX7gRTdy4moocgrXtLcSvGB
tOQfuCyS6lx+6kjFhc1kZ0ZY9QCzqa+w6dkB52zOuu40GVgDpOhRAQi4rDVSZMAD
eRDq8Z9XIQV6J6fh/2U4WQOQa+DcSD9VGdn+adrPffsY1u9W42N7x5aK2gSmdCam
LHyCiae4UeMjzD/roccIHIHantrzXO00uQGNBFvwGvYBDADaPLBXQHawjIrhfmZ+
Fjjps8FtM1EaZDrpKNsNRA6if8ZbuJrHD1aR/sLnXQdi4OVHI3xqpqrpz/qXHLRC
hYxaLCcGECJIQLR8AMDlZbJjoKXRNnRHd742uN7TBCwzetyCjOjZ1Gp3Ij1u9x6K
lsiHEtBzq//Tz9SmIascrWPFGtoGruSj7maax7UL4y4bEv9Bh6Cg8yRwgMqrRinT
p0i0BI1VpNWBaar/p60slmqL+tWFkgS8dhlLoKlRj/c3ybhYF9o4duBPOV3t1xgt
Jp1xhW95ZaCYTKR/7LOq/eMkx5HZUi+5WtFuaaoQ2+JbO8q3831ObOZMMaJVR9JV
VkPs9JQrr4re50auVOkC05LjRXmLJ504A7/HYljf9A0MEcmJeZxN/Pb2S4+yBaAc
YgTAr/Aee2FODfa4yqyLZqqaQxq9p22ytqBcFZ655MCRt35oqioRFWYikIkCZ66g
ZCXKZmM1bx9HFU/qP6lBoX65xKEcuGZdYGqb4ydC9DPMrK0AEQEAAYkBvAQYAQoA
JhYhBFkLcpJpWv+ltnLLsuE/wUXNP0MEBQJb8Br2AhsMBQkDwmcAAAoJEOE/wUXN
P0MEtB8L/R6QJWfQyB6XWDS8rDiGRdgfXMaflj7xiYG2lpxwpbk8ZtvsVxXHRSoP
RShcNum0mg/y6WZSIUvmMfejYbP9YJYEfHVwzcWN7jXBnLMq2u6JvLvCnqeUBvbf
Jd83zbVNUQMpYQAMX4Twxolqr24qhR4Gc2wYYezFrylZ9NPoiIdGf3jpunG66khC
2nrAp/bKhEtwnsND3IaBYdulWjn8vkDZRyEjbOy9zGxaB3ZTtjfNj4JI+BZ7h/YB
Las6iSZViJX3L7GEysp9f7oZ5C60y1VFQo7TcEUEUSZ9eAKrOkEBwFrMlyeneeGo
BbHFllhBMdRPr92G06GgWEK1D5KnEPo85Q47POs0MU0XRThwd2wElz79J2xOf5Ad
1edOtzpHaQli6nqybfAh6ZOKz/tUOrFAtEw765bKTpUG1sHsvapqk8+HQoOPKbE8
4axUQwMSQcHqnooHkprzib2GC/+DGwGeg1HeN5g1H1/GBPicYP//Ez9w3QbSVQ+7
KG04r8hWbw==
=m4XT
-----END PGP PUBLIC KEY BLOCK-----
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
|
|
50a6f8f821a5fe75da7f4c86414ef34c15c198da Add benthecarman to keys.txt (benthecarman)
Pull request description:
For https://github.com/bitcoin-core/gitian.sigs/issues/1427
ACKs for top commit:
laanwj:
ACK 50a6f8f821a5fe75da7f4c86414ef34c15c198da
Tree-SHA512: a667cd6bc3511feb6bfea37d9b7b9ec69dadb02f47ec6e71e478c4f2e213c5cc0b8c74beec9536d3b9aadfdc743d5fb0107bee1ce72057acf01117e0f46862c0
|
|
|
|
|
|
ccc8d5513fb2228eabc25b105f7a0498f8453885 doc: Update license year range to 2021 (Emil Engler)
Pull request description:
See #17801, #15061
The same procedure as every year. Happy new year to all of you :)
Top commit has no ACKs.
Tree-SHA512: 59ca9ba43d3722d5e2ada04fe6c361058a72c84b8437f6331f45e361d7ebf0f3586ccb02dc72af12b9d94f766897f0f041ce3a90efe95eeff22217f9f964ffc6
|
|
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
|
|
|
|
|
|
|
|
a0a771843fc39c3cc2574a51f009c3391e1808e9 contrib: Changes to checks for PowerPC64 (Luke Dashjr)
634f6ec4eb9997d7bd0f8209fad49a4171d42384 contrib: Parse ELF directly for symbol and security checks (Wladimir J. van der Laan)
Pull request description:
Instead of the ever-messier text parsing of the output of the readelf tool (which is clearly meant for human consumption not to be machine parseable), parse the ELF binaries directly.
Add a small dependency-less ELF parser specific to the checks.
This is slightly more secure, too, because it removes potential ambiguity due to misparsing and changes in the output format of `elfread`. It also allows for stricter and more specific ELF format checks in the future.
This removes the build-time dependency for `readelf`.
It passes the test-security-check for me locally, ~~though I haven't checked on all platforms~~. I've checked that this works on the cross-compile output for all ELF platforms supported by Bitcoin Core at the moment, as well as PPC64 LE and BE.
Top commit has no ACKs.
Tree-SHA512: 7f9241fec83ee512642fecf5afd90546964561efd8c8c0f99826dcf6660604a4db2b7255e1afb1e9bb0211fd06f5dbad18a6175dfc03e39761a40025118e7bfc
|
|
xorriso and its mkisofs/genisoimage emulation alter-ego xorrisofs are
more maintained, and has the right toggles for us to achieve output
determinism without using blunt tools like faketime.
In this commit, we use xorrisofs from the build environment rather than
building it ourselves using depends. This is not necessary and can be
changed in the future.
From https://wiki.debian.org/genisoimage?action=recall&rev=11 :
> The classical command line interface for production of ISO 9660
> filesystem images is the option set established by program mkisofs.
> For reasons of licensing and other problems with its author, Debian
> ships a fork of mkisofs, called genisoimage, which was split off in
> 2006 and then developed independently.
>
> Meanwhile, genisoimage gets no new features and not even bug fixes. It
> is first choice only if its options -udf or -hfs are needed.
>
> Replacement in most uses cases, especially for bootable ISO 9660
> filesystems, archiving, and backup, is xorrisofs which starts the -as
> mkisofs emulation mode of program xorriso.
|
|
Previously, the compression of the .iso file to a .dmg file was done
outside of `make deploy' in order to use the faketime-wrapped version of
libdmg-hfsplus's DMG tool.
Specifying the faketime-wrapped version of the DMG tool to ./configure
fixes this and simplifies build scripts.
|
|
|
|
b685f60a08007e0ae8a5564ee68cd94f9015d899 build: mac_alias 2.1.1 (fanquake)
5d2cbdf772030b203ab1b32c65481ce3fc524b22 macdeploy: use Python 3.6 (fanquake)
a42aa94c54699833723076f3bfaeeac668523a69 macdeploy: remove runHDIUtil in favor of directly calling subprocess.run (fanquake)
adaa26202b965346566b5adff2fc5cee65955dfe macdeploy: remove existing Bitcoin-Core.dmg if present (fanquake)
ccb0325b1bd1cee5a76382a16901dc80ea8f50d8 macdeploy: move qt_conf to where it's used (fanquake)
6390a04862c043cd2bdf3610f3bcf9cb5526659f macdeploy: consolidate .DS_Store generation (fanquake)
32347cd56aaae95f3f4c78be9270565285280d72 macdeploy: assume plistlib is available (fanquake)
0ab4018c1217f82dffd65e973d9cccf13af2ef50 macdeploy: have a single level of logging output (fanquake)
827d382aa79d503470cc7abb0000cc365db06f12 macdeploy: remove add-resources argument (fanquake)
464b34d4c328d5109b8dd197da9e7f00d1b843c2 macdeploy: remove codesigning argument (fanquake)
4d70d3d7fe29db38a1f9c84a3a6167ca57b38479 build: automatically determine macOS translations (fanquake)
Pull request description:
This consolidates our macOS build code so that `.DS_Store` generation is the same when running `make deploy` for macOS when building on Linux and macOS, rather than maintaining two version of code that essentially do the same thing (just slightly differently).
It also removes unused code and any AppleScript usage, automates finding translation files and generally simplifies `macdeployqtplus`. It also gets rid of the annoying "popping up" behaviour during DMG generation, names the created image `Bitcoin-Core.dmg` rather than `Bitcoin-Qt.dmg`.
ACKs for top commit:
dergoegge:
ACK b685f60a08007e0ae8a5564ee68cd94f9015d899 - Less and cleaner code looks good. I tested this with `make deploy` and everything still works + the popup during DMG generation is gone.
Tree-SHA512: dcd38344e2dfcfa7ffbccf6226a71425c4d16b421a4881d5ee37b8e7ef393b3e8077262444c39b11912269d8cf688aba897e6518cba8361eb24a03fdd03b8caf
|
|
a dirty branch
6690adba08006739da0060eb4937126bdfa1181a Warn when binaries are built from a dirty branch. (Tyler Chambers)
Pull request description:
- Adjusted `--version` flag behavior in bitcoind and bitcoin-wallet to have the same behavior.
- Added `--version` flag to bitcoin-tx to match.
- Added functionality in gen-manpages.sh to error when attempting to generate man pages for binaries built from a dirty branch.
mitigates problem with issue #20412
ACKs for top commit:
laanwj:
Tested ACK 6690adba08006739da0060eb4937126bdfa1181a
Tree-SHA512: b5ca509f1a57f66808c2bebc4b710ca00c6fec7b5ebd7eef58018e28e716f5f2358e36551b8a4df571bf3204baed565a297aeefb93990e7a99add502b97ee1b8
|
|
|
|
Check both failure cases:
- Use a glibc symbol from a version that is too new
- Use a symbol from a library that is not in the allowlist
And also check a conforming binary.
Adding a similar check for Windows PE can be done in a separate PR.
|
|
|
|
|
