aboutsummaryrefslogtreecommitdiff
path: root/contrib/devtools/github-merge.py
AgeCommit message (Collapse)Author
2019-01-14contrib: Allow use of github API authentication in github-mergeWladimir J. van der Laan
The API request limit for unauthenticated requests is quite low. I started running into rate limiting errors. The limit for authenticated requests is much higher. This patch adds an optional configuration setting `user.ghtoken` that, when set, is used to authenticate requests to the API.
2019-01-14contrib: Add support for http[s] URLs in github-mergeWladimir J. van der Laan
Sometimes it can be useful to use github-merge with read-only access (say, for reviewing and testing).
2019-01-14contrib: Detailed reporting for http errors in github-mergeWladimir J. van der Laan
Print detailed error, this makes it easier to diagnose github API issues.
2018-12-13Remove Python 2 import workaroundspracticalswift
2018-12-09Handle exception as ImportErrorDaniel Ingram
2018-06-12Explicitly specify encoding when opening text files in Python codepracticalswift
2018-04-16Minor Python cleanups to make flake8 pass with the new rules enabledpracticalswift
2018-03-29Remove assigned but never used local variablespracticalswift
2017-09-05github-merge: Coalesce git fetchesWladimir J. van der Laan
Fetch the destination branch as well as PR in one go. Saves a few seconds (as well as one ssh authentication, when using a yubikey) when using github-merge.py.
2017-08-28Use print(...) instead of undefined printf(...)practicalswift
2017-08-28Use sys.exit(...) instead of exit(...): exit(...) should not be used in programspracticalswift
2017-07-10Add PR description to merge commit in github-merge.pyPieter Wuille
2017-05-31devtools: Retry after signing fails in github-mergeWladimir J. van der Laan
When signing fails, go back to the sign/exit prompt instead of exiting the script.
2017-05-02Remove unused Python importspracticalswift
2017-04-21contrib: github-merge improvementsWladimir J. van der Laan
Some minor github-merge improvements I've made over time: User interface: - Print merge details again before signing off, to refresh your memory - usually I'll have done lots of different things in the shell so this will have scrolled out a long time ago. - Require a valid answer on the prompts. One of the requested answers must be typed, if not, the prompt will re-ask. This prevents accidentally rejecting. Efficiency: - Condense "accept merge" and "sign off" prompts. There's no reason to have this as two separate prompts, both are just opportunities to skip out on the merge, no action is performed in between. Merging: - Strip spaces from github title. This avoids redundant spaces surrounding it from getting into the commit message.
2017-03-13devtools: Make github-merge compute SHA512 from git, instead of worktreeWladimir J. van der Laan
This changes tree_sha512sum() to requests the objects for hashing from git instead of from the working tree. The change should make the process more deterministic (it hashes what will be pushed) and hopefully avoids the frequent miscomputed SHA512's that happen now.
2017-03-07devtools: Fix a syntax error typoWladimir J. van der Laan
Fix a typo introduced in #9880 causing the script to not even parse.
2017-03-06Merge #9880: Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1Wladimir J. van der Laan
bbd7579 Fix regsig checking for subkey sigs in verify-commits (Matt Corallo) d025bc7 Allow any subkey in verify-commits (Matt Corallo) eddc77a Add comment re: why SHA1 is disabled (Peter Todd) d9c450f Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1 (Matt Corallo) be908a6 Fail merge if there are any symlinks (Matt Corallo) Tree-SHA512: bb66c59cc1c6b1c86d7d8be7adb0769c6598c0e28ad927409941f30af87d390521e82fc13700ee22e92db1bd571db3e19a152ec7b2c0349c6e06f5de62c0b65f
2017-03-03[contrib] gh-merge: Move second sha512 check to before signingMarcoFalke
2017-03-01Fail merge if there are any symlinksMatt Corallo
2017-02-26Add SHA512 tree hash to merge commitsPieter Wuille
2017-01-13Remove unused Python importspracticalswift
2016-11-06[copyright] copyright header style uniformisle2983
Three categories of modifications: 1) 1 instance of 'The Bitcoin Core developers \n', 1 instance of 'the Bitcoin Core developers\n', 3 instances of 'Bitcoin Core Developers\n', and 12 instances of 'The Bitcoin developers\n' are made uniform with the 443 instances of 'The Bitcoin Core developers\n' 2) 3 instances of 'BitPay, Inc\.\n' are made uniform with the other 6 instances of 'BitPay Inc\.\n' 3) 4 instances where there was no '(c)' between the 'Copyright' and the year where it deviates from the style of the local directory.
2016-04-02devtools: Auto-set branch to merge to in github-mergeWladimir J. van der Laan
As we are already using the API to retrieve the pull request title, also retrieve the base branch. This makes sure that pull requests for 0.12 automatically end up in 0.12, and pull requests for master automatically end up in master, and so on. It is still possible to override the branch from the command line or using the `githubmerge.branch` git option.
2016-03-23devtools: make github-merge.py use py3Wladimir J. van der Laan
This makes github-merge.py the first developer tool to go all Python 3 (for context see #7717). The changes are straightforward as the script already was `from __future__ import division,print_function,unicode_literals`. However urllib2 changed name, and json will only accept unicode data not bytes. This retains py2 compatibility for now: not strictly necessary as it's not used by the build system - but it was easy.
2016-01-27devtools: Fix utf-8 support in messages for github-mergeWladimir J. van der Laan
Use 'utf-8' instead of the Python 2 default of 'ascii' to encode/decode commit messages. This can be removed when switching to Python 3, as 'utf-8' is the default there. Necessary for merging #7422 due to the ฿ in ฿tcDrak.
2016-01-25Merge #7402: [devtools] github-merge get toplevel dir without extra whitespaceWladimir J. van der Laan
5ed2f16 [devtools] github-merge get toplevel dir without extra whitespace (Andrew C)
2016-01-25[devtools] github-merge get toplevel dir without extra whitespaceAndrew C
Fixes a bug in github merge when it runs the tests where the toplevel directory has an extra '\n' appended to the path string. Now it doesn't.
2016-01-22devtools: show pull and commit information in github-mergeWladimir J. van der Laan
Print the number and title of the pull, as well as the commits to be merged.
2016-01-20devtools: replace github-merge with python versionWladimir J. van der Laan
This is meant to be a direct translation of the bash script, with the difference that it retrieves the PR title from github, thus creating pull messages like: Merge #12345: Expose transaction temperature over RPC