| Age | Commit message (Collapse) | Author |
|---|
|
|
|
As a first time git developer, I struggled to understand whether to create a new fork for each pull request or not.
After asking the IRC chat, I have added this to the documentation to further help new developers using git.
Co-Authored-By: Michael <fanquake@gmail.com>
|
|
Add `build' label.
Make labels lowercase.
Split long labels.
|
|
|
|
|
|
|
|
as per https://github.com/bitcoin/bitcoin/pull/15617#issuecomment-474773043 and https://github.com/bitcoin/bitcoin/pull/15626#discussion_r267286564.
|
|
|
|
Remove botbot.me link and add two other IRC history log sources: logs for #bitcoin-core-dev at http://www.erisian.com.au/bitcoin-core-dev/ and http://gnusha.org/bitcoin-core-dev/
|
|
|
|
|
|
It was not easy to read the comment lines for me because I was not sure whether the sentence ended with the line or not ("pull set commits"?).
Therefore, dots had been invented and I have added them to signal the end of a sentence. Also begin New sentence with a capital letter.
I guess, not all 'pick' words should be replaced by 'squash'? At least I found [https://www.digitalocean.com/community/tutorials/how-to-rebase-and-update-a-pull-request](this) rebase/squash documentation helpful, where is written that the first line should not be changed.
|
|
|
|
More information about connection on IRC will hopefully help new
contributors.
|
|
|
|
A numbered list is used when the sequence of steps matters. A bulleted list is used to denote a set of items where the sequence does not matter.
The workflow is a sequence and hence changed to a numbered list.
|
|
1. "If a pull request is not to be considered for merging (yet), please
prefix the ..."
2. If a particular commit references another issue, please add the reference. For
example: `refs #1234` or `fixes #4321`.
|
|
|
|
|
|
English grammar dictates that these bullet points should be capitalized.
This also makes the capitalization style consistent with the rest of the
document, e.g. the "Decision Making Process" section.
|
|
|
|
|
|
|
|
36164fa Fix typo and spelling inconsistency in CONTRIBUTING.md (Koki Takahashi)
|
|
|
|
Fix spellings of GitHub
Remove unnecessary changes
Fix GitHub spelling on doc/translation_process.md
|
|
Update CONTRIBUTING.md to document the different components.
Notably, trivial should only be used for PRs that do not change the
code.
|
|
Adding in response to a Slack discussion where someone was unclear on the fact
that a NACK may be justified if code can't be accepted due to copyright/patent
issues. For example, it would be reasonable and prudent to NACK a contribution
of AGPL-licensed consensus code on the basis that the license terms are
incompatible with the MIT license used by the rest of the codebase.
|
|
faa91bc CONTRIBUTING: Mention not to open several pulls (MarcoFalke)
|
|
|
|
All contributions to the repository will agree to use the MIT license
|
|
This commit contains two changes to CONTRIBUTING.md that:
Fix line line lengths. There were several instances where line lengths
were well over 80 characters. This commit adjusts them to make them
conform to formatting best practices, to stay under 80 characters when
possible.
Adhere to consist use of quotes. There are a few instances where smart
quotes are used (perhaps because it was pasted from a word processor).
This commit replaces them with dumb quotes to keep it consistent with
the quotation formatting found in the rest of the document.
|
|
|
|
|
|
|
|
|
