aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2025-01-29[refactor] move parent inv-adding to OrphanResolutionCandidateglozow
Deduplicate the logic of adding the parents as announcements to txrequest. The function can return a bool (indicating whether we're attempting orphan resolution) instead of the delay.
2025-01-29Merge bitcoin/bitcoin#31545: ci: optionally use local docker build cacheAva Chow
e87429a2d0f23eb59526d335844fa5ff5b50b21f ci: optionally use local docker build cache (0xb10c) Pull request description: By setting `DANGER_DOCKER_BUILD_CACHE_HOST_DIR`, the task-specific docker images built during the CI run can be cached. This allows, for example, ephemeral CI runners to reuse the docker images (or layers of it) from earlier runs, by persisting the image cache before the ephemeral CI runner is shut down. The cache keyed by `CONTAINER_NAME`. As `--cache-to` doesn't remove old cache files, the existing cache is removed after a successful `docker build` and the newly cached image is moved to it's location to avoid the cache from growing indefinitely with old, unused layers. When `--cache-from` doesn't find the directory, the cached version is a cache-miss, or the cache can't be imported for whatever other reason, it warns and `docker build` continues by building the docker image. This feature is opt-in. The documentation for the docker build cache of `type=local` can be found on https://docs.docker.com/build/cache/backends/local/ This replaces https://github.com/bitcoin/bitcoin/pull/31377 - some of the discussion there might provide more context. ACKs for top commit: maflcko: I haven't tested this, and it looks harmless and is easy to revert, if needed. So lgtm ACK e87429a2d0f23eb59526d335844fa5ff5b50b21f achow101: ACK e87429a2d0f23eb59526d335844fa5ff5b50b21f TheCharlatan: tACK e87429a2d0f23eb59526d335844fa5ff5b50b21f willcl-ark: ACK e87429a2d0f23eb59526d335844fa5ff5b50b21f Tree-SHA512: 0887c395dee2e2020394933246d4c1bfb6dde7165219cbe93eccfe01379e05c75dce8920b6edd7df07364c703fcee7be4fba8fa45fd0e0e89da9e24759f67a71
2025-01-29Merge bitcoin/bitcoin#30844: RPC: improve SFFO arg parsing, error catching ↵Ava Chow
and coverage cddcbaf81e8e3d107cd321ee2c9a7fd786a8917e RPC: improve SFFO arg parsing, error catching and coverage (furszy) 4f4cd353194310a8562da6aae27c9c8eda8a4ff0 rpc: decouple sendtoaddress 'subtractfeefromamount' boolean parsing (furszy) Pull request description: Following changes were made: 1) Catch and signal error for duplicate string destinations. 2) Catch and signal error for invalid value type. 3) Catch and signal error for string destination not found in tx outputs. 4) Improved `InterpretSubtractFeeFromOutputInstructions()` code organization. 5) Added test coverage for all possible error failures. Also, fixed two PEP 8 warnings at the 'wallet_sendmany.py' file: - PEP 8: E302 expected 2 blank lines, found 1 at the SendmanyTest class declaration. - PEP 8: E303 too many blank lines (2) at skip_test_if_missing_module() and set_test_params() ACKs for top commit: achow101: ACK cddcbaf81e8e3d107cd321ee2c9a7fd786a8917e murchandamus: crACK cddcbaf81e8e3d107cd321ee2c9a7fd786a8917e naiyoma: TACK [https://github.com/bitcoin/bitcoin/pull/30844/commits/cddcbaf81e8e3d107cd321ee2c9a7fd786a8917e](https://github.com/bitcoin/bitcoin/pull/30844/commits/cddcbaf81e8e3d107cd321ee2c9a7fd786a8917e) ismaelsadeeq: Code review and Tested ACK cddcbaf81e8e3d107cd321ee2c9a7fd786a8917e Tree-SHA512: c9c15582b81101a93987458d155394ff2c9ca42864624c034ee808a31c3a7d7f55105dea98e86fce17d3c7b2c1a6b5b77942da66b287f8b8881a60cde78c1a3c
2025-01-29Merge bitcoin/bitcoin#30125: test: improve BDB parser (handle ↵Ava Chow
internal/overflow pages, support all page sizes) d45eb3964f693eddcf96f1e4083cf19d327be989 test: compare BDB dumps of test framework parser and wallet tool (Sebastian Falbesoner) 01ddd9f646a5329a92341bb216f3757fa97c0709 test: complete BDB parser (handle internal/overflow pages, support all page sizes) (Sebastian Falbesoner) Pull request description: This PR adds missing features to our test framework's BDB parser with the goal of hopefully being able to read all legacy wallets that are created with current and past versions of Bitcoin Core. This could be useful both for making review of https://github.com/bitcoin/bitcoin/pull/26606 easier and to also possibly improve our functional tests for the wallet BDB-ro parser by additionally validating it with an alternative implementation. The second commits introduces a test that create a legacy wallet with huge label strings (in order to create overflow pages, i.e. pages needed for key/value data than is larger than the page size) and compares the dump outputs of wallet tool and the extended test framework BDB parser. It can be exercised via `$ ./test/functional/tool_wallet.py --legacy`. BDB support has to be compiled in (obviously). For some manual tests regarding different page sizes, the following patch can be used: ```diff diff --git a/src/wallet/bdb.cpp b/src/wallet/bdb.cpp index 38cca32f80..1bf39323d3 100644 --- a/src/wallet/bdb.cpp +++ b/src/wallet/bdb.cpp @@ -395,6 +395,7 @@ void BerkeleyDatabase::Open() DB_BTREE, // Database type nFlags, // Flags 0); + pdb_temp->set_pagesize(1<<9); /* valid BDB pagesizes are from 1<<9 (=512) to <<16 (=65536) */ if (ret != 0) { throw std::runtime_error(strprintf("BerkeleyDatabase: Error %d, can't open database %s", ret, strFile)); ``` I verified that the newly introduced test passes with all valid page sizes between 512 and 65536. ACKs for top commit: achow101: ACK d45eb3964f693eddcf96f1e4083cf19d327be989 furszy: utACK d45eb3964f693eddcf96f1e4083cf19d327be989 brunoerg: code review ACK d45eb3964f693eddcf96f1e4083cf19d327be989 Tree-SHA512: 9f8ac80452545f4fcd24a17ea6f9cf91b487cfb1fcb99a0ba9153fa4e3b239daa126454e26109fdcb72eb1c76a4ee3b46fd6af21dc318ab67bd12b3ebd26cfdd
2025-01-29Merge bitcoin/bitcoin#31633: net: Disconnect message follow-ups to #28521Ava Chow
551a09486c495e1a3cfc296eafdf95e914856bff net: Switch to DisconnectMsg in CConnman (Hodlinator) bbac17608d1ad3f8af5b32efad5d573c70989361 net: Bring back log message when resetting socket (Hodlinator) 04b848e4827f502d0784c5975bc8e652fc459cc8 net: Specify context in disconnecting log message (Hodlinator) 0c4954ac7d9676774434e5779bb5fd88e789bbb6 net_processing: Add missing use of DisconnectMsg (Hodlinator) Pull request description: - Add missing calls to `DisconnectMsg()` - https://github.com/bitcoin/bitcoin/pull/28521#discussion_r1890824361 - Specify context when stopping nodes - https://github.com/bitcoin/bitcoin/pull/28521#discussion_r1890780754 - Bring back log message when resetting socket in case new entrypoints are added - https://github.com/bitcoin/bitcoin/pull/28521#discussion_r1890795074 - Use `DisconnectMsg()` in `CConnman` as well - https://github.com/bitcoin/bitcoin/pull/28521#discussion_r1791797716 ACKs for top commit: Sjors: re-utACK 551a09486c495e1a3cfc296eafdf95e914856bff l0rinc: utACK 551a09486c495e1a3cfc296eafdf95e914856bff davidgumberg: Tested and Review ACK https://github.com/bitcoin/bitcoin/commit/551a09486c495e1a3cfc296eafdf95e914856bff achow101: ACK 551a09486c495e1a3cfc296eafdf95e914856bff danielabrozzoni: ACK 551a09486c495e1a3cfc296eafdf95e914856bff Tree-SHA512: 95ab8e7436e20ca3abc949ea09697facb6fbeb19981ddc7e0bf294e7ec914e72cbf836c21184a2a887f04cb264f26daf5b0cbcbebc9db633a7b1672b4e488063
2025-01-29test: make sure we are on sync with a peer before checking if they have sent ↵Sergi Delgado Segura
a message p2p_orphan_handling checks whether a message has not been requested slightly too soon, making the check always succeed. This passes unnoticed since the expected result is for the message to not have been received, but it will make the test not catch a relevant change that should make it fail
2025-01-29test: fixes p2p_ibd_txrelay wait timeSergi Delgado Segura
p2p_ibd_txrelay expects no GETDATA to have been received by a peer after announcing a transaction. The reason is that the node is doing IBD, so transaction requests are not replied to. However, the way this is checked is wrong, and the check will pass even if the node **was not** in IBD. This is due to the mocktime not being properly initialized, so the check is always performed earlier than it should, making it impossible for the request to be there
2025-01-29test: fix intermittent timeout in p2p_1p1c_network.pyMartin Zumsande
The timeout is due to outstanding txrequests with python peers. Fix this by disconnecting these peers after they send their txns, they aren't needed after this point anyway.
2025-01-29Merge bitcoin/bitcoin#31740: depends: Update libmultiprocess library before ↵merge-script
converting to subtree 4e0aa1835b3e980ceda29ec90e7115d7fef53f51 test: Add test for IPC serialization bug (Ryan Ofsky) 2221c8814d765c1e6109a6f0ecec00d5b4af2ec6 depends: Update libmultiprocess library before converting to subtree (Ryan Ofsky) Pull request description: This should be the final update to the libmultiprocess package via the depends system. It brings in the libmultiprocess cmake changes from https://github.com/chaincodelabs/libmultiprocess/pull/136 needed to support building as subtree. After this, followup PR #31741 will add libmultiprocess as a git subtree and depends will just use the git subtree instead of hardcoding its own version hash. Since there have been libmultiprocess API changes since the last update, this commit also updates bitcoin code to be compatible with them. This update has the following new changes since previous update #31105: https://github.com/chaincodelabs/libmultiprocess/pull/121 ProxyClientBase: avoid static_cast to partially constructed object https://github.com/chaincodelabs/libmultiprocess/pull/120 proxy-types.h: add static_assert to detect int/enum size mismatch https://github.com/chaincodelabs/libmultiprocess/pull/127 ProxyClientBase: avoid static_cast to partially destructed object https://github.com/chaincodelabs/libmultiprocess/pull/129 Fix "disconnected: write(m_post_fd, &buffer, 1): Broken pipe" EventLoop shutdown races. https://github.com/chaincodelabs/libmultiprocess/pull/130 refactor: Add CleanupRun function to dedup clean list code https://github.com/chaincodelabs/libmultiprocess/pull/131 doc: fix startAsyncThread comment https://github.com/chaincodelabs/libmultiprocess/pull/133 Fix debian "libatomic not found" error in downstream builds https://github.com/chaincodelabs/libmultiprocess/pull/94 c++ 20 cleanups https://github.com/chaincodelabs/libmultiprocess/pull/135 refactor: proxy-types.h API cleanup https://github.com/chaincodelabs/libmultiprocess/pull/136 cmake: Support being included with add_subdirectory https://github.com/chaincodelabs/libmultiprocess/pull/137 doc: Fix broken markdown links ACKs for top commit: Sjors: ACK 4e0aa1835b3e980ceda29ec90e7115d7fef53f51 vasild: ACK 4e0aa1835b3e980ceda29ec90e7115d7fef53f51 TheCharlatan: ACK 4e0aa1835b3e980ceda29ec90e7115d7fef53f51 Tree-SHA512: 6d81cdf7f44762c7f476212295f6224054fd0a61315bb54786bc7758a2b33e5a2fce925c71e36f7bda320049aa14e7218a458ceb03dacbb869632c466c4789b0
2025-01-29doc: release notesSjors Provoost
2025-01-29rpc: have mintime account for timewarp ruleSjors Provoost
Previously in getblocktemplate only curtime took the timewarp rule into account. Mining pool software could use either, though in general it should use curtime.
2025-01-29rpc: clarify BIP94 behavior for curtimeSjors Provoost
2025-01-29refactor: add GetMinimumTime() helperSjors Provoost
Before bip94 there was an assumption that the minimum permitted timestamp is GetMedianTimePast() + 1. This commit splits a helper function out of UpdateTime() to obtain the minimum time in a way that takes the timewarp attack rule into account.
2025-01-28test: Added coverage to the waitfornewblock rpckevkevinpal
Added a test for the Negative timeout error if the rpc is given a negative value for its timeout arg
2025-01-28Merge bitcoin/bitcoin#31736: doc: update links in ci.ymlmerge-script
1681c08d42c302088586ca9b36b278217723f66a doc: update links in ci.yml (espi3) Pull request description: Updated three outdated GitHub links to avoid redirects. ACKs for top commit: Sjors: ACK 1681c08d42c302088586ca9b36b278217723f66a Tree-SHA512: 0ef934ebf308f0fee338cb6ac80b2826b9d442285c64af9e2547b020f5f0e5a0eaba7efeee6220e55790b78649d3060470ce65f35cb0ecc1f60041e5d640c6cb
2025-01-28Merge bitcoin/bitcoin#31522: ci: Enable DEBUG=1 for one GCC-12+ build to ↵merge-script
catch 117966 regressions fa8ade300f421dcc3b0cd956ab03a50a5ae80646 refactor: Avoid GCC false positive error (MarcoFalke) fa40807fa830ee9724b5cfeef263263aaa6ce5d9 ci: Enable DEBUG=1 for one GCC-12+ build to catch 117966 regressions (MarcoFalke) Pull request description: It is possible that someone accidentally removes the workaround in fa9e0489f57968945d54ef56b275f51540f3e5e4, or more likely that someone accidentally adds new code without the workaround. Avoid this by adding a temporary CI check. This can be tested by reverting the workaround and observing a failure. ACKs for top commit: hebasto: ACK fa8ade300f421dcc3b0cd956ab03a50a5ae80646, I've tested locally on Ubuntu 24.04. Tree-SHA512: 7ee1538fd5304a5ab91ac8c7619a573548d7e0345592a1e9d38b3b73729e09e7c77a9ee703d64cf02a8218de3148376d7836e294abb939aa7533034ba36dfb6c
2025-01-28Merge bitcoin/bitcoin#31620: test: Remove --noshutdown flag, Tidy startup ↵merge-script
failures faf2f2c654d9aa18b2f49a157956f9ab0fce302a test: Avoid redundant stop and error spam on shutdown (MarcoFalke) fae3bf6b870eb0f9cddd1adac82ba72890806ae3 test: Avoid redundant stop and error spam on startup failure (MarcoFalke) fa0dc09b9002f0bcae63af6af8d37fb3e0040ef4 test: Remove --noshutdown flag (MarcoFalke) fad441fba07877ea78ed6020fde11828307273a6 test: Treat leftover process as error (MarcoFalke) Pull request description: The `--noshutdown` flag is brittle, confusing, and redundant: * Someone wanting to inspect the state after a test failure will likely also want to debug the state on the python side, so the option is redundant with `--pdbonfailure`. If there was a use case to replicate `--pdbonfailure` without starting pdb, a dedicated flag could be added for that use case. * It is brittle to use the flag for a passing test, because it will disable checks in the test. For example, on shutdown LSan will perform a leak check, and the test framework will check that the node did not crash, and it will check that the node did not print errors to stderr. Fix all issues by removing it. Also, tidy up startup error messages to be less confusing as a result. ACKs for top commit: hodlinator: re-ACK faf2f2c654d9aa18b2f49a157956f9ab0fce302a pablomartin4btc: re tACK faf2f2c654d9aa18b2f49a157956f9ab0fce302a Tree-SHA512: 46d7ae59c7be88b93f1f9e0b6be21af0fc101e646512e2c5e725682cb18bfec8aa010e0ebe89ce9ffe239e5caac0da5f81cc97b79e738d26ca5fa31930e8e4e3
2025-01-27doc: update links in ci.ymlespi3
Updated three GitHub links to avoid redirects.
2025-01-27Merge bitcoin/bitcoin#21590: Safegcd-based modular inverses in MuHash3072Ava Chow
f5883286e32b625aab3dd80c74d6adb4f37f0a80 Add a fuzz test for Num3072 multiplication and inversion (Pieter Wuille) a26ce628942243fc9848a63bfdfa5e61f5e936f3 Safegcd based modular inverse for Num3072 (Pieter Wuille) 91ce8cef2d8955d980ab7e89fbf74e8b29adf178 Add benchmark for MuHash finalization (Pieter Wuille) Pull request description: This implements a safegcd-based modular inverse for MuHash3072. It is a fairly straightforward translation of [the libsecp256k1 implementation](https://github.com/bitcoin-core/secp256k1/pull/831), with the following changes: * Generic for 32-bit and 64-bit * Specialized for the specific MuHash3072 modulus (2^3072 - 1103717). * A bit more C++ish * Far fewer sanity checks A benchmark is also included for MuHash3072::Finalize. The new implementation is around 100x faster on x86_64 for me (from 5.8 ms to 57 μs); for 32-bit code the factor is likely even larger. For more information: * [Original paper](https://gcd.cr.yp.to/papers.html) by Daniel J. Bernstein and Bo-Yin Yang * [Implementation](https://github.com/bitcoin-core/secp256k1/pull/767) for libsecp256k1 by Peter Dettman; and the [final](https://github.com/bitcoin-core/secp256k1/pull/831) version * [Explanation](https://github.com/bitcoin-core/secp256k1/blob/master/doc/safegcd_implementation.md) of the algorithm using Python snippets * [Analysis](https://github.com/sipa/safegcd-bounds) of the maximum number of iterations the algorithm needs * [Formal proof in Coq](https://medium.com/blockstream/a-formal-proof-of-safegcd-bounds-695e1735a348) by Russell O'Connor (for the 256-bit version of the algorithm; here we use a 3072-bit one). ACKs for top commit: achow101: ACK f5883286e32b625aab3dd80c74d6adb4f37f0a80 TheCharlatan: Re-ACK f5883286e32b625aab3dd80c74d6adb4f37f0a80 dergoegge: tACK f5883286e32b625aab3dd80c74d6adb4f37f0a80 Tree-SHA512: 275872c61d30817a82901dee93fc7153afca55c32b72a95b8768f3fd464da1b09b36f952f30e70225e766b580751cfb9b874b2feaeb73ffaa6943c8062aee19a
2025-01-27contrib: fix BUILDDIR in gen-bitcoin-conf script and gen-manpages.pyjurraca
the cmake build steps suggest a build/ directory, which breaks these scripts. Additionally, in-tree builds are no longer allowed, so it makes sense to update the code and the README accordingly.
2025-01-26test: Add test for IPC serialization bugRyan Ofsky
Add regression test for serialization bug in IPC mining code that is not currently being called anywhere reported: https://github.com/Sjors/bitcoin/issues/71 https://github.com/chaincodelabs/libmultiprocess/issues/122
2025-01-26depends: Update libmultiprocess library before converting to subtreeRyan Ofsky
This should be the final update to the libmultiprocess package via the depends system. It brings in the libmultiprocess cmake changes from https://github.com/chaincodelabs/libmultiprocess/pull/136 needed to support building as subtree. After this, a followup PR will add libmultiprocess as a git subtree and depends will just use the git subtree instead of hardcoding its own version hash. Since there have been libmultiprocess API changes since the last update, this commit also updates bitcoin code to be compatible with them. This update brings in the following changes: https://github.com/chaincodelabs/libmultiprocess/pull/121 ProxyClientBase: avoid static_cast to partially constructed object https://github.com/chaincodelabs/libmultiprocess/pull/120 proxy-types.h: add static_assert to detect int/enum size mismatch https://github.com/chaincodelabs/libmultiprocess/pull/127 ProxyClientBase: avoid static_cast to partially destructed object https://github.com/chaincodelabs/libmultiprocess/pull/129 Fix "disconnected: write(m_post_fd, &buffer, 1): Broken pipe" EventLoop shutdown races. https://github.com/chaincodelabs/libmultiprocess/pull/130 refactor: Add CleanupRun function to dedup clean list code https://github.com/chaincodelabs/libmultiprocess/pull/131 doc: fix startAsyncThread comment https://github.com/chaincodelabs/libmultiprocess/pull/133 Fix debian "libatomic not found" error in downstream builds https://github.com/chaincodelabs/libmultiprocess/pull/94 c++ 20 cleanups https://github.com/chaincodelabs/libmultiprocess/pull/135 refactor: proxy-types.h API cleanup https://github.com/chaincodelabs/libmultiprocess/pull/136 cmake: Support being included with add_subdirectory https://github.com/chaincodelabs/libmultiprocess/pull/137 doc: Fix broken markdown links
2025-01-24Merge bitcoin/bitcoin#31599: qa: Improve framework.generate* enforcement ↵Ava Chow
(#31403 follow-up) 1b51616f2e3b58a1c63a19e6dba8e7e9c2aefdeb test: improve rogue calls in mining functions (i-am-yuvi) Pull request description: #31403 follow-up, see [comment](https://github.com/bitcoin/bitcoin/pull/31403#pullrequestreview-2498806354) - Rename `invalid_call` parameter to `called_by_framework` in `generateblock`, `generatetoaddress` and `generatetodescriptor` mining methods to better express its intended usage. - Add explicit assertion message clarifying that these functions should only be called by TestFramework itself to maintain proper node synchronization. ACKs for top commit: maflcko: lgtm ACK 1b51616f2e3b58a1c63a19e6dba8e7e9c2aefdeb achow101: ACK 1b51616f2e3b58a1c63a19e6dba8e7e9c2aefdeb hodlinator: re-ACK 1b51616f2e3b58a1c63a19e6dba8e7e9c2aefdeb Prabhat1308: ACK [1b51616](https://github.com/bitcoin/bitcoin/pull/31599/commits/1b51616f2e3b58a1c63a19e6dba8e7e9c2aefdeb) Tree-SHA512: 56832626fe54dcaa07dacb4f9c960c0a83fad3fb12272155114ac697856c59b7f44805e1152eddeec7a5e8f7daf487382dc01b5b9ae2e74b62b2df6bd1f81f77
2025-01-24Merge bitcoin/bitcoin#30322: test: raise an error in `_bulk_tx_` when ↵Ava Chow
`target_vsize` is too low 92787dd52cd4ddc378cf1bcb7e92a649916a0f42 test: raise an error when target_vsize is below tx virtual size (ismaelsadeeq) a8780c937f730f4fa2ef2045458e3908bb2176e4 test: raise an error if output value is <= 0 in `create_self_transfer` (ismaelsadeeq) f6e88931f071f06cb8aefeac61cf3bce662eea74 test: test that `create_self_transfer_multi` respects `target_vsize` (ismaelsadeeq) Pull request description: This is a simple test PR that does two things: 1. Raise an exception in `_bulk_tx_` when `target_vsize` is too low, i.e., below the tx vsize. 2. Addresses some review comments from https://github.com/bitcoin/bitcoin/pull/30162, which are: - Raise an error if the output value is less than or equal to zero in `create_self_transfer`. This prevents creating transactions with a value of 0 or less. - Add a test to verify that `create_self_transfer_multi` also respects the passed `target_vsize`. ACKs for top commit: achow101: ACK 92787dd52cd4ddc378cf1bcb7e92a649916a0f42 theStack: ACK 92787dd52cd4ddc378cf1bcb7e92a649916a0f42 rkrux: reACK 92787dd52cd4ddc378cf1bcb7e92a649916a0f42 glozow: ACK 92787dd52cd4ddc378cf1bcb7e92a649916a0f42 Tree-SHA512: 1f2767f2cf715ed65074c5fff347eec160b142685777d833d5e872cfef364d3dc1916b52ee442e99c7b9a8d514ff62bc67a9899d8854f65a4b93ac3ae300d18e
2025-01-24Merge bitcoin/bitcoin#31241: wallet: remove BDB dependency from wallet ↵Ava Chow
migration benchmark 18619b473255786b80f27dd33b46eb26a63fffc7 wallet: remove BDB dependency from wallet migration benchmark (furszy) Pull request description: Part of the legacy wallet removal working path #20160. Stops creating a bdb database in the wallet migration benchmark. Instead, the benchmark now creates the db in memory and re-uses it for the migration process. ACKs for top commit: achow101: ACK 18619b473255786b80f27dd33b46eb26a63fffc7 brunoerg: code review ACK 18619b473255786b80f27dd33b46eb26a63fffc7 theStack: Code-review ACK 18619b473255786b80f27dd33b46eb26a63fffc7 Tree-SHA512: a107deee3d2c00b980e3606be07d038ca524b98251442956d702a7996e2ac5e2901f656482018cacbac8ef6a628ac1fb03f677d1658aeaded4036d834a95d7e0
2025-01-24Merge bitcoin/bitcoin#31674: init: Lock blocksdir in addition to datadirAva Chow
2656a5658c14b43c32959db7235e9db55a17d4c8 tests: add a test for the new blocksdir lock (Cory Fields) bdc0a68e676f237bcbb5195a60bb08bb34123e71 init: lock blocksdir in addition to datadir (Cory Fields) cabb2e5c24282c88ccc7fcaede854eaa8d7ff162 refactor: introduce a more general LockDirectories for init (Cory Fields) 1db331ba764d27537d82abd91dde50fc9d7e0ff4 init: allow a new xor key to be written if the blocksdir is newly created (Cory Fields) Pull request description: This probably should've been included in #12653 when `-blocksdir` was introduced. Credit TheCharlatan for noticing that it's missing. This guards against 2 processes running with separate datadirs but the same blocksdir. I didn't add `walletdir` as I assume sqlite has us covered there. It's not likely to happen currently, but may be more relevant in the future with applications using the kernel. Note that the kernel does not currently do any dir locking, but it should. ACKs for top commit: maflcko: review ACK 2656a5658c14b43c32959db7235e9db55a17d4c8 🏼 kevkevinpal: ACK [2656a56](https://github.com/bitcoin/bitcoin/pull/31674/commits/2656a5658c14b43c32959db7235e9db55a17d4c8) achow101: ACK 2656a5658c14b43c32959db7235e9db55a17d4c8 tdb3: Code review and light test ACK 2656a5658c14b43c32959db7235e9db55a17d4c8 Tree-SHA512: 3ba17dc670126adda104148e14d1322ea4f67d671c84aaa9c08c760ef778ca1936832c0dc843cd6367e09939f64c6f0a682b0fa23a5967e821b899dff1fff961
2025-01-24net: Switch to DisconnectMsg in CConnmanHodlinator
2025-01-24test framework, wallet: rename get_scriptPubKey method to get_output_scriptAlfonso Roman Zubeldia
2025-01-24test: add validation for gettxout RPC responseAlfonso Roman Zubeldia
2025-01-24Merge bitcoin/bitcoin#31658: test: p2p: fix sending of manual INVs in tx ↵merge-script
download test 8996fef8aebd99aa9e1dec12b0087d79c0993a84 test: p2p: check that INV messages not matching wtxidrelay are ignored (Sebastian Falbesoner) e0b333682222927d64217b07bb8cfd7ff3139660 test: p2p: fix sending of manual INVs in tx download test (Sebastian Falbesoner) Pull request description: The `test_inv_block` sub-test in p2p_tx_download.py has a subtle bug: the manual msg_inv announcements from peers currently have no effect, since they don't match the wtxidrelay setting (=true by default for `P2PInterface` instances) and are hence ignored by the nodes (since 2d282e0c / PR #18044): https://github.com/bitcoin/bitcoin/blob/e7c479495509c068215b73f6df070af2d406ae15/src/net_processing.cpp#L3904-L3911 Though the test still passes on master, it does so without the intended scenario of asking an additional peer (triggering the GETDATA_TX_INTERVAL delay). Fix this by sending the INV message with MSG_WTX instead of MSG_TX. This increases the test run time by about one minute intentionally. It might be good to avoid issues like this in the future, happy to add test framework improvements if someone has a concrete idea. (Got into the topic of tx/wtx announcements via the discussion https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1904121487) ACKs for top commit: maflcko: ACK 8996fef8aebd99aa9e1dec12b0087d79c0993a84 😸 danielabrozzoni: ACK 8996fef8aebd99aa9e1dec12b0087d79c0993a84 mzumsande: Code Review ACK 8996fef8aebd99aa9e1dec12b0087d79c0993a84 Tree-SHA512: 3da26f9539c89d64c3b0d0579d9af2a6a4577615eed192506e1fb4318421b235f99a6672a497dea3050fba85dad32678f37fd2cda9ecb70cbf52982db37982e8
2025-01-24Merge bitcoin/bitcoin#31718: Docs: fix typos in documentation filesmerge-script
81b9800c87e96c83a49cabd1eddcbef210387da5 fix typos (wgyt) Pull request description: ACKs for top commit: maflcko: lgtm ACK 81b9800c87e96c83a49cabd1eddcbef210387da5 Tree-SHA512: 6a4f718c0afb0e3bf80ab7fa7fed32f882614c60b6e4972f54584aecac2f19384d781232e923a47b72d76229af907ebf7717d7b34f9be6c00394ce5d7ed0b8d4
2025-01-24fix typoswgyt
2025-01-23Merge bitcoin/bitcoin#31416: doc: Fix incorrect send RPC docsmerge-script
fad83e759a4a6221fb3b067657f847894e5a2f20 doc: Fix incorrect send RPC docs (MarcoFalke) Pull request description: It would be good to have accurate RPC docs, so that humans and machines can read them and rely on them. This fixes one issue. ACKs for top commit: fjahr: utACK fad83e759a4a6221fb3b067657f847894e5a2f20 rkrux: tACK fad83e759a4a6221fb3b067657f847894e5a2f20 luke-jr: tACK fad83e759a4 Tree-SHA512: 65d0cc18a62ef44833621464d74b743d24ffe2b853596dce2c4f423df0495142d50387c02ba1b54f5ca77d4ddb083d55116a8ac92698aa6558762d841664911e
2025-01-23cmake: Refer to the configure log instead of printing PIE test errorHennadii Stepanov
This change improves the user experience on systems where the toolchain does not support PIE.
2025-01-23Merge bitcoin/bitcoin#31704: doc: add a section in the fuzzing documentation ↵merge-script
about using MSan 5c3e4d8b293fab06d2311a863c675a392f24e383 doc: add a section about using MSan (Antoine Poinsot) Pull request description: Just a couple lines in a subsection of the sanitizers section mentioning that using the memory sanitizer is a bit more involve than other sanitizers, describing the steps and pointing to an example. ACKs for top commit: fanquake: ACK 5c3e4d8b293fab06d2311a863c675a392f24e383 dergoegge: ACK 5c3e4d8b293fab06d2311a863c675a392f24e383 Tree-SHA512: 4ff73c2dd0f25cb96148e54bd867b8d340bd0fbc9b9a736a705125039352eb1d40bd724f9f262a44d3dbd1bea8f03166cf30e571d882fec02ceb1dd399ef7422
2025-01-23test: Avoid redundant stop and error spam on shutdownMarcoFalke
Trying to shut down a node after a test failure may fail and lead to an RPC error. Also, it is confusing to sidestep the existing fallback to kill any leftover nodes on a test failure. So just rely on the fallback. Idea by Hodlinator. Co-Authored-By: Hodlinator <172445034+hodlinator@users.noreply.github.com>
2025-01-23Merge bitcoin/bitcoin#31635: test: add coverage for unknown address type for ↵merge-script
`createwalletdescriptor` 4da7bfdcc902f22239e55cd9b90abf36b29edfde test: add coverage for unknown address type for `createwalletdescriptor` (brunoerg) Pull request description: Calling `createwalletdescriptor` RPC with an unknown address type throws an error. This PR adds test coverage for it as done for other RPCs (`getnewaddress `, `getrawchangeaddress`, etc). ACKs for top commit: maflcko: lgtm ACK 4da7bfdcc902f22239e55cd9b90abf36b29edfde rkrux: tACK 4da7bfdcc902f22239e55cd9b90abf36b29edfde Tree-SHA512: 490bc3ffeb70b0f26db0a44d3950d7410fef35d4056487f2e82c081fb14ca277a18943c487235e0163a29f90fc741a262c29835beb9f41936affa4e73ddad25f
2025-01-23Merge bitcoin/bitcoin#31696: test: Check that reindex with prune wipes blk filesmerge-script
fa9aced8006bd9b10b9239b43140c37162c9d8f2 test: Check that reindex with prune wipes blk files (MarcoFalke) fa9593efc2e19d9dfa9a62c8a3d796aad888baa0 test: Use high-level python types (MarcoFalke) Pull request description: This adds missing test coverage for `CleanupBlockRevFiles`. ACKs for top commit: TheCharlatan: Re-ACK fa9aced8006bd9b10b9239b43140c37162c9d8f2 l0rinc: ACK fa9aced8006bd9b10b9239b43140c37162c9d8f2 tdb3: re ACK fa9aced8006bd9b10b9239b43140c37162c9d8f2 Tree-SHA512: b31ff8a896ce344437715e7fb7efdb8cd7e11470e8465d8972fddfdb58ffd78257786c4060e8596cc53b6278f8ac6a9b6eb05a06e9df58b8b240bdaa719a8e5b
2025-01-23Merge bitcoin/bitcoin#31541: qa: Use `sys.executable` when invoking other ↵merge-script
Python scripts d38ade7bc409207bf425e05ee10b633b0aef4c36 qa: Use `sys.executable` when invoking other Python scripts (Hennadii Stepanov) Pull request description: This PR fixes the `rpc_signer.py` and `wallet_signer.py` functional tests on systems where `python3` is not available in the `PATH`, causing the shebang `#!/usr/bin/env python3` to fail. Here are logs on NetBSD 10.0: - without this PR: ``` $ python3.12 ./build/test/functional/test_runner.py rpc_signer.py wallet_signer.py Temporary test directory at /tmp/test_runner_₿_🏃_20241219_160538 Remaining jobs: [rpc_signer.py, wallet_signer.py --descriptors] 1/2 - rpc_signer.py failed, Duration: 1 s stdout: 2024-12-19T16:05:40.012000Z TestFramework (INFO): PRNG seed is: 1833166631173850775 2024-12-19T16:05:40.012000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20241219_160538/rpc_signer_1 2024-12-19T16:05:40.754000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "/home/hebasto/dev/bitcoin/test/functional/test_framework/util.py", line 160, in try_rpc fun(*args, **kwds) File "/home/hebasto/dev/bitcoin/test/functional/test_framework/coverage.py", line 50, in __call__ return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/hebasto/dev/bitcoin/test/functional/test_framework/authproxy.py", line 146, in __call__ raise JSONRPCException(response['error'], status) test_framework.authproxy.JSONRPCException: RunCommandParseJSON error: process(/home/hebasto/dev/bitcoin/test/functional/mocks/signer.py enumerate) returned 127: env: python3: No such file or directory (-1) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/hebasto/dev/bitcoin/test/functional/test_framework/test_framework.py", line 135, in main self.run_test() File "/home/hebasto/dev/bitcoin/build/test/functional/rpc_signer.py", line 72, in run_test assert_raises_rpc_error(-1, 'fingerprint not found', File "/home/hebasto/dev/bitcoin/test/functional/test_framework/util.py", line 151, in assert_raises_rpc_error assert try_rpc(code, message, fun, *args, **kwds), "No exception raised" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/hebasto/dev/bitcoin/test/functional/test_framework/util.py", line 166, in try_rpc raise AssertionError( AssertionError: Expected substring not found in error message: substring: 'fingerprint not found' error message: 'RunCommandParseJSON error: process(/home/hebasto/dev/bitcoin/test/functional/mocks/signer.py enumerate) returned 127: env: python3: No such file or directory '. 2024-12-19T16:05:40.756000Z TestFramework (INFO): Stopping nodes 2024-12-19T16:05:40.873000Z TestFramework (WARNING): Not cleaning up dir /tmp/test_runner_₿_🏃_20241219_160538/rpc_signer_1 2024-12-19T16:05:40.873000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/test_runner_₿_🏃_20241219_160538/rpc_signer_1/test_framework.log 2024-12-19T16:05:40.873000Z TestFramework (ERROR): 2024-12-19T16:05:40.873000Z TestFramework (ERROR): Hint: Call /home/hebasto/dev/bitcoin/test/functional/combine_logs.py '/tmp/test_runner_₿_🏃_20241219_160538/rpc_signer_1' to consolidate all logs 2024-12-19T16:05:40.873000Z TestFramework (ERROR): 2024-12-19T16:05:40.873000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log. 2024-12-19T16:05:40.873000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues 2024-12-19T16:05:40.873000Z TestFramework (ERROR): stderr: Remaining jobs: [wallet_signer.py --descriptors] 2/2 - wallet_signer.py --descriptors failed, Duration: 1 s stdout: 2024-12-19T16:05:40.014000Z TestFramework (INFO): PRNG seed is: 7530764367977090686 2024-12-19T16:05:40.014000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20241219_160538/wallet_signer_0 2024-12-19T16:05:40.526000Z TestFramework (ERROR): JSONRPC error Traceback (most recent call last): File "/home/hebasto/dev/bitcoin/test/functional/test_framework/test_framework.py", line 135, in main self.run_test() File "/home/hebasto/dev/bitcoin/build/test/functional/wallet_signer.py", line 66, in run_test self.test_valid_signer() File "/home/hebasto/dev/bitcoin/build/test/functional/wallet_signer.py", line 83, in test_valid_signer self.nodes[1].createwallet(wallet_name='hww', disable_private_keys=True, descriptors=True, external_signer=True) File "/home/hebasto/dev/bitcoin/test/functional/test_framework/test_node.py", line 935, in createwallet return self.__getattr__('createwallet')(wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup, external_signer) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/hebasto/dev/bitcoin/test/functional/test_framework/coverage.py", line 50, in __call__ return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/hebasto/dev/bitcoin/test/functional/test_framework/authproxy.py", line 146, in __call__ raise JSONRPCException(response['error'], status) test_framework.authproxy.JSONRPCException: RunCommandParseJSON error: process(/home/hebasto/dev/bitcoin/test/functional/mocks/signer.py enumerate) returned 127: env: python3: No such file or directory (-1) 2024-12-19T16:05:40.528000Z TestFramework (INFO): Stopping nodes 2024-12-19T16:05:40.645000Z TestFramework (WARNING): Not cleaning up dir /tmp/test_runner_₿_🏃_20241219_160538/wallet_signer_0 2024-12-19T16:05:40.646000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/test_runner_₿_🏃_20241219_160538/wallet_signer_0/test_framework.log 2024-12-19T16:05:40.646000Z TestFramework (ERROR): 2024-12-19T16:05:40.646000Z TestFramework (ERROR): Hint: Call /home/hebasto/dev/bitcoin/test/functional/combine_logs.py '/tmp/test_runner_₿_🏃_20241219_160538/wallet_signer_0' to consolidate all logs 2024-12-19T16:05:40.646000Z TestFramework (ERROR): 2024-12-19T16:05:40.646000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log. 2024-12-19T16:05:40.646000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues 2024-12-19T16:05:40.646000Z TestFramework (ERROR): stderr: TEST | STATUS | DURATION rpc_signer.py | ✖ Failed | 1 s wallet_signer.py --descriptors | ✖ Failed | 1 s ALL | ✖ Failed | 2 s (accumulated) Runtime: 1 s ``` - with this PR: ``` $ python3.12 ./build/test/functional/test_runner.py rpc_signer.py wallet_signer.py Temporary test directory at /tmp/test_runner_₿_🏃_20241219_160011 Remaining jobs: [rpc_signer.py, wallet_signer.py --descriptors] 1/2 - rpc_signer.py passed, Duration: 2 s Remaining jobs: [wallet_signer.py --descriptors] 2/2 - wallet_signer.py --descriptors passed, Duration: 3 s TEST | STATUS | DURATION rpc_signer.py | ✓ Passed | 2 s wallet_signer.py --descriptors | ✓ Passed | 3 s ALL | ✓ Passed | 5 s (accumulated) Runtime: 3 s ``` ACKs for top commit: maflcko: lgtm ACK d38ade7bc409207bf425e05ee10b633b0aef4c36 stickies-v: ACK d38ade7bc409207bf425e05ee10b633b0aef4c36 . I have a minor concern about `sys.executable` not being guaranteed to return a valid Python path, but this patch seems good enough as is so no blocker. Tree-SHA512: 91fe0abc0b7e2b599c5562f8b225ba60f94c5bd6baa77d8df532155ef4d3ef6c6a862cee7f4a7f565ed4bb3251adcda813b4a4f79be1aa6a4ffdfda8b4e53415
2025-01-23Merge bitcoin/bitcoin#31376: Miner: never create a template which exploits ↵merge-script
the timewarp bug 733fa0b0a140fc1e40c644a29953db090baa2890 miner: never create a template which exploits the timewarp bug (Antoine Poinsot) Pull request description: This check was introduced in #30681 but only enabled for testnet4. To avoid potentially creating an invalid block template if a soft fork to fix the timewarp attack were to activate in the future, we should have this check on all networks. It also seems wise for our miner to not support it whether or not a soft fork activates to fix it at the consensus level. ACKs for top commit: Sjors: ACK 733fa0b0a140fc1e40c644a29953db090baa2890 fjahr: utACK 733fa0b0a140fc1e40c644a29953db090baa2890 TheCharlatan: ACK 733fa0b0a140fc1e40c644a29953db090baa2890 Tree-SHA512: 9b3bc8b26a57f93425b17dda80bcfac4ecb750a3d26bc3eb8df619135634e369ac15982fac0c9770b1df207bd2e418ffe02a98f37968f024e55262d97715a4f5
2025-01-23cmake: Copy `cov_tool_wrapper.sh.in` to the build treeHennadii Stepanov
This change ensures that `cov_tool_wrapper.sh.in` is available when invoking the `Coverage.cmake` script from any directory.
2025-01-23lint: Call lint_commit_msg from test_runnerMarcoFalke
Allowing to call the check from the test_runner allows for consistent error messages. Also, manually setting the commit range is no longer needed.
2025-01-23lint: Move commit range printing to test_runnerMarcoFalke
Having a single test_runner for all logic improves the consistency and UX.
2025-01-23lint: Call lint_scripted_diff from test_runnerMarcoFalke
Allowing to call the check from the test_runner allows for consistent error messages and better UX by having a single test_runner for all checks. This requires the env var to be set for now. The next commit makes the commit range optional.
2025-01-23Merge bitcoin/bitcoin#31709: cmake: Fail if `Libmultiprocess` is missing ↵merge-script
when `WITH_MULTIPROCESS=ON` c31166ac77af8fbdc9012999b345540fe88cc394 cmake: Fail if `Libmultiprocess` is missing when `WITH_MULTIPROCESS=ON` (Hennadii Stepanov) Pull request description: Fixes https://github.com/bitcoin/bitcoin/issues/31708: ``` $ cmake -B build -DWITH_MULTIPROCESS=ON -- The CXX compiler identification is GNU 13.3.0 -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found SQLite3: /usr/include (found suitable version "3.45.1", minimum required is "3.7.17") CMake Error at CMakeLists.txt:146 (find_package): By not providing "FindLibmultiprocess.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "Libmultiprocess", but CMake did not find one. Could not find a package configuration file provided by "Libmultiprocess" with any of the following names: LibmultiprocessConfig.cmake libmultiprocess-config.cmake Add the installation prefix of "Libmultiprocess" to CMAKE_PREFIX_PATH or set "Libmultiprocess_DIR" to a directory containing one of the above files. If "Libmultiprocess" provides a separate development package or SDK, be sure it has been installed. -- Configuring incomplete, errors occurred! ``` ACKs for top commit: vasild: ACK c31166ac77af8fbdc9012999b345540fe88cc394 ryanofsky: Code review ACK c31166ac77af8fbdc9012999b345540fe88cc394 TheCharlatan: ACK c31166ac77af8fbdc9012999b345540fe88cc394 Tree-SHA512: 503e6d7ff253c9ae95b13ff0649af7db97c74a97c04ca6fe88130defae251b94bfe9f4466300d3fab16397c7c8346b392a80a7b80a2d6517464a4eabe3aa40db
2025-01-22Merge bitcoin/bitcoin#31583: rpc: add target to getmininginfo field and show ↵Ryan Ofsky
next block info a4df12323c4e9230bca58562ba17ecee4233f8fe doc: add release notes (Sjors Provoost) c75872ffdd98ce9f04fb8489515d1b63853f03b4 test: use DIFF_1_N_BITS in tool_signet_miner (tdb3) 4131f322ac0abe43639065362cd3c4ea36d2c5c3 test: check difficulty adjustment using alternate mainnet (Sjors Provoost) c4f68c12e228818f655352d17d038dcc7ba1db3a Use OP_0 for BIP34 padding in signet and tests (Sjors Provoost) cf0a62878be214cd4ec779aab214221b27b769b6 rpc: add next to getmininginfo (Sjors Provoost) 2d18a078a2d9eaa53b8b7acc7600141c69f0d742 rpc: add target and bits to getchainstates (Sjors Provoost) f153f57acc9f9a6f84af161d5bed9aa9965abaa3 rpc: add target and bits to getblockchaininfo (Sjors Provoost) baa504fdfaff4a9f61bc939035df5d5f2978cfd7 rpc: add target to getmininginfo result (Sjors Provoost) 2a7bfebd5e788e1d9e7e07a9f1b8e3625a0301cd Add target to getblock(header) in RPC and REST (Sjors Provoost) 341f93251677fee66c822f414b75499e8b3b31f6 rpc: add GetTarget helper (Sjors Provoost) d20d96fa41ce706ccc480b4f3143438ce0720348 test: use REGTEST_N_BITS in feature_block (tdb3) 7ddbed4f9fc0c90bfed244a71194740a4a1fa1be rpc: add nBits to getmininginfo (Sjors Provoost) ba7b9f3d7bf5a1ad395262b080e832f5c9958e4d build: move pow and chain to bitcoin_common (Sjors Provoost) c4cc9e3e9df2733260942e0513dd8478d2a104da consensus: add DeriveTarget() to pow.h (Sjors Provoost) Pull request description: **tl&dr for consensus-code only reviewers**: the first commit splits `CheckProofOfWorkImpl()` in order to create a `DeriveTarget()` helper. The rest of this PR does not touch consensus code. There are three ways to represent the proof-of-work in a block: 1. nBits 2. Difficulty 3. Target The latter notation is useful when you want to compare share work against either the pool target (to get paid) or network difficulty (found an actual block). E.g. for difficulty 1 which corresponds to an nBits value of `0x00ffff`: ``` share hash: f6b973257df982284715b0c7a20640dad709d22b0b1a58f2f88d35886ea5ac45 target: 7fffff0000000000000000000000000000000000000000000000000000000000 ``` It's immediately clear that the share is invalid because the hash is above the target. This type of logging is mostly done by the pool software. It's a nice extra convenience, but not very important. It impacts the following RPC calls: 1. `getmininginfo` displays the `target` for the tip block 2. `getblock` and `getblockheader` display the `target` for a specific block (ditto for their REST equivalents) The `getdifficulty` method is a bit useless in its current state, because what miners really want to know if the difficulty for the _next_ block. So I added a boolean argument `next` to `getdifficulty`. (These values are typically the same, except for the first block in a retarget period. On testnet3 / testnet4 they change when no block is found after 20 minutes). Similarly I added a `next` object to `getmininginfo` which shows `bit`, `difficulty` and `target` for the next block. In order to test the difficulty transition, an alternate mainnet chain with 2016 blocks was generated and used in `mining_mainnet.py`. The chain is deterministic except for its timestamp and nonce values, which are stored in `mainnet_alt.json`. As described at the top, this PR introduces a helper method `DeriveTarget()` which is split out from `CheckProofOfWorkImpl`. The proposed `checkblock` RPC in #31564 needs this helper method internally to figure out the consensus target. Finally, this PR moves `pow.cpp` and `chain.cpp` from `bitcoin_node` to `bitcoin_common`, in order to give `rpc/util.cpp` (which lives in `bitcoin_common`) access to `pow.h`. ACKs for top commit: ismaelsadeeq: re-ACK a4df12323c4e9230bca58562ba17ecee4233f8fe tdb3: code review re ACK a4df12323c4e9230bca58562ba17ecee4233f8fe ryanofsky: Code review ACK a4df12323c4e9230bca58562ba17ecee4233f8fe. Only overall changes since last review were dropping new `gettarget` method and dropping changes to `getdifficulty`, but there were also various internal changes splitting and rearranging commits. Tree-SHA512: edef5633590379c4be007ac96fd1deda8a5b9562ca6ff19fe377cb552b5166f3890d158554c249ab8345977a06da5df07866c9f42ac43ee83dfe3830c61cd169
2025-01-22Merge bitcoin/bitcoin#31548: fuzz: Abort when global PRNG is used before ↵Ryan Ofsky
SeedRand::ZEROS fa3c787b62af6abaac35a8f0d785becdb8871cc0 fuzz: Abort when global PRNG is used before SeedRand::ZEROS (MarcoFalke) Pull request description: This adds one more check to abort when global PRNG is used before SeedRand::ZEROS in fuzz tests. This is achieved by carving out the two remaining uses. First, `g_rng_temp_path_init`, and second the random fallback for `RANDOM_CTX_SEED`, which isn't used in fuzz tests anyway. Requested in https://github.com/bitcoin/bitcoin/pull/31521#issuecomment-2554669015 Can be tested by reverting fadd568931a2d21e0f80e1efaf2281f5164fa20e and observing an abort when running the `utxo_total_supply` fuzz target. ACKs for top commit: marcofleon: ACK fa3c787b62af6abaac35a8f0d785becdb8871cc0 hodlinator: re-ACK fa3c787b62af6abaac35a8f0d785becdb8871cc0 ryanofsky: Code review ACK fa3c787b62af6abaac35a8f0d785becdb8871cc0. This adds a new check to make that sure that RNG is never seeded during fuzzing after the RNG has been used. Together with existing checks which ensure RNG can only be seeded with zeroes during fuzzing, and that RNG must was seeded at some point if used after fuzzing, this implies it must have been seeded by zeros before being used. Tree-SHA512: 2614928d31c310309bd9021b3e5637b35f64196020fbf9409e978628799691d0efd3f4cf606be9a2db0ef60b010f890c2e70c910eaa2934a7fbf64cd1598fe22
2025-01-22cmake: Fail if `Libmultiprocess` is missing when `WITH_MULTIPROCESS=ON`Hennadii Stepanov
2025-01-22Merge bitcoin/bitcoin#31490: refactor: inline `UndoWriteToDisk` and ↵Ryan Ofsky
`WriteBlockToDisk` to reduce serialization calls 223081ece651dc616ff63d9ac447eedc5c2a28fa scripted-diff: rename block and undo functions for consistency (Lőrinc) baaa3b284671ba28dbbcbb43851ea46175fd2b13 refactor,blocks: remove costly asserts and modernize affected logs (Lőrinc) fa39f27a0f8b8d14f6769d48f43999a3a1148e4f refactor,blocks: deduplicate block's serialized size calculations (Lőrinc) dfb2f9d004860c95fc6f0d4a016a9c038d53a475 refactor,blocks: inline `WriteBlockToDisk` (Lőrinc) 42bc4914658d9834a653bd1763aa8f0d54355480 refactor,blocks: inline `UndoWriteToDisk` (Lőrinc) 86b85bb11f8999eb59e34bd026b0791dc866f2eb bench: add SaveBlockBench (Lőrinc) 34f9a0157aad7c10ac364b7e4602c5f74c1f9e20 refactor,bench: rename bench/readblock.cpp to bench/readwriteblock.cpp (Lőrinc) Pull request description: `UndoWriteToDisk` and `WriteBlockToDisk` were delegating a subset of their functionality to single-use methods that didn't optimally capture a meaningful chunk of the algorithm, resulting in calculating things twice (serialized size, header size). This change inlines the awkward methods (asserting that all previous behavior was retained), and in separate commits makes the usages less confusing. Besides making the methods slightly more intuitive, the refactorings reduce duplicate calculations as well. The speed difference is insignificant for now (~0.5% for the new `SaveBlockToDiskBench`), but are a cleanup for follow-ups such as https://github.com/bitcoin/bitcoin/pull/31539 ACKs for top commit: ryanofsky: Code review ACK 223081ece651dc616ff63d9ac447eedc5c2a28fa. Since last review, "Save" was renamed to "Write", uint32_t references were dropped, some log statements and comments were improved as suggested, and a lot of tweaks made to commits and commit messages which should make this easier to review. hodlinator: ACK 223081ece651dc616ff63d9ac447eedc5c2a28fa TheCharlatan: ACK 223081ece651dc616ff63d9ac447eedc5c2a28fa andrewtoth: ACK 223081ece651dc616ff63d9ac447eedc5c2a28fa Tree-SHA512: 951bc8ad3504c510988afd95c561e3e259c6212bd14f6536fe56e8eb5bf5c35c32a368bbdb1d5aea1acc473d7e5bd9cdcde02008a148b05af1f955e413062d5c
2025-01-22Merge bitcoin/bitcoin#31690: doc: Amend notes on benchmarkingmerge-script
e94c9d171239c1fc44fa9c77a4595ecd626b767f [doc] Amend notes on benchmarking (dergoegge) Pull request description: This gives some more context on the motivation and larger picture of benchmarks. ACKs for top commit: l0rinc: ACK e94c9d171239c1fc44fa9c77a4595ecd626b767f instagibbs: reACK e94c9d171239c1fc44fa9c77a4595ecd626b767f darosior: reACK e94c9d171239c1fc44fa9c77a4595ecd626b767f brunoerg: reACK e94c9d171239c1fc44fa9c77a4595ecd626b767f Tree-SHA512: 2cbf51f283f2efc0938e7021ae48db51fe89caf9ef9780821e99fa745dff839e2d202ca956ce6cc48b8319db304069728e77883feefe486264eb1783a0610c93
generated by cgit v1.2.3 (git 2.26.2) at 2025-03-16 10:51:26 +0000