aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-06scripts: fix check-symbols & check-security argument passingfanquake
The first argument in bin_PROGRAMS (bitcoind) was being silently dropped and never passed into the check-security.py or check-symbols.py scripts. This has been the case since the scripts were added to the makefile in https://github.com/bitcoin/bitcoin/commit/f3d3eaf78eb51238d799d8f20a585550d1567719. Example of the behavior: ```python # touch a, touch b, touch c # python3 args.py < a b c import sys if __name__ == '__main__': print(sys.argv) # ['args.py', 'b', 'c'] # if you add some lines to "a", # you'll see them here.. for line in sys.stdin: print(line) ``` Github-Pull: #17857 Rebased-From: 71af793512100ee7d508c3fb815af47925fe80ba
2019-11-25Merge #16617: [0.18.2] BackportsWladimir J. van der Laan
0b18ea6f570e24c9719c10eb6e125da743409c58 util: Filter control characters out of log messages (Wladimir J. van der Laan) ac30fc4f599b28fc09a854bf2d2940fe2eb5fcdf build: Factor out qt translations from build system (Wladimir J. van der Laan) 3b8af5f3838bb124f5f59dbaa4c553a6ad8e7c98 build: update boost macros to latest upstream (fanquake) b12defc3bc7ba68a86c053138d29d942b81af805 Test that joinpsbts randomly shuffles the inputs (Andrew Chow) eb07d22b2d3ec70203412a7746b0ec73217cc974 Shuffle inputs and outputs after joining psbts (Andrew Chow) 1175410be5959f783f0a5276451b775dc340e420 addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests. (practicalswift) c52dd120fd6498ee73b7652e3b0e5380124a5502 Handle the result of posix_fallocate system call (Luca Venturini) f792b25d1487efdfab4d78c96755a73d978abcc4 torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently (Luke Dashjr) 9fe8d283e01ed3d721591fbc7f8326ceb6d706ff Bugfix: QA: Run tests with UPnP disabled (Luke Dashjr) 1d12e52db0f325f7d5239c117e3662db7a8966ad Add vertical spacer (Josu Goñi) d764141b01d8a4827b366f6264b3c87a114a710b depends: add patch to common dependencies (fanquake) 56815e9e12cb90eae160634e3c9c3515cf145dd1 Give QApplication dummy arguments (Andrew Chow) 9d389d09ed5db1a2dda00ba999b02d38186b6af4 util: No translation of `Bitcoin Core` in the copyright (MarcoFalke) 87908e9c98f2bc6975d70d8f427a9be965effc3b scripted-diff: Avoid passing PACKAGE_NAME for translation (MarcoFalke) a44e18f20b720ec9d3bef3640ef1c1d3730e2292 build: Stop translating PACKAGE_NAME (MarcoFalke) 7bd8f4e4321b73a9d55926778655310de0166bac rpc: Fix getblocktemplate CLI example (#16594) (Emil Engler) 1cc06a1b6753362e690dc18f79ad177d5f8a87c2 doc: Fix typos in COPYRIGHT (Chuf) Pull request description: Backports some commits to the `0.18` branch: * #16596 - rpc: Fix getblocktemplate CLI example * #16615 - doc: Fix typos in COPYRIGHT * #16291 - gui: Stop translating PACKAGE_NAME (without the `make translate` commit) * #16578 - Do not pass in command line arguments to QApplication * #16051 - depends: add patch to common dependencies * #16090 - Add vertical spacer * #15651 - torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently * #15650 - Handle the result of posix_fallocate system call * #16646 - Bugfix: QA: Run tests with UPnP disabled * #16212 - addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests. * #16512 - rpc: Shuffle inputs and outputs after joining psbts * #16870 - build: update boost macros to latest upstream for improved error reporting * #16982 - build: Factor out qt translations from build system * #17095 - util: Filter control characters out of log messages ACKs for top commit: laanwj: ACK 0b18ea6f570e24c9719c10eb6e125da743409c58 Tree-SHA512: 37f0e5afc20975f4d1506e8662eda2ae0125f2f424a852818b5af2c3b8db78fc1c365b83571aa80ca63c885ca314302190b891a50ff3851fda9b9238455a5627
2019-10-19util: Filter control characters out of log messagesWladimir J. van der Laan
Belts and suspenders: make sure outgoing log messages don't contain potentially suspicious characters, such as terminal control codes. This escapes control characters except newline ('\n') in C syntax. It escapes instead of removes them to still allow for troubleshooting issues where they accidentally end up in strings. Github-Pull: #17095 Rebased-From: d7820a1250070f3640246ae497e049bee0b3516f
2019-10-01build: Factor out qt translations from build systemWladimir J. van der Laan
Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36). Github-Pull: #16982 Rebased-From: 4320bfc0c0d88633c84146f8d640f5b6e4596244
2019-10-01build: update boost macros to latest upstreamfanquake
Fixes: #16803 I opened an [upstream PR](https://github.com/autoconf-archive/autoconf-archive/pull/197) to improve the Boost error reporting, so pull the latest macros. Github-Pull: #16870 Rebased-From: bb99c4e684bbd3053ecf7a789049b11b29260189
2019-09-24Test that joinpsbts randomly shuffles the inputsAndrew Chow
Github-Pull: #16512 Rebased-From: c0b5d9710322a614a50ab5da081558cf6a38ad2a
2019-09-24Shuffle inputs and outputs after joining psbtsAndrew Chow
Github-Pull: #16512 Rebased-From: 6f405a1d3b38395e35571b68aae55cae50e0762a
2019-09-24addrdb: Remove temporary files created in SerializeFileDB. Fixes ↵practicalswift
non-determinism in unit tests. Github-Pull: #16212 Rebased-From: d9753383b9e1b61d19d98bcd1d66607f398c7e9f
2019-09-24Handle the result of posix_fallocate system callLuca Venturini
Github-Pull: #15650 Rebased-From: 5d35ae3326624da3fe5dcb4047c9a7cec6665cab
2019-09-24torcontrol: Use the default/standard network port for Tor hidden services, ↵Luke Dashjr
even if the internal port is set differently Currently, the hidden service is published on the same port as the public listening port. But if a non-standard port is configured, this can be used to guess (pretty reliably) that the public IP and the hidden service are the same node. Github-Pull: #15651 Rebased-From: 8a2656702b4b5d53d1b8343c3215302e4305a038
2019-09-24Bugfix: QA: Run tests with UPnP disabledLuke Dashjr
Needed for builds configured with --enable-upnp-default Github-Pull: #16646 Rebased-From: b168dd30cf71ac176e271bc610b0b1a79ceaf075
2019-09-24Add vertical spacerJosu Goñi
Github-Pull: #16090 Rebased-From: 36b0a2f2a6b49008c4f37866a9e3ab702eb34eda
2019-09-24depends: add patch to common dependenciesfanquake
Github-Pull: #16051 Rebased-From: 4de3c15671fea211c22b14c64ec9ac2524fcfca9
2019-09-24Give QApplication dummy argumentsAndrew Chow
QApplication takes the command line arguments and parses them itself for some built in command line arguments that it has. We don't want any of those built in arguments, so instead give it dummy arguments. Github-Pull: #16578 Rebased-From: a2714a5c69f0b0506689af04c3e785f71ee0915d
2019-09-24util: No translation of `Bitcoin Core` in the copyrightMarcoFalke
Github-Pull: #16291 Rebased-From: fa64b947bb3075ff8737656706b941af691908ab
2019-09-24scripted-diff: Avoid passing PACKAGE_NAME for translationMarcoFalke
-BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/\<\w+(::\w+)?\(PACKAGE_NAME\)/PACKAGE_NAME/g' $(git grep -l --extended-regexp '\<\w+(::\w+)?\(PACKAGE_NAME\)' src) -END VERIFY SCRIPT- Github-Pull: #16291 Rebased-From: fabe87d2c923ab3a70b8cde2666a4d1cda8b22fb
2019-09-24build: Stop translating PACKAGE_NAMEMarcoFalke
Github-Pull: #16291 Rebased-From: fa5e9f157e568b7fbbea1482b393181f0733f2ba
2019-09-24rpc: Fix getblocktemplate CLI example (#16594)Emil Engler
Github-Pull: #16596 Rebased-From: 14f7eec3bdb15a9a75f8686c0a3e879aa8ceef47
2019-09-24doc: Fix typos in COPYRIGHTChuf
Fixed a couple of typos Github-Pull: #16615 Rebased-From: 36f7697cf6c129cabff2a698a52115829cd0d1fb
2019-09-23Merge #16414: 0.18: wallet: Fix -maxtxfee check by moving it to ↵MarcoFalke
CWallet::CreateTransaction d3b3bb8c9fb3a2ff1cd3a8776552c649aaf19dc2 0.18: test: Add test for maxtxfee option (MarcoFalke) a11dbaa547ec01e7e11ca4dbe2433e7d987c82bb 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (João Barbosa) 8f354ced6e34247477c1b1a56d34e613f6104f0e 0.18: [wallet] abort when attempting to fund a transaction above maxtxfee (Sjors Provoost) Pull request description: Backports #16322 and #16257. ACKs for top commit: Sjors: re-ACK d3b3bb8c9fb3a2ff1cd3a8776552c649aaf19dc2 MarcoFalke: ACK d3b3bb8c9fb3a2ff1cd3a8776552c649aaf19dc2 (did the backport myself, arrived at the same result) Tree-SHA512: 8b0ca15fc7e893af80239afecf8ff1018d6f249f2fa530babe61ec34ede6103b9b60909259abb730ebf1d54789aceed94b136600158dc3d6c5505b07f28189e5
2019-08-250.18: test: Add test for maxtxfee optionMarcoFalke
Github-Pull: #16322 Rebased-From: 0d101a340c44841cbbc5982d55354b1787bc39e2
2019-08-250.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransactionJoão Barbosa
Github-Pull: #16322 Rebased-From: 5c1b9714cb0a13be28324f91f4ec9ca66a1de8c7
2019-08-250.18: [wallet] abort when attempting to fund a transaction above maxtxfeeSjors Provoost
FundTransaction calls GetMinimumFee which, when the fee rate is absurdly high, quietly reduced the fee to -maxtxfee. Becaue an absurdly high fee rate is usually the result of a fat finger, aborting seems safer behavior. Github-Pull: #16257 Rebased-From: 806b0052c3b45415862f74f20ba5f389e5b673de
2019-08-19Merge #16608: [0.18] Backport #15911: Use wallet RBF default for ↵MarcoFalke
walletcreatefundedpsbt 576580fe8a063f21c0e903af1cf8f85cd6cb71d7 [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0 (Sjors Provoost) 0942a60c06ab4bde275369e7b7bd1caa3b20778e [doc] rpc: remove "fallback to" from RBF default help (Sjors Provoost) ee950ec465b616b1f7dd14df8f77c66a817c0b64 [rpc] walletcreatefundedpsbt: use wallet default RBF (Sjors Provoost) Pull request description: Backport of #15911 for 0.18 branch. The original PR changed `rawtransaction_util.cpp`, whereas the backport changes `rawtransaction.cpp` to avoid having to also backport #15638. ACKs for top commit: meshcollider: re-utACK 576580fe8a063f21c0e903af1cf8f85cd6cb71d7 MarcoFalke: ACK 576580fe8a063f21c0e903af1cf8f85cd6cb71d7 Tree-SHA512: 51c40fc4db4f8739e93e931aeac572779d5ade0bfeb3bcb0082301cf73b4f48e31d4ccbe40421dc65d0ec091d6393685c0c9b8f76584c59249f13642e80a6da5
2019-08-17[test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0Sjors Provoost
2019-08-17[doc] rpc: remove "fallback to" from RBF default helpSjors Provoost
2019-08-17[rpc] walletcreatefundedpsbt: use wallet default RBFSjors Provoost
2019-08-14Merge #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixesMarcoFalke
80cd3f0ba68ccba333f0bd5241c34f2f22cf1c48 travis: Bump timeout from 50 minutes to 90 (MarcoFalke) 5aac5e9b0311e41bd3c6a07d065eae0c47004814 travis: Bump second timeout to 33 minutes, Add rationale (MarcoFalke) 2c341e3471d300b940b83f0bb90b6bcee2fa5d38 travis: Properly cache and error on timeout (MarcoFalke) Pull request description: ACKs for top commit: fanquake: ACK 80cd3f0ba68ccba333f0bd5241c34f2f22cf1c48 - assuming Travis is happy. Tree-SHA512: d903bff9407d0e07d81037f667645263ad96852ea66a1d9118365444a332e1bf8f5973ecf5ef862a9759614377409c12619a80b638bd6cde2695d6fb6532ff83
2019-08-14travis: Bump timeout from 50 minutes to 90MarcoFalke
Github-Pull: #16595 Rebased-From: fa1e9c68a72fe8a17b6cb1ce473fd79388b2b61e
2019-08-14travis: Bump second timeout to 33 minutes, Add rationaleMarcoFalke
Github-Pull: #15797 Rebased-From: fa2dfbf30a9833eaa5f006fc4102299e8302bcd9
2019-08-14travis: Properly cache and error on timeoutMarcoFalke
Github-Pull: #15693 Rebased-From: fa2056af1c71aded3a821a07ec4de71c4be0bca3
2019-08-14doc: Clean out release notes post-0.18.1Wladimir J. van der Laan
Tree-SHA512: d03bee43f65b1837a4e157acb358716f2df08c8692c8f77f9531568a3da732684b7fae6e10cf8a88c353f8f8360dd6311d5e5c936c2a3d9e0f34dfaf5b727e76
2019-08-02doc: Bump manpages pre-finalv0.18.1Wladimir J. van der Laan
No changes, only the month changed from July to August. Tree-SHA512: c8f672f3a6e570ea1feda2c2f17d30da8a04b705d990bf5aec8e09da5937f3f9a608f4f50941f183c536a4158001b13d149bd0c873a24eae48ae57d96cd274c8
2019-08-02build: set CLIENT_VERSION_RC to 0 pre-finalWladimir J. van der Laan
Tree-SHA512: b74ff824278e6a4c4781c904e3f68295c76d9de79cc174a6e7127273295ef3fddb87de89143ceb76805e33b8c2dec77b3e6ae4bec97a3128d9908c065c7f95de
2019-08-02Merge #16532: [0.18] Doc: remove old release notes about systemd and riscv ↵Wladimir J. van der Laan
changes 5f5b444cc02190352312021c736d88c925731d90 Doc: remove old release notes about systemd and riscv changes (David A. Harding) Pull request description: Removes these two paragraphs that were part of the 0.18.0 release notes but which I don't think need to be repeated for the 0.18.1 release notes. The systemd release note in particular links to a section that isn't part of the document. ACKs for top commit: practicalswift: ACK 5f5b444cc02190352312021c736d88c925731d90 laanwj: ACK 5f5b444cc02190352312021c736d88c925731d90 fanquake: ACK 5f5b444cc02190352312021c736d88c925731d90 - this should be fine. Tree-SHA512: 3930b832eeed1f938cd6423dd9ac1e02ab7bb4fc218f433551fa995f40b84e8f2af5755ca4bf56caccdc742b6884bc79b381c9bdb3ad90e99ca90011d9e12665
2019-08-01Doc: remove old release notes about systemd and riscv changesDavid A. Harding
2019-07-24doc: Update release notes for rc1Wladimir J. van der Laan
Tree-SHA512: e5422eaed5339327b600bfe07e5cdb1517bf6f3d9a39d27c9c59a68ceadbef398960c69630bc727f3f8d7330353e7823905f5107dba6d8827965565157cdeca1
2019-07-19doc: Update manpages for rc1v0.18.1rc1Wladimir J. van der Laan
Tree-SHA512: 805a6931e2bd059ee2da42634f687828a50b2ccd3a1ac0071cd626e9a2f52b7afc79af3c8f3d5b013a853d5e59068314e744a4694dceef598710f0694babbd99
2019-07-19build: Bump version to 0.18.1rc1Wladimir J. van der Laan
Tree-SHA512: f746d4cfda1eb433c4c99b8d80392ac2e905c1f39591eb5579a708129e3b1b36479a2da45221594713cf20069bde78c29a31cb10d39c7bc96544694d9832cda0
2019-07-19qt: pre-rc1 translations updateWladimir J. van der Laan
Tree-SHA512: b97fd91b7ab1eb2297007a9821def31c065a2a33f12cf51fd5e5be5dff1e8afb4f5b001d220c3873d72ca5b06484ad2d1e2c8df5300770145de0dfebe56db303
2019-07-19net: Make poll in InterruptibleRecv only filter for POLLIN events.tecnovert
poll should block until there is data to be read or the timeout expires. Filtering for the POLLOUT event causes poll to return immediately which leads to high CPU usage when trying to connect to non-responding peers through tor. Removing POLLOUT matches how select is used when USE_POLL isn't defined. Github-Pull: #16412 Rebased-From: a52818cc5633494992da7d1dc8fdb04b4a1b7c29 Tree-SHA512: eaf466630ba9d2a2a7443c9679c83c2cb13e779a5948f409cddb4c48cf32126ac68f3de48e394f9302e99858efa17cdb14650751a1b55c3b79e8a7507cab352d
2019-07-18Merge #16406: 0.18: fix: tor: Call event_base_loopbreak from the event's ↵fanquake
callback b2711b98bdc0dc220500a4b3ca94dfb97c4d17f2 fix: tor: Call event_base_loopbreak from the event's callback (João Barbosa) Pull request description: Github-Pull: #16405 Rebased-From: a981e749e6553487cd48eda28e590f769e81c85c ACKs for top commit: laanwj: ACK b2711b98bdc0dc220500a4b3ca94dfb97c4d17f2, code change is the same as for master fanquake: ACK b2711b98bdc0dc220500a4b3ca94dfb97c4d17f2 Tree-SHA512: 9f225e505c0241be422ed897f56aef6ebad57e15d3bfe5154c7fe4f874df342e0df287871cd737eb777d0f45865a6d129cd5d1a4c036ea0a4e5d4f36520ab174
2019-07-17fix: tor: Call event_base_loopbreak from the event's callbackJoão Barbosa
Github-Pull: #16405 Rebased-From: a981e749e6553487cd48eda28e590f769e81c85c
2019-07-10Merge #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result"Wladimir J. van der Laan
df695db3237571c662a4e199709f9c6615ffa0c5 qt: Assert QMetaObject::invokeMethod result (João Barbosa) e2f7677bdeb15d1517520ddc3e95e42ca13f721a gui: Fix missing qRegisterMetaType(WalletModel*) (João Barbosa) Pull request description: ACKs for top commit: hebasto: ACK df695db3237571c662a4e199709f9c6615ffa0c5, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged. laanwj: ACK df695db3237571c662a4e199709f9c6615ffa0c5 Tree-SHA512: 5ce162e59331f6da8ae9ba41eff809881442fab93d65362b5f67aba19da76a72362f0daba9ad1f909478bf26f2daf53b110a0486d7b29b23b3716a7cd7177922
2019-07-09qt: Assert QMetaObject::invokeMethod resultJoão Barbosa
Github-Pull: #16348 Rebased-From: 64fee489448c62319e77941c30152084695b5a5d
2019-07-09gui: Fix missing qRegisterMetaType(WalletModel*)João Barbosa
Github-Pull: #16348 Rebased-From: f27bd96b5fdc2921d93c44bbf422bff0e979c4de
2019-07-07Merge #16342: 0.18 backport: report error when missing ↵fanquake
redeemScript/witnessScript 1dc357dab signrawtransactionwithkey: report error when missing redeemScript/witnessScript param (Anthony Towns) Pull request description: Backport of #16250 which fixes regression introduced in 0.18 in relation to signrawtransactionwithkey error handling (see #16249). Tree-SHA512: 0d75fa2aa578b886ace3bda92a02e25993f9f51d41db8c0eb3013bd77d266c45ad8b67dd0ed11c66533724f892be4e254edeb59fa70585ff762f522791fcca36
2019-07-05signrawtransactionwithkey: report error when missing ↵Anthony Towns
redeemScript/witnessScript param Github-Pull: #16250 Rebased-From: 01174596e69568c434198a86f54cb9ea6740e6c2
2019-07-04Merge #16035: 0.18.1: Backportsfanquake
bcb27d7b0 .python-version: Bump to 3.5.6 (MarcoFalke) af25a757e Add comments to Python ECDSA implementation (John Newbery) 715da91e9 Set AA_EnableHighDpiScaling attribute early (Hennadii Stepanov) 2800b3d5c gui: Fix open wallet menu initialization order (João Barbosa) e78007fc1 Make and get the multisig redeemscript and destination in one function instead of two (Andrew Chow) d9fc969e7 Pure python EC (Pieter Wuille) 23ba460c1 test: Add test that addmultisigaddress fails for watchonly addresses (MarcoFalke) 13b3bb564 test: Fixup creatmultisig documentation and whitespace (MarcoFalke) 79745d175 Replace remaining fprintf with tfm::format manually (MarcoFalke) beb09f09b scripted-diff: Replace fprintf with tfm::format (MarcoFalke) e29aa6e72 Exceptions should be caught by reference, not by value. (Kristaps Kaupe) f88959ba7 tinyformat: Add doc to Bitcoin Core specific strprintf (MarcoFalke) 0023c9789 rpc: bugfix: Properly use iswitness in converttopsbt (MarcoFalke) 832eb4ff5 Bugfix: test/functional/rpc_psbt: Correct test description comment (Luke Dashjr) 966d8d084 Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (Luke Dashjr) bb36ac82e rpc: Switch touched RPCs to IsValidNumArgs (MarcoFalke) d24d0ec05 Add example 2nd arg to signrawtransactionwithkey (Chris Moore) 592016ba1 fixup: Fix prunning test (João Barbosa) c80a498ae Fix RPC/pruneblockchain returned prune height (Jonas Schnelli) b2398240f gui: Enable open wallet menu on setWalletController (João Barbosa) d1f261150 Add test for GCC bug 90348 (Pieter Wuille) d80c558e0 gui: Set progressDialog to nullptr (João Barbosa) 7ed1a6019 gui: Enable console line edit on setClientModel (João Barbosa) b55cbe82d qt: fix opening bitcoin.conf via Preferences on macOS; see #15409 (shannon1916) b6c1f9478 Disallow extended encoding for non-witness transactions (take 3) (MarcoFalke) 86031083c Add test for superfluous witness record in deserialization (Gregory Sanders) 5a58ddb6d Fix missing input template by making minimal tx (Gregory Sanders) 206f5ee87 Disallow extended encoding for non-witness transactions (Pieter Wuille) 3dbc7def0 Show loaded wallets as disabled in open menu instead of nothing (MeshCollider) a635377b6 Install bitcoin-wallet manpage. (Daniel Kraft) eb85ee62b Doc: remove text about txes always relayed from -whitelist (David A. Harding) 890a92eba doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) 3460555f4 test: Add test for p2p_blocksonly (MarcoFalke) 8f215c7a2 test: Format predicate source as multiline on error (MarcoFalke) 9c1a607a0 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) 5935f0126 build with -fstack-reuse=none (MarcoFalke) Pull request description: Tree-SHA512: 5cd73a4319cb69c92b528239cf97c0ed5fcf2b9e8c7fe154e4679eeec95db433a0223d8dc574e4cdc96c1913cfdf160b10c42dcdbcb5bbc8fb743c07930ef9da
2019-06-26.python-version: Bump to 3.5.6MarcoFalke
See also: dddd1d05d3df06865f5e0b1442d7425c0955de4e
generated by cgit v1.2.3 (git 2.26.2) at 2024-09-29 03:24:59 +0000