aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-06-18Bugfix: test/functional/rpc_psbt: Correct test description commentLuke Dashjr
Github-Pull: #14818 Rebased-From: c87fc71f7e9316bcc0653cd86c50177424b5b1f9
2019-06-18Bugfix: test/functional/rpc_psbt: Remove check for specific error message ↵Luke Dashjr
that depends on uncertain assumptions When converttopsbt is called with a signed transaction, it either fails with "TX decode failed" if one or more inputs were segwit, or "Inputs must not have scriptSigs and scriptWitnesses" otherwise. Since no effort is made by the test to ensure the inputs are segwit or not, avoid checking the exact message used. The error code is still checked to ensure it is of the correct kind of failure. Github-Pull: #14818 Rebased-From: 097c4aa379f255639ce0084702693fa72a595d6b
2019-06-18rpc: Switch touched RPCs to IsValidNumArgsMarcoFalke
Github-Pull: #15899 Rebased-From: fa5c5cd141f0265a5693234690ac757b811157d8
2019-06-17Add example 2nd arg to signrawtransactionwithkeyChris Moore
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter. Github-Pull: #16210 Rebased-From: 71fd628adafdeb2a4b343e0d51d7168cdb186312
2019-06-14fixup: Fix prunning testJoão Barbosa
Github-Pull: #15991 Rebased-From: f402012ccfc596d7d94851dabbf386c278ff5335
2019-06-14Fix RPC/pruneblockchain returned prune heightJonas Schnelli
Github-Pull: #15991 Rebased-From: 97f517dd851450b1ede1eb6b20f77691883a7737
2019-06-13gui: Enable open wallet menu on setWalletControllerJoão Barbosa
Github-Pull: #16118 Rebased-From: 75485ef0962a53946f17b761c4445627b07e6eff
2019-06-07Add test for GCC bug 90348Pieter Wuille
Github-Pull: #15985 Rebased-From: 58e291cfad12fa85af87d093acfa7b44702e3521
2019-06-07gui: Set progressDialog to nullptrJoão Barbosa
Github-Pull: #16135 Rebased-From: d2ae6be80f6a0156021bf8c9b9d17cd4966ddffc
2019-06-07gui: Enable console line edit on setClientModelJoão Barbosa
Github-Pull: #16122 Rebased-From: 2d8ad2f99710a8981e33fe2d6ce834b0076c4e80
2019-06-07qt: fix opening bitcoin.conf via Preferences on macOS; see #15409shannon1916
Github-Pull: #16044 Rebased-From: 6e6494b3fb345848025494cb7a79c5bf8f35e417
2019-05-20Disallow extended encoding for non-witness transactions (take 3)MarcoFalke
Github-Pull: #16021 Rebased-From: fa2b52af32f6a4b9c22c270f36e92960c29ef364
2019-05-20Add test for superfluous witness record in deserializationGregory Sanders
Github-Pull: #15893 Rebased-From: cc556e4a30b4a32eab6722f590489d89b2875de3
2019-05-20Fix missing input template by making minimal txGregory Sanders
Github-Pull: #15893 Rebased-From: 25b078658139c1aea58393a32ac5a79144d8d140
2019-05-20Disallow extended encoding for non-witness transactionsPieter Wuille
Github-Pull: #14039 Rebased-From: bb530efa1872ec963417f61da9a95185c7a7a7d6
2019-05-18Show loaded wallets as disabled in open menu instead of nothingMeshCollider
Github-Pull: #15957 Rebased-From: c3ef63a52f304a600fff1f9c7caa5cb804d41d43
2019-05-17Install bitcoin-wallet manpage.Daniel Kraft
This change marks the already-existing bitcoin-wallet.1 manpage file for installation together with the others. Previously, only bitcoind.1, bitcoin-cli.1, bitcoin-tx.1 and bitcoin-qt.1 would be installed. Github-Pull: #15947 Rebased-From: 00d110463aed12ecdc6e9c2bf47d9ef61d19fa9d
2019-05-17Doc: remove text about txes always relayed from -whitelistDavid A. Harding
Updates text since -whitelistforcerelay was set to false by default in PR #15193. Github-Pull: #15890 Rebased-From: e0bb2799992afe88e6f4efc6d90ed82ddf1ec5ec
2019-05-16doc: Mention blocksonly in reduce-traffic.md, unhide optionMarcoFalke
Github-Pull: #15990 Rebased-From: fa8ced32a60dea37ac169241cf9a1f708ef46c4b
2019-05-16test: Add test for p2p_blocksonlyMarcoFalke
Github-Pull: #15990 Rebased-From: fa320de79faaca2b088fcbe7f76701faa9bff236
2019-05-16test: Format predicate source as multiline on errorMarcoFalke
Github-Pull: #15990 Rebased-From: fa3872e7b4540857261aed948b94b6b2bfdbc3d1
2019-05-16net: Rename ::fRelayTxes to ::g_relay_txesMarcoFalke
This helps to distinguish it from CNode::fRelayTxes and avoid bugs like 425278d17bd0edf8a3a7cc81e55016f7fd8e7726 Github-Pull: #15990 Rebased-From: fa1dce7329d3e74d46ab98b93772b1832a3f1819
2019-05-16build with -fstack-reuse=noneMarcoFalke
Github-Pull: #15983 Rebased-From: faf38bc056e523485520f98f3f725c583a3b89bf
2019-05-02doc: Clean out release notes post-0.18.0Wladimir J. van der Laan
Tree-SHA512: c1076f844d7b083e1637aeed51b05a638b8d8068a58cf1f24be9af811c071d11d71552d1b1ebfc7ba14a53aa2534288d12039c1a00270a316d528244144a74ad
2019-04-30build: Bump version to -finalv0.18.0Wladimir J. van der Laan
Tree-SHA512: 94e3c6149ba6a8c49ffc64f3f0a642950ebfc722fdd6c6a30c21b989f49f8c8be827212e65a0f367332bd38a56fe4b248ccf2147f019aed06224f7975a21fff6
2019-04-26Merge #15852: doc: 0.18: Remove TODO from release notesMarcoFalke
fad9eb1014 doc: 0.18: Remove TODO from release notes (MarcoFalke) Pull request description: Also, remove section that no longer applies after #15839 ACKs for commit fad9eb: Tree-SHA512: 259cbaa313cd6cce0f83a577527612314b484e77c7001fe56a21553dc0e446d9aa2bdf1129e546f9c4c142fa3cf4479d72d4561ee553a8a6e9d5453061813a3c
2019-04-19doc: 0.18: Remove TODO from release notesMarcoFalke
2019-04-18build: Bump version to rc4v0.18.0rc4Wladimir J. van der Laan
Tree-SHA512: 5a4b6c0f38402c289ecb0abb59d45ef87a9dfb0bc135baf0512bc4e566c92fb28da519da3aec006594c8ecde38eb8ab4997f899bcd2301f506c4d5633e84391a
2019-04-18doc: Move release notes from wikiWladimir J. van der Laan
Tree-SHA512: 59b8d913d56081ac73f3777ae4017b2f416da531e8c47ab854ff277f714f58e238215e89caa7c5973899dc3114cb5bdbaf7f7ca26a22a4062d6029d30d3c1156
2019-04-18gui: Pre-rc4 translations updateWladimir J. van der Laan
Tree-SHA512: f3a7c9e0c935c869a85e3bc93a4bd33999270ffc13d35de34c46e9dab19229af19fb9c1a61a99264e8411c0966bf8b02a5ee94bf20a07f66b92234473f0e0801
2019-04-18Merge #15839: [0.18] Revert GetData randomization change (#14897)MarcoFalke
8602d8b213 Revert "Change in transaction pull scheduling to prevent InvBlock-related attacks" (Suhas Daftuar) Pull request description: This is for 0.18, not master -- I propose we revert the getdata change for the 0.18 release, rather than try to continue patching it up. It seems like we've turned up several additional bugs that slipped through initial review (see #15776, #15834), and given the potential severe consequences of these bugs I think it'd make more sense for us to delay releasing this code until 0.19. Since the bugfix PRs are getting review, I think we can leave #14897 in master, but we can separately discuss if it should be reverted in master as well if anyone thinks that would be more appropriate. ACKs for commit 8602d8: Tree-SHA512: 0389cefc1bc74ac47f87866cf3a4dcfe202740a1baa3db074137e0aa5859672d74a50a34ccdb7cf43b3a3c99ce91e4ba1fb512d04d1d383d4cc184a8ada5543f
2019-04-18GUI: Options: Remove the upper-bound limit from pruning size settingLuke Dashjr
Hypothetically, someone may wish to begin pruning at a future blockchain size, and there's no reason to limit it lower Github-Pull: #15801 Rebased-From: 8a33f4d63f9944f4877b3e2814b1582e72ceaa71 Tree-SHA512: 814dc5f004c3418216a12f8e0ef1a8db2c586d98b515d48b31a8ccd7f4e0deb12b9f2b6110bf702576a32802ca1d30e518df5ad7c28046deb4d0e9be46a6e7b8
2019-04-18GUI: Options: Set the range of pruning size before loading its valueLuke Dashjr
Without this, an out-of-default-range value gets limited to the range Github-Pull: #15801 Rebased-From: 4ddeb2f860eee98fbe94725ea8885368068a03f2 Tree-SHA512: 64c18c8be6756fc0130d3fe934edb1ea7758877d4049c5729fa2adb05abb3af4e4bbe1d5f910224e16070aada5470637a35ed14b12391efd48cf035e8a22a949
2019-04-18Merge #15818: [0.18] doc backportsWladimir J. van der Laan
a644780a2f7076d4705d4e0d3486c0df8424367d doc: Clarify RPC versioning (MarcoFalke) 194226f6798e59cfd871db0335e078101b165043 doc: describe onlynet option in doc/tor.md (Jon Atack) 6d2448ca8e8bbf326730e79a7e1d959b4e81a76e doc/dependencies: Fix typo libsrvg->librsvg (Luke Dashjr) 9c572e3b2160f3a2b78847bbdc839b7be35dffd7 doc: mention creating application support bitcoin folder on OSX (Jack Mallers) c69138a0d6b4878dfb01030861753738179ef0a4 gitignore: add *.plist (clang-check) (James O'Beirne) 8f7cfb00964a9edfa6fc46c506dad4b9c24661bf gitignore: add *.dat (James O'Beirne) Pull request description: Backports #15684, #15792, #15802, #15809 to the `0.18` branch. ACKs for commit a64478: Tree-SHA512: 6ed524a7b94242f8a738710d4321b98b9e80d6625d384fd83280b38fcb6bb8c468bcec1d980789ad2f4c91a5629ffe5c5314a7353181f08884c5a081840431cc
2019-04-17Revert "Change in transaction pull scheduling to prevent InvBlock-related ↵Suhas Daftuar
attacks" This reverts commit 1cff3d6cb017aea87d16cbda0768bbab256d16da.
2019-04-16Merge #15803: [0.18] Backport 15749: importmulti only imports origin info ↵MarcoFalke
for PKH outputs 235550d019 Take non-importing keys into account for spendability warning in descriptor import (Pieter Wuille) 802dcd37d1 Import all origin info in importmulti; even for non-importing pubkeys (Pieter Wuille) 7fcbe7dc11 Keep full pubkeys in FlatSigningProvider::origins (Pieter Wuille) Pull request description: Clean backport of #15749 by sipa to 0.18 ACKs for commit 235550: fanquake: utACK 235550d MarcoFalke: ACK 235550d019 (Checked that they are clean cherry-picks) Tree-SHA512: 1ccc19f51137ac4ef971c0bcca4c87ab2383610aa51c5d02680c485b9ce6abd698dddd7f4a45946d56b1aa741cc3fd94b4180ff15901824d20eeba89b4f12853
2019-04-16Take non-importing keys into account for spendability warning in descriptor ↵Pieter Wuille
import Github-Pull: #15749 Rebased-From: b5d39877242504160a7f2c24c60c07a845d7a064
2019-04-16Import all origin info in importmulti; even for non-importing pubkeysPieter Wuille
Github-Pull: #15749 Rebased-From: 6e597001a4fc1ba837f3f23cfd7f2d65c3d58104
2019-04-16Keep full pubkeys in FlatSigningProvider::originsPieter Wuille
Github-Pull: #15749 Rebased-From: 9a93c91c882265c908ea18496cd1bc271be914d4
2019-04-16doc: Clarify RPC versioningMarcoFalke
Github-Pull: #15799 Rebased-From: fa747498f79c9f6bf29b08f5f3cc01b276126abb
2019-04-16doc: describe onlynet option in doc/tor.mdJon Atack
as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102. Description adapted from https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L429. Also fixes a typo in doc/dependencies.md. Github-Pull: #15792 Rebased-From: 140bbeec45f14fd50cce68448bc7fa655cbef951
2019-04-16doc/dependencies: Fix typo libsrvg->librsvgLuke Dashjr
Github-Pull: #15684 Rebased-From: 7d01b5cf2ca67535374d444725fdff699b891683
2019-04-16doc: mention creating application support bitcoin folder on OSXJack Mallers
Github-Pull: #15802 Rebased-From: 8dfbb5cf236cb70a2a1e65b076ccb7e2901833bd
2019-04-16gitignore: add *.plist (clang-check)James O'Beirne
Github-Pull: #15809 Rebased-From: 17be9e0e3037b60ba7bbf4b9249f2efc5e1ba9b3
2019-04-16gitignore: add *.datJames O'Beirne
Github-Pull: #15809 Rebased-From: e7acf44bbfd05233f7753b3c8230892196facde8
2019-04-15Merge #15800: Backport: [rpc] Remove the addresses field from the ↵MarcoFalke
getaddressinfo return object b3a04c963d [rpc] Remove the addresses field from the getaddressinfo return object (John Newbery) Pull request description: Backport #15750 ACKs for commit b3a04c: MarcoFalke: ACK b3a04c963d4e761b66a1a8c1aae1c835534e47eb (checked cherry-pick) Tree-SHA512: d6e586fb6e22b9825267d6c45dd3090b7f8dc1a06804ca238103d1c665b178f8c2b3004f67aae67ea51c2c3df97561894f3f2e85d45400c760c3b7f057ff4bb8
2019-04-15[rpc] Remove the addresses field from the getaddressinfo return objectJohn Newbery
The "addresses" field was confusing because it refered to public keys using their P2PKH address. It was included in the return object when needed for backward compatibility. Remove that compatibility now that the -deprecatedrpc=validateaddress option has been removed. New applications should use the 'embedded'->'address' field for P2SH or P2WSH wrapped addresses, and 'pubkeys' for inspecting multisig participants. Github-Pull: 15750 Rebased-From: b4338c151d4788c33f4b7c54daaf7f94b193a624
2019-04-15Merge #15790: [0.18] backport #15754Wladimir J. van der Laan
60d46219754692355aef719681a7d80ec38035bc rpc: getrpcinfo docs (Ben Carman) Pull request description: Backports #15754 to the 0.18 branch #15754 added the help message for `getrpcinfo` ACKs for commit 60d462: promag: utACK 60d4621. fanquake: utACK 60d4621 Tree-SHA512: 3c0f0aded2dbd300b1cb5e3a3abb1d84852a165aa6ebb337833f06ba135730192a6e86b58323e4c5eb3a7636268125bea7be05925b5b316220bfa5ac1de4a5f4
2019-04-11rpc: getrpcinfo docsBen Carman
Github-Pull: #15754 Rebased-From: f4b7a2f2055fa52d5e02c37bed7b46599b960e2e
2019-04-09Merge #15775: [0.18] Doc BackportsMarcoFalke
bf32bc4b3d Mention new descriptor RPCs in descriptors.md (Pieter Wuille) 1b0752a265 Mention new PSBT RPCs in psbt.md (Pieter Wuille) 956c0aac28 doc: correct bitcoinconsensus_version in shared-libraries (fanquake) 538fef6625 Update bips.md for 0.18.0 (Pieter Wuille) Pull request description: Can be bumped to 0.18.1 if `rc3` ends up being final. ACKs for commit bf32bc: MarcoFalke: ACK bf32bc4b3de51d073d9308bdce8db0e0fb083727 Tree-SHA512: 60ad8f0ca53b9fbf6f2a4941bd10971cfece192032d1feff3b25e1b8572caf72cd63c5b8507c376a8bdfb57da6551ac9c2c32dc1f8dc2658a3ea4abf75b0fd9a