aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-06-21Merge bitcoin-core/gui#612: refactor: Drop unused `QFrame`s in `SendCoinsEntry`Hennadii Stepanov
7ab72b9d2a500420a1103221c3cbfac4cda1c43a qt: Fix `BitcoinAmountField`'s base widget (Hennadii Stepanov) 32625421047951b9c9fad195be3aa40d6075d469 qt, refactor: Fix `sendcoinsentry.ui` indentation (Hennadii Stepanov) f3c76033295b8007c61eab7fcb23cf119d72b8b8 qt, refactor: Convert `SendCoinsEntry` to a sub-`QWidget` (Hennadii Stepanov) 6420fb2005db1490d77c6df45d0b97d7389ff609 qt, refactor: Drop unused `QFrame`s in `SendCoinsEntry` (Hennadii Stepanov) Pull request description: The `SendCoins_UnauthenticatedPaymentRequest` and `SendCoins_AuthenticatedPaymentRequest` sub-`QFrame`'s of the `SendCoinsEntry` widget have been unused since bitcoin/bitcoin#17165. Removed all dead code. The resulted `SendCoinsEntry` widget has been simplified. ACKs for top commit: w0xlt: Tested ACK https://github.com/bitcoin-core/gui/pull/612/commits/7ab72b9d2a500420a1103221c3cbfac4cda1c43a shaavan: reACK 7ab72b9d2a500420a1103221c3cbfac4cda1c43a Tree-SHA512: a46db90d60fae584b52cc7edae910c295351cb3627e04d225708c50c04f7fdd81d2755e055115612a12a3c841e78c31bdcd57bed9feb1d3909f7a2f6e76bd356
2022-06-21test: Remove from_node from create_self_transfer* MiniWallet helpersMacroFake
The from_node argument is no longer used as of commit a55606c3bdbfdf660b093bc2a618d537ffae7f26
2022-06-21Merge bitcoin/bitcoin#25430: test: refactor: save MiniWallet mode explicitlyMacroFake
be8d0dba15528ac75a2c73d9f696b1db567d4ca4 test: refactor: save MiniWallet mode explicitly (Sebastian Falbesoner) Pull request description: Rather than abusing the member variables `self._priv_key` and `self._address` to determine the MiniWallet mode, save it explicitly (`self._mode`) in the constructor and use that instead to increase the readability and maintainability of the code. ACKs for top commit: MarcoFalke: review ACK be8d0dba15528ac75a2c73d9f696b1db567d4ca4 🔳 Tree-SHA512: 882c635e39c89911d995917a0603395158ee86dc46b26a49815756db67c61a7aa35059eddf1dc6f2933a77169941426b98bd463e60e39515a596b1b69edf89df
2022-06-21test: refactor: save MiniWallet mode explicitlySebastian Falbesoner
Rather than abusing the member variables self._priv_key and self._address to determine the MiniWallet mode, save it explicitly instead in the constructor to increase the readability and maintainability of the code.
2022-06-21guix: remove explicit glibc stack protector disablingfanquake
While glibc 2.25 and newer *can* be built with stack-smashing-protection enabled, it isn't used by default, and still isn't, as of glibc 2.35, so I can't see a reason to explicitly disable it. I'd also like to move in the direction of enabling, by default, hardening options for the toolchains we build, so removing the explicit disabling is a step in that direction. Will be following up with some changes based on this PR.
2022-06-21Merge bitcoin/bitcoin#25425: build: Fix `::_wsystem` checklaanwj
b5f6a4650334d58245b45eace57f2bc23467ffc7 build: Fix `::_wsystem` check (Hennadii Stepanov) Pull request description: The `::_wsystem` check has been introduced in bitcoin/bitcoin#15457, and it is broken. An excerpt from `config.log` for `./autogen.sh && ./configure CONFIG_SITE=$PWD/depends/x86_64-w64-mingw32/share/config.site` on master (a09033e22c4f072c86a1885dd476f3059e5416d1): ``` configure:29111: checking for ::_wsystem configure:29125: x86_64-w64-mingw32-g++-posix -std=c++17 -o conftest.exe -pipe -std=c++17 -O2 -I/home/hebasto/git/bitcoin/depends/x86_64-w64-mingw32/include/ -L/home/hebasto/git/bitcoin/depends/x86_64-w64-mingw32/lib conftest.cpp -lssp -liphlpapi -lshlwapi -lws2_32 -ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32 >&5 conftest.cpp: In function 'int main()': conftest.cpp:81:15: error: '::_wsystem' has not been declared 81 | int nErr = ::_wsystem(""); | ^~~~~~~~ configure:29125: $? = 1 configure: failed program was: | /* confdefs.h */ | #define PACKAGE_NAME "Bitcoin Core" | #define PACKAGE_TARNAME "bitcoin" | #define PACKAGE_VERSION "23.99.0" | #define PACKAGE_STRING "Bitcoin Core 23.99.0" | #define PACKAGE_BUGREPORT "https://github.com/bitcoin/bitcoin/issues" | #define PACKAGE_URL "https://bitcoincore.org/" | #define HAVE_CXX17 1 | #define HAVE_STDIO_H 1 | #define HAVE_STDLIB_H 1 | #define HAVE_STRING_H 1 | #define HAVE_INTTYPES_H 1 | #define HAVE_STDINT_H 1 | #define HAVE_STRINGS_H 1 | #define HAVE_SYS_STAT_H 1 | #define HAVE_SYS_TYPES_H 1 | #define HAVE_UNISTD_H 1 | #define STDC_HEADERS 1 | #define LT_OBJDIR ".libs/" | #define USE_ASM 1 | #define HAVE_CLMUL 1 | #define ENABLE_SSE41 1 | #define ENABLE_AVX2 1 | #define ENABLE_X86_SHANI 1 | #define HAVE_LIBKERNEL32 1 | #define HAVE_LIBUSER32 1 | #define HAVE_LIBGDI32 1 | #define HAVE_LIBCOMDLG32 1 | #define HAVE_LIBWINMM 1 | #define HAVE_LIBSHELL32 1 | #define HAVE_LIBCOMCTL32 1 | #define HAVE_LIBOLE32 1 | #define HAVE_LIBOLEAUT32 1 | #define HAVE_LIBUUID 1 | #define HAVE_LIBADVAPI32 1 | #define HAVE_LIBWS2_32 1 | #define HAVE_LIBSHLWAPI 1 | #define HAVE_LIBIPHLPAPI 1 | #define HAVE_PTHREAD_PRIO_INHERIT 1 | #define HAVE_PTHREAD 1 | #define _FILE_OFFSET_BITS 64 | #define HAVE_DECL_STRERROR_R 0 | #define HAVE_LIBSSP 1 | #define HAVE_STDIO_H 1 | #define HAVE_STDLIB_H 1 | #define HAVE_UNISTD_H 1 | #define HAVE_STRINGS_H 1 | #define HAVE_SYS_TYPES_H 1 | #define HAVE_SYS_STAT_H 1 | #define HAVE_DECL_GETIFADDRS 0 | #define HAVE_DECL_FREEIFADDRS 0 | #define HAVE_DECL_FORK 0 | #define HAVE_DECL_SETSID 0 | #define HAVE_DECL_PIPE2 0 | #define HAVE_DECL_LE16TOH 0 | #define HAVE_DECL_LE32TOH 0 | #define HAVE_DECL_LE64TOH 0 | #define HAVE_DECL_HTOLE16 0 | #define HAVE_DECL_HTOLE32 0 | #define HAVE_DECL_HTOLE64 0 | #define HAVE_DECL_BE16TOH 0 | #define HAVE_DECL_BE32TOH 0 | #define HAVE_DECL_BE64TOH 0 | #define HAVE_DECL_HTOBE16 0 | #define HAVE_DECL_HTOBE32 0 | #define HAVE_DECL_HTOBE64 0 | #define HAVE_DECL_BSWAP_16 0 | #define HAVE_DECL_BSWAP_32 0 | #define HAVE_DECL_BSWAP_64 0 | #define HAVE_BUILTIN_CLZL 1 | #define HAVE_BUILTIN_CLZLL 1 | #define HAVE_DEFAULT_VISIBILITY_ATTRIBUTE 1 | #define HAVE_DLLEXPORT_ATTRIBUTE 1 | #define HAVE_FDATASYNC 0 | #define HAVE_O_CLOEXEC 0 | /* end confdefs.h. */ | | int | main (void) | { | int nErr = ::_wsystem(""); | | ; | return 0; | } configure:29130: result: no ``` See https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/system-wsystem ACKs for top commit: laanwj: Code review ACK b5f6a4650334d58245b45eace57f2bc23467ffc7 Tree-SHA512: 30cadb7e2e2e3885955ba72c2c27c5dfef2f1b0a9e02e7e811d9bd7cb2c380bab77ca9df3a476d83105de3fa01d043f995e3680b7bff5e7c33829d281b67f374
2022-06-21Merge bitcoin-core/gui#615: If -prune=0 is set, Uncheck Prune on Intro pageHennadii Stepanov
40566e21c02ddec6458cd83fa76fea081c5469dc If -prune=0 is set, Uncheck Prune on Intro page (Jadi) Pull request description: If the bitcoin-qt is started with -prune=0 arg, On the Intro page, the Prune Checkbox will be unchecked too, to prevent confusions. refs: https://github.com/bitcoin/bitcoin/issues/25052 ACKs for top commit: hebasto: re-ACK 40566e21c02ddec6458cd83fa76fea081c5469dc Tree-SHA512: d5e0b76a7d20ae806e61a416fd907650f15a744a5823d0f8b57a634cb099bb135199e69a787bd54ecde2cf84e95633f40ff407a722350f337b27de395a6e0f78
2022-06-20Merge bitcoin/bitcoin#25378: build: use sqlite 3380500 in dependslaanwj
9d6a7b2fb1e0d1f788a3c7f464b3d8fc18769312 build: sqlite 3380500 in depends (fanquake) Pull request description: Move to using [sqlite 3380500](https://www.sqlite.org/releaselog/3_38_5.html) in depends. Other than bug fixes and improvements compared to our current version (3320100), the newer version contains changes that deal with warnings produced with newer versions of GCC (11.2.0), which are also more likely to appear when building with LTO: ```bash ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c: In function 'sqlite3SelectNew': ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c:129016: warning: function may return address of local variable [-Wreturn-local-addr] ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c:128976: note: declared here In function 'memcpy', inlined from 'sqlite3Fts5IndexQuery' at ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c:220862:18: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: warning: '__builtin_memcpy' specified bound 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=] 29 | return __builtin___memcpy_chk (__dest, __src, __len, | ^ ``` Relevant upstream discussions: https://sqlite.org/forum/forumpost/845dd0be91a54ec8 https://sqlite.org/forum/forumpost/f5eed70bd46ede56 Guix Build (x86_64): ```bash 5a2bb2a0c09ade10bc78af0eae910e842402598c28cd82dfe67fa7f0bdc7c7d0 guix-build-9d6a7b2fb1e0/output/aarch64-linux-gnu/SHA256SUMS.part e7e82c3ab4654c33389ffda83647723179f548b6d0372204914a94df1479f29c guix-build-9d6a7b2fb1e0/output/aarch64-linux-gnu/bitcoin-9d6a7b2fb1e0-aarch64-linux-gnu-debug.tar.gz 3574852251d08749193a05161a048ae7933aee8910da230a3c32fa874d4df027 guix-build-9d6a7b2fb1e0/output/aarch64-linux-gnu/bitcoin-9d6a7b2fb1e0-aarch64-linux-gnu.tar.gz a9d87e7197998051ff4d76253c5c8d86e859c3907d1f29023a62d40b5ca8f82f guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/SHA256SUMS.part a0813408afb86f505f1ffd6f9361881c08b35b1a7cd869da7e1dad9f042a63ae guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf-debug.tar.gz e3d13d137c3bde9a25bf585ecdfe9001bc10b8c82b206d8fbf4977f3ab5da374 guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf.tar.gz a84a8f5c152048e1a3287afe42f4909d2ea9a271b2474d7406a83482fb1de3c7 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/SHA256SUMS.part 4241ed6de223e899995d4df3ba8566e472e08a125cd1ecd5e1fdab5bc88bb6fd guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.dmg 75e5096ccab23b546393a368d9beb9b2b0867bb0d0c84604ff2a131f4afb24fa guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.tar.gz ec453221fbd951b0fddfad283a310a550aa15b55aefe6ba6a0f290cfff1d2cb2 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin.tar.gz e01c2894eec3827c98241f5cf9c779b07cb4dee8e9e043a6840c8fcf6a91a23c guix-build-9d6a7b2fb1e0/output/dist-archive/bitcoin-9d6a7b2fb1e0.tar.gz c926dcf8c351548c845e4c6c047a851cb99a72b028005c6c6b0e3e4f1d7384f7 guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/SHA256SUMS.part a6dea61ce6397ba4d5b3c35fae2c7b729cee23e07b71b5de6737663dd144d234 guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu-debug.tar.gz 77d6271322db5bb5ea25f20c5df5fc5a0150cfd1570a8e1a5d0c111702eca77c guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu.tar.gz 57793bf2ea341012806d6dafb49659b40496eaeee3fe1da580e7c7aed07572ba guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/SHA256SUMS.part 6a37d39313150ad90101b1e29ac7a7a32f3001cb9395326484b117c5538b27a3 guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu-debug.tar.gz 985ceb6eeba7590bef83755b73f1efdef922d50c5ebee7e0c521b27388874482 guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu.tar.gz 21a30c6f53d4544376ebc5f9fa3326edb305bf1dd55079512b7eaf16c408fcfc guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/SHA256SUMS.part c80d159154a4785dcaf42f77175aad38dd9498e8e0128f2c6277b4a2668f8aae guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu-debug.tar.gz d2ed0cde0f6e0245662e8f335091dbe0ed57dcb661ff1d5eac94f5af7cde4daf guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu.tar.gz d054f0bf16e69ad7b557faed4b5c349bdfba3ff554a2d3636ad913ac307dc2e9 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/SHA256SUMS.part a7279c357838b0aa1d3548b45be8568d759b141828e3b7d2ab2d2de9a95b7a8c guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.dmg efe4d4d9e4d7e966e19dcc819456169d02891087fa7e767c305afd297e981af2 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.tar.gz e1b72c3904a6cb3ba0c9eb156288ab216a94be5da2b10288d414d224ffa525b1 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin.tar.gz 80e5b6ffce2bf33bc024ee1decd0d024fe2f23211dbe73cf1ade89abcf5910d9 guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/SHA256SUMS.part 9903f76bfce98415c6d6d1cc2057683b4fad9d02f4da0c2afe37b108a4d8d496 guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu-debug.tar.gz 9a05903423afef05222e13646c3b249c747b8cb9d487eceb1a120ca018b02dea guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu.tar.gz bbb8e284b9dced4db64c6fbb7ac53ddcc622b9c367300b280beaae2e288140b9 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/SHA256SUMS.part b7064f1abbf8653e5c045c84244db112cef48043610a30fc878ba644e01b41ae guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-debug.zip be1a9b270d834d59a731adebed1d4f2424fb6a1bb082808fadb5cf3b930a31a1 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-setup-unsigned.exe b893e54fb43b5c256d46e4a58d65a8d3fc111eb65417cb56810f793b1813ca86 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-unsigned.tar.gz 603eb61bcf37ad0939cc588c79c544be545d443043bc194094d203eaab7981d2 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64.zip ``` Guix Build (arm64): ```bash e4bd8215fb9ff88c58b7d1b2d13f90110585e3a7de7be20a962b4b00b5817012 guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/SHA256SUMS.part e03b9d5201b68087c267875a570e675a838753cc4062105bc3820b594dfbddc1 guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf-debug.tar.gz 7bb1d6c34910fcd8036adcf1c92ddff330242ad92ecd489864b7a44386e6afec guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf.tar.gz 2e8dd34a1ff1ee041a7c2eb423ee84bdf00be28d71b2ffeb20752f10d10b856b guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/SHA256SUMS.part b448114fdb7be57070d7bc563cfc8a3ef7b6658689598e8c1091c359f62a2445 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.dmg ea9d06d6208d3279c11eb2845fc6c1cbee4293ca0169e1ac3a6cec737f022230 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.tar.gz 0a267860eb0414ac2a213b9c6accd24cc73da3474d535c85ec7d542aa08fda30 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin.tar.gz e01c2894eec3827c98241f5cf9c779b07cb4dee8e9e043a6840c8fcf6a91a23c guix-build-9d6a7b2fb1e0/output/dist-archive/bitcoin-9d6a7b2fb1e0.tar.gz 8b3a0634a29579352a50b596ff79b58442d53951e6fe7ca291362d697d8bff26 guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/SHA256SUMS.part 2acc3541cf7d09eb0302605b8131aae4561918969bee2a397ef550412afecd86 guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu-debug.tar.gz eec1781a5daf7e98213299c6aac37d111528f03bd5fa595371e4984491137e0b guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu.tar.gz b8d4b83f8194d77bbc09e1cbda9406365655865959bcb200eca76d5db630a0e3 guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/SHA256SUMS.part 05502d75b749465cc2deedcafdb34a910a14c75d3c0b25964899ef102dec8da3 guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu-debug.tar.gz 7c66573cc96f62a75549a5333d2b5c27fde78691f3fe8d863bb676a0a1052a0b guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu.tar.gz fac4613cf7d47f2f22a45c0030c480802dae805f46f59a596a98f4fd709209fd guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/SHA256SUMS.part df3d1045cb10d815f5b3bba5246c3349654346a156982c767e2c3b076598185b guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu-debug.tar.gz 64ec31b702d3c6c25615618be64de631c70f69383e150f27493139933591f024 guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu.tar.gz d054f0bf16e69ad7b557faed4b5c349bdfba3ff554a2d3636ad913ac307dc2e9 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/SHA256SUMS.part a7279c357838b0aa1d3548b45be8568d759b141828e3b7d2ab2d2de9a95b7a8c guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.dmg efe4d4d9e4d7e966e19dcc819456169d02891087fa7e767c305afd297e981af2 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.tar.gz e1b72c3904a6cb3ba0c9eb156288ab216a94be5da2b10288d414d224ffa525b1 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin.tar.gz 05fa5c84dce57bb1728a8ac36a967177f25d9f8892b272da0483e4b8f4ea2b94 guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/SHA256SUMS.part 40cb0712447dc4e1f0574fcd307012206ce64c32aa12a240666070a18cf6af51 guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu-debug.tar.gz 7f6b0696f28348584eb62d69ab936f864310dd42a7e4cba7abe087e563b3b77f guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu.tar.gz d79bab5b5d4414d23cf26eaddb3c5eabc88e0700e9fd62686e5b44735c62453b guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/SHA256SUMS.part 55029375d671803013ba49c8f287101c49f62033569240efe9f089907dc47a58 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-debug.zip be1a9b270d834d59a731adebed1d4f2424fb6a1bb082808fadb5cf3b930a31a1 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-setup-unsigned.exe b893e54fb43b5c256d46e4a58d65a8d3fc111eb65417cb56810f793b1813ca86 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-unsigned.tar.gz 9626a24a47af1a1d5240a50c3d7fd74053657bc87a5dff32007b200f48e5573d guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64.zip ``` ACKs for top commit: hebasto: ACK 9d6a7b2fb1e0d1f788a3c7f464b3d8fc18769312. Confirming that `-Wreturn-local-addr` and `-Wstringop-overflow=` warnings are gone. Verified the hash of the new source archive. Tree-SHA512: 28783479623be0ccc8169ff63e169a61f850106e820f12917b867b07087d2817fe0d5432a5e1ddf564ed90ba371aaf801dd4e7b32acb3907736dc4dcdd129355
2022-06-20Merge bitcoin/bitcoin#25424: build, qt: Fix `QMAKE_CXXFLAGS` expression for ↵laanwj
`mingw32` host 71d33bf33f8837f80d623c8c05342388e414c46d build, qt: Fix `QMAKE_CXXFLAGS` expression for `mingw32` host (Hennadii Stepanov) Pull request description: A "copy-paste typo" was introduced in bitcoin/bitcoin#21593. I'm sorry about that. ACKs for top commit: laanwj: Code review ACK 71d33bf33f8837f80d623c8c05342388e414c46d Tree-SHA512: 9433d9e51d7772d4ac1579aab75d184bb486e575ec216933b1a5171b0b68718943c96bd3669fe239b1d1ed17ec82bc5d14e777d4ff8b6fae370352864da88534
2022-06-20Merge bitcoin/bitcoin#25118: wallet: unify “allow/block other inputs“ ↵laanwj
concept d33871288636d9e4cdde2e1430de1f4223e2dd3f scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs (furszy) 8dea74a8ff8f5d3fdf6602c0eaa0fcc5877fc569 refactor: use GetWalletTx in SelectCoins instead of access mapWallet (furszy) b4e2d4d4eea5f53aeb3124f966157222ea91106b wallet: move "use-only coinControl inputs" below the selected inputs lookup (furszy) 25749f1df77c78eb146978ca0485cf9f91b5ce49 wallet: unify “allow/block other inputs“ concept (furszy) Pull request description: Seeking to make the `CoinControl` options less confusing/redundant. It should have no functional changes. The too long to read technical description; remove `m_add_inputs`, we can use the already existent `fAllowOtherInputs` flag. In #16377 the `CoinControl` flag ‘m_add_inputs’ was added to tell the coin filtering and selection process two things: - Coin Filtering: Only use the provided inputs. Skip the Rest. - Coin Selection: Search the wtxs-outputs and append all the `CoinControl` internal and external selected outpoints to the selection result (skipping all the available output checks). Nothing else. Meanwhile, in `CoinControl` we already have a flag ‘fAllowOtherInputs’ which is already saying: - Coin Filtering: Only use the provided inputs. Skip the Rest. - Coin Selection: If false, no selection process -> append all the `CoinControl` selected outpoints to the selection result (while they passed all the `AvailableCoins` checks and are available in the 'vCoins' vector). ### Changes As can notice, the first point in the coin filtering process is duplicated in the two option flags. And the second one, is slightly different merely because it takes into account whether the coin is on the `AvailableCoins` vector or not. So it makes sense to merge ‘m_add_inputs’ and ‘fAllowOtherInputs’ into a single field for the coin filtering process while introduce other changes to add the missing/skipped internal and external coins into 'vCoins' vector if they were manually selected by the user. —————————————————————————————————— Just as an extra note: On top of this, I’m working on unifying/untangling further the coin filtering and selection processes so we have less duplicate functionality in both processes. ACKs for top commit: laanwj: Code review ACK d33871288636d9e4cdde2e1430de1f4223e2dd3f Tree-SHA512: 98920b80dd787cfe737dacd4c59575dfa8393c799b55f2aaef9aed2b15c61470715a88663557b49c7400938220f99af7690be01980a8684f4f71947407f21750
2022-06-20Merge bitcoin/bitcoin#25388: refactor: move policy constants to policylaanwj
0d8e68d7054466925ecd165a871fc0e3f53cdafa refactor: move DEFAULT_*_LIMIT assertions from validation to policy (fanquake) 9c94f3b3a71b6d1c30471cf6a2a4fbadcc351a3f refactor: move EXTRA_DESCENDANT_TX_SIZE_LIMIT to policy/policy.h (fanquake) 39c60362536a868712f5b4c3ba8d04ef811e9e40 refactor: use braced initialization in policy/policy.h (fanquake) 01ccfbe3aaf96be4304640dd0df04d576b50a725 scripted-diff: use static constexpr in policy/policy.h (fanquake) 62d56bb714e98c54051f8564991b2748efa1737c refactor: Move DEFAULT_DESCENDANT_SIZE_LIMIT to policy/policy.h (fanquake) a34aa4c187d854b410f04df639b19f4ef8e92078 refactor: Move DEFAULT_DESCENDANT_LIMIT to policy/policy.h (fanquake) 05fc5fdc134cdf466b8cce757088b9a550bf0c30 refactor: Move DEFAULT_ANCESTOR_SIZE_LIMIT to policy/policy.h (fanquake) da8d304960d0e1368e5a08a4107537cab6bea52f refactor: Move DEFAULT_ANCESTOR_LIMIT to policy/policy.h (CAnon) Pull request description: Picks up #25295. Which was a follow up to [a comment in #25254](https://github.com/bitcoin/bitcoin/pull/25254#discussion_r890595318). Moves policy constants from validation.h to policy.h. ACKs for top commit: laanwj: Code review ACK 0d8e68d7054466925ecd165a871fc0e3f53cdafa w0xlt: reACK https://github.com/bitcoin/bitcoin/pull/25388/commits/0d8e68d7054466925ecd165a871fc0e3f53cdafa darosior: ACK 0d8e68d7054466925ecd165a871fc0e3f53cdafa Tree-SHA512: 79900b09dc3a8020b5053ec734f462cb6e8184ed2b76e9d8afae7fe5331bbc906daaa42c0f622782797d971aaf5698aa0155511ec1d15582cc7675c271664a8d
2022-06-20wallet: avoid extra wtx lookup in AddToSpendsfurszy
This method is only called from AddToWallet and LoadToWallet, places where we already have the wtx.
2022-06-20net: remove CloseSocket()Vasil Dimov
Do the closing in `Sock::Reset()` and remove the standalone `CloseSocket()`. This reduces the exposure of low-level sockets (i.e. integer file descriptors) outside of the `Sock` class.
2022-06-20net: remove now unused Sock::Release()Vasil Dimov
2022-06-20net: change GetBindAddress() to take Sock argumentVasil Dimov
This avoids the direct call to `getsockname()` and allows mocking.
2022-06-20net: add new method Sock::GetSockName() that wraps getsockname()Vasil Dimov
This will help to increase `Sock` usage and make more code mockable.
2022-06-20build: Fix `::_wsystem` checkHennadii Stepanov
See https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/system-wsystem
2022-06-20build, qt: Fix `QMAKE_CXXFLAGS` expression for `mingw32` hostHennadii Stepanov
2022-06-20build: globally define NOMINMAXfanquake
Define (and document) `NOMINMAX` once, rather than across multiple source files. Defining this prevents the definition of min/max macros when using mingw-w64, which may conflict with unprefixed std::min/max usage. While that might not be the case for us, we'd always prefer to use the standard library in any case. For example: https://github.com/mingw-w64/mingw-w64/blob/73cadc06c62c6af5faf76f64ef08e684b48de48c/mingw-w64-headers/include/ntdef.h#L289-L300
2022-06-20Merge bitcoin/bitcoin#25409: doc: fix typosMacroFake
20c58a3e506d768970bb1a588fd8db8ae1a5ffbb doc: typo fix (Marnix) Pull request description: `contrib/devtools/test-symbol-check.py`: envinonment -> environment `contrib/seeds/asmap.py`: succesful -> successful ACKs for top commit: brunoerg: ACK 20c58a3e506d768970bb1a588fd8db8ae1a5ffbb Tree-SHA512: acbe060b7c27673208715c4f6d0fac913c61c94a5e7e37b0ab9865d099067568dc683bd0099e5dc46e3602b13b5dae512ec713bd65f56fa10a59d946d5fd2649
2022-06-20refactor: move DEFAULT_*_LIMIT assertions from validation to policyfanquake
2022-06-20refactor: move EXTRA_DESCENDANT_TX_SIZE_LIMIT to policy/policy.hfanquake
2022-06-20refactor: use braced initialization in policy/policy.hfanquake
2022-06-20scripted-diff: use static constexpr in policy/policy.hfanquake
-BEGIN VERIFY SCRIPT- sed -i -e "s/static const /static constexpr /" src/policy/policy.h -END VERIFY SCRIPT-
2022-06-20refactor: Move DEFAULT_DESCENDANT_SIZE_LIMIT to policy/policy.hfanquake
2022-06-20refactor: Move DEFAULT_DESCENDANT_LIMIT to policy/policy.hfanquake
2022-06-20refactor: Move DEFAULT_ANCESTOR_SIZE_LIMIT to policy/policy.hfanquake
2022-06-20refactor: Move DEFAULT_ANCESTOR_LIMIT to policy/policy.hCAnon
2022-06-19scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputsfurszy
-BEGIN VERIFY SCRIPT- sed -i 's/fAllowOtherInputs/m_allow_other_inputs/g' -- $(git grep --files-with-matches 'fAllowOtherInputs') -END VERIFY SCRIPT-
2022-06-19refactor: use GetWalletTx in SelectCoins instead of access mapWalletfurszy
2022-06-19wallet: move "use-only coinControl inputs" below the selected inputs lookupfurszy
Otherwise, RPC commands such as `walletcreatefundedpsbt` will not support the manual selection of locked, spent and externally added coins. Full explanation is inside #25118 comments but brief summary is: `vCoins` at `SelectCoins` time could not be containing the manually selected input because, even when they were selected by the user, the current `AvailableCoins` flow skips locked and spent coins. Extra note: this is an intermediate step to unify the `fAllowOtherInputs`/`m_add_inputs` concepts. It will not be a problem anymore in the future when we finally decouple the wtx-outputs lookup process from `SelectCoins` and don't skip the user's manually selected coins in `AvailableCoins`.
2022-06-19wallet: unify “allow/block other inputs“ conceptfurszy
Seeking to make the `CoinControl` option less confusing/redundant. In #16377 the `CoinControl` flag ‘m_add_inputs’ was added to tell the coin filtering and selection process two things: - Coin Filtering: Only use the provided inputs. Skip the Rest. - Coin Selection: Search the wtxs-outputs and append all the `CoinControl` selected outpoints to the selection result (skipping all the available output checks). Nothing else. Meanwhile, in `CoinControl` we already have a flag ‘fAllowOtherInputs’ which is already saying: - Coin Filtering: Only use the provided inputs. Skip the Rest. - Coin Selection: If false, no selection process -> append all the `CoinControl` selected outpoints to the selection result (while they passed all the `AvailableCoins` checks and are available in the 'vCoins' vector). As can notice, the first point in the coin filtering process is duplicated in the two option flags. And the second one, is slightly different merely because it takes into account whether the coin is on the `AvailableCoins` vector or not. So it makes sense to merge ‘m_add_inputs’ and ‘fAllowOtherInputs’ into a single field for the coin filtering process while introduce other changes to add the missing/skipped coins into 'vCoins' vector if they were manually selected by the user (follow-up commits).
2022-06-18doc: typo fixMarnix
2022-06-18Merge bitcoin/bitcoin#25410: wallet: fix warning: "argument name 'feerate' ↵MacroFake
in comment does not match parameter name" 7ca8726f6355f8738e9c49533d028123051a624b wallet: fix warning: "argument name 'feerate' in comment does not match parameter name" (furszy) Pull request description: Should solve the tiny https://github.com/bitcoin/bitcoin/pull/25005#issuecomment-1159403854. Which merely happens for the extra "=" character after the comma. ACKs for top commit: Empact: Code Review ACK https://github.com/bitcoin/bitcoin/pull/25410/commits/7ca8726f6355f8738e9c49533d028123051a624b Tree-SHA512: e5368c1114f715bd93cb653c607fd0942ab0b79f709ed7aa627b3fc7e7efd096c92c5c86908c7f26c363b21e391a8faa812727eb32c285e54da3ce0429290361
2022-06-18wallet: fix warning: "argument name 'feerate' in comment does not match ↵furszy
parameter name" Happened because the "feerate=" comment was after the comma.
2022-06-17Merge bitcoin/bitcoin#25005: wallet: remove extra wtx lookup in ↵Andrew Chow
'AvailableCoins' + several code cleanups. fd5c996d1609e6f88769f6f3ef0c322e3435b3aa wallet: GetAvailableBalance, remove double walk-through every available coin (furszy) 162d4ad10f28c5fa38551d69ce9b296ab3933c77 wallet: add 'only_spendable' filter to AvailableCoins (furszy) cdf185ccfb2085e5a4bf82d833392d74b748aeff wallet: remove unused IsSpentKey(hash, index) method (furszy) 4b83bf8dbcf6b8b1c1293575391e90ac7e21b0e0 wallet: avoid extra IsSpentKey -> GetWalletTx lookups (furszy) 3d8a2822570e3cf4d1bc4f9d59b5dcb0145920ad wallet: decouple IsSpentKey(scriptPubKey) from IsSpentKey(hash, n) (furszy) a06fa94ff81e2bccef0316ea5ec4eca0f4de5071 wallet: IsSpent, 'COutPoint' arg instead of (hash, index) (furszy) 91902b77202fc636edb3db587cb6e87d9fb9b60a wallet: IsLockedCoin, 'COutPoint' arg instead of (hash, index) (furszy) 9472ca0a65396206b3078bddf98f4c1807be2d82 wallet: AvailableCoins, don't call 'wtx.tx->vout[i]' multiple times (furszy) 4ce235ef8f9a9dddc52d7ab60c8f71bda1d38873 wallet: return 'CoinsResult' struct in `AvailableCoins` (furszy) Pull request description: This started in #24845 but grew out of scope of it. So, points tackled: 1) Avoid extra `GetWalletTx` lookups inside `AvailableCoins -> IsSpentKey`. `IsSpentKey` was receiving the tx hash and index to internally lookup the tx inside the wallet's map. As all the `IsSpentKey` function callers already have the wtx available, them can provide the `scriptPubKey` directly. 2) Most of the time, we call `Wallet::AvailableCoins`, and later on the process, skip the non-spendable coins from the result in subsequent for-loops. So to speedup the process: introduced the ability to filter by "only_spendable" coins inside `Wallet::AvailableCoins` directly. (the non-spendable coins skip examples are inside `AttemptSelection->GroupOutputs` and `GetAvailableBalance`). 4) Refactored `AvailableCoins` in several ways: a) Now it will return a new struct `CoinsResult` instead of receiving the vCoins vector reference (which was being cleared at the beginning of the method anyway). --> this is coming from #24845 but cherry-picked it here too to make the following commits look nicer. b) Unified all the 'wtx.tx->vout[I]' calls into a single call (coming from this comment https://github.com/bitcoin/bitcoin/pull/24699#discussion_r854163032). 5) The wallet `IsLockedCoin` and `IsSpent` methods now accept an `OutPoint` instead of a hash:index. Which let me cleanup a bunch of extra code. 6) Speeded up the wallet 'GetAvailableBalance': filtering `AvailableCoins` by spendable outputs only and using the 'AvailableCoins' retrieved `total_amount` instead of looping over all the retrieved coins once more. ------------------------------------------------------- Side topic, all this process will look even nicer with #25218 ACKs for top commit: achow101: ACK fd5c996d1609e6f88769f6f3ef0c322e3435b3aa brunoerg: crACK fd5c996d1609e6f88769f6f3ef0c322e3435b3aa w0xlt: Code Review ACK https://github.com/bitcoin/bitcoin/pull/25005/commits/fd5c996d1609e6f88769f6f3ef0c322e3435b3aa Tree-SHA512: 376a85476f907f4f7d1fc3de74b3dbe159b8cc24687374d8739711ad202ea07a33e86f4e66dece836da3ae6985147119fe584f6e672f11d0450ba6bd165b3220
2022-06-17Merge bitcoin/bitcoin#25289: test: implement 'bech32m' mode for ↵laanwj
`getnewdestination()` helper dcf36fe8e3e1fc1e865072232281b72889586e40 test: implement 'bech32m' mode for `getnewdestination()` helper (Sebastian Falbesoner) 1999dcfa40ddedb6cf15f9d66b90fa0f537b4842 test: add helpers for creating P2TR scripts/addresses from output key (Sebastian Falbesoner) Pull request description: This PR adds the missing 'bech32m' mode for the `getnewdestination()` helper and sets it as default, i.e. the function returns a tuple (output x-only-pubkey, scriptPubKey, taproot address) now if not specified otherwise. In a preparation commit, the helpers `output_key_to_p2tr{_script}` are introduced. Note that in contrast to all other common script output types, there are usually _two_ keys involved in creating a taproot output (internal key and output key), hence the prefix `output_` is used to clarify that the output key is expected and the helpers don't do any key tweaking. Thanks to michaelfolkson (for pointing out this TODO that I forgot about) and sipa (for patiently explaining basic things about BIP341). ACKs for top commit: michaelfolkson: ACK dcf36fe8e3e1fc1e865072232281b72889586e40 w0xlt: reACK https://github.com/bitcoin/bitcoin/pull/25289/commits/dcf36fe8e3e1fc1e865072232281b72889586e40 Tree-SHA512: 5bb8d5fd96c63092ede10c3f022ffb2e13c14e333c4aa73348d95deb70cbf0a74745218dc4a7c419eb846793dd69e8217a7b4332a13ae2b2758e100b51fb1a9f
2022-06-17p2p, doc: Use MAX_BLOCKS_TO_ANNOUNCE consistentlyMartin Zumsande
It is an inclusive upper bound according to its definition.
2022-06-17Merge bitcoin/bitcoin#25360: build: SystemTap 4.7 (RISC-V support)laanwj
b8c146b8772030c6efaac43198c4de0d76fd25af build: systemtap 4.7 (fanquake) Pull request description: As of version 4.6, SystemTap now fully supports 64-bit RISC-V. Full SystemTap NEWS is here: https://sourceware.org/git/?p=systemtap.git;a=blob;f=NEWS; Guix Build (x86_64): ```bash 2c4cf36ea601de27ce1b56b923d41aee30d9d64295a700dcc705bd518865c81c guix-build-b8c146b87720/output/aarch64-linux-gnu/SHA256SUMS.part 10dbe855ab64e0e76398fc27e9471071820b9cd5289773c8d9d272f9bb51b7ba guix-build-b8c146b87720/output/aarch64-linux-gnu/bitcoin-b8c146b87720-aarch64-linux-gnu-debug.tar.gz 530808f3803a31c4fe84ec85e7b6c284e52850ba32df12dd1e273e9896bad7ff guix-build-b8c146b87720/output/aarch64-linux-gnu/bitcoin-b8c146b87720-aarch64-linux-gnu.tar.gz 9fa9e1f2412854f87d980e97cb7b4df37a1a13d48a633b9df5b0006d60c10ede guix-build-b8c146b87720/output/arm-linux-gnueabihf/SHA256SUMS.part dcf44666f80b71637403d5f6fb4eb8159ef61815b3feedc84e3a26c99bd18152 guix-build-b8c146b87720/output/arm-linux-gnueabihf/bitcoin-b8c146b87720-arm-linux-gnueabihf-debug.tar.gz 8623a1e969a8f40286060ebbd9085f3d4f621c507fd5448b38ba36129ba0950a guix-build-b8c146b87720/output/arm-linux-gnueabihf/bitcoin-b8c146b87720-arm-linux-gnueabihf.tar.gz 59a71bdc8403f4fff4370922a297a7a2200b0a206d68ac71960f09e728bf0781 guix-build-b8c146b87720/output/arm64-apple-darwin/SHA256SUMS.part 5e17c76526da9f4630ffed2cc2870aa058139fa439d4c756055d8b9f53fc05dc guix-build-b8c146b87720/output/arm64-apple-darwin/bitcoin-b8c146b87720-arm64-apple-darwin-unsigned.dmg 72ebdf006dd279128b33e3b0902f8d3d1291d90fd2d67be60bbbd0f0d5e5b336 guix-build-b8c146b87720/output/arm64-apple-darwin/bitcoin-b8c146b87720-arm64-apple-darwin-unsigned.tar.gz d3a1bafba070e8197d2d3f790053b6204e6779b8352c41118c82e16f2e500620 guix-build-b8c146b87720/output/arm64-apple-darwin/bitcoin-b8c146b87720-arm64-apple-darwin.tar.gz 76510b7e6aaccfa8c0f370e1a6d4b6f79e21572ebc0a369d2195557cfc9f6966 guix-build-b8c146b87720/output/dist-archive/bitcoin-b8c146b87720.tar.gz cb18e130efa70ca58df2b89d7cc368f0374ad3cf6c59f97cee4c12cfbec6982c guix-build-b8c146b87720/output/powerpc64-linux-gnu/SHA256SUMS.part 1028f9deaa1bd140ead816e0278ea5f3eb27e0d70e3e3b11d1f6098da46a0538 guix-build-b8c146b87720/output/powerpc64-linux-gnu/bitcoin-b8c146b87720-powerpc64-linux-gnu-debug.tar.gz 013d97e33f51b985b2b514dbdae093806c890d9f6ca58aec1d62814a874efb8a guix-build-b8c146b87720/output/powerpc64-linux-gnu/bitcoin-b8c146b87720-powerpc64-linux-gnu.tar.gz 3b2cfa1d9418682eeed02718de36137e330573df24b28b5681301a5cb5320e6b guix-build-b8c146b87720/output/powerpc64le-linux-gnu/SHA256SUMS.part 480fd977d8eda3bb9440bfa3e37452ecbeb0f1f4e36a35f6bfa820e7666d2a71 guix-build-b8c146b87720/output/powerpc64le-linux-gnu/bitcoin-b8c146b87720-powerpc64le-linux-gnu-debug.tar.gz eabab79ff95df3f326dc1e40dba4925b9a6de374763180c4170a30cdfe26136a guix-build-b8c146b87720/output/powerpc64le-linux-gnu/bitcoin-b8c146b87720-powerpc64le-linux-gnu.tar.gz 7f5b6d482bee0c73cf0727395d78591559ab974a2b9bff9689ca2262d0612f39 guix-build-b8c146b87720/output/riscv64-linux-gnu/SHA256SUMS.part 228cc22329e50d99edc33465f10e136742833ebc675920bdbde07ca3388523d7 guix-build-b8c146b87720/output/riscv64-linux-gnu/bitcoin-b8c146b87720-riscv64-linux-gnu-debug.tar.gz b5d2565a0b05d51e9834c0212b34903c362061c2489878c82dfbe04729cefa2c guix-build-b8c146b87720/output/riscv64-linux-gnu/bitcoin-b8c146b87720-riscv64-linux-gnu.tar.gz dde6dcf82d7b2f3279150564302a5008d69a3a0fcdedc717c124d460d73ff71d guix-build-b8c146b87720/output/x86_64-apple-darwin/SHA256SUMS.part a5c2e69aba46a164425013b0360674d77687dfe8accc8e8cb97dc630542dc1d3 guix-build-b8c146b87720/output/x86_64-apple-darwin/bitcoin-b8c146b87720-x86_64-apple-darwin-unsigned.dmg cea73001db5a31880ec119f959bb0db21b3f7a12ac21a630b2f12247c4c0b578 guix-build-b8c146b87720/output/x86_64-apple-darwin/bitcoin-b8c146b87720-x86_64-apple-darwin-unsigned.tar.gz 8cf6ba1de32f68c70ee23a19fbbeadb59df4c008792c717ac22d476ebe9aa921 guix-build-b8c146b87720/output/x86_64-apple-darwin/bitcoin-b8c146b87720-x86_64-apple-darwin.tar.gz 061247b31ba1012689817e304357fca0b7262106223d6eaf8d0b31148bd764d1 guix-build-b8c146b87720/output/x86_64-linux-gnu/SHA256SUMS.part 20caf9d234a88333b696e0261284c29ea4f83c3b9e590696230614220b2c7e2e guix-build-b8c146b87720/output/x86_64-linux-gnu/bitcoin-b8c146b87720-x86_64-linux-gnu-debug.tar.gz 54c3e57cc4cc6173aa2bb4e17f47e85a346ef752973d6b97f7a3ff015d4f5068 guix-build-b8c146b87720/output/x86_64-linux-gnu/bitcoin-b8c146b87720-x86_64-linux-gnu.tar.gz 47f4104cbd46c96bf9c3cb4fcf9e813ee73566781a599e850bf8c5c8d6e7970a guix-build-b8c146b87720/output/x86_64-w64-mingw32/SHA256SUMS.part b337b2841988f0cdcd8aebec669467f38354b626a7d331e84a5a7b7fc47f6a47 guix-build-b8c146b87720/output/x86_64-w64-mingw32/bitcoin-b8c146b87720-win64-debug.zip 25e97d46edb35dd87a55b285dad03a6c571336ab93f8c7457571498e3057118a guix-build-b8c146b87720/output/x86_64-w64-mingw32/bitcoin-b8c146b87720-win64-setup-unsigned.exe bc9870404d52a5423ce8fee37cae3ebda00d9958b1469d2930aa8f0d61ab55ef guix-build-b8c146b87720/output/x86_64-w64-mingw32/bitcoin-b8c146b87720-win64-unsigned.tar.gz 194615a1645bed622d91e8760cd3ec33fd0ef684dd6a7a04d1731272f7fd1557 guix-build-b8c146b87720/output/x86_64-w64-mingw32/bitcoin-b8c146b87720-win64.zip ``` Guix Build (arm64): ```bash 442bf81809c481be38317703bdf6ae45d9dd6f1b044515dfe36be514eae8b66a guix-build-b8c146b87720/output/arm-linux-gnueabihf/SHA256SUMS.part a104a61a1dd4f663e809344cc86d500254d4d451f23c062f48e50c6418fcd135 guix-build-b8c146b87720/output/arm-linux-gnueabihf/bitcoin-b8c146b87720-arm-linux-gnueabihf-debug.tar.gz 12f84be1ad44d28595144bbb6319cb2f6fb95b27c633f54771815ccff4fb40aa guix-build-b8c146b87720/output/arm-linux-gnueabihf/bitcoin-b8c146b87720-arm-linux-gnueabihf.tar.gz e6b42524123488ef3342d0806ac562985a1fff214c1bfcd1a26ab8e288caf24a guix-build-b8c146b87720/output/arm64-apple-darwin/SHA256SUMS.part bb01d384bff21c5280d4a193bd4fb158ecaa41d0746db30a52c135e5a6e76750 guix-build-b8c146b87720/output/arm64-apple-darwin/bitcoin-b8c146b87720-arm64-apple-darwin-unsigned.dmg 2ebeca13939e408aae304f77eb32c683ce703262475d70f9c0a9a51533cabdb4 guix-build-b8c146b87720/output/arm64-apple-darwin/bitcoin-b8c146b87720-arm64-apple-darwin-unsigned.tar.gz b5df98dc9b66eb1ae725c050f9e1d94a551ce9637cef29f82cb38ef784996c1c guix-build-b8c146b87720/output/arm64-apple-darwin/bitcoin-b8c146b87720-arm64-apple-darwin.tar.gz 76510b7e6aaccfa8c0f370e1a6d4b6f79e21572ebc0a369d2195557cfc9f6966 guix-build-b8c146b87720/output/dist-archive/bitcoin-b8c146b87720.tar.gz d38cc0e933f37108f71d826e20d6cc1510fe98d830484977d032fbb66d94ab02 guix-build-b8c146b87720/output/powerpc64-linux-gnu/SHA256SUMS.part 8dc33ebac8ec67cefe842419015ab42f344971a9fe071bda2b09f6b1696fea68 guix-build-b8c146b87720/output/powerpc64-linux-gnu/bitcoin-b8c146b87720-powerpc64-linux-gnu-debug.tar.gz 57b01141e859246a70c9110c5daa2b388dfc5bab442a873f6b715981bd3dfca1 guix-build-b8c146b87720/output/powerpc64-linux-gnu/bitcoin-b8c146b87720-powerpc64-linux-gnu.tar.gz 282befd619cfb541c31d1a81495e08c409f2d9174e876f05dc7bd361a3a1821e guix-build-b8c146b87720/output/powerpc64le-linux-gnu/SHA256SUMS.part 8ef3a9e19393ef36c8a001477e9ee08dba705978775fcebb5c2349612ce22808 guix-build-b8c146b87720/output/powerpc64le-linux-gnu/bitcoin-b8c146b87720-powerpc64le-linux-gnu-debug.tar.gz bbfde476e8f630783a12e9d900d91ab2ab24ee2c7e607699e37fd2d273627a0e guix-build-b8c146b87720/output/powerpc64le-linux-gnu/bitcoin-b8c146b87720-powerpc64le-linux-gnu.tar.gz b0f8f33becc355ab70f549ed4d33b49f73aa5b4adb793b0e661ff1180861cdba guix-build-b8c146b87720/output/riscv64-linux-gnu/SHA256SUMS.part 7ee185e1aa6a7b4c536f375d165dd0232a310892a2e9446de713081b471d5d9e guix-build-b8c146b87720/output/riscv64-linux-gnu/bitcoin-b8c146b87720-riscv64-linux-gnu-debug.tar.gz 8d15acb1da57c753131e887453d95c0539f2d4bbb4e3a6deb976e17dee306946 guix-build-b8c146b87720/output/riscv64-linux-gnu/bitcoin-b8c146b87720-riscv64-linux-gnu.tar.gz dde6dcf82d7b2f3279150564302a5008d69a3a0fcdedc717c124d460d73ff71d guix-build-b8c146b87720/output/x86_64-apple-darwin/SHA256SUMS.part a5c2e69aba46a164425013b0360674d77687dfe8accc8e8cb97dc630542dc1d3 guix-build-b8c146b87720/output/x86_64-apple-darwin/bitcoin-b8c146b87720-x86_64-apple-darwin-unsigned.dmg cea73001db5a31880ec119f959bb0db21b3f7a12ac21a630b2f12247c4c0b578 guix-build-b8c146b87720/output/x86_64-apple-darwin/bitcoin-b8c146b87720-x86_64-apple-darwin-unsigned.tar.gz 8cf6ba1de32f68c70ee23a19fbbeadb59df4c008792c717ac22d476ebe9aa921 guix-build-b8c146b87720/output/x86_64-apple-darwin/bitcoin-b8c146b87720-x86_64-apple-darwin.tar.gz a05b02f8270bc1928e89ac03d2ab40da9e1fc35cf5416c511fe67a197c64b241 guix-build-b8c146b87720/output/x86_64-linux-gnu/SHA256SUMS.part 9f213cfc3afb899cf1e06b796f0ab7e4414f60e267f286837d10944c592d0cad guix-build-b8c146b87720/output/x86_64-linux-gnu/bitcoin-b8c146b87720-x86_64-linux-gnu-debug.tar.gz 7f8100bbf4415f4cf531e0b652026e1429877df873bce6b45433e7e1b638efe4 guix-build-b8c146b87720/output/x86_64-linux-gnu/bitcoin-b8c146b87720-x86_64-linux-gnu.tar.gz 8d5ad864562ca22a37380a89db7a78574462b78bd74fcf8b663b8164043e800f guix-build-b8c146b87720/output/x86_64-w64-mingw32/SHA256SUMS.part 3713b4d70e4eb56b0875d07c698eab270c680da0f81be5394ea16750c5b56490 guix-build-b8c146b87720/output/x86_64-w64-mingw32/bitcoin-b8c146b87720-win64-debug.zip 25e97d46edb35dd87a55b285dad03a6c571336ab93f8c7457571498e3057118a guix-build-b8c146b87720/output/x86_64-w64-mingw32/bitcoin-b8c146b87720-win64-setup-unsigned.exe bc9870404d52a5423ce8fee37cae3ebda00d9958b1469d2930aa8f0d61ab55ef guix-build-b8c146b87720/output/x86_64-w64-mingw32/bitcoin-b8c146b87720-win64-unsigned.tar.gz 1d78eb522fdebb8e494c63656212972657f323406b43a5f6af835f272529915f guix-build-b8c146b87720/output/x86_64-w64-mingw32/bitcoin-b8c146b87720-win64.zip ``` ACKs for top commit: laanwj: Tested ACK b8c146b8772030c6efaac43198c4de0d76fd25af Tree-SHA512: e62621b3b51fe7e391f262137de87231a3fb0e39c4090017990317ae758493fab36e5764843b905b86a5d48bbf2c8a08de7c596c1cc590585099fe5bc9cc18be
2022-06-17Merge bitcoin/bitcoin#25281: build: Remove unused `LIBBITCOIN_KERNEL` variablelaanwj
ce1c8104aa40db9a0b11e48b8633d3440a37eb36 build: Remove unused `LIBBITCOIN_KERNEL` variable (Hennadii Stepanov) Pull request description: Noticed that while working on moving the build system to CMake. But I [am not the first](https://github.com/bitcoin/bitcoin/pull/24322/files#r860472867) one :) ACKs for top commit: laanwj: ACK ce1c8104aa40db9a0b11e48b8633d3440a37eb36 Tree-SHA512: 877b9f0d64c4c72f403335d7a8462e551f6f8cd5648a211f980d6da5ed7683521d6549f6acf15ac8e55f67915c556201a1980228c975a22135507746e2f392ce
2022-06-17Merge bitcoin/bitcoin#25299: doc: Correct comments re. units of constantslaanwj
241c4d047ee658a976625c39c6acd04dd7b071ef doc: Correct comment describing value of MAX_FILE_SIZE_PSBT as in MiB (Ben Woosley) 64f81a38b9f0e09e353d058aa88eb681a181df37 doc: Correct nPruneTarget misidentifying units of variable (darosior) Pull request description: In https://github.com/bitcoin/bitcoin/pull/15848, darosior fixed up a comment which mis-identified the units of a constant. Another comment misidentified a value as in MiB rather than MB. ACKs for top commit: laanwj: Code review ACK 241c4d047ee658a976625c39c6acd04dd7b071ef darosior: ACK 241c4d047ee658a976625c39c6acd04dd7b071ef, with or without https://github.com/bitcoin/bitcoin/pull/25299#discussion_r892705277 Tree-SHA512: 96c03a35140e5c53759f387bd292a8f8f621ba74c3cf6621939fad40f48892d23141c747ad3ab4fd71108e3b737670175abc2eb3990a1bd1660366c55d61ddf8
2022-06-17Merge bitcoin/bitcoin#25392: scripts: remove no-longer-needed ignored exportslaanwj
84e56b45b45e6c79331de59eab5d394eb2655538 scripts: remove no-longer-needed ignored exports (fanquake) Pull request description: Haven't checked which commit this changed (I assume the GCC-10 consolidation), however Guix builds no-longer require these exports to be ignored. Guix Build (x86_64): ```bash 9be92af4d0697aec2e54fd105002f690c174e0da07fd62506865a7d52395afb5 guix-build-84e56b45b45e/output/aarch64-linux-gnu/SHA256SUMS.part a7c9e708c9a8e6e8c98dab326e010719f6f89c2d81e6ce61a9d976e1a179ea44 guix-build-84e56b45b45e/output/aarch64-linux-gnu/bitcoin-84e56b45b45e-aarch64-linux-gnu-debug.tar.gz e0ba3a6a9c319739cfdb0cf6d3f389cfd1e16008385fcad6d70ac404c9bf9db0 guix-build-84e56b45b45e/output/aarch64-linux-gnu/bitcoin-84e56b45b45e-aarch64-linux-gnu.tar.gz f3e71a81727a4a177454e9c15d2a07fcf8f9431e0259eabd31d5cef72682f33c guix-build-84e56b45b45e/output/arm-linux-gnueabihf/SHA256SUMS.part ff8cf7390281bdd3c421f1ee19b68727732e0676058eb2dd442b7ae1fc80e0f1 guix-build-84e56b45b45e/output/arm-linux-gnueabihf/bitcoin-84e56b45b45e-arm-linux-gnueabihf-debug.tar.gz 561f69b6862a4c24bc00a18249e1ef0064c221ab96047ac8fd57b54dc102332c guix-build-84e56b45b45e/output/arm-linux-gnueabihf/bitcoin-84e56b45b45e-arm-linux-gnueabihf.tar.gz a1352d3e1720d8b67e009596dea8bfe873e9200150b2ff9219d2c44b14273b10 guix-build-84e56b45b45e/output/arm64-apple-darwin/SHA256SUMS.part fe6ab4fb695322fe5247f8b355ca5d0a2f94d5dda67b44f710b640971fa8b29c guix-build-84e56b45b45e/output/arm64-apple-darwin/bitcoin-84e56b45b45e-arm64-apple-darwin-unsigned.dmg 13aa79cfb9642efe00fe03389dd4b358d767a9ee8268da3705f0c6d112400b8a guix-build-84e56b45b45e/output/arm64-apple-darwin/bitcoin-84e56b45b45e-arm64-apple-darwin-unsigned.tar.gz e62df23e9bbccaa6864eef8d8efa2a701a0b1322d6feca7b134311ba13621f99 guix-build-84e56b45b45e/output/arm64-apple-darwin/bitcoin-84e56b45b45e-arm64-apple-darwin.tar.gz 0d22f8d02f9b16aace107c013166b52e4ea9b3f7babf44257b6c51bb30418f27 guix-build-84e56b45b45e/output/dist-archive/bitcoin-84e56b45b45e.tar.gz edd3cd49d8bf1765cc008f63a94e53cb153a646f072599637153573f77f4696a guix-build-84e56b45b45e/output/powerpc64-linux-gnu/SHA256SUMS.part 868602e7bbdce98a0974eb057b1b3670e87c9bcd110d40004e86e20768c8de32 guix-build-84e56b45b45e/output/powerpc64-linux-gnu/bitcoin-84e56b45b45e-powerpc64-linux-gnu-debug.tar.gz 449c261eb9125764f0c9796bb48f01a12e3d034dd9591bb7722fa85451e4abf9 guix-build-84e56b45b45e/output/powerpc64-linux-gnu/bitcoin-84e56b45b45e-powerpc64-linux-gnu.tar.gz 154e03ba9103ecc72c9cfa1fa2dbad1ab626e44502b520599791de3772656fd1 guix-build-84e56b45b45e/output/powerpc64le-linux-gnu/SHA256SUMS.part a9469869fcf1d0b92abe6ecdb1eb99d251da158ad867db342ef8bd1875b3ec13 guix-build-84e56b45b45e/output/powerpc64le-linux-gnu/bitcoin-84e56b45b45e-powerpc64le-linux-gnu-debug.tar.gz 5118caa6e4df5f99f0fd11911578758e8969d11766a042b986bcb83fbe1ba114 guix-build-84e56b45b45e/output/powerpc64le-linux-gnu/bitcoin-84e56b45b45e-powerpc64le-linux-gnu.tar.gz 879f536a3a1486465611281b50fd4607c78da935b9cf9478b75c204560cc919c guix-build-84e56b45b45e/output/riscv64-linux-gnu/SHA256SUMS.part 25665580fc1cb830483dfb8ae0238dba14237e726e830028a043b09c93ef71a1 guix-build-84e56b45b45e/output/riscv64-linux-gnu/bitcoin-84e56b45b45e-riscv64-linux-gnu-debug.tar.gz 833c7e202c937c2577ecee2c974c9d15c5042e7e1a0a19c10bd80e8ea748c643 guix-build-84e56b45b45e/output/riscv64-linux-gnu/bitcoin-84e56b45b45e-riscv64-linux-gnu.tar.gz 372c6778a9cdb488b02600d6a0b7c4f0acb7418a00bc80817cbf09e7ed20d56a guix-build-84e56b45b45e/output/x86_64-apple-darwin/SHA256SUMS.part b711303e1fcda56ca9e804d12c674687a1906a0d33025153f0795b374d35f8a4 guix-build-84e56b45b45e/output/x86_64-apple-darwin/bitcoin-84e56b45b45e-x86_64-apple-darwin-unsigned.dmg 8a41582ca663a12c4e46752f96cff2f82b3c03b9a99a6d2aa9b545d49f2c3adf guix-build-84e56b45b45e/output/x86_64-apple-darwin/bitcoin-84e56b45b45e-x86_64-apple-darwin-unsigned.tar.gz 5d622bdf94e009483fa287b611a3eb6c887e88fd3c242e323015f96aaa7ae645 guix-build-84e56b45b45e/output/x86_64-apple-darwin/bitcoin-84e56b45b45e-x86_64-apple-darwin.tar.gz 836ec0b63b44cfaca13fe1bbf150a250a04b748457a01b72f7d178df8bf3d7ea guix-build-84e56b45b45e/output/x86_64-linux-gnu/SHA256SUMS.part ed2ad8864c361df278288b5e18047f1d98960a0d10bf34f09e30558237610ba8 guix-build-84e56b45b45e/output/x86_64-linux-gnu/bitcoin-84e56b45b45e-x86_64-linux-gnu-debug.tar.gz bda24f092de4bb7d995e9d21714619a0a8bc4ee762e0ef3063201a2b38311256 guix-build-84e56b45b45e/output/x86_64-linux-gnu/bitcoin-84e56b45b45e-x86_64-linux-gnu.tar.gz ad21413d411dada0b40b566311531a21022dc0b6eea77ec1807ba59a7000deff guix-build-84e56b45b45e/output/x86_64-w64-mingw32/SHA256SUMS.part 5573d65bce9ce5ee65f9ae34b2bd4da8af0ff4ec60a67dfb45ac76bf696711a0 guix-build-84e56b45b45e/output/x86_64-w64-mingw32/bitcoin-84e56b45b45e-win64-debug.zip 09e29350ef8f6246d5cd16b7b7d6602bf04f0aea41445ae3f7aa235a1ace79d4 guix-build-84e56b45b45e/output/x86_64-w64-mingw32/bitcoin-84e56b45b45e-win64-setup-unsigned.exe d5804a4e267a36b603723e149833cbb1e1740d34a89f66034e80c3caff31c4cf guix-build-84e56b45b45e/output/x86_64-w64-mingw32/bitcoin-84e56b45b45e-win64-unsigned.tar.gz aa54a35c667f560609a3f418defd8558806b6081a5a027707954f69557b36f63 guix-build-84e56b45b45e/output/x86_64-w64-mingw32/bitcoin-84e56b45b45e-win64.zip ``` Guix Build (arm64): ```bash 8cedaaa26db8ad04063b350e475834beaaede949ae985d67bb661f367cacbd5c guix-build-84e56b45b45e/output/arm-linux-gnueabihf/SHA256SUMS.part 134a567e6671ac31d911956118794347e37abd647940183f291f985146595ebf guix-build-84e56b45b45e/output/arm-linux-gnueabihf/bitcoin-84e56b45b45e-arm-linux-gnueabihf-debug.tar.gz 1a53bd0029537e153be032f09c69a4d950442319c03a6c1f7f2a16ef444c39b7 guix-build-84e56b45b45e/output/arm-linux-gnueabihf/bitcoin-84e56b45b45e-arm-linux-gnueabihf.tar.gz b9de5a0182e15c43223bce6a5dcd423c760d1be5c2c3256b69948e35e574e530 guix-build-84e56b45b45e/output/arm64-apple-darwin/SHA256SUMS.part 86dc1aef2d7fc52b52c26bff5c57415a38d84600430761b296669891dd5dd216 guix-build-84e56b45b45e/output/arm64-apple-darwin/bitcoin-84e56b45b45e-arm64-apple-darwin-unsigned.dmg 043ba78adfac04bbeda75fd9c8718980abd2073716e0925a0eda688755e91765 guix-build-84e56b45b45e/output/arm64-apple-darwin/bitcoin-84e56b45b45e-arm64-apple-darwin-unsigned.tar.gz 1adccc66e8bfe48e1cfaaa9c5a254310565b6897d7b0134d5fc5c787c8d56583 guix-build-84e56b45b45e/output/arm64-apple-darwin/bitcoin-84e56b45b45e-arm64-apple-darwin.tar.gz 0d22f8d02f9b16aace107c013166b52e4ea9b3f7babf44257b6c51bb30418f27 guix-build-84e56b45b45e/output/dist-archive/bitcoin-84e56b45b45e.tar.gz 50e98b648087f4d20f7e6b4cdee07f200523a9ba7474db8ac9771fdedd391c76 guix-build-84e56b45b45e/output/powerpc64-linux-gnu/SHA256SUMS.part 35f200e58e9b206d2743a1e94e0857e0494fa650be91683b89328fcad55e643f guix-build-84e56b45b45e/output/powerpc64-linux-gnu/bitcoin-84e56b45b45e-powerpc64-linux-gnu-debug.tar.gz 09d1263b33bee32c9a7584155c4cd2e129ae0cff1b7a1f7049773501841b74b5 guix-build-84e56b45b45e/output/powerpc64-linux-gnu/bitcoin-84e56b45b45e-powerpc64-linux-gnu.tar.gz d63b6e9e47ed0fb6f52b7285638eb7030b68d1e821978b8f7fb4a94122f88106 guix-build-84e56b45b45e/output/powerpc64le-linux-gnu/SHA256SUMS.part 3addd674c1b45bab6b9e5882cce6a0e1138df876a214297554cf957cc9abd3ad guix-build-84e56b45b45e/output/powerpc64le-linux-gnu/bitcoin-84e56b45b45e-powerpc64le-linux-gnu-debug.tar.gz 5b2353043239b78a28607cd037729181ddd3705cb6595df0cefc8d2c38e8ce35 guix-build-84e56b45b45e/output/powerpc64le-linux-gnu/bitcoin-84e56b45b45e-powerpc64le-linux-gnu.tar.gz 7ee90e3c72890bd10ada21ae9223301ea7faf283f937993d9e036bb423351526 guix-build-84e56b45b45e/output/riscv64-linux-gnu/SHA256SUMS.part 4e660b9a497cc0d1142dfc91ed2ac85bff16eaafe6a28a4f31b3b7650d0b9345 guix-build-84e56b45b45e/output/riscv64-linux-gnu/bitcoin-84e56b45b45e-riscv64-linux-gnu-debug.tar.gz 6779bcabe53ce8d276082d7694fc897bb0e366a038bca5d45a81ca357fa7a3bc guix-build-84e56b45b45e/output/riscv64-linux-gnu/bitcoin-84e56b45b45e-riscv64-linux-gnu.tar.gz 372c6778a9cdb488b02600d6a0b7c4f0acb7418a00bc80817cbf09e7ed20d56a guix-build-84e56b45b45e/output/x86_64-apple-darwin/SHA256SUMS.part b711303e1fcda56ca9e804d12c674687a1906a0d33025153f0795b374d35f8a4 guix-build-84e56b45b45e/output/x86_64-apple-darwin/bitcoin-84e56b45b45e-x86_64-apple-darwin-unsigned.dmg 8a41582ca663a12c4e46752f96cff2f82b3c03b9a99a6d2aa9b545d49f2c3adf guix-build-84e56b45b45e/output/x86_64-apple-darwin/bitcoin-84e56b45b45e-x86_64-apple-darwin-unsigned.tar.gz 5d622bdf94e009483fa287b611a3eb6c887e88fd3c242e323015f96aaa7ae645 guix-build-84e56b45b45e/output/x86_64-apple-darwin/bitcoin-84e56b45b45e-x86_64-apple-darwin.tar.gz a20620da9eddd9039a4af4a22ac675047fd84b2897c1077c0c23ce29836617e9 guix-build-84e56b45b45e/output/x86_64-linux-gnu/SHA256SUMS.part caeea4294f8b3e76f3a997fc0a4ac11c26b4c6d65430d6293318f2e74bfda8fe guix-build-84e56b45b45e/output/x86_64-linux-gnu/bitcoin-84e56b45b45e-x86_64-linux-gnu-debug.tar.gz 59cba65f31fd34d656a86bcf5b6ea8326d7e7cdb215931fc9943dadedcc84ed3 guix-build-84e56b45b45e/output/x86_64-linux-gnu/bitcoin-84e56b45b45e-x86_64-linux-gnu.tar.gz 3b70924b559c1bd7c05bb8862bb19051af674488b9f03364a20164dc6ae05f36 guix-build-84e56b45b45e/output/x86_64-w64-mingw32/SHA256SUMS.part cb0dc3594503b41d0e716be7049eaffe87a85ff15c746e03130ca79f64c308da guix-build-84e56b45b45e/output/x86_64-w64-mingw32/bitcoin-84e56b45b45e-win64-debug.zip 09e29350ef8f6246d5cd16b7b7d6602bf04f0aea41445ae3f7aa235a1ace79d4 guix-build-84e56b45b45e/output/x86_64-w64-mingw32/bitcoin-84e56b45b45e-win64-setup-unsigned.exe d5804a4e267a36b603723e149833cbb1e1740d34a89f66034e80c3caff31c4cf guix-build-84e56b45b45e/output/x86_64-w64-mingw32/bitcoin-84e56b45b45e-win64-unsigned.tar.gz 62881744e69b717cba75cf449fbcd0d4cdee21a88fb002cafaa71439abec339a guix-build-84e56b45b45e/output/x86_64-w64-mingw32/bitcoin-84e56b45b45e-win64.zip ``` ACKs for top commit: laanwj: Tested ACK 84e56b45b45e6c79331de59eab5d394eb2655538 hebasto: ACK 84e56b45b45e6c79331de59eab5d394eb2655538 Tree-SHA512: 682527f4492f04bddfe9f669171c1121da987a485525bcd33a3da9e60b29416e5bab751c9c47849970bfed03a3705475b0a513579c6dde6e896d66e49f0510eb
2022-06-17build: add *_STANDARD vars to depends gen_idfanquake
Followup to #22380. We need to have these in the id so that we rebuild if we change / unset a *_STANDARD.
2022-06-16Merge bitcoin/bitcoin#22380: build: add and use C_STANDARD and CXX_STANDARD ↵laanwj
in depends f7595f1354f4618436fdab232000dc152bff315a build: add and use CXX_STANDARD in depends (fanquake) 7e7b3e42fa98b584ae60513a6774037bf677b8ce build: add and use C_STANDARD in depends (fanquake) Pull request description: By explicitly setting a C standard version we avoid any potential for issues/differences in libraries that may come about due to C STD version, as well as avoid potentially being opted into newer code / features in libraries when compiler defaults change (i.e as of 11.0.0, Clang now defaults to gnu17 over gnu11). This should be a no-op for our release builds, because it's just explicitly setting the default that is [already being used](https://github.com/fanquake/core-review/blob/master/compiler-defaults.md). However this is relevant for anyone building depends with a newer compiler. I found [one broken `__STDC_VERSION__` check in the](https://github.com/miniupnp/miniupnp/pull/552) miniupnpc header. At the same time, add `CXX_STANDARD` for setting our C++ standard, and use that over setting `-std=c++17` for cxx packages. Guix builds: ```bash ``` ACKs for top commit: dongcarl: Code Review ACK f7595f1354f4618436fdab232000dc152bff315a laanwj: Code review ACK f7595f1354f4618436fdab232000dc152bff315a Tree-SHA512: 9255190d91ba3de20762b1d6af35c59d64f3d77a52bbe9a3f1dfb6bcf16daef66054ebef96b58e7285cd01bf613e69a78bd5e8681c21293e254f23d1fa7b0f71
2022-06-16Merge bitcoin/bitcoin#24864: contrib: Use asmap for ASN lookup in makeseedslaanwj
667e316bcb300eec131727a7ce54dd038031e267 contrib: Update makeseeds to asmap-nextgen (laanwj) ae00b9e02c819a69293fdcdab91f57b33e9275d9 contrib: add seeds progress indicator and remove asmap one in makeseeds script (Jon Atack) b54180303de0df9be7023577f35648225cf95443 contrib: Use asmap for ASN lookup in makeseeds (laanwj) Pull request description: Add an argument `-a` to provide a asmap file to do the IP to ASN lookups. This speeds up the script greatly, and makes the output deterministic. Also removes the dependency on `dns.lookup`. I've annotated the output with ASxxxx comments to provide a way to verify the functionality. For now I've added instructions in README.md to download and use the `demo.map` from the asmap repository. When we have some other mechanism for distributing asmap files we could switch to that. This continues #24824. I've removed the fallbacks and extra complexity, as everyone will be using the same instructions anyway. Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com> Co-authored-by: russeree <reese.russell@ymail.com> ACKs for top commit: sipa: ACK 667e316bcb300eec131727a7ce54dd038031e267 dunxen: re-ACK 667e316 Tree-SHA512: c4cedfbd1dee6be7547aa92dd9e262c46f0ff8099e647559b2a40eab0cc9874e9a813706630dd5c880390d23f432e789fb3e7e8a09f376f567071e68f5904c65
2022-06-16Merge bitcoin/bitcoin#24649: wallet: do not count wallet utxos as externalAndrew Chow
7832e9438f5c66b88f60676d14e1e11d669eb109 test: fundrawtransaction preset input weight calculation (S3RK) c3981e379fa088aa7aa03b2f505342a5b3bc3436 wallet: do not count wallet utxos as external (S3RK) Pull request description: Correctly differentiating between external vs non-external utxos in coin control produces more accurate weight and fee estimations. Weight for external utxos is estimated based on the maximum signature size, while for the wallet utxos we expect minimal signature due to signature grinding. ACKs for top commit: achow101: re-ACK 7832e9438f5c66b88f60676d14e1e11d669eb109 Xekyo: re-ACK 7832e9438f5c66b88f60676d14e1e11d669eb109 furszy: ACK 7832e943 Tree-SHA512: bb5635b0bd85fa9a76922a53ad3fa062286424c06a695a0e87407c665713e80a33555b644fbb13bcc1ab503dcd7f53aacbdc368d69ac0ecff8005603623ac94f
2022-06-16Merge bitcoin/bitcoin#24356: refactor: replace CConnman::SocketEvents() with ↵laanwj
mockable Sock::WaitMany() 6e68ccbefea6509c61fc4405a391a517c6057bb0 net: use Sock::WaitMany() instead of CConnman::SocketEvents() (Vasil Dimov) ae263460bab9e6aa112dc99790c8ef06a56ec838 net: introduce Sock::WaitMany() (Vasil Dimov) cc74459768063a923fb6220a4f420eaf211aee7b net: also wait for exceptional events in Sock::Wait() (Vasil Dimov) Pull request description: _This is a piece of #21878, chopped off to ease review._ `Sock::Wait()` waits for IO events on one socket. Introduce a similar `virtual` method `WaitMany()` that waits simultaneously for IO events on more than one socket. Use `WaitMany()` instead of `CConnman::SocketEvents()` (and ditch the latter). Given that the former is a `virtual` method, it can be mocked by unit and fuzz tests. This will help to make bigger parts of `CConnman` testable (unit and fuzz). ACKs for top commit: laanwj: Code review ACK 6e68ccbefea6509c61fc4405a391a517c6057bb0 jonatack: re-ACK 6e68ccbefea6509c61fc4405a391a517c6057bb0 per `git range-diff e18fd47 6747729 6e68ccb`, and verified rebase to master and debug build Tree-SHA512: 917fb6ad880d64d3af1ebb301c06fbd01afd8ff043f49e4055a088ebed6affb7ffe1dcf59292d822f10de5f323b6d52d557cb081dd7434634995f9148efcf08f
2022-06-16Merge bitcoin/bitcoin#25215: [kernel 2d/n] Reduce CTxMemPool constructor ↵laanwj
call sites d273e53b6e2cabd91a83f0ff0f9b6cfe1815b637 bench/rpc_mempool: Create ChainTestingSetup, use its CTxMemPool (Carl Dong) 020caba3df727ae8ede50eace86ae76971c0fea1 bench: Use existing CTxMemPool in TestingSetup (Carl Dong) 86e732def3983f99ec84b59375615bedcdc0e664 scripted-diff: test: Use CTxMemPool in TestingSetup (Carl Dong) 213457e170ce41a0b26c644aa010111df36414a6 test/policyestimator: Use ChainTestingSetup's CTxMemPool (Carl Dong) 319f0ceeeb25f28e027fc41be2755092dc5365b4 rest/getutxos: Don't construct empty mempool (Carl Dong) 03574b956a274207ba90591781e0914609225136 tree-wide: clang-format CTxMemPool references (Carl Dong) Pull request description: This is part of the `libbitcoinkernel` project: #24303, https://github.com/bitcoin/bitcoin/projects/18 This PR reduces the number of call sites where we explicitly construct CTxMemPool. This is done in preparation for later PRs which decouple the mempool module from `ArgsManager`, eventually all of libbitcoinkernel will be decoupled from `ArgsManager`. The changes in this PR: - Allows us to have less code churn as we modify `CTxMemPool`'s constructor in later PRs - In many cases, we can make use of existing `CTxMemPool` instances, getting rid of extraneous constructions - In other cases, we construct a `ChainTestingSetup` and use the `CTxMemPool` there, so that we can rely on the logic in `setup_common` to set things up correctly ## Notes for Reviewers ### A note on using existing mempools When evaluating whether or not it's appropriate to use an existing mempool in a `*TestingSetup` struct, the key is to make sure that the mempool has the same lifetime as the `*TestingSetup` struct. Example 1: In [`src/fuzz/tx_pool.cpp`](https://github.com/bitcoin/bitcoin/blob/b4f686952a60bbadc7ed2250651d0d6af0959f4d/src/test/fuzz/tx_pool.cpp), the `TestingSetup` is initialized in `initialize_tx_pool` and lives as a static global, while the `CTxMemPool` is in the `tx_pool_standard` fuzz target, meaning that each time the `tx_pool_standard` fuzz target gets run, a new `CTxMemPool` is created. If we were to use the static global `TestingSetup`'s CTxMemPool we might run into problems since its `CTxMemPool` will carry state between subsequent runs. This is why we don't modify `src/fuzz/tx_pool.cpp` in this PR. Example 2: In [`src/bench/mempool_eviction.cpp`](https://github.com/bitcoin/bitcoin/blob/b4f686952a60bbadc7ed2250651d0d6af0959f4d/src/bench/mempool_eviction.cpp), we see that the `TestingSetup` is in the same scope as the constructed `CTxMemPool`, so it is safe to use its `CTxMemPool`. ### A note on checking `CTxMemPool` ctor call sites After the "tree-wide: clang-format CTxMemPool references" commit, you can find all `CTxMemPool` ctor call sites with the following command: ```sh git grep -E -e 'make_unique<CTxMemPool>' \ -e '\bCTxMemPool\s+[^({;]+[({]' \ -e '\bCTxMemPool\s+[^;]+;' \ -e '\bnew\s+CTxMemPool\b' ``` At the end of the PR, you will find that there are still quite a few call sites that we can seemingly get rid of: ```sh $ git grep -E -e 'make_unique<CTxMemPool>' -e '\bCTxMemPool\s+[^({;]+[({]' -e '\bCTxMemPool\s+[^;]+;' -e '\bnew\s+CTxMemPool\b' # rearranged for easier explication src/init.cpp: node.mempool = std::make_unique<CTxMemPool>(node.fee_estimator.get(), mempool_check_ratio); src/test/util/setup_common.cpp: m_node.mempool = std::make_unique<CTxMemPool>(m_node.fee_estimator.get(), 1); src/rpc/mining.cpp: CTxMemPool empty_mempool; src/test/util/setup_common.cpp: CTxMemPool empty_pool; src/bench/mempool_stress.cpp: CTxMemPool pool; src/bench/mempool_stress.cpp: CTxMemPool pool; src/test/fuzz/rbf.cpp: CTxMemPool pool; src/test/fuzz/tx_pool.cpp: CTxMemPool tx_pool_{/*estimator=*/nullptr, /*check_ratio=*/1}; src/test/fuzz/tx_pool.cpp: CTxMemPool tx_pool_{/*estimator=*/nullptr, /*check_ratio=*/1}; src/test/fuzz/validation_load_mempool.cpp: CTxMemPool pool{}; src/txmempool.h: /** Create a new CTxMemPool. ``` Let's break them down one by one: ``` src/init.cpp: node.mempool = std::make_unique<CTxMemPool>(node.fee_estimator.get(), mempool_check_ratio); src/test/util/setup_common.cpp: m_node.mempool = std::make_unique<CTxMemPool>(m_node.fee_estimator.get(), 1); ``` Necessary ----- ``` src/rpc/mining.cpp: CTxMemPool empty_mempool; src/test/util/setup_common.cpp: CTxMemPool empty_pool; ``` These are fixed in #25223 where we stop requiring the `BlockAssembler` to have a `CTxMemPool` if it's not going to consult it anyway (as is the case in these two call sites) ----- ``` src/bench/mempool_stress.cpp: CTxMemPool pool; src/bench/mempool_stress.cpp: CTxMemPool pool; ``` Fixed in #24927. ----- ``` src/test/fuzz/rbf.cpp: CTxMemPool pool; src/test/fuzz/tx_pool.cpp: CTxMemPool tx_pool_{/*estimator=*/nullptr, /*check_ratio=*/1}; src/test/fuzz/tx_pool.cpp: CTxMemPool tx_pool_{/*estimator=*/nullptr, /*check_ratio=*/1}; src/test/fuzz/validation_load_mempool.cpp: CTxMemPool pool{}; ``` These are all cases where we don't want the `CTxMemPool` state to persist between runs, see the previous section "A note on using existing mempools" ----- ``` src/txmempool.h: /** Create a new CTxMemPool. ``` It's a comment (someone link me to a grep that understands syntax plz thx) ACKs for top commit: laanwj: Code review ACK d273e53b6e2cabd91a83f0ff0f9b6cfe1815b637 Tree-SHA512: c4ff3d23217a7cc4a7145defc7b901725073ef73bcac3a252ed75f672c87e98ca0368d1d8c3f606b5b49f641e7d8387d26ef802141b650b215876f191fb6d5f9
2022-06-16Merge bitcoin/bitcoin#25282: Bugfix: configure: Define default for use_libeventlaanwj
f0f5cd79b5d65c1c123400569c33745d8a6127ac Bugfix: configure: Define default for use_libevent (Luke Dashjr) Pull request description: Another trivial fix like #25051 - I think this is the only other one missing. ACKs for top commit: laanwj: Code review ACK f0f5cd79b5d65c1c123400569c33745d8a6127ac Tree-SHA512: 888c2e6d032ef1de5af635e2a9b2b8ab560c86bd10a6cee54aa9aa62ae43f03c19889bb6a2b64cf8982d4cd514f97ca3ed743c71ed0651e9295a4b1726955b9b
2022-06-16build: add and use CXX_STANDARD in dependsfanquake
generated by cgit v1.2.3 (git 2.26.2) at 2024-10-16 10:46:22 +0000