| Age | Commit message (Collapse) | Author |
|---|
|
This commit adds support for ckeys, or enCrypted private keys, to the wallet.
All keys are stored in memory in their encrypted form and thus the passphrase
is required from the user to spend coins, or to create new addresses.
Keys are encrypted with AES-256-CBC using OpenSSL's EVP library. The key is
calculated via EVP_BytesToKey using SHA512 with (by default) 25000 rounds and
a random salt.
By default, the user's wallet remains unencrypted until they call the RPC
command encryptwallet <passphrase> or, from the GUI menu, Options->
Encrypt Wallet.
When the user is attempting to call RPC functions which require the password
to unlock the wallet, an error will be returned unless they call
walletpassphrase <passphrase> <time to keep key in memory> first.
A keypoolrefill command has been added which tops up the users keypool
(requiring the passphrase via walletpassphrase first).
keypoolsize has been added to the output of getinfo to show the user the
number of keys left before they need to specify their passphrase (and call
keypoolrefill).
Note that walletpassphrase will automatically fill keypool in a separate
thread which it spawns when the passphrase is set. This could cause some
delays in other threads waiting for locks on the wallet passphrase, including
one which could cause the passphrase to be stored longer than expected,
however it will not allow the passphrase to be used longer than expected as
ThreadCleanWalletPassphrase will attempt to get a lock on the key as soon
as the specified lock time has arrived.
When the keypool runs out (and wallet is locked) GetOrReuseKeyFromPool
returns vchDefaultKey, meaning miners may start to generate many blocks to
vchDefaultKey instead of a new key each time.
A walletpassphrasechange <oldpassphrase> <newpassphrase> has been added to
allow the user to change their password via RPC.
Whenever keying material (unencrypted private keys, the user's passphrase,
the wallet's AES key) is stored unencrypted in memory, any reasonable attempt
is made to mlock/VirtualLock that memory before storing the keying material.
This is not true in several (commented) cases where mlock/VirtualLocking the
memory is not possible.
Although encryption of private keys in memory can be very useful on desktop
systems (as some small amount of protection against stupid viruses), on an
RPC server, the password is entered fairly insecurely. Thus, the only main
advantage encryption has for RPC servers is for RPC servers that do not spend
coins, except in rare cases, eg. a webserver of a merchant which only receives
payment except for cases of manual intervention.
Thanks to jgarzik for the original patch and sipa, gmaxwell and many others
for all their input.
Conflicts:
src/wallet.cpp
|
|
be on a page boundary.
|
|
Inline comment and idea come from the encprivkeys branch
by Matt Corallo <matt@bluematt.me>.
|
|
|
|
Fix synchronization of default key
|
|
Fix UPnP building, entirely my fault.
|
|
Also fix a minor type in gitian.yml
|
|
This reverts commit ee1f884229736da6f5443157ccba97f4e8f50f82.
Stupid, stupid me...there is exactly 0 way to convince make to
execute a conditional based on a target-specific variable.
|
|
|
|
Do not use comma as thousands separator
|
|
Added a couple minor things to match newer build process.
|
|
This adds the relevent patches which are applied to wx,
and updates for cross compiling.
|
|
Using the comma as thousands separator causes problems for parts of the world
where comma == decimal point. Germans sending 0,001 bitcoins are unpleasantly
surprised when that results in 1 BTC getting sent.
|
|
|
|
|
|
|
|
|
|
Give more detailed error messages for connection failure.
|
|
|
|
Make UPnP default on Bitcoin but not on Bitcoind.
|
|
Another Visual C++ Makefile Update
|
|
|
|
|
|
This is a bit of an ugly hack, but its the only way to do it.
|
|
rpc server: send '403 Forbidden' to rejected clients
|
|
Only use dnsseeds when not on testnet.
|
|
Updated Visual C++ Makefile
|
|
|
|
Limit size of response to getblocks
|
|
|
|
|
|
Introduce SendBufferSize() and ReceiveBufferSize(), and limit
the blocks sent as response to the "getblocks" message to
half of the active send buffer size.
|
|
Add new DNSSeed dnsseed.bluematt.me.
|
|
This seed will pull a random set of 20 nodes from the network which
are tested to be online instead of a static list.
|
|
Add OSX App bundle and correct build instructions to reflect reality.
|
|
added polish translation
|
|
Fix connection failure debug output
|
|
|
|
|
|
This problem was reported independently by laanwj in Issue #350.
|
|
Boost unit-testing framework. Thanks to Steve (gasteve in irc) for original code.
|
|
|
|
make -f makefile.{unix,osx,mingw} test_bitcoin
to compile dumb, do-almost-nothing placeholder unit tests.
|
|
Signed-off-by: Giel van Schijndel <me@mortis.eu>
|
|
In order to be a proper HTTP implementation clients that aren't allowed
to connect to the RPC server (using -rpcallowip), should receive a
proper HTTP response. So instead of closing the connection on them send
a '403 Forbidden' status.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
|
|
Fix segfault when creating new wallet
|
|
The initialization of the default key used keyUser instead
of vchDefaultKey. keyUser is now complete removed.
|
|
|
|
Edited init.cpp to include a check that -datadir exists
|
|
|
