aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-09-23Merge bitcoin/bitcoin#26160: [24.x] fuzz: Avoid timeout in bitdeque fuzz targetMacroFake
fa4ba04c157b83b827f7541fa007710bd6211fe7 fuzz: Remove no-op call to get() (MacroFake) fa642286b83f29cb0ac0c8d4c7d8eba10600402c fuzz: Avoid timeout in bitdeque fuzz target (MacroFake) Pull request description: Identical commit from https://github.com/bitcoin/bitcoin/pull/26012 Not strictly required for 24.x, but I guess it can't hurt to avoid timeouts. Top commit has no ACKs. Tree-SHA512: 4d4bfb645e3513bf22cc9c64bdcbde2ad9e28b5a07ab07a02fbfa19df02147b371d2ca794ab3a095c22b66781832055e0de3af908aaead4c26ea12189e05cbe3
2022-09-21Merge bitcoin/bitcoin#26145: [24.x] init: abort if i2p/cjdns are chosen via ↵fanquake
-onlynet but are unreachable 68209a7b5c0326e14508d9cf749771605bd6ffe7 rpc: make addpeeraddress work with cjdns addresses (Martin Zumsande) a8a9ed67cc447d204304ccfd844c45fd76486c6a init: Abort if i2p/cjdns are chosen via -onlynet but unreachable (Martin Zumsande) Pull request description: Identical commit from https://github.com/bitcoin/bitcoin/pull/25989 ACKs for top commit: fanquake: ACK 68209a7b5c0326e14508d9cf749771605bd6ffe7 Tree-SHA512: eec335df06b4c209cfe3473cb623828effd00c45a5dd605bb920edd265de1c789627482b005a51e89b8fc79cc4c5d26ff1fc306f2e4573897c5c7f083aa22861
2022-09-21Merge bitcoin/bitcoin#26144: [24.x] wallet: Fix nNextResend data race in ↵MacroFake
ResubmitWalletTransactions fad61573ed547615f73710cb59b2fb0ecafed127 Fix nNextResend data race in ResubmitWalletTransactions (MacroFake) Pull request description: Identical commit id from https://github.com/bitcoin/bitcoin/pull/26132 Top commit has no ACKs. Tree-SHA512: 9404e2e10ba059c412e282abbf9bef581cf5ddcac36cf05da1dff3927b5015e12469238c402c28308a774fdd969d1039e595d5e2caca0902977ae0a72746ff43
2022-09-20Fix nNextResend data race in ResubmitWalletTransactionsMacroFake
2022-09-20Merge bitcoin/bitcoin#26123: [24.x] doc: Move -permitbaremultisig to the ↵MacroFake
relay help category faf5bb87dab0984cc2d3ad02da21f3470243d17f doc: Move -permitbaremultisig to the relay help category (MacroFake) Pull request description: Identical commit from https://github.com/bitcoin/bitcoin/pull/26119 ACKs for top commit: glozow: ACK faf5bb87dab0984cc2d3ad02da21f3470243d17f jarolrod: ACK faf5bb87dab0984cc2d3ad02da21f3470243d17f Tree-SHA512: 42d3fd541703cbea7d2afff54dc7a42dac475c70c59ed124aba59cae6a87898040d964201e6cc6098e202f7b87bfa98513b3efd3c25d9fe52dc0ef55f3540bef
2022-09-19Merge bitcoin/bitcoin#26122: [24.x] Bump version to 24.0rc1v24.0rc1fanquake
ab4a32b8aff14da3f6d116b6a81ad0bb29397f1c doc: update version number in bips.md to v24.0 (fanquake) bd44c69238e3d147eeb3d77428445850e4cec1e3 doc: Generate example bitcoin conf for 24.0rc1 (fanquake) 06371697600c260e8c22683ad5a4cb6a97977443 doc: Generate manual pages for 24.0rc1 (fanquake) 7869b169f22ab51cca0d840fe51bc53dce2a0f3a build: Bump version to 24.0rc1 (fanquake) Pull request description: Bump the version to 24.0rc1 Generate the man pages. Generate the example bitcoin conf file. Update the version number in bips.md. ACKs for top commit: achow101: ACK ab4a32b8aff14da3f6d116b6a81ad0bb29397f1c Tree-SHA512: bb26216a4114b3c7e7a4b44abfee78a119b4b310b36bfac5124aa6cfc2d0a27ad30fa4b0d490fc214281973dde2c220e3c00e99b110ea5c6ccbe906f17ae3c89
2022-09-19doc: update version number in bips.md to v24.0fanquake
2022-09-19doc: Generate example bitcoin conf for 24.0rc1fanquake
2022-09-19doc: Generate manual pages for 24.0rc1fanquake
2022-09-19build: Bump version to 24.0rc1fanquake
2022-09-19Merge bitcoin/bitcoin#26005: Wallet: Fix error handling (copy_file failure ↵fanquake
in RestoreWallet, and in general via interfaces) c3e536555aa3a7db773170671da1256a2ace2094 Bugfix: Wallet: Return util::Error rather than non-error nullptr when CreateWallet/LoadWallet/RestoreWallet fail (Luke Dashjr) 335ff98c8a64eda38a2a2334102bd253f108c253 Bugfix: Wallet: Wrap RestoreWallet content in a try block to ensure exceptions become returned errors and incomplete wallet directory is removed (Luke Dashjr) Pull request description: Bug 1: `copy_file` can throw exceptions, but `RestoreWallet` is expected to return a nullptr with a populated `errors` parameter. This is fixed by wrapping `copy_file` and `LoadWallet` (for good measure) in a `try` block, and converting any exceptions to the intended return style. Bug 2: `util::Result` turns what would have been a `false` unique_ptr into a `true` nullptr result, which leads to nullptr dereferences in at least the 3 cases of wallet creation/loading/restoring. This is fixed by keeping the pointer as a plain `std::unique_ptr` until actually returning it (ie, after the nullptr check). Fixes https://github.com/bitcoin-core/gui/issues/661 ACKs for top commit: achow101: ACK c3e536555aa3a7db773170671da1256a2ace2094 Tree-SHA512: 4291b3dbbb147acea2e63a704324c9371bc16ecb4237f8753729b0b0a6e55c9758ad61bfe8bd432fd7b0bae95d8b63a9831e61ac8b8d5c0197b550a2e0f4a105
2022-09-19rpc: make addpeeraddress work with cjdns addressesMartin Zumsande
This allows us to add cjdns addresses to addrman for testing and debug purposes (if -cjdnsreachable is true)
2022-09-19init: Abort if i2p/cjdns are chosen via -onlynet but unreachableMartin Zumsande
...because -i2psam or -cjdnsreachable are not provided. This mimics existing behavior for -onlynet=onion and non-specified proxy.
2022-09-19Merge bitcoin/bitcoin#25540: miniscript: avoid wasteful computation, prevent ↵glozow
memory blowup when fuzzing e8cc2e4afc1142aa2b3da19cd5c17deea9963244 Make miniscript string parsing account for exact script size as bound (Pieter Wuille) 4cb8f9a92c0ab5d45f2e545bbc13fc3f2ec611ea Permit delaying duplicate key check in miniscript::Node construction (Pieter Wuille) Pull request description: As reported in https://github.com/bitcoin/bitcoin/pull/24860#discussion_r893109311, the current code to construct a `miniscript::Node` could cause a blowup on large fuzzer inputs. This is because: 1. The duplicate key check is redundantly done at parsing time, since we will recursively create miniscript nodes and the constructor will unconditionally look for duplicate across this node's keys and all its sub-nodes'. 2. We don't put an upper bound on the size of the inputs to consider for parsing. To avoid wasteful computation, and prevent the blowup on some fuzzer inputs, limit the size of reasonable inputs and only perform the check for duplicate keys once when parsing. Regarding the duplicate key check bypass in the constructor we iterated on different approaches, and eventually settled on passing a dummy argument. Albeit less elegant, all other approaches required getting rid of `std::make_shared` and adding an allocation *per node created*. This PR contains code from Pieter Wuille (see commits). Fixes https://github.com/bitcoin/bitcoin/pull/25824. ACKs for top commit: darosior: ACK e8cc2e4afc1142aa2b3da19cd5c17deea9963244 -- it's my own PR but most of the code here was written by sipa. I've reviewed and tested it. sipa: ACK e8cc2e4afc1142aa2b3da19cd5c17deea9963244 (for the few parts of the code that aren't mine) Tree-SHA512: c21de39b3eeb484393758629882fcf8694a9bd1b8f15ae22efcec1582efc9c2309c5a0c2d90f361dd8e233d704a07dcd5fb982f4a48a002c4d8789e1d78bb526
2022-09-19doc: Move -permitbaremultisig to the relay help categoryMacroFake
2022-09-18Merge bitcoin/bitcoin#26075: contrib: remove 32bit linux code from release ↵fanquake
scripts 656f9b0ba233dfc35763658e14a128487a1d1350 contrib: remove outdated comment from symbol-check script (fanquake) c36afe39ddcc5d94418b9e8309eb279a82b33978 contrib: remove 32bit linux code from release scripts (fanquake) Pull request description: We don't produce 32-bit Linux release binaries. Guix Build (x86_64 / arm64): ```bash 173c0caab1fc390fa2ccc58b8037e6b0456ac5f814fac84383afd0fcf8207471 guix-build-656f9b0ba233/output/aarch64-linux-gnu/SHA256SUMS.part 6d19c872dcad072de768e24f44ea517d3181783f0157f287b0d756b186264d3b guix-build-656f9b0ba233/output/aarch64-linux-gnu/bitcoin-656f9b0ba233-aarch64-linux-gnu-debug.tar.gz bd02655a22ca1e254034e250b5263ae65b5268f84cf3715da97c049c8b52834d guix-build-656f9b0ba233/output/aarch64-linux-gnu/bitcoin-656f9b0ba233-aarch64-linux-gnu.tar.gz adaf2e7ea8940716be066fd7669686afc1f6d493738ae257c1963955f41d5d04 guix-build-656f9b0ba233/output/arm-linux-gnueabihf/SHA256SUMS.part 619db8a6ce4740933126e6aa397e982ea9323b6e9641825d32673e009eceed1d guix-build-656f9b0ba233/output/arm-linux-gnueabihf/bitcoin-656f9b0ba233-arm-linux-gnueabihf-debug.tar.gz f73e3c1e7051d09b0bdaf8e0c67339b8eef9dec152817e418b878f8165688a42 guix-build-656f9b0ba233/output/arm-linux-gnueabihf/bitcoin-656f9b0ba233-arm-linux-gnueabihf.tar.gz de7c35702b2e585b479fbbda8e43b611200ad87cd6a67c04786fe44ee5aec9bb guix-build-656f9b0ba233/output/arm64-apple-darwin/SHA256SUMS.part 53235690d0203b7ea8f53797b7f6c387d35d66ddf0cd9d620260e301e834275f guix-build-656f9b0ba233/output/arm64-apple-darwin/bitcoin-656f9b0ba233-arm64-apple-darwin-unsigned.dmg 0b2a60d6cbf12e09917e7072fd5dfe343757f6ff77ad53e1b214be019bf60f25 guix-build-656f9b0ba233/output/arm64-apple-darwin/bitcoin-656f9b0ba233-arm64-apple-darwin-unsigned.tar.gz 8240ba04bd9e743684a70fceb8c0e57c295e6bf9b987f9506a013418917d4d48 guix-build-656f9b0ba233/output/arm64-apple-darwin/bitcoin-656f9b0ba233-arm64-apple-darwin.tar.gz a83c4a6fdb2aa07f21c85ffb6fb58d188e55b6a68ed9431e7562a75168511f70 guix-build-656f9b0ba233/output/dist-archive/bitcoin-656f9b0ba233.tar.gz f18254bc90cabbf2311d61aa13c2b33cc205bd8c1ec3b488be6579cc7a744d69 guix-build-656f9b0ba233/output/powerpc64-linux-gnu/SHA256SUMS.part 193fdaf1bd85ca69825ad7462dce7bcc874a196913fd4aa9e830d19696fb336d guix-build-656f9b0ba233/output/powerpc64-linux-gnu/bitcoin-656f9b0ba233-powerpc64-linux-gnu-debug.tar.gz d12266e5d73ec40c9a356bdf2118b3e186a0675aa66a76097f3170e213a2918d guix-build-656f9b0ba233/output/powerpc64-linux-gnu/bitcoin-656f9b0ba233-powerpc64-linux-gnu.tar.gz 71e779a3a96959ce3d04de605dbe886741166a56e3599a63867ea6bfd7b2ad2f guix-build-656f9b0ba233/output/powerpc64le-linux-gnu/SHA256SUMS.part 621b9707a8d7a0806703aadec91d1c8ecf8979d0c8e58f3af67881114386fece guix-build-656f9b0ba233/output/powerpc64le-linux-gnu/bitcoin-656f9b0ba233-powerpc64le-linux-gnu-debug.tar.gz 957ebd909f209d2308f9e18241354b7c460267e2d9964daad383be94f4470eb6 guix-build-656f9b0ba233/output/powerpc64le-linux-gnu/bitcoin-656f9b0ba233-powerpc64le-linux-gnu.tar.gz c70dfcc02b3bf11352ae4842dba73748bc59454303506bba046d620a7ff302e2 guix-build-656f9b0ba233/output/riscv64-linux-gnu/SHA256SUMS.part 5c71397b29ea73666a9e8b23c1948dcfb00478a5cd8aa0442d5f8065b1a7bef8 guix-build-656f9b0ba233/output/riscv64-linux-gnu/bitcoin-656f9b0ba233-riscv64-linux-gnu-debug.tar.gz 0d413d7f483872699f878ce8102a9c8e91ee889cb791396e0a750062481e3340 guix-build-656f9b0ba233/output/riscv64-linux-gnu/bitcoin-656f9b0ba233-riscv64-linux-gnu.tar.gz 0a22a1c8ea57b25a2372192279ef2584f8ccf06f219a72436293f52294fa3b9a guix-build-656f9b0ba233/output/x86_64-apple-darwin/SHA256SUMS.part be8d4766384eb8d582a58ad0cb8ac04f456afc74f0ada24f04a839fa1c16f8d9 guix-build-656f9b0ba233/output/x86_64-apple-darwin/bitcoin-656f9b0ba233-x86_64-apple-darwin-unsigned.dmg 1e5bd0eeb22dbae7c347e722267f6317a221abb9e610d1208c13d93cbcd6f881 guix-build-656f9b0ba233/output/x86_64-apple-darwin/bitcoin-656f9b0ba233-x86_64-apple-darwin-unsigned.tar.gz 6f0b3986689ad1da6945f2cc9706753204a7bc625fd1a48d3952c2f71a8114be guix-build-656f9b0ba233/output/x86_64-apple-darwin/bitcoin-656f9b0ba233-x86_64-apple-darwin.tar.gz bacaff5157ef53cf4e8087b166272f03e16a7b9b8eb2258b0cac8169666f721b guix-build-656f9b0ba233/output/x86_64-linux-gnu/SHA256SUMS.part e822e98f8c44e8b7760542780a2e3c7e41f0c245764a5126af235603d455b93c guix-build-656f9b0ba233/output/x86_64-linux-gnu/bitcoin-656f9b0ba233-x86_64-linux-gnu-debug.tar.gz 270e66fc16dd3e2a825c7b01f51caa242354279be4b65fe6ed0d438405b7dc38 guix-build-656f9b0ba233/output/x86_64-linux-gnu/bitcoin-656f9b0ba233-x86_64-linux-gnu.tar.gz 42b67a4eff63956604f06af5919a45d0c8fd43d4bfa4a0d3b3dda3b2684e8ef0 guix-build-656f9b0ba233/output/x86_64-w64-mingw32/SHA256SUMS.part 04a9d09af75622cadc405ba4d0db251f643fd6d8e5bdffe94a283b53c77d9d83 guix-build-656f9b0ba233/output/x86_64-w64-mingw32/bitcoin-656f9b0ba233-win64-debug.zip 463b2188a1710917e5faba55f2f4bce72ad3188860e3736643f860493b464c27 guix-build-656f9b0ba233/output/x86_64-w64-mingw32/bitcoin-656f9b0ba233-win64-setup-unsigned.exe d9e27f2d99a83b4d3dc689ec1a69c08d580bb1b77f0f83298fd3586bd61517bb guix-build-656f9b0ba233/output/x86_64-w64-mingw32/bitcoin-656f9b0ba233-win64-unsigned.tar.gz 51e45cd129d62bc810654b5ca235c7d52d9d5a93bce244c18b1bbe9d70ec61fc guix-build-656f9b0ba233/output/x86_64-w64-mingw32/bitcoin-656f9b0ba233-win64.zip ``` ACKs for top commit: hebasto: ACK 656f9b0ba233dfc35763658e14a128487a1d1350 Tree-SHA512: a82338634cb24ea16689aaee30985e5c12316fbf95b17c683a709d4e0cb0d7ba7c9dd0da6aecb1eb1aa6edca2b476479c91a58906b974c3cb1d465c07a963787
2022-09-17Make miniscript string parsing account for exact script size as boundPieter Wuille
Co-Authored-by: Antoine Poinsot <darosior@protonmail.com>
2022-09-17Permit delaying duplicate key check in miniscript::Node constructionPieter Wuille
2022-09-16Bugfix: Wallet: Return util::Error rather than non-error nullptr when ↵Luke Dashjr
CreateWallet/LoadWallet/RestoreWallet fail
2022-09-16Bugfix: Wallet: Wrap RestoreWallet content in a try block to ensure ↵Luke Dashjr
exceptions become returned errors and incomplete wallet directory is removed
2022-09-16contrib: remove outdated comment from symbol-check scriptfanquake
2022-09-16contrib: remove 32bit linux code from release scriptsfanquake
2022-09-16Merge bitcoin/bitcoin#26087: build: prune BOOST_CPPFLAGS from libbitcoin_zmqfanquake
a10df7cf351e3947ba2d6cd1357d2c3348f8559a build: prune BOOST_CPPFLAGS from libbitcoin_zmq (fanquake) Pull request description: Rather than including `validation.h`, which ultimately means needing boost via `txmempool.h`, include `primitives/block.h` for `CBlock`, and remove `validation.h`, as we can get `cs_main` from `node/blockstorage.h`. ACKs for top commit: theuni: Nice. ACK a10df7cf351e3947ba2d6cd1357d2c3348f8559a. hebasto: ACK a10df7cf351e3947ba2d6cd1357d2c3348f8559a, tested on Linux x86_64 using theuni's [patch](https://github.com/theuni/bitcoin/commit/e131d8f1e33baa9a9499d2e1a4a99b171566c5a5) with depends. Tree-SHA512: 792b6f9e7e7788d10333b4943609efbc798f3b187c324a0f2d5acbb2d44e3c67705dc54d698eb04c23e5af7b8b73a47f8e7974e819eac12f12ae62f28c807476
2022-09-16Merge bitcoin/bitcoin#26107: [test] only run feature_rbf.py onceMacroFake
667401a8557f94a3e0b7ec17096077dd8985eac7 [test] only run feature_rbf.py once (glozow) Pull request description: There is no need to run this test twice with --descriptors and --legacy-wallet, as it doesn't use the wallet. ACKs for top commit: aureleoules: ACK 667401a8557f94a3e0b7ec17096077dd8985eac7. theStack: ACK 667401a8557f94a3e0b7ec17096077dd8985eac7 brunoerg: ACK 667401a8557f94a3e0b7ec17096077dd8985eac7 Tree-SHA512: 339213159fac29ebc5678461fae41645aed57877d5525e8ca4755890b869a17ae0bea3f590114769c84b71a7df20c59c9530ab8b327912151c82ec58022f7e71
2022-09-16Merge bitcoin/bitcoin#26086: build: remove BOOST_CPPFLAGS usage from bitcoin-txfanquake
f839697d9b89002d020997154e182ddb4dccf45b build: remove BOOST_CPPFLAGS usage from bitcoin-tx (fanquake) Pull request description: The only reason `BOOST_CPPFLAGS` was needed here, is because of the `policy/rbf.h` include, which ultimately includes boost multi_index via `txmempool.h`. However this include is unused. ACKs for top commit: theuni: Nice. ACK f839697d9b89002d020997154e182ddb4dccf45b. hebasto: ACK f839697d9b89002d020997154e182ddb4dccf45b, tested on Linux x86_64 using theuni's [patch](https://github.com/theuni/bitcoin/commit/e131d8f1e33baa9a9499d2e1a4a99b171566c5a5) with depends. Tree-SHA512: ec93f4045d927789d70e2a96a6869c0df63891483bb61361327bfefafaabc2925f63382aa3d9302963df2306bc035edad4cabd5eeb315db6603266e677be7cd3
2022-09-16Merge bitcoin/bitcoin#25918: build: prune event2 compat headersfanquake
22dada5d1744c3e6f1a38ef1b3f5a93cba6e3163 build: prune compat event headers (fanquake) Pull request description: The `*_compat` headers are the deprecated / non-threadsafe function containing versions of the current headers. There's no need for us to ship them in depends. Prune them to save the safe / nuke the possibility of them being used. Guix Build (x86_64): ```bash 4f48b4987101c3624673ab0a19daad5b99cb3c99b273d96a65e77cbbc3813444 guix-build-22dada5d1744/output/aarch64-linux-gnu/SHA256SUMS.part 8296443d555666628d43be42c507e15856ee8e611738a1cdf4bdb731e1d75264 guix-build-22dada5d1744/output/aarch64-linux-gnu/bitcoin-22dada5d1744-aarch64-linux-gnu-debug.tar.gz dc986fe901d2fdfd2596325798ac8da3d3170ef66dfd3a4eb8804a3883c9e133 guix-build-22dada5d1744/output/aarch64-linux-gnu/bitcoin-22dada5d1744-aarch64-linux-gnu.tar.gz dcb142a1b2b9370cb2e3bf52853afc66ca9abede97189da8b05ecf5563054fb0 guix-build-22dada5d1744/output/arm-linux-gnueabihf/SHA256SUMS.part 5e42eef5e8bc618878647e782a307f5a7780ffc1a263b3466d277341fdc33e2b guix-build-22dada5d1744/output/arm-linux-gnueabihf/bitcoin-22dada5d1744-arm-linux-gnueabihf-debug.tar.gz 4d766d4799e354c24973396eb97efefb356847b2b35a5540d2861ea8010ed8ca guix-build-22dada5d1744/output/arm-linux-gnueabihf/bitcoin-22dada5d1744-arm-linux-gnueabihf.tar.gz a174b3da7a4a66210dafb4c7b1742e6fcefa2ac2d7e332cb1bd2e7d909fe2728 guix-build-22dada5d1744/output/arm64-apple-darwin/SHA256SUMS.part 010fb348996a7ba55746d02ba83ad0638768c235015b23b84ab1fea5dc50fc55 guix-build-22dada5d1744/output/arm64-apple-darwin/bitcoin-22dada5d1744-arm64-apple-darwin-unsigned.dmg 163a3e5f8ad71e41ce52a1f1f1281fbcbc73cfc66500345eae1ca99c3f5fba85 guix-build-22dada5d1744/output/arm64-apple-darwin/bitcoin-22dada5d1744-arm64-apple-darwin-unsigned.tar.gz bf88d8ab9d70be73e9d7b14053e7a9c5cf6641ccef8f100f6f6fba7762e8092e guix-build-22dada5d1744/output/arm64-apple-darwin/bitcoin-22dada5d1744-arm64-apple-darwin.tar.gz d60415586a2d66558e816bc2be8b7a74f111b944ddb15e5a8e9c6331a0436083 guix-build-22dada5d1744/output/dist-archive/bitcoin-22dada5d1744.tar.gz 665a9677417a1931382cf5dbeab29c84f642da31cf3258b5879ebd29ad43bed8 guix-build-22dada5d1744/output/powerpc64-linux-gnu/SHA256SUMS.part 0e2551558bd40657bf0cc3cbd03b4bfdf3b87ac07258dc8751d616af5fce729d guix-build-22dada5d1744/output/powerpc64-linux-gnu/bitcoin-22dada5d1744-powerpc64-linux-gnu-debug.tar.gz fd771b607cc5749b666ddd995f47ff7ba8e0e46d811abb295636cc90270ed30a guix-build-22dada5d1744/output/powerpc64-linux-gnu/bitcoin-22dada5d1744-powerpc64-linux-gnu.tar.gz 117e11774ab23f6302c363f710ea68367f8fa80342d8a8919775db76864fc151 guix-build-22dada5d1744/output/powerpc64le-linux-gnu/SHA256SUMS.part 6e10bc01e2352d8db7eb16328206ee622fc2605a87d203f134e6137954789ce8 guix-build-22dada5d1744/output/powerpc64le-linux-gnu/bitcoin-22dada5d1744-powerpc64le-linux-gnu-debug.tar.gz 1825d5bda86f6fd247c43cbf1922e0bcd60a0637233c6eb95d58917751eb2e3a guix-build-22dada5d1744/output/powerpc64le-linux-gnu/bitcoin-22dada5d1744-powerpc64le-linux-gnu.tar.gz 15ea9e04d72ebe4fd446698f71bf45c76b7e5bb8bdd5e027250d6efe1ac3ddfa guix-build-22dada5d1744/output/riscv64-linux-gnu/SHA256SUMS.part 7cf329951c79ccdf700f9283b5e55990eb85c9f11e74ee3672a15f5e5c1250f8 guix-build-22dada5d1744/output/riscv64-linux-gnu/bitcoin-22dada5d1744-riscv64-linux-gnu-debug.tar.gz 5a73600f715e01823e9ede02376fc6538680996c713d04ccc8b2ae0caa6b476c guix-build-22dada5d1744/output/riscv64-linux-gnu/bitcoin-22dada5d1744-riscv64-linux-gnu.tar.gz f5b30bcea748e78b125fa4da979038627e9a15b7a20f002f53538b4dbeed2c5d guix-build-22dada5d1744/output/x86_64-apple-darwin/SHA256SUMS.part f649de898e0e2aebf7e94ee0fbd2d7011a789b235e0c9c151f33e0b9ad0fa132 guix-build-22dada5d1744/output/x86_64-apple-darwin/bitcoin-22dada5d1744-x86_64-apple-darwin-unsigned.dmg 9f36c3d2edfd5f5b8d1833bb54f9fe0b91805de85828fed211d4d1e43c9d0fe3 guix-build-22dada5d1744/output/x86_64-apple-darwin/bitcoin-22dada5d1744-x86_64-apple-darwin-unsigned.tar.gz 43b1c1880858a6a1c94bd2004d25172f0d12e5e6042c83f1905eda6252a0febb guix-build-22dada5d1744/output/x86_64-apple-darwin/bitcoin-22dada5d1744-x86_64-apple-darwin.tar.gz ce7b249b3349f5c272484fd108239260c70eb6c9d2afcf2031650f7cbb09cd17 guix-build-22dada5d1744/output/x86_64-linux-gnu/SHA256SUMS.part ea6d8ffd517a07cb8c1806e6d4bf90dd5784db76bb8cb3ea0f747da92672a7f6 guix-build-22dada5d1744/output/x86_64-linux-gnu/bitcoin-22dada5d1744-x86_64-linux-gnu-debug.tar.gz 18bed83f2384d8952c86c760f012fe870922a8cccaeb1181176bd05f06b43436 guix-build-22dada5d1744/output/x86_64-linux-gnu/bitcoin-22dada5d1744-x86_64-linux-gnu.tar.gz 1836ad08ef45635dc2f5f49f48b0a812290b7cce23974474cc6a1db9e779d54e guix-build-22dada5d1744/output/x86_64-w64-mingw32/SHA256SUMS.part 37c859523561a9dedd956ef235189eb4335396f0be154cb36aa35cb0cd4f1b93 guix-build-22dada5d1744/output/x86_64-w64-mingw32/bitcoin-22dada5d1744-win64-debug.zip d574828d8a7c3ddcdc1ea1cf686ba7102a25b7403d338d896ef0e9a57e3b5611 guix-build-22dada5d1744/output/x86_64-w64-mingw32/bitcoin-22dada5d1744-win64-setup-unsigned.exe 20828fd22d8b2104747440a180d4a944912244f405061c29fb58a8e19604dcbd guix-build-22dada5d1744/output/x86_64-w64-mingw32/bitcoin-22dada5d1744-win64-unsigned.tar.gz a0ecdec301e54cb65e35badae05d94338ec33b03e0b4e0f332025ce5248fd74a guix-build-22dada5d1744/output/x86_64-w64-mingw32/bitcoin-22dada5d1744-win64.zip ``` ACKs for top commit: hebasto: ACK 22dada5d1744c3e6f1a38ef1b3f5a93cba6e3163 Tree-SHA512: 8a042b25a8081678465fd00b615f8007a4be65c4d383725586e4b5f1b89638ad7d9eaba6113a8d96413aa774ec15b6593b0a364b593db8cdbb09e80e0b358109
2022-09-16Merge bitcoin/bitcoin#25971: refactor: Use std::string for thread and index ↵MacroFake
names 26cf9ea8e44d7fd6450336f567afaedd1275baf7 scripted-diff: rename pszThread to thread_name (stickies-v) 200d84d5681918523d982b9ddf60d1127edcb448 refactor: use std::string for index names (stickies-v) 97f5b20c12ca6ccf89d7720a5d41eaf4cda1b695 refactor: use std::string for thread names (stickies-v) Pull request description: As a follow-up to https://github.com/bitcoin/bitcoin/pull/25967#discussion_r959637189, this PR changes the return type of [`BaseIndex::GetName()`](https://github.com/bitcoin/bitcoin/blob/fa5c224d444802dabec5841009e029b9754c92f1/src/index/base.h#L120) to `const std::string&` instead of `const char*`. The first commit is not essential for this change, but since the code is touched and index names are commonly used to specify thread names, I've made the same update there. No behaviour change, just refactoring to further phase out C-style strings. Note: `util::ThreadRename()` used to take an rvalue ref, but since it then passes this to `SetInternalName()` by value, I don't think there's any benefit to having both an rvalue and lvalue ref function so I just changed it into lvalue ref. Not 100% sure I'm missing something? ACKs for top commit: MarcoFalke: review ACK 26cf9ea8e44d7fd6450336f567afaedd1275baf7 only change is new scripted-diff 😀 hebasto: ACK 26cf9ea8e44d7fd6450336f567afaedd1275baf7, I have reviewed the code and it looks OK. w0xlt: reACK https://github.com/bitcoin/bitcoin/pull/25971/commits/26cf9ea8e44d7fd6450336f567afaedd1275baf7 Tree-SHA512: 44a03ebf2bb86ca1411a36222a575217cdba8ee3a3c985e74d74c934516f002b27336147fa22f59eda7dac21204a93951563317005d475da95b23c427014d77b
2022-09-16Merge bitcoin/bitcoin#25499: Use steady clock for all millis bench loggingfanquake
fa521c960337a65d4ce12cd1ef009c652ffe57e6 Use steady clock for all millis bench logging (MacroFake) Pull request description: Currently `GetTimeMillis` is used for bench logging in milliseconds integral precision. Replace it to use a steady clock that is type-safe and steady. Microsecond or float precision can be done in a follow-up. ACKs for top commit: fanquake: ACK fa521c960337a65d4ce12cd1ef009c652ffe57e6 - started making the same change. Tree-SHA512: 86a810e496fc663f815acb8771a6c770331593715cde85370226685bc50c13e8e987e3c5efd0b4e48b36ebd2372255357b709204bac750d41e94a9f7d9897fa6
2022-09-16Merge bitcoin/bitcoin#26057: build, guix: Get rid of perl dependencyfanquake
d0433a31534d49d628ad4eec21fc8a5b00f4d129 guix: Drop perl package (Hennadii Stepanov) 55e468f149c54b71872594176447016703c80c55 build: Add `-no-mimetype-database` option to qt package in depends (Hennadii Stepanov) Pull request description: Perl is required only in Qt to create its own MIME database, which we never use. Guix build on `x86_64`: ``` b63983137239de664edba06834d48fbfc1957d4c56aaf1b2c4cd253bad2856f9 guix-build-d0433a31534d/output/aarch64-linux-gnu/SHA256SUMS.part f4ea6d24a0248f573a0e6e207f872a964ad061459837e3c44ddc2257871349f9 guix-build-d0433a31534d/output/aarch64-linux-gnu/bitcoin-d0433a31534d-aarch64-linux-gnu-debug.tar.gz 00efef73311e2a231255f7e2010d5a77ec986b60be26be10f27dc24aa84382c7 guix-build-d0433a31534d/output/aarch64-linux-gnu/bitcoin-d0433a31534d-aarch64-linux-gnu.tar.gz 8eaf54f1d867b8279e5bf7db9d57a86b9d63dbb7f17bc8df131336781325ca25 guix-build-d0433a31534d/output/arm-linux-gnueabihf/SHA256SUMS.part 1fc60e3086e09cefef8f3848787c4bf601a017a5e75a1dd322c81916ad737d30 guix-build-d0433a31534d/output/arm-linux-gnueabihf/bitcoin-d0433a31534d-arm-linux-gnueabihf-debug.tar.gz 92b51c48dd7aeb1853345bc17f433c56c3704755008fbe2d5b203145af87b667 guix-build-d0433a31534d/output/arm-linux-gnueabihf/bitcoin-d0433a31534d-arm-linux-gnueabihf.tar.gz 7daadc27af84bfeab98802481c3dbce852613b712db1711f5bf67c36ad54414a guix-build-d0433a31534d/output/arm64-apple-darwin/SHA256SUMS.part 2d1de48b0acfdd6aa3a5dd7c97557463d11ef8a2a12b2227bf555a8d387c3db9 guix-build-d0433a31534d/output/arm64-apple-darwin/bitcoin-d0433a31534d-arm64-apple-darwin-unsigned.dmg a1fd2d0103295b4a3bda8f8be39df2bb3cef1be18235c20f7a4f13e4f839b9b0 guix-build-d0433a31534d/output/arm64-apple-darwin/bitcoin-d0433a31534d-arm64-apple-darwin-unsigned.tar.gz abb9c9f2a2506205a236240de3fc602d9bc884a19a8d64ede2d9abf03c29141c guix-build-d0433a31534d/output/arm64-apple-darwin/bitcoin-d0433a31534d-arm64-apple-darwin.tar.gz 13f21eb33c2d0719da0bd5227ea58e5bb625a7fd0bd2af8d1a13efe7a00ab46c guix-build-d0433a31534d/output/dist-archive/bitcoin-d0433a31534d.tar.gz 0a83e8b591fd79d0493f381f1fc849ed89428e43794c9f791e5ee36fa6b945b8 guix-build-d0433a31534d/output/powerpc64-linux-gnu/SHA256SUMS.part 56b592cf691ef22557a03d6083a0603b45caa6ebfd17c0dda6fc870c8612a19f guix-build-d0433a31534d/output/powerpc64-linux-gnu/bitcoin-d0433a31534d-powerpc64-linux-gnu-debug.tar.gz 9d72a57f5bd509aaf48c18bf7d8b27861722242aa85036e7c6512983e6f102ee guix-build-d0433a31534d/output/powerpc64-linux-gnu/bitcoin-d0433a31534d-powerpc64-linux-gnu.tar.gz 0512992f6ee3ca2693121cd4bcb45a23de7759ccd87db67e4f091ada75fca3e1 guix-build-d0433a31534d/output/powerpc64le-linux-gnu/SHA256SUMS.part b3ccdeac6bc7c36ce5792018dbad81b18a6fb62c4fc67df820796e70f4630100 guix-build-d0433a31534d/output/powerpc64le-linux-gnu/bitcoin-d0433a31534d-powerpc64le-linux-gnu-debug.tar.gz f4c11cbd56431f5d257dff881a46d7ddf83b3d3a2e05c5e88e5575c4bb552960 guix-build-d0433a31534d/output/powerpc64le-linux-gnu/bitcoin-d0433a31534d-powerpc64le-linux-gnu.tar.gz ad71196a5af12eedb906fb009b8f635933fa2bf83586b4b2360f6b84f52998ca guix-build-d0433a31534d/output/riscv64-linux-gnu/SHA256SUMS.part 6fe7dbb772e91dccec781b4d7a47cc8179ba0fb4614a3da6423679a4539ae96e guix-build-d0433a31534d/output/riscv64-linux-gnu/bitcoin-d0433a31534d-riscv64-linux-gnu-debug.tar.gz f8fb450f627791b20e56d00bc9544984120fe22d9644318bc01cf027914b7338 guix-build-d0433a31534d/output/riscv64-linux-gnu/bitcoin-d0433a31534d-riscv64-linux-gnu.tar.gz fb741950e3699fe2ffa44754e493a28b06c00ce12f9a4c073e38dd960bfe805d guix-build-d0433a31534d/output/x86_64-apple-darwin/SHA256SUMS.part 47dfb3eb3526c319ed528c24f19dda4ee3e6e03ca36d62f31207bad65083be76 guix-build-d0433a31534d/output/x86_64-apple-darwin/bitcoin-d0433a31534d-x86_64-apple-darwin-unsigned.dmg 4e306e35e7c885791694762d10fbc4e563466a2240036c3e1fc877c2806ac583 guix-build-d0433a31534d/output/x86_64-apple-darwin/bitcoin-d0433a31534d-x86_64-apple-darwin-unsigned.tar.gz ac71e5164142225fc018f47d278d5450a28de05259f41437a7c4183708d8681d guix-build-d0433a31534d/output/x86_64-apple-darwin/bitcoin-d0433a31534d-x86_64-apple-darwin.tar.gz f670fbe6652211d57dca9c79a6e37023b40d32117cf5e0d28dd9ba6247af1d61 guix-build-d0433a31534d/output/x86_64-linux-gnu/SHA256SUMS.part 94b23c572cac60f7ce1f7851e1aa0c8d41cc5fa5863089027aa8d524b6940d91 guix-build-d0433a31534d/output/x86_64-linux-gnu/bitcoin-d0433a31534d-x86_64-linux-gnu-debug.tar.gz 6d48a676f126eea585ab352c6bc923341903d891da6e8c4d4e2e168b8d6c4820 guix-build-d0433a31534d/output/x86_64-linux-gnu/bitcoin-d0433a31534d-x86_64-linux-gnu.tar.gz 23bb6919646725bfe35f4e3eb1beedb3ee4f49dc0b410d47185a2e06fb0184e3 guix-build-d0433a31534d/output/x86_64-w64-mingw32/SHA256SUMS.part a92202b0c397aede252c433dbf83d5094141d5263f32d1078a052da7cf23059b guix-build-d0433a31534d/output/x86_64-w64-mingw32/bitcoin-d0433a31534d-win64-debug.zip 11d84ad174e12f3342764b47f42e32a55bd6d277416dcf6b05556173ace48430 guix-build-d0433a31534d/output/x86_64-w64-mingw32/bitcoin-d0433a31534d-win64-setup-unsigned.exe 436364e555e57090472600b5486af8bdefe0baaab7441b919e23f90d01a3347f guix-build-d0433a31534d/output/x86_64-w64-mingw32/bitcoin-d0433a31534d-win64-unsigned.tar.gz e193bf3179194d68d88e295d0ef830ef77ddb504bc0f9aa17f84b537b275ddde guix-build-d0433a31534d/output/x86_64-w64-mingw32/bitcoin-d0433a31534d-win64.zip ``` ACKs for top commit: fanquake: ACK d0433a31534d49d628ad4eec21fc8a5b00f4d129 - with the cavaet that I haven't looked at the qt changes, or the effects of using the `-no-mimetype-database` flag, at all. Also performed a Guix build from scratch with this branch rebased on master. jarolrod: ACK d0433a31534d49d628ad4eec21fc8a5b00f4d129 Tree-SHA512: d6dc9bb19e793027d818aee0e248e59fdbf4f4ff46d55538f30e1731254c4739de342a3e917ae7d3f3bc1b6451667b9e8984a6522a1fcece7891c51502a420e8
2022-09-16Merge bitcoin/bitcoin#26105: Use ReadLE64 in uint256::GetUint64 instead of ↵fanquake
duplicating logic 04fee75bacb9ec3bceff1246ba6c8ed8a8759548 Use ReadLE64 in uint256::GetUint64() instead of duplicating logic (Pieter Wuille) Pull request description: No need to have a (naive) copy of the `ReadLE64` logic inside `uint256::GetUint64`, when we have an optimized function for exactly that. ACKs for top commit: davidgumberg: ACK 04fee75bacb9ec3bceff1246ba6c8ed8a8759548 jonatack: ACK 04fee75bacb9ec3bceff1246ba6c8ed8a8759548 review, this use of ReadLE64() is similar to the existing invocation by Num3072::Num3072(), sanity checked that before and after this change GetUint64() returns the same result (debug build, clang 13) Tree-SHA512: 0fc2681536a18d82408411bcc6d5c6445fb96793fa43ff4021cd2933d46514c725318da35884f428d1799023921f33f8af091ef428ceb96a50866ac53a345356
2022-09-16Merge bitcoin/bitcoin#26065: i2p: use the same destination type for ↵fanquake
transient and persistent addresses 8b2891a6d10f4a3875010d2e8eafd78bcf378952 i2p: use the same destination type for transient and persistent addresses (Vasil Dimov) Pull request description: We generate our persistent I2P address with type `EdDSA_SHA512_Ed25519` (`DEST GENERATE SIGNATURE_TYPE=7`). Use the same type for our transient addresses which are created by the `SESSION CREATE ...` command. If not specified, then the default one is `DSA_SHA1` according to https://geti2p.net/en/docs/api/samv3. Fixes https://github.com/bitcoin/bitcoin/issues/26062 ACKs for top commit: mzumsande: ACK 8b2891a6d10f4a3875010d2e8eafd78bcf378952 sipa: utACK 8b2891a6d10f4a3875010d2e8eafd78bcf378952; didn't test but verified this matches the documentation Tree-SHA512: 1b10e7e1e274b77609d08ee9cf9d73fef8c975c51aec452ce23e15fcf41709398c697087bfdece121b1fd26bc0501fc45857a91aaab679cadd0cbb37dd94c3a7
2022-09-16Merge bitcoin/bitcoin#26093: doc: consolidate release-note fragments pre-wikiMacroFake
b0349a7d9504b214fedb57775c32dc3e3289ed9d doc: consolidate & remove release-note fragments (fanquake) Pull request description: The formatting / ordering doesn't matter a great deal here, given this will shortly be moving to the wiki for further additions / formatting changes etc. ACKs for top commit: MarcoFalke: ACK b0349a7d9504b214fedb57775c32dc3e3289ed9d achow101: ACK b0349a7d9504b214fedb57775c32dc3e3289ed9d jarolrod: ACK b0349a7d9504b214fedb57775c32dc3e3289ed9d Tree-SHA512: 80d2f9f25bc13d407ab9fd0473ff02043a1e6b9895e27d3229d717d357606063472582d31bc1b4058741d2e34be806ef1460acd66d43d6493562ffcf3f6defa5
2022-09-15Use ReadLE64 in uint256::GetUint64() instead of duplicating logicPieter Wuille
2022-09-15Merge bitcoin/bitcoin#26024: wallet: fix sendall creates tx that fails ↵Andrew Chow
tx-size check cc434cbf583ec8d1b0f3aa504417231fdc81f33a wallet: fix sendall creates tx that fails tx-size check (kouloumos) Pull request description: Fixes https://github.com/bitcoin/bitcoin/issues/26011 The `sendall` RPC doesn't use `CreateTransactionInternal` as the rest of the wallet RPCs. [This has already been discussed in the original PR](https://github.com/bitcoin/bitcoin/pull/24118#issuecomment-1029462114). By not going through that path, it never checks the transaction's weight against the maximum tx weight for transactions we're willing to relay. https://github.com/bitcoin/bitcoin/blob/447f50e4aed9a8b1d80e1891cda85801aeb80b4e/src/wallet/spend.cpp#L1013-L1018 This PR adds a check for tx-size as well as test coverage for that case. _Note: It seems that the test takes a bit of time on slower machines, I'm not sure if dropping it might be for the better._ ACKs for top commit: glozow: re ACK cc434cb via range-diff. Changes were addressing https://github.com/bitcoin/bitcoin/pull/26024#discussion_r971325299 and https://github.com/bitcoin/bitcoin/pull/26024#discussion_r970651614. achow101: ACK cc434cbf583ec8d1b0f3aa504417231fdc81f33a w0xlt: reACK https://github.com/bitcoin/bitcoin/pull/26024/commits/cc434cbf583ec8d1b0f3aa504417231fdc81f33a Tree-SHA512: 64a1d8f2c737b39f3ccee90689eda1dd9c1b65f11b2c7bc0ec8bfe72f0202ce90ab4033bb0ecfc6080af8c947575059588a00938fe48e7fd553f7fb5ee03b3cc
2022-09-15Merge bitcoin/bitcoin#26091: test: Fix syncwithvalidationinterfacequeue callsAndrew Chow
fa1ce96184a1815f453e64e14d77cb0025800be9 test: Add missing syncwithvalidationinterfacequeue (MacroFake) faa4916529699f9a057e2bf2459d957bcec1de84 test/doc: Remove unused syncwithvalidationinterfacequeue (MacroFake) Pull request description: Fixes #26071 ACKs for top commit: achow101: ACK fa1ce96184a1815f453e64e14d77cb0025800be9 glozow: ACK fa1ce96184a1815f453e64e14d77cb0025800be9 w0xlt: ACK https://github.com/bitcoin/bitcoin/commit/fa1ce96184a1815f453e64e14d77cb0025800be9 Tree-SHA512: d1e101b55477360ead2b99ade5d42b922aabe293ec84fb26764e29161c5be6c534aef6f22d2cc5ea63a4bd6b6e77b701f1a7a2283b8e7e815d343a604cd77656
2022-09-15doc: consolidate & remove release-note fragmentsfanquake
These have been moved here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft.
2022-09-15Merge bitcoin/bitcoin#26090: fs: fully initialize `_OVERLAPPED` for win32fanquake
02c9e564687af6ae2b0b6589108d502963f879cb fs: fully initialize _OVERLAPPED for win32 (Cory Fields) Pull request description: ```bash fs.cpp: In member function ‘bool fsbridge::FileLock::TryLock()’: fs.cpp:129:32: error: missing initializer for member ‘_OVERLAPPED::InternalHigh’ [-Werror=missing-field-initializers] 129 | _OVERLAPPED overlapped = {0}; | ^ fs.cpp:129:32: error: missing initializer for member ‘_OVERLAPPED::<anonymous>’ [-Werror=missing-field-initializers] fs.cpp:129:32: error: missing initializer for member ‘_OVERLAPPED::hEvent’ [-Werror=missing-field-initializers] ``` Came up in #25972. That PR is now rebased on this change. Closes: #26006 ACKs for top commit: sipsorcery: tACK 02c9e564687af6ae2b0b6589108d502963f879cb. hebasto: ACK 02c9e564687af6ae2b0b6589108d502963f879cb, tested on Linux x86_64: Tree-SHA512: 6a0495c34bd952b2bb8c994a1450da7d3eee61225bb4ff0ce009c013f5e29dba94bb1c3ecef9989dc18c939909fdc8eba690a38f96da431ae9d64c23656de7d0
2022-09-15Merge bitcoin/bitcoin#26089: build: remove unused cppflagsfanquake
4b656b9ed35d502d39ca745047961f242a5d868d build: remove unused libevent cppflags (fanquake) afce044bb6d99f01736013988f274863bebafce5 build: remove unused natpmp / upnp cppflags (fanquake) Pull request description: Their inclusion is likely just the result of copy-paste. The only place upnp & natpmp CPPFLAGS should be used is [`libbitcoin_node` (mapport.cpp)](https://github.com/bitcoin/bitcoin/blob/13fd9ee5c2d747e9f74d3fd8e33a4f0c9eaa769c/src/Makefile.am#L352). ACKs for top commit: theuni: ACK 4b656b9ed35d502d39ca745047961f242a5d868d hebasto: ACK 4b656b9ed35d502d39ca745047961f242a5d868d, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 800daeb06ddcbade3a862ca939a8cf87dc36282ed4fe9dc256d17b78a8751e2e08799788dc449046e1d875f93372912269d3ffcb5702628a41648794df32e887
2022-09-15wallet: fix sendall creates tx that fails tx-size checkkouloumos
The `sendall` RPC doesn't use `CreateTransactionInternal`as the rest of the wallet RPCs and it never checks against the tx-size mempool limit. Add a check for tx-size as well as test coverage for that case.
2022-09-15build: remove unused libevent cppflagsfanquake
2022-09-15build: remove unused natpmp / upnp cppflagsfanquake
Their inclusion is likely just the result of copy-paste. The only place upnp/natpmpflags should be used is `libbitcoin_node` (mapport.cpp).
2022-09-15test: Add missing syncwithvalidationinterfacequeueMacroFake
2022-09-15Merge bitcoin/bitcoin#26084: sendall: check if the maxtxfee has been exceededMacroFake
6f8e3818af7585b961039bf0c768be2e4ee44e0f sendall: check if the maxtxfee has been exceeded (ishaanam) Pull request description: Previously the `sendall` RPC didn't check whether the fees of the transaction it creates exceed the set `maxtxfee`. This PR adds this check to `sendall` and a test case for it. ACKs for top commit: achow101: ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f Xekyo: ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f glozow: Concept ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f. The high feerate is unlikely but sendall should respect the existing wallet options. Tree-SHA512: 6ef0961937091293d49be16f17e4451cff3159d901c0c7c6e508883999dfe0c20ed4d7126bf74bfea8150d4c1eef961a45f0c28ef64562e6cb817fede2319f1a
2022-09-14Merge bitcoin/bitcoin#26053: rpc: bugfix, 'add_inputs' default value is true ↵Andrew Chow
unless 'inputs' are provided b00fc44ca5cb938f18d31cde7feb4e1c968dcc2f test: add coverage for 'add_inputs' dynamic default value (furszy) ddbcfdf3d050061f4e8979a0e2bb63bba5a43c47 RPC: bugfix, 'add_inputs' default value is true unless 'inputs' are provided (furszy) Pull request description: This bugfix was meant to be in #25685, but decoupled it to try to make it part of 24.0 release. It's a truly misleading functionality. This PR doesn't change behavior in any way. Just fixes two invalid RPC help messages and adds test coverage for the current behavior. #### Description In both RPC commands `send()` and `walletcreatefundedpsbt` the help message says that `add_inputs` default value is false when it's actually dynamically set by the following statement: ```c++ coin_control.m_allow_other_inputs = rawTx.vin.size() == 0; ``` Which means that, by default, `add_inputs` is true unless there is any pre-set input, in which case, the default is false. ACKs for top commit: achow101: ACK b00fc44ca5cb938f18d31cde7feb4e1c968dcc2f S3RK: ACK b00fc44ca5cb938f18d31cde7feb4e1c968dcc2f Tree-SHA512: 5c68a40d81c994e0ab6de0817db69c4d3dea3a9a64a60362531bf583b7a4c37d524b740905a3f3a89cdbf221913ff5b504746625adb8622788aea93a35bbcd40
2022-09-14Merge bitcoin-core/gui#669: Update translation source file for string freeze ↵Hennadii Stepanov
(round 2) 6725030e41340ffa15d980d1d8af48b689403865 qt: Update translation source file for string freeze (round 2) (Hennadii Stepanov) Pull request description: On the day of [translation string freeze](https://github.com/bitcoin/bitcoin/issues/24987#issuecomment-1234026641), it happened that bitcoin-core/gui#660 did not include new strings from bitcoin/bitcoin#19602. This PR includes all recent updates. As a Transifex translator, I believe it is enough time for all translators to handle a few new strings by a release date. Also a Transifex check failure has been [fixed](bitcoin-core/gui/pull/664). ACKs for top commit: jarolrod: ACK 6725030e41340ffa15d980d1d8af48b689403865 Tree-SHA512: d57b841e87e389d31ec4ae9067b83f7f209e168399bc088c3234c2c66b34772739cb801f04b5038d55de115083d022d603bc976374bfd537b8ea10c10a545183
2022-09-14test: add coverage for 'add_inputs' dynamic default valuefurszy
Covered cases for send() and walletcreatefundedpsbt() RPC commands: 1. Default add_inputs value with no preset inputs (add_inputs=true): Expect: automatically add coins from the wallet to the tx. 2. Default add_inputs value with preset inputs (add_inputs=false): Expect: disallow automatic coin selection. 3. Explicit add_inputs=true and preset inputs (with preset inputs not-covering the target amount). Expect: include inputs from the wallet. 4. Explicit add_inputs=true and preset inputs (with preset inputs covering the target amount). Expect: only preset inputs are used. 5. Explicit add_inputs=true, no preset inputs (same as (1) but with an explicit set): Expect: include inputs from the wallet.
2022-09-14qt: Update translation source file for string freeze (round 2)Hennadii Stepanov
2022-09-14Merge bitcoin-core/gui#664: Prevent wrong handling of `%2` token by TransifexHennadii Stepanov
8ed2b72767de55dce033d8bfe6f9414ae14e1452 qt: Prevent wrong handling of `%2` token by Transifex (Hennadii Stepanov) Pull request description: On master (124e75a41ea0f3f0e90b63b0c41813184ddce2ab), Transifex translation check fails for https://github.com/bitcoin-core/gui/blob/124e75a41ea0f3f0e90b63b0c41813184ddce2ab/src/qt/forms/intro.ui#L206 with a message: > The expression '%2G' is not present in the translation. In "Organization Settings" --> ["Translation checks"](https://www.transifex.com/bitcoin/settings/validations/) I have changed the status of the "**Variable substitution specifiers (like "%s") are preserved in the translations.**" check from "error" to "warning" temporarily. This setting should be reverted after applying this PR change. [Noted](https://www.transifex.com/bitcoin/bitcoin/translate/#ru/qt-translation-024x/436102928/) by Transifex user [AHOHNMYC](https://www.transifex.com/user/profile/AHOHNMYC/). I faced the same issue while working on Ukrainian translation. ACKs for top commit: katesalazar: ACK 8ed2b72767de55dce033d8bfe6f9414ae14e1452 jarolrod: ACK 8ed2b72767de55dce033d8bfe6f9414ae14e1452 Tree-SHA512: 304f795ac9241ac8453c614ed18d967226d9d515f9ea079b51af5bcbe2f0760ca7dcaea5efb38207720cb7a18159c2bcd337b961bc522a128715c70e0db81061
2022-09-14Merge bitcoin-core/gui#663: Cleanup translation commentHennadii Stepanov
5f28fc81600736d499391c4cb6dc34ece5d4229c qt: Cleanup translation comment (Hennadii Stepanov) Pull request description: An unneeded character slipped in bitcoin-core/gui#629. ACKs for top commit: jarolrod: ACK 5f28fc81600736d499391c4cb6dc34ece5d4229c jonatack: utACK 5f28fc81600736d499391c4cb6dc34ece5d4229c Tree-SHA512: 210fb626e8035786cf6859160c60b2815c813e02908c75efc71a2c64d511edd6f81b2f67f1c98b29122b990260ebf663da445ea2d01b6268e3e046ada1ca5b6e
2022-09-14Merge bitcoin/bitcoin#26079: Revert "doc: note that brew installed qt is not ↵fanquake
supported" 34a2f91055ea467b4c20c419646849da5bd7fb94 Revert "doc: note that brew installed qt is not supported" (Hennadii Stepanov) Pull request description: As bitcoin/bitcoin#26056 fixes bitcoin/bitcoin#25947 it looks reasonable to revert bitcoin/bitcoin#21988. ACKs for top commit: fanquake: ACK 34a2f91055ea467b4c20c419646849da5bd7fb94 - haven't tested at all. jarolrod: ACK https://github.com/bitcoin/bitcoin/commit/34a2f91055ea467b4c20c419646849da5bd7fb94 Tree-SHA512: 4470f21fb6ea32970d7572c83ba064bcbe6e3282cea79122312f8ac203a5b1617b21952db1d6e47ba5b6f605abc23f72c04c07cef7251272e22fb593ff317beb
generated by cgit v1.2.3 (git 2.26.2) at 2024-11-08 03:39:43 +0000