| Age | Commit message (Collapse) | Author |
|---|
|
columnCount
195fcb53a09e9b852544778a077727f81d31303e qt: Follow Qt docs when implementing rowCount and columnCount (Hennadii Stepanov)
Pull request description:
[`QAbstractItemModel::rowCount`](https://doc.qt.io/qt-5/qabstractitemmodel.html#rowCount):
> **Note:** When implementing a table based model, `rowCount()` should return 0 when the parent is valid.
[`QAbstractItemModel::columnCount`](https://doc.qt.io/qt-5/qabstractitemmodel.html#columnCount):
> **Note:** When implementing a table based model, `columnCount()` should return 0 when the parent is valid.
ACKs for top commit:
jarolrod:
Tested ACK 195fcb53a09e9b852544778a077727f81d31303e. Compiled and ran on macOS (Big Sur 11.1 and Catalina 10.15.7), Arch Linux, and FreeBSD. visually verified no weird effects with the `Address`, `Ban`, `Peer`, and `Transaction` tables. As already stated, the code change brings us inline with what the QT Docs recommend.
Tree-SHA512: 179a3430e68e77b22cdf642964cd96c023a2286ee256bbeb25b43df3d2eef6f59978c8d92173c6be5071d127fdcd6aa338142f6eaf003ff08e4abd65172d20ca
|
|
fa210689e27b0d78b2fe894e51e364179db7a3ce net: Move SocketSendData lock annotation to header (MarcoFalke)
fa0a71781a964d944db9ecc002675ef32249f62e net: Move CConnman/NetEventsInterface after CNode in header file (MarcoFalke)
Pull request description:
Lock annotations must be in the header, otherwise the will have limited or no effect
ACKs for top commit:
jnewbery:
utACK fa210689e2
Tree-SHA512: c25aac793662227f2bb163e2f98cd38e89b43a03bad925d192d6166dee76a456110eaf55be5e4b4f2ddcf20bde7e3fc82a7a4338670a1f2d027d01b4a8908303
|
|
f2d93b229d8a95c0ff6c6cb9253d11cceec9d5d8 gitian-keys: add miketwenty1 key (Michael Tidwell)
Pull request description:
in ref to:
bitcoin-core/gitian.sigs#1427
ACKs for top commit:
laanwj:
ACK f2d93b229d8a95c0ff6c6cb9253d11cceec9d5d8
Tree-SHA512: 895935981ada0c3a094adde556b86b73dc440b599f8d6e2a7dd1e82592351c820b797c64a3e0fa1e79ab4c2f992afb3363b4a12625a54bdfbdea75b5a19d7e95
|
|
Also, add lock annotation to SendMessages
Can be reviewed with "--word-diff-regex=."
|
|
Can be reviewed with --color-moved=dimmed-zebra --patience
|
|
90f9fc274bf69b33adea593146ff5d6793123781 qt: Save QSplitter state in QSettings (Hennadii Stepanov)
Pull request description:
This PR adds the ability to save the `QSplitter` widget state in `QSettings` during shutdown, and restore it on startup.
A user no longer needs to adjust the splitter every time :)
ACKs for top commit:
jonasschnelli:
utACK 90f9fc274bf69b33adea593146ff5d6793123781
jonatack:
ACK 90f9fc274bf69b33adea593146ff5d6793123781 this sets the "PeersTabSplitterSizes" value in the RPCConsole dtor and restores it in the RPCConsole ctor; tested in Debian with various split settings, tab open/close sequences, and shutdown methods, and the Peers window split state was faithfully maintained.
Tree-SHA512: efbd6a4cee512982944955d36775e75a8a217b1dc49e62d42c6e402d2710dd44324b2c3c1edeb5fe38d9229e0e4a39734d1f4e63405ade8694762e1bbf72020b
|
|
const
31b136e5802e1b1e5f9a9589736afe0652f34da2 Don't declare de facto const reference variables as non-const (practicalswift)
1c65c075ee4c7f98d9c1fac5ed7576b96374d4e9 Don't declare de facto const member functions as non-const (practicalswift)
Pull request description:
_Meta: This is the second and final part of the `const` refactoring series (part one: #20581). **I promise: no more refactoring PRs from me in a while! :)** I'll now go back to focusing on fuzzing/hardening!_
Changes in this PR:
* Don't declare de facto const member functions as non-const
* Don't declare de facto const reference variables as non-const
Awards for finding candidates for the above changes go to:
* `clang-tidy`'s [`readability-make-member-function-const`](https://clang.llvm.org/extra/clang-tidy/checks/readability-make-member-function-const.html) check ([list of `clang-tidy` checks](https://clang.llvm.org/extra/clang-tidy/checks/list.html))
* `cppcheck`'s `constVariable` check ([list of `cppcheck` checks](https://sourceforge.net/p/cppcheck/wiki/ListOfChecks/))
See #18920 for instructions on how to analyse Bitcoin Core using Clang Static Analysis, `clang-tidy` and `cppcheck`.
ACKs for top commit:
ajtowns:
ACK 31b136e5802e1b1e5f9a9589736afe0652f34da2
jonatack:
ACK 31b136e5802e1b1e5f9a9589736afe0652f34da2
theStack:
ACK 31b136e5802e1b1e5f9a9589736afe0652f34da2 :snowflake:
Tree-SHA512: f58f8f00744219426874379e9f3e9331132b9b48e954d24f3a85cbb858fdcc98009ed42ef7e7b4619ae8af9fc240a6d8bfc1c438db2e97b0ecd722a80dcfeffe
|
|
|
|
6f2c4fd0775a9c45eacc4bab8f138528852fdf44 netinfo: add user help documentation (Jon Atack)
Pull request description:
This is the help doc commit of #20764 without the rest of the PR or anything new since the 0.21.0 branch-off in order to target giving users a -netinfo help doc for 0.21.
- to test the new help
```
$ ./src/bitcoin-cli -netinfo help
```
- to see the updated short help
```
$ ./src/bitcoin-cli -help | grep -A4 netinfo
```
<details><summary><code>-netinfo</code> help doc</summary><p>
```
$ ./src/bitcoin-cli -netinfo help
-netinfo level "help"
Returns a network peer connections dashboard with information from the remote server.
Under the hood, -netinfo fetches the data by calling getpeerinfo and getnetworkinfo.
An optional integer argument from 0 to 4 can be passed for different peers listings.
Pass "help" to see this detailed help documentation.
If more than one argument is passed, only the first one is read and parsed.
Suggestion: use with the Linux watch(1) command for a live dashboard; see example below.
Arguments:
1. level (integer 0-4, optional) Specify the info level of the peers dashboard (default 0):
0 - Connection counts and local addresses
1 - Like 0 but with a peers listing (without address or version columns)
2 - Like 1 but with an address column
3 - Like 1 but with a version column
4 - Like 1 but with both address and version columns
2. help (string "help", optional) Print this help documentation instead of the dashboard.
Result:
* The peers listing in levels 1-4 displays all of the peers sorted by direction and minimum ping time:
Column Description
------ -----------
<-> Direction
"in" - inbound connections are those initiated by the peer
"out" - outbound connections are those initiated by us
type Type of peer connection
"full" - full relay, the default
"block" - block relay; like full relay but does not relay transactions or addresses
net Network the peer connected through ("ipv4", "ipv6", "onion", "i2p", or "cjdns")
mping Minimum observed ping time, in milliseconds (ms)
ping Last observed ping time, in milliseconds (ms)
send Time since last message sent to the peer, in seconds
recv Time since last message received from the peer, in seconds
txn Time since last novel transaction received from the peer and accepted into our mempool, in minutes
blk Time since last novel block passing initial validity checks received from the peer, in minutes
age Duration of connection to the peer, in minutes
asmap Mapped AS (Autonomous System) number in the BGP route to the peer, used for diversifying
peer selection (only displayed if the -asmap config option is set)
id Peer index, in increasing order of peer connections since node startup
address IP address and port of the peer
version Peer version and subversion concatenated, e.g. "70016/Satoshi:21.0.0/"
* The connection counts table displays the number of peers by direction, network, and the totals
for each, as well as a column for block relay peers.
* The local addresses table lists each local address broadcast by the node, the port, and the score.
Examples:
Connection counts and local addresses only
> bitcoin-cli -netinfo
Compact peers listing
> bitcoin-cli -netinfo 1
Full dashboard
> bitcoin-cli -netinfo 4
Full live dashboard, adjust --interval or --no-title as needed (Linux)
> watch --interval 1 --no-title ./src/bitcoin-cli -netinfo 4
See this help
> bitcoin-cli -netinfo help
```
</p></details>
ACKs for top commit:
laanwj:
ACK 6f2c4fd0775a9c45eacc4bab8f138528852fdf44
Tree-SHA512: dd49b1ce65546dacfb8ba9f9d57de0eae55560fd05533cf26c0b5d6ec65bf1de789c3287e90a0e2f47707532fab2fe62919a4192a7ffd58ac8eec18293e9aaeb
|
|
c3aa1a16b2e4d53a0bba3b79ce257c9d5c85e87d gitian-keys: add key for guggero (Oliver Gugger)
Pull request description:
As asked in bitcoin-core/gitian.sigs#1427
Full key(s) available at https://keybase.io/guggero/pgp_keys.asc
```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
My key is F4FC70F07310028424EFC20A8E4256593F177720
(Oliver Gugger <gugger@gmail.com>)
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEbgHuyWVpA7BUK48QA9tjIiZ8NzsFAl/0uXEACgkQA9tjIiZ8
NzsMeQgAiuj0PqUQYRn3xyxdqAGpN/JdUgCC0HjolW44kDPvij1Tb1ZrvSQD1Amh
H0XLca+eROGmdgSMNFIBcsh4/Ikh11hRVsbDtf2v2Q3xuM6abklzCFZto47QFgf6
PZZIVUu9MespkOXOa8NK+nhsq241S6gp+dJkd39sW0q1+B7/7zVoV1v2tSCxkKeI
x8TbHfH+BGhB0I7Kwanz/tz5rX5U7GdF8ajjKg4p/Z303UP6+j+j5eT4b8WJKVKN
9N9mtx9h0sgo/i3Vk6KZ7Y74YYH3e3FL7ZVaoWxZgDPX79724F2l7K8n3q60F2X7
jhB7uMTZ2trD7A2qtrpK7HnRVYlbVA==
=AOM6
-----END PGP SIGNATURE-----
```
ACKs for top commit:
laanwj:
ACK c3aa1a16b2e4d53a0bba3b79ce257c9d5c85e87d
Tree-SHA512: 494b22bccb38b517fec642828d77e0ef50b07527d803be7374da1c54295e0e8958eee8a9ad0bbfbd47d4f553507011ac4417b02694a878ff4ce78639baa1801d
|
|
fa6c114ae604571435e8c4d25906a8b6d5b9984c test: Add sanitizer suppressions for AMD EPYC CPUs (MarcoFalke)
Pull request description:
Currently the ci system only runs on intel cpus (and some arm devices), but it won't run on CPUs `Using the 'shani(1way,2way)' SHA256 implementation` (excerpt from debug log).
For reference, google cloud CPUs (which is what Cirrus CI uses) print `Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation`
The traceback I got:
```
crypto/sha256_shani.cpp:87:18: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'size_t' (aka 'unsigned long')
#0 0x55c0000e95ec in sha256_shani::Transform(unsigned int*, unsigned char const*, unsigned long) /root/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/crypto/sha256_shani.cpp:87:18
#1 0x55bfffb926f8 in (anonymous namespace)::SelfTest() /root/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/crypto/sha256.cpp:517:9
#2 0x55bfffb906ed in SHA256AutoDetect[abi:cxx11]() /root/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/crypto/sha256.cpp:626:5
#3 0x55bfff87ab97 in BasicTestingSetup::BasicTestingSetup(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<char const*, std::allocator<char const*> > const&) /root/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/util/setup_common.cpp:104:5
#4 0x55bffe885877 in main /root/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/qt/test/test_main.cpp:52:27
#5 0x7f20c3bf60b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
#6 0x55bffe7a5f6d in _start (/root/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/qt/test/test_bitcoin-qt+0x1d00f6d)
SUMMARY: UndefinedBehaviorSanitizer: unsigned-integer-overflow crypto/sha256_shani.cpp:87:18 in
ACKs for top commit:
laanwj:
Anyhow ACK fa6c114ae604571435e8c4d25906a8b6d5b9984c
Tree-SHA512: 968a1d28eedec58c337b1323862f583cb1bcd78c5f03396940b9ab53ded12f8c6652877909aba05ee5586532137418fd817ff979bd7bef6e07856094f9d7f9b1
|
|
378aedc45248cea82d9a3e6dc1038d6828008a76 [net] Add cs_vSend lock annotations (John Newbery)
673254515a2f97e53dd8c7335c836b083ba7e31a [net] Move RecordBytesSent() call out of cs_vSend lock (John Newbery)
Pull request description:
RecordBytesSent() does not require cs_vSend to be locked, so reduce the scope of cs_vSend.
Also correctly annotate the CNode data members that are guarded by cs_vSend.
This is a simpler alternative to #19673.
ACKs for top commit:
jnewbery:
ok, reverting to commit 378aedc which has two ACKs already. Any style issues can be fixed up in future PRs.
troygiorshev:
ACK 378aedc45248cea82d9a3e6dc1038d6828008a76
theStack:
re-ACK 378aedc45248cea82d9a3e6dc1038d6828008a76
MarcoFalke:
review ACK 378aedc45248cea82d9a3e6dc1038d6828008a76 🔌
Tree-SHA512: e9cd6c472b7e1479120c1bf2d1c640cf6d18c7d589a5f9b7dfc4875e5790adaab403a7a1b945a47e79e7249a614b8583270e4549f89b22e8a9edb2e4818b0d07
|
|
and drop no longer needed sort description header to save screen space
|
|
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
My key is F4FC70F07310028424EFC20A8E4256593F177720
(Oliver Gugger <gugger@gmail.com>)
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEbgHuyWVpA7BUK48QA9tjIiZ8NzsFAl/0uXEACgkQA9tjIiZ8
NzsMeQgAiuj0PqUQYRn3xyxdqAGpN/JdUgCC0HjolW44kDPvij1Tb1ZrvSQD1Amh
H0XLca+eROGmdgSMNFIBcsh4/Ikh11hRVsbDtf2v2Q3xuM6abklzCFZto47QFgf6
PZZIVUu9MespkOXOa8NK+nhsq241S6gp+dJkd39sW0q1+B7/7zVoV1v2tSCxkKeI
x8TbHfH+BGhB0I7Kwanz/tz5rX5U7GdF8ajjKg4p/Z303UP6+j+j5eT4b8WJKVKN
9N9mtx9h0sgo/i3Vk6KZ7Y74YYH3e3FL7ZVaoWxZgDPX79724F2l7K8n3q60F2X7
jhB7uMTZ2trD7A2qtrpK7HnRVYlbVA==
=AOM6
-----END PGP SIGNATURE-----
|
|
0e51a355128a825d428fe2b9017c25085731fc04 refactor: Use Mutex type for some mutexes in CNode class (Hennadii Stepanov)
Pull request description:
No need the `RecursiveMutex` type for the `CNode::cs_vSend`, `CNode::cs_hSocket` and `CNode::cs_vRecv`.
Related to #19303.
ACKs for top commit:
jnewbery:
utACK 0e51a35512
MarcoFalke:
review ACK 0e51a355128a825d428fe2b9017c25085731fc04 🔊
Tree-SHA512: 678ee5e3c15ad21a41cb86ec7179741bd505a138638fdc07f41d6d677c38fbf2208219bfc0509e3675e721fc8d8816e858070db7b87c5d72ad93aae81f7e1636
|
|
819d03b932134ee91df3b0fe98a481a331ce57bf refactor: took out unused member functions (Zero)
ed69213c2b2a99023bdee5168614cb8b71990f5f build: enable unused member function diagnostic (Zero)
Pull request description:
This PR enables the `-Wunused-member-function` compiler diagnostic, as discussed in #19702.
> **Notice**: The `unused-member-function` diagnostic is only available on clang. Therefore, clang should be used to test this PR.
- [x] Include the `-Wunused-member-function`diagnostic in `./configure.ac`. (ed69213c2b2a99023bdee5168614cb8b71990f5f)
- [x] Resolve the reported warnings. (819d03b932134ee91df3b0fe98a481a331ce57bf)
Currently, enabling this flag no longer reports the following warnings:
> **Note**: output from `make 2>&1 | grep "warning: unused member function" | sort | uniq -c`
```
1 index/blockfilterindex.cpp:54:5: warning: unused member function 'DBHeightKey' [-Wunused-member-function]
2 script/bitcoinconsensus.cpp:50:9: warning: unused member function 'GetType' [-Wunused-member-function]
1 test/util_tests.cpp:1975:14: warning: unused member function 'operator=' [-Wunused-member-function]
```
All tests have passed locally (from `make check` & `src/test/test_bitcoin`).
This PR closes #19702.
ACKs for top commit:
practicalswift:
ACK 819d03b932134ee91df3b0fe98a481a331ce57bf - patch still looks correct :)
MarcoFalke:
ACK 819d03b932134ee91df3b0fe98a481a331ce57bf
pox:
Tested ACK 819d03b932134ee91df3b0fe98a481a331ce57bf with clang after `make clean`. No unused member function warnings.
theStack:
tested ACK 819d03b932134ee91df3b0fe98a481a331ce57bf
Tree-SHA512: 5fdfbbb02b3dc618a90a874a5caa5e01e596fc1d14a209e75a6981f01b253f9bca0cfac8fdd758dd7151986609fb76571c3745124a29cfd4f8cbb8d82a07272e
|
|
1112035d32ffe73a4522226c8cb2f6a5878d3ada doc: fix various typos (Ikko Ashimine)
e8640849c775efcf202dbd34736fed8d61379c49 doc: Use https URLs where possible (Sawyer Billings)
Pull request description:
Consolidates / fixes the changes from #20762, #20836, #20810. There is no output when `test/lint/lint-all.sh` is run.
Closes #20807.
ACKs for top commit:
MarcoFalke:
ACK 1112035d32ffe73a4522226c8cb2f6a5878d3ada
Tree-SHA512: 22ca824688758281a74e5ebc6a84a358142351434e34c88c6b36045d2d241ab95fd0958565fd2060f98317e62e683323b5320cc7ec13592bf340e6922294ed78
|
|
7ff05358a96f49ae6b7eb265ce301748bfde30a8 [mempool] Remove error suppression on upgrade (Amiti Uttarwar)
Pull request description:
In 0.21, we added unbroadcast txids to mempool.dat (#18038). When users upgraded from 0.21 to 0.22, this would throw a misleading "failed to deserialize mempool data" error even though everything actually loaded properly. So, commit 9c8a55d added a try-block to prevent throwing the error. After upgrading to 0.22, this exception handling is no longer useful, so now we can remove it.
ACKs for top commit:
MarcoFalke:
review ACK 7ff05358a96f49ae6b7eb265ce301748bfde30a8
theStack:
Code review ACK 7ff05358a96f49ae6b7eb265ce301748bfde30a8
Tree-SHA512: 0444eea2b1326904f9855fd0af6669a4990f0427cf7c9293252a5b7049cdcc785bdf9398fd08ed8dedacfdd78e75039ddf1087b3654c558ff52498df15f05daf
|
|
Apple's"
a0eb4c551ebf8adfacb8c38c4ce56641fe379667 Revert "Add patch to make codesign_allocate compatible with Apple's" (Pieter Wuille)
Pull request description:
This reverts #20644.
It appears that Apple has recently changed their `codesign_allocate` tool back to using 4k alignment on x86_64, at least in some cases, so this patch isn't causing our cctools-based version to be exactly compatible.
Furthermore, if codesigning were to change to use https://github.com/achow101/signapple instead, there is no need anymore to try to mimick Apple.
ACKs for top commit:
laanwj:
ACK a0eb4c551ebf8adfacb8c38c4ce56641fe379667
MarcoFalke:
checked-clean-revert ACK a0eb4c551ebf8adfacb8c38c4ce56641fe379667
jonasschnelli:
ACK a0eb4c551ebf8adfacb8c38c4ce56641fe379667
Tree-SHA512: 529719a76811006122406689233d1e80995107fe1ac1fc862a4ac53ca21685748ed76cac7ca648dd70f0ea43dd8dcf2e29d559beeab10e1d30dc5542ac95fd97
|
|
d825a3957ee317c74147611a7791193438f0e53c gitian-keys: add darosior's key (Antoine Poinsot)
Pull request description:
As per https://github.com/bitcoin-core/gitian.sigs/issues/1427
ACKs for top commit:
fanquake:
ACK d825a3957ee317c74147611a7791193438f0e53c
Tree-SHA512: d5ad39e0484d3d244911fd152d75f82141ca8ac4a7f21955cd428eee7433869b76026105a83bf50319aca0518bc96d5a1ed087c263c31bdfbf89a583e94bc1f5
|
|
-----BEGIN PGP PUBLIC KEY BLOCK-----
mQGNBFvwGvYBDADiZ/8Vi95xgj1GX/1Bot+y+MM/OSoJaXXQRnBGUjO5WLGG79Wh
cdQR53JZ7+MN7kHk/R7ZNjtTJdQi3HYfeDUQdQpknuNJN3qLrLuZ93jIhagvKfmJ
MpXhxikz/D3O67kLmbh+qUEhyMB8SvyUxbAaA/5laLeAdxeFWuVvFmngpnRKIAoa
k2PgPEO36+ghAb72GjSHtSFFIK+zn/dimHpLIOjKvERLoWGUSaXo/M5Uy1r67gke
TA3MyMGe1TU2SyMZEZR6LLOtPs0kxf5eU4blEpWs26/UdIAfKfayTnkvqpBHI1TR
6wbH7HlQVB8I1QrDg51oFDZ6DazKyNgnIAlWiM10Q2PlUunnT7NFfPSgDkAw/tR/
xsAMFbPT5NAD4TYqnK3NBlSTVNTmvyyy7EwQv0b1kO2fM/IYZ8XsJtCVJvaNXSbW
VoueDX5ZQ5z3ja/Y/Y7SSUbdJcMiNYrQZ/GbvwiNvjkmBR9UCBi7fSeRMQgl6tIK
ctIwqb7a4UjO42cAEQEAAbQpQW50b2luZSBQb2luc290IDxkYXJvc2lvckBwcm90
b25tYWlsLmNvbT6JAdcEEwEIAEEFCQYonioFCwkIBwIGFQoJCAsCBBYCAwECHgEC
F4ACGQEWIQRZC3KSaVr/pbZyy7LhP8FFzT9DBAUCX8I0iwIbDwAKCRDhP8FFzT9D
BKOQDACedmkzuKME1kS3heZGx7fezOJF9vNUuqKiP8eSCauZrWZCe02biyB5MGF6
20nijrxIpsiOfcr2iJJGvk4FQxmuZUFwM+r3+lJZTmBiEMWk9U/G/FLHEbTgIMOT
ehSzQZmp4S98FcChvNdxdXBMZMf/xrDVVqBWk8oBTEkQipVuQp3Jx8phl2ICCkU5
ni9e5ZMVI3zkdSm2DmlhK08tW+5iMczeGt9n9LMr2w3AVRPVIfIhYTf4mwCVfoLF
ScpurBljyVNm1Rwjs63hdN01jx27pSqDIntGTS/R8hJZrxNEn1Tb5zXGHhtDDZ3i
CTb0ANw32bQoQEJOdCHjryWQnFUn81MP1uf5NoKwsWYqHU8JU5dt4egZslwGrg6w
32jGG3fonrcRMblrO3dxd2LGwFpim4cQ7vxwdqaotDs6Wo3NSGkjrDaN0p7Lt2VO
LkIMWm1IYyW9gGHYfaw7XYSA/Nj4SAqkQTX+yHBidl5rBSBNM2u6nGLOCSidWxu/
iDByidOJAjMEEAEKAB0WIQTcD5pmgKm5i5kyhYGqIUI/fgqb5gUCX7G19QAKCRCq
IUI/fgqb5s1KD/4itFySsRwQFkJkg/QTvA7oi4h/oyASvhXC1vECO5OHYaxt49ok
KdkZOJRblD3weyUbbQ54OxvPvIadgxzwWYm6qqsXmRCt7C4lY1xSgyk5ct8n2Ytb
DzzNBuYRhdu9Qti28SY6EHvvjOE1gQTx1B+bkv75ih3KZrlURvJ8Rgdbc11BJDk8
3Q6fP27peqC5WbQOufY7ncfI+Dw9ecgffOPFINKYDAg8A22bDci0LNQG5xOkp+pl
VGKTf3TJdQSUelF62gqrFrY1EcgR3wP8kh2J2S3hBKiSUzN5bX3db2r8y03MOmiD
BKIjoWqSBC1ZfRuqfqqAJgTPIp0NzSK3tOpQYPRX5PrrKW+uRmQQsqC2rrF1Wj9T
hQ0Yxn6gbpbhSP7fAAepmlE64IxeaIXRgcHQ2Jog+3TkSDXXwURstjvVzmOg0NeP
FCsSXXau9eIvvXoO1BYsbV1XN2Rvp8DxvsGiukqK7t6qOq5PZHJoBB0nzD9vmFyz
Vz6X9yeKbbx50ocWV4OC55pIZFz8sKzW0FyPn97QQftfVGAbn82bBjAEEAzRujMx
qqE7Y13r0OzVwOd4k1e5o2GbcHi6xJHHFOgcYDKm7ye5E8CDmwn4VHSh/YXSXQph
2fFCLOJxx3dAaJ+0xMZb8auHsjBRJpyKCWX8IptRoW4ZrI+KSYm4ncsGmYkB1wQT
AQgAQQIbAwUJBiieKgULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBFkLcpJpWv+l
tnLLsuE/wUXNP0MEBQJfscd7AhkBAAoJEOE/wUXNP0MEVOYMAIN8k5UOQz5/dFiC
iRLfuHVwzrKcPSeQnRSdNEgXoqOrKesvO0pWulSJwKHR2wD6jrYQKZNJH7p72pCy
dEXjyaa/yMY2Q5Nso9za5K3PyabyOHN+gRiRWaZ1xAGBfxQX+7m0PYaW9r8tHLv5
SBfjF4wpV7qHqVYqfBTO2S2NRAnRtZdv2bLNW+QuwTZbN6/jWQJ2wbevuS29aUpL
tzOXzMj/4gJ+oW4Pt4TEiu28H554z68jXjLzCh3SylpuSUp1YtvUSnbRR8KnGcpb
+BzSqhemgeWDprj18LRTgrXEkyFsyHbSlk2NxViPDHklHO1FbJL7azuuDCAwBeTS
3F6k3msSEWjdfdv55VorBBdnU+bKJMQsdUClnN/LB72qTRPnnbfqy9WIOndwOQaT
5CKLmLMPo6zSJ4J4p/uj2Dh9Xr+wD6PuXXF3qrh1x9HEYONZzIcaN95YtYcerBCp
xJaxSx94cmCzArIo/hVo5E4VATwOyUvIXcFBl6HJodLjvWnSQ4kB1AQTAQoAPhYh
BFkLcpJpWv+ltnLLsuE/wUXNP0MEBQJek0vNAhsDBQkGKJ4qBQsJCAcCBhUKCQgL
AgQWAgMBAh4BAheAAAoJEOE/wUXNP0MEMSgL/1opoJjNREeHa143GmwL/dRvjKtI
apiIpMX64OqZQKqatF0zhMTKmR+yqmmk1TBbIK2Zu/lUgEP/naidKpje7ZFgpI4t
C/Tdcb/em34aRCsAbZbLLGlNaqOZVOSAoQzKvzUx6oya3EdCJuZqNqQSvnNr+bSS
/HeKY9PhOLSLrNCBJl+9C58KwC6WpeZX576lKm5RexeF0JNWxFunE19e9Rs5QyZm
sBQbj9CsUcReI93cU4DrY9+T1sT7yXGtfsR0B8eFRREXF+I2hvJ6IJ4R3xUS7h11
Ifx9hTW+DkWhQgRbV2EeHpJExELsB1yC+luqNpWjo4Z8dT1ISAkOb3hRx4/L0jcv
lNqgZbp0FyvZnBttV6WwWNPTx+fAbVsoaM2DhTSl+EqOl6qPws/S66ETKp2OCGBt
WGYDnL9PJGdBKfCX9saH1yVsorqVRLxbhmd5tgwGRj4ZXfMz3UrSY/4ny0wU7dz+
JUtvcqdbGTiHUKCXwiCf8ybeTcPMmFccwIaiU7QhQW50b2luZSBQb2luc290IDxk
YXJvc2lvckBsbi5kZXY+iQG2BDABCAAgFiEEWQtykmla/6W2csuy4T/BRc0/QwQF
Al+81V8CHQAACgkQ4T/BRc0/QwQd7gwApliX71tXlxmKoEtplPsEZJAJmXLglwsv
JO0C5tLCUjD2ir8BGvfGehOeD9/ATOwHAhTAAs41nFEp8sw8F7eAFEhPLg0BLWZ5
eAgAofEO9qmOIvaZYivWEZx6vT84cc/yASThU9TeDoSoReczqMeATE53fIljh3Ce
ruBNN/fKjDXaDkpxZAcRzqfdj0Nu3vpA6a42VqaGS5rHPamgl+JriH966XvbCJxx
sK8U9FxsXYL5Yi2BzQRZK0Y6CVBRlG24T77lkw9PQ1SZz412X0SUFE8zYsYkJ6Cb
/ExpLY/3aiIoEKz/FLpEp8MeqB2W24vjnC2qqmNkMguIR7hUehHv0leZK4kc5WxM
l7/0NLxHYi43wfKv7FkMoEXDJlrefjJ46S3SFI3/UKnhVyXA3QZtCJHFYBbEL5Ho
zLo1HdURHPiVJ3yBDsHsCS11GlICaNyC72qpAJ+iotTOqO5dQfQyGummXmFHc/8/
8eyZVXGeXbTiyvO7gl8EhMn3bCPtWbmUiQHUBBMBCgA+FiEEWQtykmla/6W2csuy
4T/BRc0/QwQFAl6TTE0CGwMFCQYonioFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AA
CgkQ4T/BRc0/QwTJEwv/agA8Szf1JtOnPaVT3hkaeSSvRSBTcgx7RLH3QZwO8W+m
Yu402/6q5AT1+Ra9XYyk5S7QjcLwnnohpfCKRDpsIdOl5Td+S5xMGqacm85YyRl3
uAyuW+9eAEmOD14LzhK0mu4UZN8JseRg9l0uguX4k8gFJuQMhFmBA0aRcYBB/sQG
1uuyjoGGXDfPsxNTB0oFCd0cKXl9iU8WkWTQg0jjRbFJA301HCff7z5o6/W3t87p
db0KwCoa/8RPZ6+qiUZlx2K85A0dveU0K5JSs0hASLI7xhuOLMtxdzx74vkKwZis
YL2Nz5IKmrp2vO7pvYnC3YjycqJmiQSqHDyqo4j4QZm8/WxaDsSgHlvzHp/EjNHK
Bi35jfbctVjKPcRIGKfR4bcns8pFvBslQ6ar6CPtCKymkN+WuNRtZbc8HI4Yo2Xl
pXcneBsXDrVWfO8AzYEV8q0GynsXwEuTHfft0vyjV3laK2K4reMKjECh1BZ5FPUw
wrTnKsfmiddv4f7rDdTjiQIzBBABCgAdFiEE3A+aZoCpuYuZMoWBqiFCP34Km+YF
Al+xtdMACgkQqiFCP34Km+ZdvA//Wh0irz3TwANLR6tAb//CCXSTEAcKS+Dgtn92
Jd7+uKUure3PV4gVYkPK0v4fYb0cdfuGT97eXQOo2fcwbCA30Q04sN8X5grrmrkD
r4MdIsORquEnAmTqmN/mRUyoF/r1sb93LW5x/VNNlAa6gQJwEOdki6orP9xuRW9m
UKm/tNCSuK1LELR64mNfC2ETrZNCF2gxTFi4s2uleIQb5RqnAbg+HYV9dOuD64Ed
+FvNrlF/7uyDsI/8FawtyO61HEiE71maIwSboDxeaRwPGkF8OtobQg7EIJp2hG9N
cPV6+ENJCDlQwL4oTgpWFnls0E++OKW+NADyTECBYf1Pm5XZsMVV56RG1GJ5kmBJ
sPOvjvmtIqaEiEaE6Veor31uesbXT3peytWUWHldh9DCzCF9Ee6mbvTlJTywU3Mu
B4XI9jQYMbBdrPDv+dBUYgQxWJL9vkOQsYUFcrdgFhXehFiSQJ9VENcWr50zxLWN
SWn8cVnkdHHkZhLJzj2NtobNLnSjmhrsFtruNNd0ECMw6E612nw4M+W2CHurQ9VT
Nnuw+rTtH2DllckQD3rsnTM3Fc52V0qBfs8xJDjT7Z2Sg/mY7R1BuRGvy/8LYQCt
2XzwkEySNM95jnACoAD4qZPRn120lHq0vEb9MqD+HqbtgoZUjExQ98Br4C3fnO/m
4riELKu0JUFudG9pbmUgUG9pbnNvdCA8YW50b2luZUByZXZhdWx0LmRldj6JAdQE
EwEIAD4WIQRZC3KSaVr/pbZyy7LhP8FFzT9DBAUCX7HHsgIbAwUJBiieKgULCQgH
AgYVCgkICwIEFgIDAQIeAQIXgAAKCRDhP8FFzT9DBFqNC/45VPmwp4kvDxRjmI9T
X/OwLfXVJVehYFNAuKukeiw5Vnt2XC2PF1XM/qMSypr69ium/I83VeFdZbWR7nm1
MeDcPpmE7D8wX9zy53XbWElJD++72+q51RSdC5+g3HFcNQyD0rLI9lJ+MT42/Z56
+V4KnhcPrh6Jm+1JDCnBmJEW5vV4HInlapfwUEUgz0uKEigDfRQn7vRp2x1Hio8l
SBsLIp6J4pnDqSz0x5hroGFSW8DvyjBAvf+OrTLNS+DQf/p/x6JTRBPep/oIRWNL
XzN161jfBGoZtHSj+FGwed6CoTHpgr0uZtI/giYnnzPq/MWevHdo9Tc2uOGzasO6
JOBPE5p4JtSceExoCL8mNpUO5g8KfnhaRQNniyQ9LEt8n/zW5LFJ1GthKqwR++hr
Fnza3bZMMGknKP++ogrJqoPjWnVapiuZvGl+WGhfA/a+ybZ9qongEfu1DE3NnH2q
2vjYyMmFbKR+2HdISY17RuS84kOKlLHm+9+37Q1+eqOpjrG0GmRhcm9zaW9yIDxk
YXJvc2lvckBsbi5kZXY+iQHUBBMBCgA+FiEEWQtykmla/6W2csuy4T/BRc0/QwQF
Al6C+OkCGwMFCQYonioFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ4T/BRc0/
QwR2vAwA0TJI8+2fOFqrliAVEDMSXJGigPyZ7AHUljcpdVUBV7Pw4VcdwUnD759k
chsYyOBbSKk67emxQe4Sjgk9UzjpfKYaqe8jiW4X11/43qubtV/SRWRRluJ1+jq/
OBFYflpy+zQKTeymXBcw9y6/tUtGBBoo4o4LAvBo7oNyYNgBcYW/D2q/RO/GhDAu
pnEONJm6iy+r6Icdf33EC+JL2eJV7UHXrbHgcGIriPPyHYVbcv/Q5gECrkUVTpha
MYGmKCPy1z55zNh+j6b0WjanJo90I2rjJUJiujzyEc/pbIaZU8AlFaaayIIZg9z2
CXDOirzoRblINzadF6WgbZmXTjTM30Sp04znDjWGfRBQgjNCaAKO1ErE1EaytM1s
t20dE1qJMqJuL/ck5V8pHySvQVgEk1XbFsWrcLlwIlyJqo59oLL2I4PylHlIeVjS
0tFkyLgtfxK2jskfwYeQabmECLE5/iXpClmHzJplt9obgTI5v9XHptt6EtFAJYws
649S+XHOtCJkYXJvc2lvciA8ZGFyb3Npb3JAcHJvdG9ubWFpbC5jb20+iQHUBBMB
CgA+AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEWQtykmla/6W2csuy4T/B
Rc0/QwQFAl5WUiAFCQYonioACgkQ4T/BRc0/QwQ8zwv7BLPZ1feTaqgkPNcuN48q
8m0uxveoIU1aLlblAdpaCv1hz83Ui9kD8YpmtgbYHCX6dZbpclJcMD3OggnmD1PE
3c/g97iWopbUIDIDc2RZJN66CrO8v4cHBBAc6PE0Jz6ZaJ+r15jRsWvxO0ORK9wX
faq57D3DMZMt/Nh89fXXWTr4imHtcIZRUc2/eAYSJHOx89ZUTJLxuXuWSYuseh6g
jipArqvsih2Qjn62ZbCL7EAt0g/QIRU4eOZ71vB8W/t6qfDrAvPiEpa+vjm9vXf5
NpiVuKOhi02VVZYIW8udXbnuNDOE6gV/IVeAwW/1sNcjzqqaEFnnpHv8Gr8EhCLv
XiiWDzvi4zgdyprkz/lI41zQ6nz8ZGI+qwJn4qtcQKhB53Wm1Iootr5kHZbB+1T0
mAIb8uwEyeFLHUV2LKJqiNaE2K3nf3GaoxJ3g88P3YF8KmISSHgZvZ7leKz7Ox8S
1CLgqut1FmO9TyuvbxRn7fngp+B7x4H9MSjq4IKPq2DiiQHUBBMBCgA+FiEEWQty
kmla/6W2csuy4T/BRc0/QwQFAlvwGvYCGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYC
AwECHgECF4AACgkQ4T/BRc0/QwSJygv8CiL/P1lrc6Zx6pORDIGQshXvzFcAWQWW
27NRrHkBRl7YkiQTTVZx5CReH9cy86Y//LC88iPcJ2AjlSnozj6o2sW3moxRxGGO
rNBkwoglASesZmId69Yifu40Ogk35ctazOFsDYnzTsNFlcDrEMpK+OcbjchQByuo
iDnQ9Z0stQW79Qw0dPt+NtvDgOVzp4HKbW/F7ZK9i2Bir6eMbvNCOn7i4t9lQM9P
vP11y75/TFVM56HB9RijujP+WvpgchwCyo1nEGjPjnCLs+MVi2u+u5gr3Jjev2Mb
MTd4tI7O7dMhMb+JRjcSTXKDiaQAsaeAmjBC+MVU6KX7gRTdy4moocgrXtLcSvGB
tOQfuCyS6lx+6kjFhc1kZ0ZY9QCzqa+w6dkB52zOuu40GVgDpOhRAQi4rDVSZMAD
eRDq8Z9XIQV6J6fh/2U4WQOQa+DcSD9VGdn+adrPffsY1u9W42N7x5aK2gSmdCam
LHyCiae4UeMjzD/roccIHIHantrzXO00uQGNBFvwGvYBDADaPLBXQHawjIrhfmZ+
Fjjps8FtM1EaZDrpKNsNRA6if8ZbuJrHD1aR/sLnXQdi4OVHI3xqpqrpz/qXHLRC
hYxaLCcGECJIQLR8AMDlZbJjoKXRNnRHd742uN7TBCwzetyCjOjZ1Gp3Ij1u9x6K
lsiHEtBzq//Tz9SmIascrWPFGtoGruSj7maax7UL4y4bEv9Bh6Cg8yRwgMqrRinT
p0i0BI1VpNWBaar/p60slmqL+tWFkgS8dhlLoKlRj/c3ybhYF9o4duBPOV3t1xgt
Jp1xhW95ZaCYTKR/7LOq/eMkx5HZUi+5WtFuaaoQ2+JbO8q3831ObOZMMaJVR9JV
VkPs9JQrr4re50auVOkC05LjRXmLJ504A7/HYljf9A0MEcmJeZxN/Pb2S4+yBaAc
YgTAr/Aee2FODfa4yqyLZqqaQxq9p22ytqBcFZ655MCRt35oqioRFWYikIkCZ66g
ZCXKZmM1bx9HFU/qP6lBoX65xKEcuGZdYGqb4ydC9DPMrK0AEQEAAYkBvAQYAQoA
JhYhBFkLcpJpWv+ltnLLsuE/wUXNP0MEBQJb8Br2AhsMBQkDwmcAAAoJEOE/wUXN
P0MEtB8L/R6QJWfQyB6XWDS8rDiGRdgfXMaflj7xiYG2lpxwpbk8ZtvsVxXHRSoP
RShcNum0mg/y6WZSIUvmMfejYbP9YJYEfHVwzcWN7jXBnLMq2u6JvLvCnqeUBvbf
Jd83zbVNUQMpYQAMX4Twxolqr24qhR4Gc2wYYezFrylZ9NPoiIdGf3jpunG66khC
2nrAp/bKhEtwnsND3IaBYdulWjn8vkDZRyEjbOy9zGxaB3ZTtjfNj4JI+BZ7h/YB
Las6iSZViJX3L7GEysp9f7oZ5C60y1VFQo7TcEUEUSZ9eAKrOkEBwFrMlyeneeGo
BbHFllhBMdRPr92G06GgWEK1D5KnEPo85Q47POs0MU0XRThwd2wElz79J2xOf5Ad
1edOtzpHaQli6nqybfAh6ZOKz/tUOrFAtEw765bKTpUG1sHsvapqk8+HQoOPKbE8
4axUQwMSQcHqnooHkprzib2GC/+DGwGeg1HeN5g1H1/GBPicYP//Ez9w3QbSVQ+7
KG04r8hWbw==
=m4XT
-----END PGP PUBLIC KEY BLOCK-----
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
|
|
50a6f8f821a5fe75da7f4c86414ef34c15c198da Add benthecarman to keys.txt (benthecarman)
Pull request description:
For https://github.com/bitcoin-core/gitian.sigs/issues/1427
ACKs for top commit:
laanwj:
ACK 50a6f8f821a5fe75da7f4c86414ef34c15c198da
Tree-SHA512: a667cd6bc3511feb6bfea37d9b7b9ec69dadb02f47ec6e71e478c4f2e213c5cc0b8c74beec9536d3b9aadfdc743d5fb0107bee1ce72057acf01117e0f46862c0
|
|
729e1d151c1a86cd2166e97490f5d68c2f519a38 Add gitian PGP key for theStack (Sebastian Falbesoner)
Pull request description:
As requested per https://github.com/bitcoin-core/gitian.sigs/issues/1427#issue-778159391 🔑
(my key is published at https://keybase.io/thestack / https://gist.github.com/theStack/60ed7ccc7c0caffeef2d001b8b54148b)
ACKs for top commit:
laanwj:
ACK 729e1d151c1a86cd2166e97490f5d68c2f519a38
Tree-SHA512: 23eb4206040fc3933fab71d4a5905adcada7bb0953fafd8e9905ea02d375d5909aeaff5782710023e72e6dceaa403a3a9c0f8246a03ee60b5ab45332ed0e9b9a
|
|
This reverts commit a4118c6e200e02e7560f8bc213697aa2909d95b1.
|
|
In 0.21, we added unbroadcast txids to mempool.dat. Commit 9c8a55d
added a try-block to prevent throwing a "failed to deserialize mempool data"
error when a user upgrades from 0.21 to 0.22. This exception handling is no
longer useful, so now we can remove it.
|
|
|
|
|
|
|
|
RPCArg.m_fallback
fa749fbea3cad64582f76f7a58cfcc0d91a97326 rpc: Replace boost::variant with std::variant for RPCArg.m_fallback (MarcoFalke)
Pull request description:
Now that we can use std::variant from the vanilla standard library, drop the third-party boost variant dependency.
Patch is split out from #20480. A step-by-step replacement is possible because we don't have our own `Variant` wrapper and the source code specifies `boost::variant` explicitly.
I think a step-by-step replacement should be preferred, because it simplifies review.
ACKs for top commit:
fjahr:
re-ACK fa749fbea3cad64582f76f7a58cfcc0d91a97326
Sjors:
re-ACK fa749fbea3cad64582f76f7a58cfcc0d91a97326
Tree-SHA512: 5e3c12b7d535f73065b4afa8df0a488f78fb25d2234f5ecbf740e624db03a34c35fea100eb7d37e84741721310e6450b7fb4296a2207a7ed1fa24485b3650981
|
|
Co-authored-by: Peter Yordanov <ppyordanov@yahoo.com>
|
|
|
|
codespell 2.0.0
f3ba916e8b5b5ee2a381cef38882671eadb231df lint: ignore gitian keys file for spelling linter (Sebastian Falbesoner)
da289a6c4a0a5e110e301f34f1db57b6d31bcdcc lint: update list of spelling linter false positives (Sebastian Falbesoner)
a0022f1cfbb3d8f1f8f3ff135f854be0cb89643f test: bump codespell linter version to 2.0.0 (Sebastian Falbesoner)
Pull request description:
This small patch updates the ignore list for the spelling linter script (which uses `codespell`), both removing false-positives that are not relevant anymore and adding new ones. As [suggested by jonatack](https://github.com/bitcoin/bitcoin/pull/20762#issuecomment-750889701)~~, whose last name is now also part of the list :)~~. Also changed the linter script to not check the gitian keys file, as [suggested by hebasto](https://github.com/bitcoin/bitcoin/pull/20817#discussion_r550763409). The codespell version used is bumped to most recent version 2.0.0, which is more aware of some terms that were previously needed in the ignorelist for v1.17.1, see https://github.com/bitcoin/bitcoin/pull/20817#issuecomment-753428669.
Running spelling linter on master branch (repeated findings in the same file are removed to keep the output short):
```
$ ./test/lint/lint-spelling.sh
contrib/gitian-keys/keys.txt:16: Atack ==> Attack
doc/developer-notes.md:1284: inout ==> input, in out
doc/psbt.md:122: Asend ==> Ascend, as end
src/bench/verify_script.cpp:27: Keypair ==> Key pair
src/blockencodings.h:30: Unser ==> Under, unset, unsure, user
src/compressor.h:65: Unser ==> Under, unset, unsure, user
src/core_read.cpp:131: presense ==> presence
src/index/disktxpos.h:21: blockIn ==> blocking
src/net_processing.h:67: anounce ==> announce
src/netaddress.h:486: compatiblity ==> compatibility
src/primitives/transaction.h:35: nIn ==> inn, min, bin, nine
src/qt/bitcoinunits.cpp:101: nIn ==> inn, min, bin, nine
src/rpc/blockchain.cpp:2150: nIn ==> inn, min, bin, nine
src/rpc/misc.cpp:198: nIn ==> inn, min, bin, nine
src/script/bitcoinconsensus.cpp:81: nIn ==> inn, min, bin, nine
src/script/bitcoinconsensus.h:63: nIn ==> inn, min, bin, nine
src/script/interpreter.cpp:1279: nIn ==> inn, min, bin, nine
src/script/interpreter.h:222: nIn ==> inn, min, bin, nine
src/script/sign.cpp:17: nIn ==> inn, min, bin, nine
src/script/sign.h:39: nIn ==> inn, min, bin, nine
src/serialize.h:181: Unser ==> Under, unset, unsure, user
src/signet.cpp:142: nIn ==> inn, min, bin, nine
src/test/base32_tests.cpp:17: fo ==> of, for
src/test/base64_tests.cpp:17: fo ==> of, for
src/test/script_tests.cpp:1509: nIn ==> inn, min, bin, nine
src/test/sighash_tests.cpp:27: nIn ==> inn, min, bin, nine
src/test/validation_tests.cpp:78: excercise ==> exercise
src/undo.h:36: Unser ==> Under, unset, unsure, user
src/validation.cpp:1403: nIn ==> inn, min, bin, nine
src/validation.h:255: nIn ==> inn, min, bin, nine
src/wallet/wallet.cpp:1532: nIn ==> inn, min, bin, nine
src/wallet/walletdb.cpp:429: Crypted ==> Encrypted
test/functional/feature_nulldummy.py:63: unnecssary ==> unnecessary
test/functional/wallet_encryption.py:81: crypted ==> encrypted
test/functional/wallet_upgradewallet.py:36: fpr ==> for, far, fps
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt
```
Running spelling linter on PR branch:
```
$ ./test/lint/lint-spelling.sh
src/core_read.cpp:131: presense ==> presence
src/net_processing.h:67: anounce ==> announce
src/netaddress.h:486: compatiblity ==> compatibility
src/test/validation_tests.cpp:78: excercise ==> exercise
src/wallet/walletdb.cpp:429: Crypted ==> Encrypted
test/functional/feature_nulldummy.py:63: unnecssary ==> unnecessary
test/functional/wallet_encryption.py:81: crypted ==> encrypted
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt
```
This list of remaining findings doesn't contain false positives anymore -- the typos are fixed in PR https://github.com/bitcoin/bitcoin/pull/20762.
Happy new year! 🍾
ACKs for top commit:
hebasto:
re-ACK f3ba916e8b5b5ee2a381cef38882671eadb231df, only suggested changes since my [previous](https://github.com/bitcoin/bitcoin/pull/20817#pullrequestreview-560632881) review.
jonatack:
ACK f3ba916e8b5b5ee2a381cef38882671eadb231df I don't know if there are any particular issues with bumping codespell to v2.0.0, but locally running the spelling linter and the cirrus job at https://cirrus-ci.com/task/5004066998714368 both LGTM. Thanks for also verifying and removing the unused words from the ignore list.
Tree-SHA512: e92ae6f16c01d4ff3d54f8c3a0ee95e12741f7bfe031d307a785f5cfd8a80525b16b34275f413b914c4a318f5166f9887399c21f2dad9cc7e9be41647042ef37
|
|
fad140e311028f904635126e3c77352afac1b75e test: Set correct nValue for multi-op-return policy check (MarcoFalke)
Pull request description:
`CTxOut::nValue` is default-initialized to `-1`. The dust-threshold for `OP_RETURN` outputs is `0`. Thus, the policy failure would be `dust` instead of `multi-op-return`. The test only passes because the dust check is currently not run.
Avoid that confusion by setting the value to `0`, to ensure the dust check passes.
ACKs for top commit:
theStack:
ACK fad140e311028f904635126e3c77352afac1b75e
Tree-SHA512: f0c7a68eb2c573d6595b2b129fa8fa2a34fa35c17691f448bf1c54ccf66059c37562e7480cde7b51c4de677038d7717873da4257147a5f60acc8bbcd25fb7e3f
|
|
efaf80e9bb0afeca2955720bfe6c225d7864036b fuzz: check that certain script TxoutType are nonstandard (Michael Dietz)
Pull request description:
- Every transaction of type NONSTANDARD must not be a standard script
- The only know types of nonstandard scripts are NONSTANDARD and certain NULL_DATA and MULTISIG scripts
When reviewing https://github.com/bitcoin/bitcoin/pull/20761 I figured this is very similar and might also be good to have
ACKs for top commit:
MarcoFalke:
ACK efaf80e9bb0afeca2955720bfe6c225d7864036b
Tree-SHA512: 6f563ee3104ea9d2633aad95f1d003474bea759d0f22636c37aa91b5536a6ff0800c42447285ca8ed12f1b3699bf781dae1e5e0a3362da578749cd3164a06ea4
|
|
0dade9154d2e5d4b1725fbe27720d54396c4db1d fuzz: remove no-longer-necessary packages from fuzzbuzz config (fanquake)
Pull request description:
I take it this is actively being used, given [comments in #20560](https://github.com/bitcoin/bitcoin/pull/20560#issuecomment-743747317); so remove old dependencies from setup.
ACKs for top commit:
practicalswift:
ACK 0dade9154d2e5d4b1725fbe27720d54396c4db1d
Tree-SHA512: 781466776575e6051d0dddf4101bd057e484648f63e8e967240fefbf4b5832cacda6f6543708a0c368214a1efe0d60d371da78d7a920646cb93f1a4752aaf639
|
|
|
|
ee701a92041c33f62b4e1adc3b10d2f1bb74f4c8 doc: update developer notes for signet (Jon Atack)
Pull request description:
Preview with working anchor links:
https://github.com/jonatack/bitcoin/blob/add-signet-to-developer-notes/doc/developer-notes.md
ACKs for top commit:
0xB10C:
ACK ee701a92041c33f62b4e1adc3b10d2f1bb74f4c8
michaelfolkson:
ACK ee701a92041c33f62b4e1adc3b10d2f1bb74f4c8
MarcoFalke:
ACK ee701a92041c33f62b4e1adc3b10d2f1bb74f4c8
Tree-SHA512: 12f0a81a701d9fd48e1f314e7a66b865309fdcb8f139323410d35c0cfb093d23a2f899249d1b0a025078894cf4789ed7221ae42804a56ab704a8b9ad35077bac
|
|
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
|
|
|
|
|
|
|
|
|
|
faaa4f2b6af4ce249fc4809a030240afa45b1a33 refactor: Remove nMyStartingHeight from CNode/Connman (MarcoFalke)
Pull request description:
CNode and CConnman keep track of the active chain height when CNodes have been created, but apart from serializing the int once (when sending a version message), it is unused. So it can simply be removed in favor of a single int in PeerMan that can do the same.
ACKs for top commit:
jnewbery:
utACK faaa4f2b6af4ce249fc4809a030240afa45b1a33
theStack:
re-ACK faaa4f2b6af4ce249fc4809a030240afa45b1a33 ⚓
Tree-SHA512: 713919e49e0f799c4a5a2e5ab07d1ca1c92d4049829680c4f436f9b3b545c548ddbee78ff80611de50cc91a116a416bcc4602e80ee64953597dc04ca15f9806d
|
|
|
|
|
|
getter, unit tests
86c495223f048e5ca2cf0d8730af7db3b76f7aba net: add CNode::IsInboundOnion() public getter and unit tests (Jon Atack)
6609eb8cb50fe92c7317b5db9e72d4333b3aab1b net: assert CNode::m_inbound_onion is inbound in ctor (Jon Atack)
993d1ecd191a7d9161082d4026f020cbf00835bb test, fuzz: fix constructing CNode with invalid inbound_onion (Jon Atack)
Pull request description:
The goal of this PR is to be able to depend on `m_inbound_onion` in AttemptToEvictConnection in #20197:
- asserts `CNode::m_inbound_onion` is inbound in the CNode ctor to have a validity check at the class boundary
- fixes a unit test and a fuzz utility that were passing invalid inbound onion values to the CNode ctor
- drops an unneeded check in `CNode::ConnectedThroughNetwork()` for its inbound status
- adds a public getter `IsInboundOnion()` that also allows unit testing it
- adds unit test coverage
ACKs for top commit:
sipa:
utACK 86c495223f048e5ca2cf0d8730af7db3b76f7aba
LarryRuane:
ACK 86c495223f048e5ca2cf0d8730af7db3b76f7aba
vasild:
ACK 86c495223f048e5ca2cf0d8730af7db3b76f7aba
MarcoFalke:
review ACK 86c495223f048e5ca2cf0d8730af7db3b76f7aba 🐍
Tree-SHA512: 21109105bc4e5e03076fadd489204be00eac710c9de0127708ca2d0a10a048ff81f640f589a7429967ac3eb51d35fe24bb2b12e53e7aa3efbc47aaff6396d204
|
|
|
|
ccc8d5513fb2228eabc25b105f7a0498f8453885 doc: Update license year range to 2021 (Emil Engler)
Pull request description:
See #17801, #15061
The same procedure as every year. Happy new year to all of you :)
Top commit has no ACKs.
Tree-SHA512: 59ca9ba43d3722d5e2ada04fe6c361058a72c84b8437f6331f45e361d7ebf0f3586ccb02dc72af12b9d94f766897f0f041ce3a90efe95eeff22217f9f964ffc6
|
|
fa0074e2d82928016a43ca408717154a1c70a4db scripted-diff: Bump copyright headers (MarcoFalke)
Pull request description:
Needs to be done because no one has removed the years yet
ACKs for top commit:
practicalswift:
ACK fa0074e2d82928016a43ca408717154a1c70a4db
Tree-SHA512: 210e92acd7d400b556cf8259c3ec9967797420cfd19f0c2a4fa54cb2b3d32ad9ae27e771269201e7d554c0f4cd73a8b1c1a42c9f65d8685ca4d52e5134b071a3
|
|
fa5b935840e857a36e01579eeed7011a0359931b fuzz: Remove duplicate ALL_OUTPUT_TYPE array (MarcoFalke)
fafce49336e18033b26948886bbd7342c779b246 fuzz: Bump FuzzedDataProvider.h (MarcoFalke)
Pull request description:
ACKs for top commit:
practicalswift:
ACK fa5b935840e857a36e01579eeed7011a0359931b
Tree-SHA512: eacf97f26869fb226d7ac5ea1f8204b25ebb7551d084af0da02cc1a850a1fdf7d7a4919386b7f27ab9acb1873f63aafe9ad9f8ea2668aea366e11c7c0991a2f4
|
