aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-06-21Take the training wheels off anti-fee-snipingPeter Todd
Now that the off-by-one error w/nLockTime txs issue has been fixed by 87550eef (75a4d512 in the 0.11 branch) we can make the anti-fee-sniping protection create transactions with nLockTime set such that they're only valid in the next block, rather than an earlier block. There was also a concern about poor propagation, however testing with transactions with nLockTime = GetAdjustedTime()+1 as a proxy for nLockTime propagation, as well as a few transactions sent the moment blocks were received, has turned up no detectable issues with propagation. If you have a block at a given height you certainly have at least one peer with that block who will accept the transaction. That peer will certainly have other peers who will accept it, and soon essentially the whole network has the transaction. In particular, if a node recives a transaction that it rejects due to the tx being non-final, it will be accepted again later as it winds its way around the network.
2015-06-19Merge pull request #6262Wladimir J. van der Laan
506bae3 Return all available information via validateaddress (dexX7)
2015-06-19Merge pull request #6290Wladimir J. van der Laan
57092ed rpc: make `gettxoutsettinfo` run lock-free (Wladimir J. van der Laan)
2015-06-19Merge pull request #6307Wladimir J. van der Laan
1c043d5 fix lock issue for QT node diconnect and RPC disconnectnode (Jonas Schnelli) 932687b setban: add IPv6 tests (Jonas Schnelli) 62909f6 fix missing lock in CNode::ClearBanned() (Jonas Schnelli)
2015-06-19fix lock issue for QT node diconnect and RPC disconnectnodeJonas Schnelli
2015-06-19Merge pull request #6301Wladimir J. van der Laan
82e6487 Adding pgp public key for cdecker as requested by @jonasschnelli in bitcoin/gitian.sigs#182 (Christian Decker)
2015-06-19Merge pull request #6305Wladimir J. van der Laan
a4d9f95 build: comparison tool swap (Cory Fields)
2015-06-19setban: add IPv6 testsJonas Schnelli
2015-06-19fix missing lock in CNode::ClearBanned()Jonas Schnelli
2015-06-19build: comparison tool swapCory Fields
This should be functionally identical to what's in place now. It was built from https://github.com/theuni/bitcoinj/commit/be0eef774462409df277b2a83d71c30451f107c5 That commit is the same as this pruned commit in TheBlueMatt's repo: https://github.com/TheBlueMatt/bitcoinj/commit/0f7b5d8 Now we'll be able to trust the line numbers in the stack traces.
2015-06-18Adding pgp public key for cdecker as requested by @jonasschnelli in ↵Christian Decker
bitcoin/gitian.sigs#182
2015-06-18Merge pull request #6272Wladimir J. van der Laan
edbdf88 tests: Extend RPC proxy tests (Wladimir J. van der Laan) baf0507 Improve proxy initialization (Wladimir J. van der Laan)
2015-06-18Merge pull request #6158Wladimir J. van der Laan
9d79afe add RPC tests for setban & disconnectnode (Jonas Schnelli) 1f02b80 setban: add RPCErrorCode (Jonas Schnelli) d624167 fix CSubNet comparison operator (Jonas Schnelli) 4e36e9b setban: rewrite to UniValue, allow absolute bantime (Jonas Schnelli) 3de24d7 rename json field "bannedtill" to "banned_until" (Jonas Schnelli) 433fb1a [RPC] extend setban to allow subnets (Jonas Schnelli) e8b9347 [net] remove unused return type bool from CNode::Ban() (Jonas Schnelli) 1086ffb [QA] add setban/listbanned/clearbanned tests (Jonas Schnelli) d930b26 [RPC] add setban/listbanned/clearbanned RPC commands (Jonas Schnelli) 2252fb9 [net] extend core functionallity for ban/unban/listban (Jonas Schnelli)
2015-06-18Merge pull request #6282Wladimir J. van der Laan
0ce30ea fix crash on shutdown when e.g. changing -txindex and abort action (Philip Kaufmann)
2015-06-17add RPC tests for setban & disconnectnodeJonas Schnelli
2015-06-17setban: add RPCErrorCodeJonas Schnelli
2015-06-17fix CSubNet comparison operatorJonas Schnelli
2015-06-17setban: rewrite to UniValue, allow absolute bantimeJonas Schnelli
2015-06-17rename json field "bannedtill" to "banned_until"Jonas Schnelli
2015-06-17[RPC] extend setban to allow subnetsJonas Schnelli
2015-06-17[net] remove unused return type bool from CNode::Ban()Jonas Schnelli
2015-06-17[QA] add setban/listbanned/clearbanned testsJonas Schnelli
2015-06-17[RPC] add setban/listbanned/clearbanned RPC commandsJonas Schnelli
2015-06-17[net] extend core functionallity for ban/unban/listbanJonas Schnelli
2015-06-17Merge pull request #6280Wladimir J. van der Laan
b19a88b depends: fix Boost 1.55 build on GCC 5 (Jacob Welsh)
2015-06-17Merge pull request #6286Wladimir J. van der Laan
a3a80c2 remove berkeley-db4 workaround (rion)
2015-06-16fix crash on shutdown when e.g. changing -txindex and abort actionPhilip Kaufmann
- fixes #3136 - the problem is related to Boost path and a static initialized internal pointer - using a std::string in CDBEnv::EnvShutdown() prevents the problem - this removes the boost::filesystem::path path field from CDBEnv
2015-06-16Merge pull request #6271Wladimir J. van der Laan
60dbe73 New RPC command disconnectnode (Alex van der Peet)
2015-06-16New RPC command disconnectnodeAlex van der Peet
2015-06-16Merge pull request #6283Wladimir J. van der Laan
26a639e remove using namespace std from addrman.cpp (Philip Kaufmann) 40c592a make CAddrMan::size() return the correct type of size_t (Philip Kaufmann)
2015-06-16Merge pull request #6285Wladimir J. van der Laan
72bf90d Fix scheduler build with some boost versions. (Cory Fields)
2015-06-16rpc: make `gettxoutsettinfo` run lock-freeWladimir J. van der Laan
For leveldb "An iterator operates on a snapshot of the database taken when the iterator is created". This means that it is unnecessary to lock out other threads while computing statistics, and neither to hold cs_main for the whole time. Let the thread run free.
2015-06-15remove berkeley-db4 workaroundrion
"brew install berkeley-db4" appears to be working again. simplified instructions by removing the berkeley-db4 workaround.
2015-06-15Fix scheduler build with some boost versions.Cory Fields
Some boost versions have a conflicting overload of wait_until that returns void. Explicitly use a template here to avoid hitting that overload.
2015-06-15remove using namespace std from addrman.cppPhilip Kaufmann
2015-06-15make CAddrMan::size() return the correct type of size_tPhilip Kaufmann
2015-06-15tests: Extend RPC proxy testsWladimir J. van der Laan
Also test -noonion
2015-06-15Merge pull request #6274Wladimir J. van der Laan
02a6702 Add option `-alerts` to opt out of alert system (Wladimir J. van der Laan)
2015-06-15Add option `-alerts` to opt out of alert systemWladimir J. van der Laan
Make it possible to opt-out of the centralized alert system by providing an option `-noalerts` or `-alerts=0`. The default remains unchanged. This is a gentler form of #6260, in which I went a bit overboard by removing the alert system completely. I intend to add this to the GUI options in another pull after this.
2015-06-15Merge pull request #6269Wladimir J. van der Laan
c110575 gitian: Use the new bitcoin-detached-sigs git repo for OSX signatures (Cory Fields)
2015-06-15Merge pull request #6257Wladimir J. van der Laan
ef2a3de Add paytxfee to getwalletinfo, warnings to getnetworkinfo (Stephen)
2015-06-15Merge pull request #6276Wladimir J. van der Laan
7d6a85a Fix getbalance * (Tom Harding)
2015-06-15doc: Add section on plurals to strings policyWladimir J. van der Laan
Thanks to @pryds for explaining this to me on Transifex.
2015-06-13depends: fix Boost 1.55 build on GCC 5Jacob Welsh
Boost assumes variadic templates are always available in GCC 4.4+, but they aren't since we don't build with -std=c++11. This applies the patch that fixed the issue in boost 1.57: https://github.com/boostorg/config/commit/eec808554936ae068b23df07ab54d4dc6302a695 See also: https://svn.boost.org/trac/boost/ticket/10500
2015-06-12Fix getbalance *Tom Harding
Chance "getbalance *" not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance * 0" now works. Also fixed a comment -- GetGalance has required 1 confirmation for many years, and the default "getbalance *" behavior matches that.
2015-06-12Merge pull request #6209Wladimir J. van der Laan
e059726 [Qt] deselect peer when switching away from peers tab in RPC console (Philip Kaufmann) 7211ada [Qt] replace Boost foreach with Qt version peertablemodel.cpp (Philip Kaufmann) 1b0db7b [Qt] extend rpc console peers tab (Philip Kaufmann)
2015-06-12Merge pull request #6256Wladimir J. van der Laan
65b9454 Use best header chain timestamps to detect partitioning (Gavin Andresen)
2015-06-12Improve proxy initializationWladimir J. van der Laan
Simplify and make the code in AppInit2 more clear. This provides a straightforward flow, gets rid of .count() (which makes it possible to override an earlier provided proxy option to nothing), as well as comments the different cases.
2015-06-12Merge pull request #6266Wladimir J. van der Laan
0cc7b23 Fix univalue handling of \u0000 characters. (Daniel Kraft)
2015-06-11Add paytxfee to getwalletinfo, warnings to getnetworkinfoStephen