aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-07-13Merge pull request #411 from TheBlueMatt/masterGavin Andresen
Fix Build in GetReservedKey() in wallet.cpp
2011-07-14Fix Build in GetReservedKey() in wallet.cppMatt Corallo
2011-07-13Merge pull request #410 from TheBlueMatt/masterGavin Andresen
Generate Warning when using default key.
2011-07-14Generate Warning when using default key.Matt Corallo
2011-07-13Merge pull request #409 from TheBlueMatt/masterJeff Garzik
Fix crashes when a wallet is locked and GetReservedKey() is called
2011-07-14Fix crashes when a wallet is locked and GetReservedKey() is calledMatt Corallo
2011-07-13Merge pull request #406 from muggenhor/warning-fixesJeff Garzik
Warning fixes
2011-07-13Merge pull request #405 from sipa/syncdefaultJeff Garzik
Bugfix: add autogenerated addresses to address book
2011-07-13fix warning: control reaches end of non-void function [-Wreturn-type]Giel van Schijndel
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13fix warning: variable ‘nMinDepth’ set but not used ↵Giel van Schijndel
[-Wunused-but-set-variable] Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13Merge pull request #404 from TheBlueMatt/newencPieter Wuille
Fix makefile.linux-mingw
2011-07-13Fix makefile.linux-mingwMatt Corallo
2011-07-13Bugfix: add autogenerated addresses to address bookPieter Wuille
2011-07-13doc/README: word wrap into something readableJeff Garzik
2011-07-13Bump version to 0.3.25Jeff Garzik
Yes, we might release as v0.4, but let's just do a simple increment for now.
2011-07-13Update CWallet::LoadWallet for proper return type.Jeff Garzik
2011-07-12Merge pull request #399 from muggenhor/warning-fixesJeff Garzik
Warning fixes
2011-07-13fix warning: unused function 'SigIllHandlerSSE2' [-Wunused-function]Giel van Schijndel
Only declare & define SigIllHandlerSSE2 when its used. Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13fix warning: unused variable 'X' [-Wunused-variable]Giel van Schijndel
Remove several unused variables. Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13fix warning: X enumeration values not handled in switch [-Wswitch-enum]Giel van Schijndel
Add default cases to opcode switches to assert that they should never occur. Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13fix warning: comparison of unsigned expression < 0 is always false ↵Giel van Schijndel
[-Wtautological-compare] Don't check for a negative parameter count, because not only will it never happen, it doesn't make any sense either. Invalid sockets (as returned by socket(2)) are always exactly -1 (not just negative as negative file descriptors are technically not prohibited by POSIX) on POSIX systems. Since we store them in SOCKET (unsigned int), however, that really is ~0U (or MAX_UINT) which happens to be what INVALID_SOCKET is already defined to, so an additional check for being negative is not only unnecessary (unsigned integers aren't *ever* negative) its redundant as well (the INVALID_SOCKET comparison is enough). Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13fix warnings: using the result of an assignment as a condition without ↵Giel van Schijndel
parentheses [-Wparentheses] Don't unnecessarily assign to variables within the *boolean* expression of a conditional. Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13fix warnings: expression result unused [-Wunused-value]Giel van Schijndel
In the assert()s take advantage of the fact that string constants ("string") are effectively of type 'const char []', which when used in an expression yield a non-NULL pointer. An assertion that should always fail can thus be formulated as: assert(!"fail); An assertion where a text message should be added to the expression can be written as such: assert("message" && expression); Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13fix warning on 64bit systems: cast to pointer from integer of different size ↵Giel van Schijndel
[-Wint-to-pointer-cast] Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-12Update makefile.linux-mingw to work with crypter and UPnP fix.Matt Corallo
2011-07-12Merge pull request #381 from TheBlueMatt/nminversionJeff Garzik
Add minversion to wallet.
2011-07-12Merge pull request #402 from jayschwa/hirez-iconJeff Garzik
High resolution Windows icon
2011-07-12Merge pull request #396 from jayschwa/nsis-brandingJeff Garzik
Add bitcoin.org logos/branding to NSIS installer.
2011-07-12Merge pull request #352 from TheBlueMatt/newencJeff Garzik
Wallet Private Key Encryption (on CWallet)
2011-07-12Increase resolution of Windows icon.Jay Weisskopf
The .ico file has changed in the following ways: * Added 64x64 layer (max size for "Classic Mode"). * Added 256x256 layer (max size for Vista and 7). * Removed copies with no alpha channel: * Display depths lower than 32-bits are rare nowadays. * 8-bit alpha channels in icons has been supported since XP. * If the display depth is lowered, they look no better than the downsampled versions that Windows automatically generates. Tested various sizes on both XP and Win 7. It looks fine (unchanged) on XP and downright sexy on Win 7.
2011-07-13Make an invalid addrIncoming so that old clients crash.Matt Corallo
This prevents old clients from opening, and thus corrupting or otherwise causing harm to encrypted wallets.
2011-07-13Use DB Transactions when encrypting wallet.Matt Corallo
This speeds up the encryption process significantly.
2011-07-13Do not use obsolete CPrivKey for passing keys aroundPieter Wuille
2011-07-13Add Wallet Encryption section to READMEMatt Corallo
2011-07-13Add the walletlock RPC method to lock the wallet manually.Matt Corallo
2011-07-13Dynamically remove/insert the Options for encryption in the menus.Matt Corallo
2011-07-13Push unlocked_until in getinfo.Matt Corallo
2011-07-13Set the number of SHA512 rounds based on the speed of the computer.Matt Corallo
2011-07-13Add wallet privkey encryption.Matt Corallo
This commit adds support for ckeys, or enCrypted private keys, to the wallet. All keys are stored in memory in their encrypted form and thus the passphrase is required from the user to spend coins, or to create new addresses. Keys are encrypted with AES-256-CBC using OpenSSL's EVP library. The key is calculated via EVP_BytesToKey using SHA512 with (by default) 25000 rounds and a random salt. By default, the user's wallet remains unencrypted until they call the RPC command encryptwallet <passphrase> or, from the GUI menu, Options-> Encrypt Wallet. When the user is attempting to call RPC functions which require the password to unlock the wallet, an error will be returned unless they call walletpassphrase <passphrase> <time to keep key in memory> first. A keypoolrefill command has been added which tops up the users keypool (requiring the passphrase via walletpassphrase first). keypoolsize has been added to the output of getinfo to show the user the number of keys left before they need to specify their passphrase (and call keypoolrefill). Note that walletpassphrase will automatically fill keypool in a separate thread which it spawns when the passphrase is set. This could cause some delays in other threads waiting for locks on the wallet passphrase, including one which could cause the passphrase to be stored longer than expected, however it will not allow the passphrase to be used longer than expected as ThreadCleanWalletPassphrase will attempt to get a lock on the key as soon as the specified lock time has arrived. When the keypool runs out (and wallet is locked) GetOrReuseKeyFromPool returns vchDefaultKey, meaning miners may start to generate many blocks to vchDefaultKey instead of a new key each time. A walletpassphrasechange <oldpassphrase> <newpassphrase> has been added to allow the user to change their password via RPC. Whenever keying material (unencrypted private keys, the user's passphrase, the wallet's AES key) is stored unencrypted in memory, any reasonable attempt is made to mlock/VirtualLock that memory before storing the keying material. This is not true in several (commented) cases where mlock/VirtualLocking the memory is not possible. Although encryption of private keys in memory can be very useful on desktop systems (as some small amount of protection against stupid viruses), on an RPC server, the password is entered fairly insecurely. Thus, the only main advantage encryption has for RPC servers is for RPC servers that do not spend coins, except in rare cases, eg. a webserver of a merchant which only receives payment except for cases of manual intervention. Thanks to jgarzik for the original patch and sipa, gmaxwell and many others for all their input. Conflicts: src/wallet.cpp
2011-07-12Remove NSIS branding from bottom divider.Jay Weisskopf
2011-07-11Set default compression for NSIS installer to LZMA.Jay Weisskopf
Use of LZMA (versus the current zlib) shaves a few MB off the installer.
2011-07-11Add logos/branding currently found on bitcoin.org into NSIS installer.Jay Weisskopf
2011-07-10Make mlock() and munlock() portable to systems that require the address to ↵Doug Huff
be on a page boundary.
2011-07-09Merge pull request #392 from laanwj/antimagicJeff Garzik
Remove another magic number: change threshold for nLockTime to constant
2011-07-09remove magic number: change threshold for nLockTime to constantWladimir J. van der Laan
2011-07-08Compile 'sv' translationv0.3.24Jeff Garzik
2011-07-08Merge pull request #376 from codler/translateJeff Garzik
Minor translation changes for latest build (Swedish)
2011-07-08mlock() all private keys in memoryDylan Noblesmith
Inline comment and idea come from the encprivkeys branch by Matt Corallo <matt@bluematt.me>.
2011-07-08Prepare codebase for Encrypted Keys.Pieter Wuille
2011-07-05Merge pull request #383 from sipa/syncdefaultv0.3.24rc3Jeff Garzik
Fix synchronization of default key