Age | Commit message (Collapse) | Author |
|
4412c5a Fix `getaddednodeinfo` RPC call with dns=false (Wladimir J. van der Laan)
|
|
The getaddednodeinfo RPC call, when invoked with the dns flag set to
false, returns a malformed JSON object with duplicate keys.
Change this to return an array of objects with one key as
shown in the help message.
Fixes #3581.
|
|
69d03bc qt: Fix tab order in send and receive tab (Wladimir J. van der Laan)
79fb055 [Qt] minor receive tab improvements (Cozz Lovan)
|
|
|
|
|
|
3cf1f43 Mention `*` value for account in documentation for `getbalance` RPC (Wladimir J. van der Laan)
|
|
- remove btc address length from address validator
- add an optional btc address check in validated line edit that defaults
to off and is used in GUIUtil::setupAddressWidget()
- an isAcceptable() check is added to validated line edit on focus out
which only kicks in, when a validator is used with that widget
- remove an isAcceptable() check from sendcoinsentry.cpp
- remove obsolete attributes from ui files, which are set by calling
GUIUtil::setupAddressWidget()
- move some more things to GUIUtil::setupAddressWidget() and remove them
from normal code e.g. placeholder text
|
|
|
|
4c0b2cd Win32: use a more modern API call in FileCommit() (Philip Kaufmann)
|
|
As reported by @Subo1978, error messages don't have a trailing newline
anymore after commit b77dfdc9. Add back this newline.
|
|
e5aadb2 Updated fallback seed nodes from sipa's DNS seeds (Gavin Andresen)
|
|
c7f9332 Add check for valid keys in `importprivkey` (Wladimir J. van der Laan)
|
|
edd735d [Qt] Fix coin control labels update (Cozz Lovan)
|
|
d7aa1ec [Qt] fix bitcoin: URI strings (spelling fixes) (Philip Kaufmann)
|
|
|
|
The base58 armoring was checked, but not the resulting private key,
which could be out of range. Fix this by adding a check.
|
|
6986861 build: use -mwindows for gui targets when linking with mingw (Cory Fields)
|
|
use english for all reason strings in IsStandardTx()
|
|
|
|
|
|
|
|
665bdd3 Fix off-by-one errors in use of IsFinalTx() (Peter Todd)
|
|
Update English .ts file from source as well as pull changes from transifex
to current translation.
|
|
f3005c8 [Qt] harmonize strings used when exporting in addressbookpage (Philip Kaufmann)
|
|
|
|
Previously CreateNewBlock() didn't take into account the fact that
IsFinalTx() without any arguments tests if the transaction is considered
final in the *current* block, when both those functions really needed to
know if the transaction would be final in the *next* block.
Additionally the UI had a similar misunderstanding.
Also adds some basic tests to check that CreateNewBlock() is in fact
mining nLockTime-using transactions correctly.
Thanks to Wladimir J. van der Laan for rebase.
|
|
|
|
Unit test fixes for AssertLockHeld / -DDEBUG_LOCKORDER
|
|
Unit tests would fail if compiled with -DDEBUG_LOCKORDER (AssertLockHeld()
would fail; AssertLockHeld() relies on the DEBUG_LOCKORDER code to keep
track of locks held).
Fixed by LOCK'ing the wallet mutex in the unit tests that manipulate the
wallet.
|
|
57feb1b ui: Clarify help messages for 'message' fields (Wladimir J. van der Laan)
|
|
Add or amend tooltips to clarify what the message is for and that it
doesn't go over the network.
|
|
7d9d134 Remove redundant .c_str()s (Wladimir J. van der Laan)
b77dfdc Typesafe strprintf/error/LogPrint functions (Wladimir J. van der Laan)
|
|
After the tinyformat switch sprintf() family functions support passing
actual std::string objects.
Remove unnecessary c_str calls (236 of them) in logging and formatting.
|
|
Switch to tinyformat-based formatting.
Tinyformat is a typesafe drop-in replacement for C99 printf functions:
https://github.com/c42f/tinyformat
|
|
--with-qt-libdir etc, not --with-gui-libdir.
The typo was introduced in a9dbcf036bc866c2e413b1d068541e35eafdfcd0.
|
|
17b409b qt: Fix richtext detection hang issue on very old Qt versions (Wladimir J. van der Laan)
|
|
Alternative implementation. Thanks to @awoland for the original.
Fixes #3486.
|
|
a8db31c qt: allow `walletpassphrase` in debug console without -server (Wladimir J. van der Laan)
|
|
fe14e8d build: Change package name to Bitcoin Core (Wladimir J. van der Laan)
6c980c7 build: Package docs/ and don't package source. (Wladimir J. van der Laan)
39db27c build: Add bitcoin-cli.exe to installer (Wladimir J. van der Laan)
2f87b38 Adapt Windows installer for 64 bit (Wladimir J. van der Laan)
f622232 gitian: Windows 64 bit support (Wladimir J. van der Laan)
|
|
f021981 [Qt] move helpmessage from debug window to main menu (Philip Kaufmann)
|
|
- the option to show our help message dialog resides now in main menu
under help
|
|
4bee715 [Qt] very minor style cleanups (Philip Kaufmann)
|
|
22a5120 [Qt] Show and store message of normal bitcoin:URI (Cozz Lovan)
|
|
6ac0b3b build: Add -static for mingw builds (Wladimir J. van der Laan)
4e57e23 enable full GCC Stack-smashing protection for all OSes (Philip Kaufmann)
|
|
This avoids a dependency on libssp-0.dll when built with
-fstack-protector-all.
|
|
- rebuilt some ui file layout to remove unreal values from the files
- remove an unneeded attribute from an ui file
- add / remove some spaces in files
|
|
- change our hardening options to use -fstack-protector-all even for
Windows builds, as we recently switched to a newer compiler suite
- also removes an obsolete workaround for GCC 4.5
(https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/691722), which
required to first set -fno-stack-protector, before -fstack-protector-all
|
|
1ba3560 [Qt] let OptionsModel::getProxySettings() directly query proxy (Philip Kaufmann)
|
|
4d90102 [Qt] Add sorting feature to the requested payments table (Cozz Lovan)
8476d5d [Qt] Permanently store requested payments in wallet (Cozz Lovan)
b10e147 wallet: add interface for storing generic data on destinations (Wladimir J. van der Laan)
|
|
1f12844 Fix importprivkey / rescan (Cozz Lovan)
|