aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-08-19Move CAddress to protocol.[ch]ppGiel van Schijndel
This commit does *not* and should not modify *any* code, it only moves it from net.h and splits it across protocol.cpp and protocol.hpp. Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-08-19Start moving protocol-specific code to protocol.[ch]ppGiel van Schijndel
Move CMessageHeader from net.h to protocol.[ch]pp, with the implementation in the .cpp compilation unit (compiling once is enough). This commit does *not* and should not modify *any* code, it only moves it from net.h and splits it across protocol.cpp and protocol.hpp. Indentation changes aside the closest thing to a modification of code is the addition of the 'TODO' comment (the execution of which requires code modifications and thus doesn't belong in this commit). Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-08-19Move func 'REF' from util.h to serialize.hGiel van Schijndel
util.h doesn't use REF, serialize.h does, creating a dependency of serialize.h on util.h, but util.h already depends on serialize.h. To resolve this circular dependency the function 'REF' has now been moved closer to one of its two points of use. Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-08-19Cleanup makefiles such that diffs to them are smallerGiel van Schijndel
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-08-19Make some global variables less-global (static)Giel van Schijndel
Explicitly make these global variables less-global to reduce the maximum scope of this global state. In my experience global variables tend to be a major source of bugs. As such the less accessible they are the less likely they are to be the source of a bug. Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-08-17Compile with DEBUG_LOCKORDER to detect inconsistent lock orderings that can ↵Gavin Andresen
cause deadlocks
2011-08-16Remove unused ScanMessageStart functionGavin Andresen
2011-08-16src/makefile.unix: remove -DFOURWAYSSE2Jeff Garzik
Spotted by Venkatesh Srinivas <me@endeavour.zapto.org>
2011-08-12Don't std::advance past beginning of transactions array. Fixes #465Gavin Andresen
2011-08-11Merge pull request #458 from TheBlueMatt/copyrightGavin Andresen
Unify copyright notices.
2011-08-10Merge pull request #459 from jgarzik/char-msgstartGavin Andresen
Use 'unsigned char' rather than 'char' for pchMessageStart.
2011-08-10Merge pull request #460 from jgarzik/make-tupleGavin Andresen
Qualify make_tuple with boost:: namespace.
2011-08-10Use 'unsigned char' rather than 'char' for pchMessageStart.Venkatesh Srinivas
Regarding https://bitcointalk.org/index.php?topic=28022.0 main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };" Per discussion on the thread linked, leaving the signedness of pchMessageStart is unsafe for values > 0x80. This patch specifies 'unsigned char' in main.cpp and net.h. Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
2011-08-10Qualify make_tuple with boost:: namespace.Venkatesh Srinivas
db.cpp has a number of uses of make_tuple and has 'using namespace std' and 'using namespace boost'. Without qualifying make_tuple, std::make_tuple is preferred, which is incorrect. This patch qualifies make_tuple. Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
2011-08-10Test for SO_NOSIGPIPE rather than assuming all BSDs support it.Venkatesh Srinivas
Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
2011-08-09Do-nothing MapPort() ifndef USE_UPNP. fixes #450Gavin Andresen
2011-08-09Unify copyright notices.Matt Corallo
To a variation on: // Copyright (c) 2009-2010 Satoshi Nakamoto // Copyright (c) 2011 The Bitcoin developers
2011-08-08Cleanup test suite output to be more useful.Matt Corallo
2011-08-08Add file for transaction tests.Matt Corallo
2011-08-08Add a file for script testsVegard Nossum
2011-08-08Add prototype for EvalScript() to script.hVegard Nossum
This is needed for the script unit tests.
2011-08-08Fix testing setupVegard Nossum
There were some problems with the existing testing setup: - Makefile rules for test-file compilation used CFLAGS instead of CXXFLAGS in makefile.unix
2011-08-08Add missing include to serialize.hMatt Corallo
2011-08-08Add missing includes to net.hVegard Nossum
2011-08-08Add missing include to script.hVegard Nossum
2011-08-08Add missing includes to key.hVegard Nossum
2011-08-08Merge pull request #443 from TheBlueMatt/dupinGavin Andresen
Check for duplicate txins in CheckTransaction.
2011-08-04Merge branch 'tmp2'Jeff Garzik
2011-08-04Merge pull request #448 from sipa/cbitcoinaddressJeff Garzik
avoid strAddress + validity checks
2011-08-04Merge pull request #446 from WakiMiko/upnp-descJeff Garzik
Identify as "Bitcoin + version number" when mapping UPnP port
2011-08-04Merge pull request #451 from TheBlueMatt/tornolistenJeff Garzik
Don't listen if on TOR (resolves #441).
2011-08-03Don't listen if on TOR (resolves #441).Matt Corallo
2011-08-03Make it clear that setting proxy requires restart to fully apply.Matt Corallo
2011-08-03avoid strAddress + validity checksPieter Wuille
Avoid references to addresses using strings, and use CBitcoinAddress as much as possible. Also added some validity checks on addresses entered using RPC.
2011-08-01Merge pull request #444 from Jeroenz0r/patch-2Pieter Wuille
Translation from "Open Bitcoin" to "Verstuur Bitcoins"
2011-08-01Identify as "Bitcoin + version number" when mapping UPnP portJohannes Henninger
Makes Bitcoin identify itself as "Bitcoin + version number" instead of the nondescript "libminiupnpc" when forwarding a port via UPnP.
2011-07-31Merge pull request #437 from codler/patch-2Gavin Andresen
Comment "deprecated"
2011-08-01Translation from "Open Bitcoin" to "Verstuur Bitcoins"Jeroenz0r
2011-07-31Check for duplicate txins in CheckTransaction.Matt Corallo
2011-07-30Comment "deprecated"Han Lin Yap
2011-07-27Merge pull request #436 from TheBlueMatt/masterPieter Wuille
Fix EncryptKeys crash introduced by a9ba471, identified by TD.
2011-07-27Fix EncryptKeys crash introduced by a9ba4710, identified by TD.Matt Corallo
2011-07-26CAddrDB::LoadAddresses: properly initialize CAddressJeff Garzik
Fixes issue #424
2011-07-26Merge pull request #435 from sipa/fixextractPieter Wuille
Bugfix: don't overuse limited ExtractAddress
2011-07-26Bugfix: don't overuse limited ExtractAddressPieter Wuille
ExtractAddress was called with the keystore as argument in RPC and UI, limiting results to own keys. This caused empty "address" fields.
2011-07-26Merge pull request #434 from laanwj/addkey_retvalPieter Wuille
make SetHash160 return a value (as specified in the function signature)
2011-07-26make SetHash160 return a value (as specified in the function signature)Wladimir J. van der Laan
2011-07-25Fix UNIX-specific thread handle leak.JoelKatz
2011-07-24Merge pull request #403 from sipa/cbitcoinaddressJeff Garzik
keys indexed by address + introduced CBitcoinaddress
2011-07-24Merge pull request #428 from sipa/mintxfeefixPieter Wuille
Fix for small change outputs