| Age | Commit message (Collapse) | Author |
|---|
|
Versions of bitcoin before 0.8.6 have a bug that inserted
empty transactions into the vtxPrev in the wallet, which will cause the node to be
banned when retransmitted, hence add a check for !tx.vin.empty()
before RelayTransaction.
|
|
6c98cca qt: use deleteLater to remove send entries (Wladimir J. van der Laan)
|
|
Use deleteLater() instead of delete, as it is not allowed
to delete widgets directly in an event handler.
Should solve the MacOSX random crashes on send with coincontrol.
|
|
d3207b6 [Qt] coin-control features GUI cleanup 3 (Philip Kaufmann)
834e14e [Qt] coin-control features GUI cleanup 2 (Philip Kaufmann)
|
|
bitcoin-cli: remove unneeded dependencies (only minor code movement)
|
|
Remove unnecessary dependencies for bitcoin-cli
(leveldb, berkelydb, wallet, RPC server)
Build system changes:
- split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and
libbitcoin_cli.a
Code changes (movement only):
- split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli
in rpcclient.cpp
- move uiInterface from init.cpp to util.cpp
|
|
Fix file hash verification error in deps-win32.yml
|
|
Sanitize assert usage and refuse to compile with NDEBUG.
|
|
libpng was being sha256summed twice, and miniupnpc wasn't being checked at all.
|
|
There were quite a few places where assert() was used with side effects,
making operation with NDEBUG non-functional. This commit fixes all the
cases I know about, but also adds an #error on NDEBUG because the code
is untested without assertions and may still have vulnerabilities if
used without assert.
|
|
- remove style sheets from ui files and use Qt attributes instead
- make some more strings untranslatable, to make life for translators
easier
- split up long tooltips an rework the texts a little
|
|
- remove monospace labels from sendcoinsdialog also
- use a validated line edit for the change address
- add a tooltip to change address switch
- ensure we have a valid change address in
CoinControlDialog::coinControl->destChange or just CNoDestination()
- some small ui file changes
|
|
Lossless image optimization
|
|
less bytes, same images
|
|
bae6c7e Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that was not necessary, as the field still receives focus without it. (Ryan Niebur)
|
|
was not necessary, as the field still receives focus without it.
|
|
|
|
mutex debugging routines: LocksHeld() and AssertLockHeld()
|
|
84b695c [Qt] allow deletion of payment-requests in sendcoins (Philip Kaufmann)
|
|
Add verbose flag to getrawmempool
|
|
Also changes mempool to store CTxMemPoolEntries
to keep track of when they enter/exit the pool.
|
|
GetValueIn makes more sense as a CTransaction member.
|
|
This dead code can be resurrected from git history if
transaction replacement is ever implemented. Keeping
dead code in the source is a bad idea, because it implies
it was tested and worked at some point, which is not true.
|
|
9ac5a01 Move types.h include before ifaddres.h for u_int declaration (Robert Backhaus)
|
|
|
|
9d2b73d bitcoin-cli: Add missing SelectParamsFromCommandLine (Wladimir J. van der Laan)
|
|
9e7776b Integration tests via RPC calls (Gavin Andresen)
|
|
The SelectParamsFromCommandLine call was missing in bitcoin-cli,
which caused `-testnet` and `-regtest` to be ignored. Add this
call just like in bitcoind.cpp.
|
|
0078841 prevent Windows redefinition warning cause by compat.h (Philip Kaufmann)
|
|
|
|
fb78cc2 Split up bitcoinrpc (code movement only) (Wladimir J. van der Laan)
|
|
a946aa8 Store and use a sanitized subVer (Mike Hearn)
ba6a4ea Add some additional logging to give extra network insight. (Mike Hearn)
|
|
871ac37 qt: restore icon dock menu (theuni)
|
|
Split bitcoinrpc up into
- rpcserver: bitcoind RPC server
- rpcclient: bitcoin-cli RPC client
- rpcprotocol: shared common HTTP/JSON-RPC protocol code
One step towards making bitcoin-cli independent from the rest
of the code, and thus a smaller executable that doesn't have to
be linked against leveldb.
This commit only does code movement, there are no functional changes.
|
|
qa/rpc-tests/wallet.sh runs a three-node -regtest network,
generates a fresh blockchain, and then exercises basic wallet
sending/receiving functionality using command-line RPC.
|
|
This was removed by 25c0cce7f. It was apparently removed in qt5, but
may return for 5.1.
|
|
|
|
|
|
106f133 Fix uninitialized variable added in b33b9a6fe (theuni)
|
|
After discussing with BlueMatt, this appears to be harmless in its
current state since it's always set before it's used. Initialize it
anyway for readability and future safety.
|
|
c8b7425 setgenerate creates multiple blocks in -regtest mode (Gavin Andresen)
|
|
- this adds a delete button for insecure and secure payment requests in
the sendcoins dialog
- it also enables the delete button even for single and empty entries, as
this is much easier to handle and doesn't need to special case single
entries
- big parts of the ui file were changed, because I copied the delete
button and had to delete the layout too and created it from scratch
(which seems to cleanup the rows and colums in the layout also, which is
nice IMHO)
|
|
e5adec3 contrib: add sipa's github-merge script (Wladimir J. van der Laan)
|
|
|
|
848fe68 cleanup error message consistency (Julian Langschaedel)
|
|
|
|
fb0507f qt: show all units in send confirmation (Wladimir J. van der Laan)
|
|
c89d59c Remove '/': prefix always starts with '/' (Florin)
|
|
relicts from the CTransaction refactor.
|
|
brew --prefix retruns a fully qualified path, so using -L/$prefix results in a path with two leading '/'.
|
