Age | Commit message (Collapse) | Author |
|
some small fixes for main.cpp/.h
|
|
Print error for coinbase-pays-too-much case of ConnectBlock failing
|
|
and associated RPC "listlockunspent".
This is a memory-only filter, which is empty when a node restarts.
|
|
Added security measure.
|
|
make enum and parameter used in Bind() unsigned
|
|
Cleaner and removes the need for the application-specific flags in
serialize.h.
|
|
Introduce script verification flags
|
|
These flags select features to be enabled/disabled during script
evaluation/checking, instead of several booleans passed along.
Currently these flags are defined:
* SCRIPT_VERIFY_P2SH: enable BIP16-style subscript evaluation
* SCRIPT_VERIFY_STRICTENC: enforce strict adherence to pubkey/sig encoding standards.
|
|
VariantClear@4 + shutdown@8 patch
|
|
|
|
- it's good practise to use unsigned int for enum flags, so change this
one, as I introduced this for Bind()
|
|
o Remove unused Leave and GetLock functions
o Make Enter and TryEnter private.
o Simplify Enter and TryEnter.
boost::unique_lock doesn't really know whether the
mutex it wraps is locked or not when the defer_lock
option is used.
The boost::recursive_mutex does not expose this
information, so unique_lock only infers this
knowledge. When taking the lock is defered, it
(randomly) assumes that the lock is not taken.
boost::unique_lock has the following definition:
unique_lock(Mutex& m_,defer_lock_t):
m(&m_),is_locked(false)
{}
bool owns_lock() const
{
return is_locked;
}
Thus it is a mistake to check owns_lock() in Enter
and TryEnter - they will always return false.
|
|
It seemed to create two CWalletDB objects that both grab the
database lock.
|
|
|
|
|
|
add CWalletTx::GetImmatureCredit() and use it in CWallet::GetImmatureBalance()
|
|
|
|
o Removed verbose clang warning
|
|
|
|
- remove an unwanted ";" at the end of the ~CCoinsView() destructor
- in FindBlockPos() and FindUndoPos() only call fclose(), is file is open
- fix an error string in the CBlockUndo class
|
|
leveldb cannot compile with custom CFLAGS / CXXFLAGS / LDFLAGS
|
|
simplify CDBEnv::Open() / fix small glitches
|
|
fix some missing indentations in main.cpp for better readability
|
|
o Removed unused function EndMessageAbortIfEmpty
|
|
API, compatible with clang's -Wthread-safety
|
|
feature in clang. These macros should primarily be used to
document which locks protect a given piece of data. Secondary it
can be used to document the set of held and excluded locks when
entering a function.
|
|
|
|
One-line comments for public main functions
|
|
|
|
|
|
don't use memset() in privacy/security relevant code parts
|
|
|
|
remove printf redefinition from bitcoinrpc.cpp
|
|
Qt: small header changes / fixes
|
|
- remove pathEnv from CDBEnv, as this attribute is not needed
- change path parameter in ::Open() to a reference
- make nDbCache variable an unsigned integer
- remove a missplaced ";" behin ::IsMock()
|
|
allow listening on -bind=address for blocked networks
|
|
- this allows the client to listen on via -bind specified addresses
(e.g. 127.0.0.1), even when a network (IPv4 in that case) was blocked
via e.g -onlynet="Tor"
- introduce enum BindFlags to avoid passing multiple bools to Bind()
- make -bind help text clear we ALWAYS listen on the specified address
- remove an unused variable
- remove 2 unneeded IsLimited() checks before calling Bind(), which does
these checks anyway
- usage case: specify -bind=127.0.0.1 -onlynet="Tor" to allow incoming
connections to a Tor hidden service, but still don't allow other IPv4
nodes to connect / get connected
|
|
|
|
Add -reindex, to perform in-place reindexing of block chain files
|
|
The base bits of pull req #1982.
|
|
Remove -detachdb and stop's detach argument.
|
|
- this way there is no need for an explicit destructor, who does the same
thing anyway
|
|
As memset() can be optimized out by a compiler it should not be used in
privacy/security relevant code parts. OpenSSL provides the safe
OPENSSL_cleanse() function in crypto.h, which perfectly does the job of
clean and overwrite data.
For details see: http://www.viva64.com/en/b/0178/
- change memset() to OPENSSL_cleanse() where appropriate
- change a hard-coded number from netbase.cpp into a sizeof()
|
|
Flushes the blktree/ and coins/ databases, and reindexes the
block chain files, as if their contents was loaded via -loadblock.
Based on earlier work by Jeff Garzik.
|
|
|
|
|
|
|
|
Cache size optimizations
|
|
- ensure header inclusion guard is named after the header file
- add missing comments at the end of some inclusion guards
- add a small Qt5 compatibility fix in macdockiconhandler.h
|
|
|