aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-07-11qt: Do not extend recent transaction width to address/label stringHennadii Stepanov
Github-Pull: bitcoin-core/gui#365 Rebased-From: 9ea1da6fc91e17bdaa722001b97aadf576f07f65
2021-07-11qt: Do not use QClipboard::Selection on Windows and macOS.Hennadii Stepanov
Windows and macOS do not support the global mouse selection. Github-Pull: bitcoin-core/gui#277 Rebased-From: 7f3a5980c1d54988a707b961fd2ef647cebb4c5b
2021-07-08Merge bitcoin/bitcoin#22366: [0.21] fuzz: add missing ECCVerifyHandle to ↵fanquake
base_encode_decode da816247f0c00e1644f7ebe2b848cfd6a5c7026e util: Properly handle -noincludeconf on command line (MarcoFalke) 513613d8a87337f1d1f639bc9426165c3b6be62e Cleanup -includeconf error message (MarcoFalke) 70eac6fcd02b6c44cb4b1f2fb895eae147e3f490 Fix crash when parsing command line with -noincludeconf=0 (MarcoFalke) c5357fa4151e1ac90427ae0493a7bb3e451f8de5 fuzz: add missing ECCVerifyHandle to base_encode_decode (Andrew Poelstra) Pull request description: Backports #22279, #22002 and #22137 to fix fuzzing issues in the 0.21 branch: https://github.com/bitcoin/bitcoin/runs/2864012729. ACKs for top commit: achow101: ACK da816247f0c00e1644f7ebe2b848cfd6a5c7026e Tree-SHA512: ab8751387e42e03ff43594ae34be8ed0dba903d7da1aaecb9f19c08366570d8995abe89ba0c9bafe37662940f3e83bef1e9e50f330e86114cd6a773becd1fd21
2021-07-01Merge bitcoin/bitcoin#22255: [0.21] wallet: Do not iterate a directory if ↵MarcoFalke
having an error while accessing it 7b0b201d109b6240f114498fc1b94af9cb85f26e wallet: Do not iterate a directory if having an error while accessing it (Hennadii Stepanov) Pull request description: This change prevents infinite looping for, for example, system folders on Windows. Github-Pull: #21907 Rebased-From: 29c9e2c2d2015ade47ed4497926363dea3f9c59b Note: Trivial backport, but in a differently-named function in another file ACKs for top commit: hebasto: ACK 7b0b201d109b6240f114498fc1b94af9cb85f26e, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: d41ab267250e8bfd9289cacf1fd804cc1a3bb20fc479dc9da5a69ebf26530b552b11b2ee6b11e17a1c146ca792ee65bd64eeb2269fa5e73a70361da8a2a09925
2021-06-30util: Properly handle -noincludeconf on command lineMarcoFalke
This bug was introduced in commit fad0867d6ab9430070aa7d60bf7617a6508e0586. Unit test Co-Authored-By: Russell Yanofsky <russ@yanofsky.org> Github-Pull: #22137 Rebased-From: fa910b47656d0e69cccb1f31804f2b11aa45d053
2021-06-30Cleanup -includeconf error messageMarcoFalke
Remove the erroneous trailing newline '\n'. Also, print only the first value to remove needless redundancy in the error message. Github-Pull: #22002 Rebased-From: fad0867d6ab9430070aa7d60bf7617a6508e0586
2021-06-30Fix crash when parsing command line with -noincludeconf=0MarcoFalke
Github-Pull: #22002 Rebased-From: fa9f711c3746ca3962f15224285a453744cd45b3
2021-06-29fuzz: add missing ECCVerifyHandle to base_encode_decodeAndrew Poelstra
GitHub Pull: #22279 Rebased-From: 906d7913117c8f10934b37afa27ae8ac565da042
2021-06-19Merge bitcoin/bitcoin#22191: [0.21] gitian: Use custom MacOS code signing toolMarcoFalke
0fe60a84ae2f52e87ee07cd0243f09d45b0b15e2 Use latest signapple commit (Andrew Chow) 5313d6aed2d8bd515401b3782c0bc352af423015 gitian: Remove codesign_allocate and pagestuff from MacOS build (Andrew Chow) 27d691b6b5b4a15dc3d1f9dd248a8880ab3ab326 gitian: use signapple to create the MacOS code signature (Andrew Chow) 2f33e339a8903e79bf750367c073056bea4a9788 gitian: use signapple to apply the MacOS code signature (Andrew Chow) 65ce8330427114c2827d00a658d2e5887349c76a gitian: install signapple in gitian-osx-signer.yml (Andrew Chow) Pull request description: Backport of #20880 and #22190 ACKs for top commit: MarcoFalke: cherry-pick-only ACK 0fe60a84ae 🍀 Tree-SHA512: e864048fab02a1857161602dd53abba552ca3f859c133a47a5e62c28d3e4de9cd099bce86123a1b5892042b09f51cc1ddd2ed1b0c71bfba162710eaee3f5bf91
2021-06-15wallet: Do not iterate a directory if having an error while accessing itHennadii Stepanov
This change prevents infinite looping for, for example, system folders on Windows. Github-Pull: #21907 Rebased-From: 29c9e2c2d2015ade47ed4497926363dea3f9c59b
2021-06-08Use latest signapple commitAndrew Chow
Update gitian and guix to use the same latest signapple commit Github-Pull: #22190 Rebased-From: 683d197970a533690ca1bd4d06d021900e87cb8b
2021-06-08gitian: Remove codesign_allocate and pagestuff from MacOS buildAndrew Chow
Github-Pull: #20880 Rebased-From: 2c403279e2f0f7c8c27c56d4e7b0573c59571f0a
2021-06-08gitian: use signapple to create the MacOS code signatureAndrew Chow
Github-Pull: #20880 Rebased-From: f55eed251488d70d5e2e3a2965a4f8ec0c476853
2021-06-08gitian: use signapple to apply the MacOS code signatureAndrew Chow
Github-Pull: #20880 Rebased-From: 95b06d21852b28712db6c710e420a58bdc1a0944
2021-06-08gitian: install signapple in gitian-osx-signer.ymlAndrew Chow
Github-Pull: #20880 Rebased-From: 42bb1ea363286b088257cabccb686ef1887c1d3b
2021-05-31Merge bitcoin/bitcoin#22022: Final backports for 0.21.2rc1fanquake
09620b89f5f78434080196162c75e3e65cc8d47f Update Windows code signing certificate (Andrew Chow) 46320ba72f80dd865b05bbfe2654cde124859881 Remove user input from URI error message (unknown) f2a88986a18f197f6a4690f5dcca248f6b6170e2 p2p, bugfix: use NetPermissions::HasFlag() in CConnman::Bind() (Jon Atack) Pull request description: ACKs for top commit: achow101: ACK 09620b89f5f78434080196162c75e3e65cc8d47f Diffs match. hebasto: ACK 09620b89f5f78434080196162c75e3e65cc8d47f, tested https://github.com/bitcoin-core/gui/pull/280 behavior. fanquake: ACK 09620b89f5f78434080196162c75e3e65cc8d47f Tree-SHA512: 1c4aaec42ea047261b5d30851bca605540eccf572708403335b38016127d3230b5380b3f5ef03921ed62192239b0d3da9787d51f557ed7911bf6bb2a7c172753
2021-05-22Update Windows code signing certificateAndrew Chow
Github-Pull: bitcoin/bitcoin#22017 Rebased-From: 167fb1fc72e309587a8ef1d7844cb51a5483f54f
2021-05-22Remove user input from URI error messageunknown
+ Detailed error messages for invalid address + Used `IsValidDestination` instead of `IsValidDestinationString` + Referred to https://github.com/bitcoin/bitcoin/pull/20832 for solution Github-Pull: bitcoin-core/gui#280 Rebased-From: 3bad0b3fada9ab7c5b03d31dc33d72654c1ba2be
2021-05-22p2p, bugfix: use NetPermissions::HasFlag() in CConnman::Bind()Jon Atack
PF_NOBAN is a multi-flag that includes PF_DOWNLOAD, so the conditional in CConnman::Bind() using a bitwise AND will return the same result for both the "noban" status and the "download" status. Example: `PF_DOWNLOAD` is `0b1000000` `PF_NOBAN` is `0b1010000` This makes a check like `flags & PF_NOBAN` return `true` even if `flags` is equal to `PF_DOWNLOAD`. If `-whitebind=download@1.1.1.1:8765` is specified, then `1.1.1.1:8765` should be added to the list of local addresses. We only want to avoid adding to local addresses (that are advertised) a whitebind that has a `noban@` flag. As a result of a mis-check in `CConnman::Bind()` we would not have added `1.1.1.1:8765` to the local addresses in the example above. Co-authored-by: Vasil Dimov <vd@FreeBSD.org> Github-Pull: bitcoin/bitcoin#21644 Rebased-From: dde69f20a01acca64ac21cb13993c6e4f8709f23
2021-05-13Merge bitcoin/bitcoin#21932: [0.21] depends: update Qt 5.9 source urlW. J. van der Laan
deff4e763e11f92e5cb7732cace7239fead4fba8 depends: update Qt 5.9 source url (Kittywhiskers Van Gogh) Pull request description: ## Expected Behavior Running `make` in the depends directory should result in the successful building of host platform dependencies ## Actual Behavior `make` terminates as `qt.mk` points to (now) outdated URL path for Qt 5.9 sources, returning error 404 ## Remedy Update `qt.mk` to point to updated source location as Qt has relocated them ACKs for top commit: RandyMcMillan: tACK deff4e7 hebasto: ACK deff4e763e11f92e5cb7732cace7239fead4fba8, I have verified the new link, and checked that old one is unavailable: jarolrod: tACK deff4e763e11f92e5cb7732cace7239fead4fba8 Tree-SHA512: d5b11a678c871a87e6884a35641178ee349728ead51da06018953be36aab5a30aef9c80b549da49802e87903eb0b7836cc343301325bd8c505cb4246f6752505
2021-05-12depends: update Qt 5.9 source urlKittywhiskers Van Gogh
2021-05-05doc: Archive and clean out release notes post-0.21.1W. J. van der Laan
Tree-SHA512: 0ae93cb9dae1449318913a7a6f32c233aefddf77335dc1ad416e84beab39ab45cd863073ddc69a243bbb704951d99646f734717f71d9599a54592699f15d84ab
2021-05-05Merge bitcoin/bitcoin#21860: [0.21] Backport update to Boost download URLMarcoFalke
856de5bd5e4594d12c1d35704c49d0d086fc3d84 build,boost: update download url. (fdov) Pull request description: Backports #21662 to the 0.21 branch. Boost has migrated it's download URLs due to bintrays imminent closure. The Boost site has also been updated to point to the new URLs. i.e: https://www.boost.org/users/history/version_1_70_0.html. Github-Pull: #21662 Rebased-From: 36c10b9f4b181db6afa2f8cb7d4872b158768c16 ACKs for top commit: jarolrod: ACK 856de5bd5e4594d12c1d35704c49d0d086fc3d84 Tree-SHA512: cae7262f963dd6e00af699c3e1bce2ee3ff9f76c5dcc24c8a5bf37025b53de28e4cb80de65a380208ee1841a89736d5c35605e40b728b6c7a9f026d8165d74c8
2021-05-05build,boost: update download url.fdov
- bintray is closing. - updated to jfrog.io. Github-Pull: #21662 Rebased-From: 36c10b9f4b181db6afa2f8cb7d4872b158768c16
2021-04-29build: Bump RC to 0 (-final)v0.21.1W. J. van der Laan
Tree-SHA512: b63d8c2514fa34d4503da8a37fb42948e03610e06dae6aaef7ba3d2568efd3bb138e7510da569a49d83c2618fa697ba949d55880fc2884a75a87028259d7c544
2021-04-22doc: Merge release notes fragment, merge taproot description from wikiW. J. van der Laan
Co-authored-by: David A. Harding <dave@dtrt.org> Co-authored-by: Jon Atack <jon@atack.com> Co-authored-by: Pieter Wuille <pieter@wuille.net> Tree-SHA512: dd9ac416ff22276833111198445d76cf8417012a6faad0c3560276f1dcf24586ff41c65ac3430fbf1e840aaa563d3dd101671cff306b0fd92aa2ee03bb7f926b
2021-04-19doc: Add PR and author list to release notes for 0.21.1W. J. van der Laan
Tree-SHA512: c74b12dee645bd8d3dcff8d572a82369ea0895339d0d12e5360182421fa8cef4d3eba309ff7668e97dc24cd6afc800ab9ceb4eca5458085acf12c368f6c2f859
2021-04-16doc: Regenerate manual pages for 0.21.1rc1v0.21.1rc1W. J. van der Laan
Tree-SHA512: cc9cd502dc40d89f34b1b043e96df180f0e16ba7c6e039866b349d19aff582d1c4b4ab8e8960b4f427d72ad5f97c7c1e8fec3f2e008a0107dea33a2c8f13febc
2021-04-16build: Bump version to 0.21.1rc1W. J. van der Laan
2021-04-16gui: Pre-rc1 translations updateW. J. van der Laan
Tree-SHA512: 6978293bda56b0cb1370f3ddf201477a2f12e0b8c9462d3f4703b837d9be4be65142a5e97c4a473fb9fa90edd83dba8a98ea3b0ecc335062868d1e6c550241b2
2021-04-16Merge #21614: [0.21] test: Backportsfanquake
b8af67eeefc9fc9622f839ec8919b7391d91bf6f fuzz: cleanups for versionbits fuzzer (Anthony Towns) 79cdb4a1984c90a4d9377fbb0dda7bdd61d57031 test: make sure non-IP peers get discouraged and disconnected (Vasil Dimov) b765f41164663c93d63e5a401d3b23c586a4e4fe test: also check disconnect in denialofservice_tests/peer_discouragement (Vasil Dimov) dfeb6c10bba80dc91245318feb0ad1d879015a99 test: use pointers in denialofservice_tests/peer_discouragement (Vasil Dimov) Pull request description: Backport tests ACKs for top commit: vasild: ACK b8af67eeefc9fc9622f839ec8919b7391d91bf6f jnewbery: ACK b8af67eeefc9fc9622f839ec8919b7391d91bf6f ajtowns: ACK b8af67eeefc9fc9622f839ec8919b7391d91bf6f ; visually compared individual commits to originals, checked original commits are in master Tree-SHA512: 22f665560f9d452993b12508d93d93ff54e3e91dcf39f731e27aedfb891570168066c185413d455bee4fa082c011b65ea1b0eee51e3633392b07a0db008d51c8
2021-04-16fuzz: cleanups for versionbits fuzzerAnthony Towns
Github-Pull: #21489 Rebased-From: aa7f418fe32b3ec53285693a7731decd99be4528
2021-04-16test: make sure non-IP peers get discouraged and disconnectedVasil Dimov
Github-Pull: #21571 Rebased-From: 81747b21719b3fa6b0fdfc3b084c0104d64903f9
2021-04-16test: also check disconnect in denialofservice_tests/peer_discouragementVasil Dimov
Use `CConnmanTest` instead of `CConnman` and add the nodes to it so that their `fDisconnect` flag is set during disconnection. Github-Pull: #21571 Rebased-From: 637bb6da368b87711005b909f451f94909400092
2021-04-16test: use pointers in denialofservice_tests/peer_discouragementVasil Dimov
This is a non-functional change that replaces the `CNode` on-stack variables with `CNode` pointers. The reason for this is that it would allow us to add those `CNode`s to `CConnman::vNodes[]` which in turn would allow us to check that they are disconnected properly - a `CNode` object must be in `CConnman::vNodes[]` in order for its `fDisconnect` flag to be set. If we store pointers to the on-stack variables in `CConnman` then it would crash at the end, trying to `delete` them. Github-Pull: #21571 Rebased-From: 4d6e246fa46f2309e2998b542e4c104d73d29071
2021-04-16Merge #21701: [0.21] Speedy trial activation for TaprootMarcoFalke
cbd64c3a28a7466f421477daadc6e6e6b69b898a Add mainnet and testnet taproot activation params (Andrew Chow) ec7824396bdd2e93b429ddce9fea6bb29695454a chainparams: drop versionbits threshold to 90% for mainnnet and signet (Anthony Towns) 600357306e2e182a457174862ea2e41c7ba39c64 versionbits: simplify state transitions (Anthony Towns) 3acf0379e0979ea4bdd03976f4987aa6711eb92f versionbits: Add explicit NEVER_ACTIVE deployments (Anthony Towns) b529222ad18f7facbaff394455875b4aa65d653e fuzz: test versionbits delayed activation (Anthony Towns) 71917e01ebf48790b9df48421d8e97986f92e2e4 tests: test versionbits delayed activation (Anthony Towns) 4cab84cfdfc98cd10462681b5eb0fbbc08afd2a7 versionbits: Add support for delayed activation (Anthony Towns) f9517e6014ccfe91d5a77e2bacca928bdce7c285 tests: clean up versionbits test (Anthony Towns) 1c0164544c66b691f93b3b1114eee97cbabd99b2 tests: test ComputeBlockVersion for all deployments (Anthony Towns) 2e9e7f4329fc313adf9ba2394edbaf2a69b59bc1 tests: pull ComputeBlockVersion test into its own function (Anthony Towns) Pull request description: Backport of #21377 and #21686 ACKs for top commit: instagibbs: cherry-pick ACK https://github.com/bitcoin/bitcoin/pull/21701/commits/cbd64c3a28a7466f421477daadc6e6e6b69b898a jnewbery: ACK cbd64c3a28a7466f421477daadc6e6e6b69b898a Sjors: tACK cbd64c3 MarcoFalke: cherry-pick-only ACK cbd64c3a28a7466f421477daadc6e6e6b69b898a 🌾 Tree-SHA512: e9efb0ca9986d685161bcba5ed43efdc5f1dca88322cf65faccf17009b567c2d930c2aba4d1541539fc65347574ed4faa3d4558b907c779d1c128b3d2c681f31
2021-04-16Merge #21520: [0.21] wallet: Avoid requesting fee rates multiple times ↵fanquake
during coin selection d61fb07da7c12e4a1f68cf645f32d563a657a506 Rename CoinSelectionParams::effective_fee to m_effective_feerate (Andrew Chow) 5fc381e443d6d967e6f7f8bc88a4fd66e18379eb wallet: Move discard feerate fetching to CreateTransaction (Andrew Chow) bcd716670ba8a189a2e9b8b035318abceb9ce631 wallet: Move long term feerate setting to CreateTransaction (Andrew Chow) 34c89f92f34b5ca12da95d5f0b0240682c5a1c1f wallet: Replace nFeeRateNeeded with effective_fee (Andrew Chow) 48fc675163a657e615fd4b2680fc3accba12f95d wallet: Use existing feerate instead of getting a new one (Andrew Chow) Pull request description: Backport of #21083 ACKs for top commit: MarcoFalke: cherry-pick-only re-ACK d61fb07da7c12e4a1f68cf645f32d563a657a506 🔙 instagibbs: utACK https://github.com/bitcoin/bitcoin/pull/21520/commits/d61fb07da7c12e4a1f68cf645f32d563a657a506 Tree-SHA512: 23b212301bb467153dd9723903918ae01dd520525c81d541c411e7a4381e46594fe032e2a7c06ddcff7dc56dcb546991d50187c33fcff08ec45bd835cc01bd19
2021-04-15Add mainnet and testnet taproot activation paramsAndrew Chow
Github-Pull: #21686 Rebased-From: f979b3237f1cfc28f9c4ccb07beab558d5357a55
2021-04-15chainparams: drop versionbits threshold to 90% for mainnnet and signetAnthony Towns
Github-Pull: #21377 Rebased-From: ffe33dfbd4c3b11e3475b022b6c1dd077613de79
2021-04-15versionbits: simplify state transitionsAnthony Towns
This removes the DEFINED->FAILED transition and changes the STARTED->FAILED transition to only occur if signalling didn't pass the threshold. This ensures that it is always possible for activation to occur, no matter what settings are chosen, or the speed at which blocks are found. Github-Pull: #21377 Rebased-From: f054f6bcd2c2ce5fea84cf8681013f85a444e7ea
2021-04-15versionbits: Add explicit NEVER_ACTIVE deploymentsAnthony Towns
Previously we used deployments that would timeout prior to Bitcoin's invention, which allowed the deployment to still be activated in unit tests. This switches those deployments to be truly never active. Github-Pull: #21377 Rebased-From: 55ac5f568a3b73d6f1ef4654617fb76e8bcbccdf
2021-04-15fuzz: test versionbits delayed activationAnthony Towns
Github-Pull: #21377 Rebased-From: dd07e6da48040dc7eae46bc7941db48d98a669fd
2021-04-15tests: test versionbits delayed activationAnthony Towns
Github-Pull: #21377 Rebased-From: dd85d5411c1702c8ae259610fe55050ba212e21e
2021-04-15versionbits: Add support for delayed activationAnthony Towns
Github-Pull: #21377 Rebased-From: 73d4a706393e6dbd6b6d6b6428f8d3233ac0a2d8
2021-04-15tests: clean up versionbits testAnthony Towns
Simplify the versionbits unit test slightly to make the next set of changes a little easier to follow. Github-Pull: #21377 Rebased-From: 9e6b65f6fa205eee5c3b99343988adcb8d320460
2021-04-15tests: test ComputeBlockVersion for all deploymentsAnthony Towns
This generalises the ComputeBlockVersion test so that it can apply to any activation parameters we might set, and checks all the parameters set for each deployment on each chain, to simultaneously ensure that the deployments we have configured work sensibly, and that the test code does not suffer bitrot in the event that all interesting deployments are buried. Github-Pull: #21377 Rebased-From: 593274445004506c921d5d851361aefb3434d744
2021-04-15tests: pull ComputeBlockVersion test into its own functionAnthony Towns
The intent here is to allow checking ComputeBlockVersion behaviour with each deployment, rather than only testdummy on mainnet. This commit does the trivial refactoring component of that change. Github-Pull: #21377 Rebased-From: 63879f0a4760c0c0f784029849cb5d21ee088abb
2021-04-12Merge #21640: [0.21] Introduce DeferredSignatureChecker and have ↵fanquake
SignatureExtractorClass subclass it f79189ca54524881d52b91679eb9035d6718ce01 Test that signrawtx works when a signed CSV and CLTV inputs are present (Andrew Chow) 7de019bc619b0b2433bfb553feba5f6dc58c8db8 Introduce DeferringSignatureChecker and inherit with SignatureExtractor (Andrew Chow) Pull request description: Backport of #21166 ACKs for top commit: MarcoFalke: checked this is a clean cherry-pick did not review ACK f79189ca54524881d52b91679eb9035d6718ce01 🐖 instagibbs: ACK https://github.com/bitcoin/bitcoin/pull/21640/commits/f79189ca54524881d52b91679eb9035d6718ce01 Tree-SHA512: 51e945c9b353713423d3886c557066c66a6517d2300523832e5a5471ab91a8943385096d9bf5b46910477cb4c47470431690cf3da09b9f6956fe030f13ddff51
2021-04-08Test that signrawtx works when a signed CSV and CLTV inputs are presentAndrew Chow
Github-Pull: #21166 Rebased-From: a97a9298cea085858e1a65a5e9b20d7a9e0f7303
2021-04-08Introduce DeferringSignatureChecker and inherit with SignatureExtractorAndrew Chow
Introduces a DeferringSignatureChecker which simply takes a BaseSignatureChecker and passes through everything. SignatureExtractorChecker now subclasses DeferringSignatureChecker. This allows for all BaseSignatureChecker functions to be implemented for SignatureExtractorChecker, while allowing for future signature checkers which opreate similarly to SignatureExtractorChecker. Github-Pull: #21166 Rebased-From: 6965456c10c9c4025c71c5e24fa5b27b15e5933a
generated by cgit v1.2.3 (git 2.26.2) at 2024-07-20 02:21:51 +0000