Age | Commit message (Collapse) | Author |
|
|
|
6c37f7f `getrawchangeaddress` should fail when keypool exhausted (Wladimir J. van der Laan)
|
|
An user on IRC reported an issue where `getrawchangeaddress`
keeps returning a single address when the keypool is exhausted.
In my opinion this is strange behaviour.
- Change CReserveKey to fail when running out of keys in the keypool.
- Make `getrawchangeaddress` return RPC_WALLET_KEYPOOL_RAN_OUT when
unable to create an address.
- Add a Python RPC test for checking the keypool behaviour in combination
with encrypted wallets.
|
|
b60be6b Clean up RPCs that are disabled in safe-mode. (Gregory Maxwell)
|
|
954d2e7 Avoid a segfault on getblock if it can't read a block from disk. (Ruben Dario Ponticelli)
|
|
This removes some inconsistencies in what worked and didn't work in
safemode. Now only RPCs involved in getting balances or sending
funds are disabled.
Previously you could mine but not submit blocks— but we may need more
blocks to resolve a fork that triggered safe mode in the first place,
and the non-submission was not reliable since some miners submit
blocks via multiple means. There were also a number of random commands
disabled that had nothing to do with the blockchain like verifymessage.
Thanks to earlz for pointing out that there were some moderately cheap
ways to maliciously trigger safe mode, which brought attention to
the fact that safemode wasn't used in a very intelligent way.
|
|
502972f Fix Error: No file at @loader_path/libboost_system-mt.dylib (Federico Bond)
|
|
|
|
|
|
Refactor common RPC test code to BitcoinTestFramework base class
|
|
00d1980 init.cpp: log fee estimates filename on error (Philip Kaufmann)
|
|
45abeb2 Update Debian packaging description for new bitcoin-cli (Johnathan Corgan)
|
|
|
|
Inspired by #3956, with a little more flexibility built in.
I didn't touch rpcbind_test.py, because it only runs on Linux.
|
|
Improved bitcoinrpc logging and Decimal support
|
|
33cc907 Add DNS seed of open-nodes.org (kevin)
|
|
- small changes to Shutdown(), buffer __func__, which is now used in
all LogPrintf() calls and format for better readability
- order using namespace alpabetically
|
|
509f926 Payment request parsing on startup now only changes network if a valid network name is specified. (Ross Nicoll)
|
|
575e70c build: fix win32 static linking after libtool merge (Cory Fields)
9a427da build: re-add AM_LDFLAGS where it's overridden (Cory Fields)
|
|
network name is specified.
|
|
Libtool eats the -static flag rather than passing it along to the compiler. To
get the same effect, -all-static is used instead.
|
|
using _LDFLAGS replaces AM_LDFLAGS rather than adding to it.
|
|
|
|
|
|
109849e Bugfix: strerror_r can return an error, and if it does, POSIX does not specify the content of the buffer (Luke Dashjr)
|
|
d88af56 Fee fixes (Cozz Lovan)
|
|
|
|
2227725 test/bloom_tests: Use UL suffix for unsigned long number to ensure compatibility (Luke Dashjr)
|
|
|
|
specify the content of the buffer
|
|
40f5cb8 Send rejects and apply DoS scoring for errors in direct block validation. (Pieter Wuille)
|
|
a3e192a replaced MINE_ with ISMINE_ (JaSK)
53a2148 fixed bug where validateaddress doesn't display information (JaSK)
f28707a fixed bug in ListReceived() (JaSK)
519dd1c Added MINE_ALL = (spendable|watchonly) (JaSK)
23b0506 Fixed some stuff in TransactionDesc (JaSK)
80dda36 removed default argument values for ismine filter (JaSK)
d5087d1 Use script matching rather than destination matching for watch-only. (Pieter Wuille)
0fa2f88 added includedWatchonly argument to listreceivedbyaddress/...account (JaSK)
f87ba3d added includeWatchonly argument to 'gettransaction' because it affects balance calculation (JaSK)
a5c6c5d fixed tiny glitch and improved readability like laanwj suggested (JaSK)
d7d5d23 Added argument to listtransactions and listsinceblock to include watchonly addresses (JaSK)
952877e Showing 'involvesWatchonly' property for transactions returned by 'listtransactions' and 'listsinceblock'. It is only appended when the transaction involves a watchonly address. (JaSK)
83f3543 Added argument to listaccounts to include watchonly addresses (JaSK)
d4640d7 Added argument to getbalance to include watchonly addresses and fixed errors in balance calculation. (JaSK)
d2692f6 Watchonly transactions are marked in transaction history (JaSK)
ffd40da Watchonly balances are shown separately in gui. (JaSK)
2935b21 qt: Hide unspendable outputs in coin control (Wladimir J. van der Laan)
c898846 Add support for watch-only addresses (Pieter Wuille)
|
|
Problem introduced in caf6150. Thanks to @drak for noticing. Fixes #4473.
|
|
a339a37 error out, when we detect -socks argument (Philip Kaufmann)
0127a9b remove SOCKS4 support from core and GUI (Philip Kaufmann)
|
|
18c7ba8 Add translation mailing list to README.md (Michael Ford)
|
|
ad87bc4 [Qt] Replace status bar unit icon with actual images (Cozz Lovan)
|
|
cf04d83 add OpenSSL RAND_cleanup() on OpenSSL shutdown (Philip Kaufmann)
|
|
Link to the new translation mailing list from README.md
|
|
674c070 [Qt] seed OpenSSL PNRG with Windows event data (Philip Kaufmann)
|
|
2ec5a3d rpc: Prevent easy memory exhaustion attack (Wladimir J. van der Laan)
|
|
209377a Use GetBlockTime() more (jtimon)
|
|
f4b00be Add CChain::GetLocator() unit test (Pieter Wuille)
3c85d2e Fix CChain::GetLocator (Pieter Wuille)
|
|
e832ab7 Rename SendMoneyToDestination to SendMoney. (Daniel Kraft)
|
|
|
|
3d0e92d [Qt] remove dup includes in bitcoingui (Philip Kaufmann)
|
|
1f740dd Remove unused variable (R E Broadley)
|
|
73ac7ab Move ui_interface to bitcoin_server.a (Wladimir J. van der Laan)
5090303 qt: Pick translation messages only from necessary files (Wladimir J. van der Laan)
|
|
There is no need for it in the utility libraries or tools.
Put it in init.cpp, and in the tests separately (as they can't link init).
|
|
Utility libraries (common, util) as well as extra tools shouldn't be
parsed for translation messages, only the server and wallet part qualify
here.
|
|
Get rid of SendMoney and replace it by the functionality of
SendMoneyToDestination. This cleans up the code, since only
SendMoneyToDestination was actually used (SendMoney internally from this
routine).
|