aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-10Mention reporting security issues responsiblyPavel Janík
2016-11-10Merge #9097: [qa] Rework sync_* and preciousblock.pyMarcoFalke
fa97ccb [qa] util: Rework sync_*() (MarcoFalke) fac1141 [qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
2016-11-10Merge #9122: fix getnettotals RPC description about timemillis.MarcoFalke
a79f864 fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
2016-11-10Merge #9121: Initialize variable to prevent compiler warningWladimir J. van der Laan
bdcba6d Initialize variable to prevent compiler warning (Pavel Janík)
2016-11-10Merge #9120: bug: Missed one "return false" in recent refactoring in #9067Wladimir J. van der Laan
45d372f Missed one "return false" in recent refactoring in #9067 (UdjinM6)
2016-11-10fix getnettotals RPC description about timemillis.Masahiko Hyuga
2016-11-10Initialize variable to prevent compiler warningPavel Janík
2016-11-10Missed one "return false" in recent refactoring in #9067UdjinM6
2016-11-09Merge #8894: [Testing] Include fRelay in mininode version messagesWladimir J. van der Laan
e5d682f Fix mininode version message format (jnewbery)
2016-11-09Merge #9111: Remove unused variable UNLIKELY_PCT from fees.hWladimir J. van der Laan
d8edf03 Remove unused var UNLIKELY_PCT from fees.h (fanquake)
2016-11-09Revert "Check and enable -Wshadow by default."Wladimir J. van der Laan
This reverts commit fd5654cab1e5d317119f747abd245c620e8ba29b. This is still causing too many warnings for some compiler combinations, forget it for now.
2016-11-09Merge #8794: Enable -Wshadow by defaultWladimir J. van der Laan
359bac7 Add notes about variable names and shadowing (Pavel Janík) fd5654c Check and enable -Wshadow by default. (Pavel Janík)
2016-11-09Add notes about variable names and shadowingPavel Janík
2016-11-09Merge #9039: Various serialization simplifcations and optimizationsWladimir J. van der Laan
d59a518 Use fixed preallocation instead of costly GetSerializeSize (Pieter Wuille) 25a211a Add optimized CSizeComputer serializers (Pieter Wuille) a2929a2 Make CSerAction's ForRead() constexpr (Pieter Wuille) a603925 Avoid -Wshadow errors (Pieter Wuille) 5284721 Get rid of nType and nVersion (Pieter Wuille) 657e05a Make GetSerializeSize a wrapper on top of CSizeComputer (Pieter Wuille) fad9b66 Make nType and nVersion private and sometimes const (Pieter Wuille) c2c5d42 Make streams' read and write return void (Pieter Wuille) 50e8a9c Remove unused ReadVersion and WriteVersion (Pieter Wuille)
2016-11-09Merge #8874: Multiple Selection for peer and ban tablesWladimir J. van der Laan
1077577 Fix auto-deselection of peers (Andrew Chow) addfdeb Multiple Selection for peer and ban tables (Andrew Chow)
2016-11-09Remove unused var UNLIKELY_PCT from fees.hfanquake
2016-11-09Fix mininode version message formatjnewbery
2016-11-08Fix auto-deselection of peersAndrew Chow
2016-11-08Merge #9087: RPC: why not give more details when "generate" fails?MarcoFalke
1adf82a RPC: Give more details when "generate" fails (Jorge Timón)
2016-11-08RPC: Give more details when "generate" failsJorge Timón
2016-11-08Multiple Selection for peer and ban tablesAndrew Chow
Allows multiple selection and action for the nodes in the peer and ban tables in the Debug Window.
2016-11-08Merge #9088: Reduce ambiguity of warning messageWladimir J. van der Laan
77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley)
2016-11-08Merge #9098: [qa] Handle zombies and cluttered tmpdirsWladimir J. van der Laan
fab0f07 [qa] rpc-tests: Apply random offset to portseed (MarcoFalke) fae19aa [qa] test_framework: Exit when tmpdir exists (MarcoFalke)
2016-11-08Merge #9067: Fix exit codesWladimir J. van der Laan
4441018 Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers (UdjinM6) bd0de13 Fix exit codes: - `--help`, `--version` etc should exit with `0` i.e. no error ("not enough args" case should still trigger an error) - error reading config file should exit with `1` (UdjinM6)
2016-11-08[qa] rpc-tests: Apply random offset to portseedMarcoFalke
This helps to skip over resources, which are blocked by regtest bitcoind zombie nodes
2016-11-08Merge #9095: test: Fix test_random includesJonas Schnelli
fa8278e test: Fix test_random includes (MarcoFalke)
2016-11-07Merge #9026: Fix handling of invalid compact blocksPieter Wuille
d4833ff Bump the protocol version to distinguish new banning behavior. (Suhas Daftuar) 88c3549 Fix compact block handling to not ban if block is invalid (Suhas Daftuar) c93beac [qa] Test that invalid compactblocks don't result in ban (Suhas Daftuar)
2016-11-07Merge #9045: Hash P2P messages as they are received instead of at process-timePieter Wuille
fe1dc62 Hash P2P messages as they are received instead of at process-time (Matt Corallo)
2016-11-07Use fixed preallocation instead of costly GetSerializeSizePieter Wuille
Dbwrapper used GetSerializeSize() to compute the size of the buffer to preallocate. For some cases (specifically: CCoins) this requires a costly compression call. Avoid this by just using fixed size preallocations instead.
2016-11-07Add optimized CSizeComputer serializersPieter Wuille
To get the advantages of faster GetSerializeSize() implementations back that were removed in "Make GetSerializeSize a wrapper on top of CSizeComputer", reintroduce them in the few places in the form of a specialized Serialize() implementation. This actually gets us in a better state than before, as these even get used when they're invoked indirectly in the serialization of another object.
2016-11-07Make CSerAction's ForRead() constexprPieter Wuille
The CSerAction's ForRead() method does not depend on any runtime data, so guarantee that requests to it can be optimized out by making it constexpr. Suggested by Cory Fields.
2016-11-07Avoid -Wshadow errorsPieter Wuille
Suggested by Pavel Janik.
2016-11-07Get rid of nType and nVersionPieter Wuille
Remove the nType and nVersion as parameters to all serialization methods and functions. There is only one place where it's read and has an impact (in CAddress), and even there it does not impact any of the recursively invoked serializers. Instead, the few places that need nType or nVersion are changed to read it directly from the stream object, through GetType() and GetVersion() methods which are added to all stream classes.
2016-11-07Make GetSerializeSize a wrapper on top of CSizeComputerPieter Wuille
Given that in default GetSerializeSize implementations created by ADD_SERIALIZE_METHODS we're already using CSizeComputer(), get rid of the specialized GetSerializeSize methods everywhere, and just use CSizeComputer. This removes a lot of code which isn't actually used anywhere. For CCompactSize and CVarInt this actually removes a more efficient size computing algorithm, which is brought back in a later commit.
2016-11-07[qa] test_framework: Exit when tmpdir existsMarcoFalke
2016-11-07Make nType and nVersion private and sometimes constPieter Wuille
Make the various stream implementations' nType and nVersion private and const (except in CDataStream where we really need a setter).
2016-11-07[qa] util: Rework sync_*()MarcoFalke
* Only allow named args in sync_*() * Make sync_* fails more verbose * Add timeout to sync_chain()
2016-11-07Every main()/exit() should return/use one of EXIT_ codes instead of magic ↵UdjinM6
numbers
2016-11-07[qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__MarcoFalke
2016-11-07Make streams' read and write return voidPieter Wuille
The stream implementations had two cascading layers (the upper one with operator<< and operator>>, and a lower one with read and write). The lower layer's functions are never cascaded (nor should they, as they should only be used from the higher layer), so make them return void instead.
2016-11-07Remove unused ReadVersion and WriteVersionPieter Wuille
CDataStream and CAutoFile had a ReadVersion and WriteVersion method that was never used. Remove them.
2016-11-07Merge #9077: [qa] Increase wallet-dump RPC timeoutMarcoFalke
e89614b [qa] Add more helpful RPC timeout message (Russell Yanofsky) 8463aaa [qa] Increase wallet-dump RPC timeout (Russell Yanofsky)
2016-11-07[qa] Add more helpful RPC timeout messageRussell Yanofsky
Replace previous timeout('timed out',) exception with more detailed error.
2016-11-07[qa] Increase wallet-dump RPC timeoutRussell Yanofsky
Increase wallet-dump RPC timeout from 30 seconds to 1 minute. This avoids a timeout error that seemed to happen regularly (around 50% of builds) on a particular jenkins server during the first getnewaddress RPC call made by the test. The failing stack trace looked like: Unexpected exception caught during testing: timeout('timed out',) File ".../bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 146, in main self.run_test() File ".../bitcoin/qa/rpc-tests/wallet-dump.py", line 73, in run_test addr = self.nodes[0].getnewaddress() File ".../bitcoin/qa/rpc-tests/test_framework/coverage.py", line 49, in __call__ return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs) File ".../bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 145, in __call__ response = self._request('POST', self.__url.path, postdata.encode('utf-8')) File ".../bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 121, in _request return self._get_response() File ".../bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 160, in _get_response http_response = self.__conn.getresponse() File "/usr/lib/python3.4/http/client.py", line 1171, in getresponse response.begin() File "/usr/lib/python3.4/http/client.py", line 351, in begin version, status, reason = self._read_status() File "/usr/lib/python3.4/http/client.py", line 313, in _read_status line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1") File "/usr/lib/python3.4/socket.py", line 374, in readinto return self._sock.recv_into(b)
2016-11-07test: Fix test_random includesMarcoFalke
2016-11-07Merge #9094: qt: Use correct conversion function for boost::path datadirJonas Schnelli
e760b30 qt: Use correct conversion function for boost::path datadir (Wladimir J. van der Laan)
2016-11-07Merge #8981: Wshadow: Do not shadow argument with a local variableWladimir J. van der Laan
ff6639b Do not shadow local variable (Pavel Janík)
2016-11-07Merge #8976: libconsensus: Add input validation of flagsWladimir J. van der Laan
5ca8ef2 libconsensus: Add input validation of flags (Wladimir J. van der Laan)
2016-11-07Merge #7730: Remove priority estimationWladimir J. van der Laan
0bd581a add release notes for removal of priority estimation (Alex Morcos) b2322e0 Remove priority estimation (Alex Morcos)
2016-11-07add release notes for removal of priority estimationAlex Morcos
generated by cgit v1.2.3 (git 2.26.2) at 2024-11-07 08:13:44 +0000