aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-03-24wallet: Move discard feerate fetching to CreateTransactionAndrew Chow
Instead of fetching the discard feerate for each SelectCoinsMinConf iteration, fetch and cache it once during CreateTransaction so that it is shared for each SelectCoinsMinConf through coin_selection_params.m_discard_feerate. Does not change behavior. Github-Pull: #21083 Rebased-From: bdd0c2934b7f389ffcfae3b602ee3ecee8581acd
2021-03-24wallet: Move long term feerate setting to CreateTransactionAndrew Chow
Instead of setting the long term feerate for each SelectCoinsMinConf iteration, set it once during CreateTransaction and let it be shared with each SelectCoinsMinConf through coin_selection_params.m_long_term_feerate. Does not change behavior. Github-Pull: #21083 Rebased-From: 448d04b931f86941903e855f831249ff5ec77485
2021-03-24wallet: Replace nFeeRateNeeded with effective_feeAndrew Chow
Make sure that all fee calculations use the same feerate. coin_selection_params.effective_fee is the variable we use for all fee calculations, so get rid of remaining nFeeRateNeeded usages and just directly set coin_selection_params.effective_fee. Does not change behavior. Github-Pull: #21083 Rebased-From: e2f429e6bbf7098f278c0247b954ecd3ba53cf37
2021-03-24wallet: Use existing feerate instead of getting a new oneAndrew Chow
During each loop of CreateTransaction, instead of constantly getting a new feerate, use the feerate that we have already fetched for all fee calculations. Thix fixes a race condition where the feerate required changes during each iteration of the loop. This commit changes behavior as the "Fee estimation failed" error will now take priority over "Signing transaction failed". Github-Pull: #21083 Rebased-From: 1a6a0b0dfb90f9ebd4b86d7934c6aa5594974f5f
2021-03-21Merge #21490: [0.21] Backport versionbits testsMarcoFalke
e775b0a6dd8358df0e8921739faf15942027239e tests: Add fuzzing harness for versionbits (Anthony Towns) 0c471a5f306044cbd2eb230714571f05dd6aaf3c tests: check never active versionbits (Anthony Towns) 3ba9283a47ac358168db9db7840ae559f443486c tests: more helpful errors for failing versionbits tests (Anthony Towns) Pull request description: Backport of unit test (#21334) and fuzz test (#21380) changes for versionbits. Top commit has no ACKs. Tree-SHA512: b68b570e48e0076bb2ade3b91c59612029235d2c9e39048d548aa141fa0906343fa492e9a981065fbdbbebecbbb3dcbaf39ec69228c7581178fcca567e8201b8
2021-03-21tests: Add fuzzing harness for versionbitsAnthony Towns
Github-Pull: #21380 Rebased-From: 1639c3b76c3f2b74606f62ecd3ca725154e27f1b
2021-03-03tests: check never active versionbitsAnthony Towns
2021-03-03tests: more helpful errors for failing versionbits testsAnthony Towns
Co-authored-by: Sjors Provoost <sjors@sprovoost.nl>
2021-01-14Merge #20933: [0.21] doc: Archive release notes, Add template for minor releaseWladimir J. van der Laan
b6d35029932ef245e040723dc924be2db4928666 doc: Archive release notes, Add template for minor release (MarcoFalke) Pull request description: Same as #20931, but also clearing the template ACKs for top commit: laanwj: ACK b6d35029932ef245e040723dc924be2db4928666 Tree-SHA512: 929d2f774904b58d62dd60d4dcf8447f7e40d959596f3f97462076627d89549ad39dc39c56456f4c8861353cfdf6633abca0be3e84a783f174be1ee1b8d213a4
2021-01-14doc: Archive release notes, Add template for minor releaseMarcoFalke
2021-01-13build: Bump RC to 0 (-final)v0.21.0Wladimir J. van der Laan
Tree-SHA512: 1a626b9bb7fb04ece4acb24ffcfed178cc5128d16af6860ed37097b6ed36be8b33797bd70a6da0364cd6a9246ebc02fbb83f9523abf5f8dc3c7a524a58416a8f
2021-01-13Merge #20929: doc: Move 0.21.0 release notes from wikiWladimir J. van der Laan
66e6742a273796e9bdab37b4ad9e05cf18a99981 doc: Move 0.21.0 release notes from wiki (Wladimir J. van der Laan) Pull request description: These were the contents of https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.21.0-Release-Notes-Draft, minus the paragraph about gauging how fast taproot can be deployed. Top commit has no ACKs. Tree-SHA512: d7bb61a76d87cb9d9e43602bf81b51ea463e3a098748e42440950d08e6f6e84bf6c02b07b297ac959f979aa72682775dd2ae2be6d30b22977ed60ed454b9c66d
2021-01-13doc: Move 0.21.0 release notes from wikiWladimir J. van der Laan
2021-01-05qt: Pre-rc5 translations updatev0.21.0rc5Wladimir J. van der Laan
Tree-SHA512: f6986d00a9565ee7fbf8dd2766dca9c90af931e2dc2fdc0faf5734a2e9be1a0e0774031a20207aa2afa645f1d6229aac9751c84ada324a8dcb463497fb9f237f
2021-01-05build: Bump RC to rc5Wladimir J. van der Laan
Tree-SHA512: ed01a7a66e5d064c77c948b87afce832b33852005ec1dc556bf4fcc69fa3743aaa6dea4c03a5d2d520682d8de9c7596f1eec3db326caf754726d1ca4aab2cec3
2021-01-05Merge #20850: [0.21] final rc5 backportsWladimir J. van der Laan
3308718a6b41f09e9dd3c7caa9986cd6cb8f2eeb Revert "Add patch to make codesign_allocate compatible with Apple's" (Pieter Wuille) Pull request description: ACKs for top commit: jonasschnelli: ACK 3308718a6b41f09e9dd3c7caa9986cd6cb8f2eeb fanquake: ACK 3308718a6b41f09e9dd3c7caa9986cd6cb8f2eeb Tree-SHA512: 2a1002499e6f0da6e9ac7ae393e478bd34e55390ff1a41c5b16b4e91e339fef4b82642237af6725507337cadf9ddc1f2f23b2512d8dd47e5a345770c6c0d1b02
2021-01-05Revert "Add patch to make codesign_allocate compatible with Apple's"Pieter Wuille
This reverts commit a4118c6e200e02e7560f8bc213697aa2909d95b1. Github-Pull: #20855 Rebased-From: a0eb4c551ebf8adfacb8c38c4ce56641fe379667
2021-01-03doc: Generate manual pages for 0.21.0rc4v0.21.0rc4Wladimir J. van der Laan
Tree-SHA512: c2ff50dbb54c42db9d56f1fcb0d8a2ce9c89089254f1a6b6f2aa98959f47699cd72c7771b53490232938b45d9bb030ce7fe08707c62190e68ada0ddbd8b6e13a
2021-01-03build: Bump RC to rc4Wladimir J. van der Laan
Tree-SHA512: f22375573f1737d64b62351cdec58f0f3e17d9f21b044430f366cbf272514369b73f24cc34e499e2637f0a0fa57ce5b925dd2df8ba0265b1b9c37beb7c8b8e22
2021-01-03qt: Pre-rc4 translations updateWladimir J. van der Laan
Tree-SHA512: 14259d2f469ea588f364f64fdd89b90cbcde8f66ddc011d96d656a06920584c0577e64fa15a41a1dc1c8c8a98a1f955748c61def6807b1bb71b0113bb28268f2
2021-01-02Merge #20669: [0.21] final rc4 backportsWladimir J. van der Laan
b1c0f97483f01f8836e5d83e98c881e44018cde5 [doc] Add permissions to the getpeerinfo help. (Amiti Uttarwar) 1fda7db64f0f30c23724f6db14f8a49d3975c716 rpc: Add missing description of vout in getrawtransaction help text (Ben Carman) ef7a155cf06bf54fff4ff9fda9b28207fcc9adfb qt: Align layout of checkboxes (Hennadii Stepanov) 35a10e4ebc9da916c470d2a9e5b68c3cfc3efd02 Add patch to make codesign_allocate compatible with Apple's (Pieter Wuille) e70ccb0bc4b695cd331aeda6d7aa405fa6d8f2e7 doc: update -externalip documentation in tor.md (Jon Atack) 2c8482d0a279d07a814eaaae231c90d3d2058e55 doc: add tor.md section on how to get tor info via bitcoind (Jon Atack) 0c1fa78af1c413c848359df76f4d55f819b9fad5 doc: update tor.md address examples from onion v2 to v3 (Jon Atack) 84e8d5467fcec3b7c8ce950cd7a3e7e7b24452a3 doc: warn that incoming conns are unlikely when not using default ports (Adam Jonas) e4440eb67b339fdacb2c1476f8f909a009c6a47f doc: Add warnings for http interfaces limitations (Fabian Jahr) 85dabd12494a0d82a8f5883cee1c1ff29fb81b27 Removed redundant git pull from appveyor config. (Aaron Clauson) 249d61a382014c15025fe63025ac5f46d4721262 Adjusted msvc compiler and linker settings to remove optimisations that are causing sporadic ABI issues on Visual Studio updates. (Aaron Clauson) e7b53d47218301790bfec44d50219561502922ad This change to the appveyor CI config for msvc builds reverses a change introduced in #19960. It re-applies a setting to inform vcpkg to only build release vesions of the dependencies rather than the default of debug and release. (Aaron Clauson) 8273ea3b8db1449b65cf369e541a1253c4490f45 Move signet onion seed from v2 to v3 (Sjors Provoost) Pull request description: The remaining backports to get rc4 out. Currently only waiting on the macOS build fix. ACKs for top commit: benthecarman: ACK b1c0f97483f01f8836e5d83e98c881e44018cde5 Sjors: ACK b1c0f97 Tree-SHA512: 53eaecd531ba461678917cb630d67f1e6bb737d64022abe971eaced6eca366c9ed593e44276bd9c7ad7b3aebe3850d2d29282eb310e10b547986d10fe77a8482
2020-12-26[doc] Add permissions to the getpeerinfo help.Amiti Uttarwar
This field was already being returned, but the RPCHelpMan did not indicate this. So, this PR updates the help text to match. Github-Pull: #20756 Rebased-From: 667d203687708390bc0f43f2dd3f4ab427b88338
2020-12-21rpc: Add missing description of vout in getrawtransaction help textBen Carman
Github-Pull: #20731 Rebased-From: b23349b8804fb60c6b3d7d0e2a95927a0d1b49b9
2020-12-18qt: Align layout of checkboxesHennadii Stepanov
Github-Pull: bitcoin-core/gui#155 Rebased-From: e71b656f317f38ef0ba0874736f116dae39efc67
2020-12-17Add patch to make codesign_allocate compatible with Apple'sPieter Wuille
Github-Pull: #20644 Rebased-From: a4118c6e200e02e7560f8bc213697aa2909d95b1
2020-12-17doc: update -externalip documentation in tor.mdJon Atack
Github-Pull: #19961 Rebased-From: a34eceb4cc054b4233e7321de927e8a7a2146301
2020-12-17doc: add tor.md section on how to get tor info via bitcoindJon Atack
Github-Pull: #19961 Rebased-From: dc8a591222f249da81c7eef8aa5961f8d7dd1e23
2020-12-17doc: update tor.md address examples from onion v2 to v3Jon Atack
Github-Pull: #19961 Rebased-From: e1765d8b04fe1fb775f3750e0fa59f13a58eb176
2020-12-17doc: warn that incoming conns are unlikely when not using default portsAdam Jonas
Github-Pull: #20668 Rebased-From: 010eed3ce03cf4fc622a48f40fc4d589383f7a44
2020-12-17doc: Add warnings for http interfaces limitationsFabian Jahr
Github-Pull: #19050 Rebased-From: 5c3eaf9983043db1b61a98c95d692a6958670b86
2020-12-16Removed redundant git pull from appveyor config.Aaron Clauson
Github-Pull: #20506 Rebased-From: 2c69381f3de5091e103cb8bef299aba321503e7c
2020-12-16Adjusted msvc compiler and linker settings to remove optimisations that are ↵Aaron Clauson
causing sporadic ABI issues on Visual Studio updates. Tidied up debug and release configuration blocks in common project file to avoid duplication. Updated appveyor config to use latest Visual Studio 2019 image. Changed appveyor config file hash to use a new version of Qt pre-compiled binaries built for Visual Studio 2019 v16.8.1. Bumped vcpkg version to tag '2020.11-1' for binary caching feature. See #20392 for related discussion. Github-Pull: #20506 Rebased-From: 8b99e609e7da5dd3601e9214d8f869e96108fffe
2020-12-16This change to the appveyor CI config for msvc builds reverses a change ↵Aaron Clauson
introduced in #19960. It re-applies a setting to inform vcpkg to only build release vesions of the dependencies rather than the default of debug and release. It had been expected that the vcpkg manifest mechanism introduced in #19960 would do this automatically but it turns out not to be the case. Github-Pull: #20489 Rebased-From: fa18e7cbc5ea6aaba94dca4ebdc850c9db141f89
2020-12-16Move signet onion seed from v2 to v3Sjors Provoost
Github-Pull: #20660 Rebased-From: 3e6657a14d501c6315ab46ffe7d204684491c710
2020-12-10build: Bump RC to rc3v0.21.0rc3Wladimir J. van der Laan
Tree-SHA512: a6d81259e17c6b55b33c638a9054eaee2f82322ce0482a73f85562cd56efeb73e2b19b3f7b44fd97e7caa6e757573a8c13ae8967b1e6492f2483d2e057d96c87
2020-12-10gui: pre-rc3 translations updateWladimir J. van der Laan
Tree-SHA512: 2aba5a743ecc1f9e336b8db036640182eb3e85449d9ab4c883c97e6ac75466760939b29c18560205d25489d58091212f7f1dcf651388deb675f824703c943cbf
2020-12-10Merge #20612: [0.21] final rc3 backportsWladimir J. van der Laan
48134a09adef3b5302cdd6e95500db404c9ac961 doc: Update wallet database installation guide for macOS (Hennadii Stepanov) f51e1cb2917bbd7b0966a7ad688e04fc3ce02ccf build: Use Homebrew's sqlite package if it is available (Hennadii Stepanov) 48f8929aade118469cb0014e78a15b4e71fdd17d build, refactor: Check that Homebrew's qt5 package is actually installed (Hennadii Stepanov) 96124a204193ed114ca9594df7d5151206990e91 build: Check that Homebrew's berkeley-db4 package is actually installed (Hennadii Stepanov) 61e316e66168be593fcc90b90217062fa9d993dc Don't set BDB flags when configuring without (Jonas Schnelli) ce13b99020df8d46a9b594add3c49e38d4601b42 Add regression test for incorrect decoding (Pieter Wuille) 1caa32e3f2a74cd5700a4afe8ecf650f9020fb5c Improve heuristic hex transaction decoding (Pieter Wuille) 0d3c140c4db051fb33c2935ad9536f0f4aa2a8c5 test: add coverage for passing fee rate as a string (Jon Atack) 06c84232b310e6196c814894537ad935d773fe98 wallet, bugfix: allow send to take string fee rate values (Jon Atack) bead93547067e4b62b44fba335f1d4697119c2d7 Send and require SENDADDRV2 before VERACK (Pieter Wuille) 9e806887a8f9ef63431b28d7dfd0470aa663dd02 Don't send 'sendaddrv2' to pre-70016 software (Pieter Wuille) Pull request description: ACKs for top commit: laanwj: ACK 48134a09adef3b5302cdd6e95500db404c9ac961 Tree-SHA512: 92f1199b96ab7775f88e882ec7fedf43118a4b8452d1c8d0b1cf072d8de153bbb601c7381bc1c5c80c93803c6f9942d54646e9c74e3a6703ce13854fb383fd5e
2020-12-10doc: Update wallet database installation guide for macOSHennadii Stepanov
Github-Pull: #20527 Rebased-From: c932e0d67e4b369e4265267da6c8bebac2b6fb53
2020-12-10build: Use Homebrew's sqlite package if it is availableHennadii Stepanov
Github-Pull: #20527 Rebased-From: ee7b84e63cbeadd5e680d69ff0548275581e9241
2020-12-10build, refactor: Check that Homebrew's qt5 package is actually installedHennadii Stepanov
This change unifies Homebrew packages workflow, and does not change behavior. Github-Pull: #20527 Rebased-From: c96d1f65a552712f8476269ad64a415717ead50d
2020-12-10build: Check that Homebrew's berkeley-db4 package is actually installedHennadii Stepanov
Github-Pull: #20563 Rebased-From: d3ef947524a07f8d7fbad5b95781ab6cacb1cb49
2020-12-10Don't set BDB flags when configuring withoutJonas Schnelli
Github-Pull: #20478 Rebased-From: 982e548a9a78b1b0abad59b54c780b6b06570452
2020-12-10Add regression test for incorrect decodingPieter Wuille
Github-Pull: #20595 Rebased-From: 0f949cde3dff15170db7930b0f7345ff995c267d
2020-12-10Improve heuristic hex transaction decodingPieter Wuille
Whenever both encodings are permitted, try both, and if only one succeeds, return that one. Otherwise prefer the one for which the heuristic sanity check passes. If that is the case for neither or for both, return the extended-permitting deserialization. Github-Pull: #20595 Rebased-From: 39c42c442044aef611d03ee7053d2dd6df63deb7
2020-12-10test: add coverage for passing fee rate as a stringJon Atack
Github-Pull: #20573 Rebased-From: 6fa72ceb8021c3b5aea62f6cfe92665c29212923
2020-12-10wallet, bugfix: allow send to take string fee rate valuesJon Atack
Github-Pull: #20573 Rebased-From: ce207d6b93d35bc02fcd2dd28f1fd95869261d43
2020-12-10Send and require SENDADDRV2 before VERACKPieter Wuille
See the corresponding BIP change: https://github.com/bitcoin/bips/pull/1043 Github-Pull: #20564 Rebased-From: 1583498fb6781c01ca2f33c09319ed793964c574
2020-12-10Don't send 'sendaddrv2' to pre-70016 softwarePieter Wuille
Github-Pull: #20564 Rebased-From: c5a89196602e43ebb1cdc9cd4f08d153419c13e1
2020-12-04Merge #20510: [backport] wallet: allow zero-fee ↵MarcoFalke
fundrawtransaction/walletcreatefundedpsbt and other fixes 6313362553d91bddb75a43f62dffbec16065e4d6 Use the correct incremental fee constant in bumpfee help (Jon Atack) 6e4969f76f58518d47ce2f2cdfc4e3ef1f2228bd Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee (Jon Atack) 54e1edcc2bca76f783170768e65bf0850b036b81 Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls (Jon Atack) Pull request description: Github-Pull: #20426 Rebased-From: 1b3d7009280595108eb22ac1188bc4367804fc5d Github-Pull: #20426 Rebased-From: 3f1e10b2b1cd11f7112fbad6355464bd4adbbc5c Github-Pull: #20426 Rebased-From: 9f08780dd7946b63476e9736745131db8e7f4e93 Top commit has no ACKs. Tree-SHA512: 89556f69ca4a36d86d6ab5df740b6d5de809f13d45b03450fb526362b1eabd3d2d5285f97c552dc0bcb07e17ac2e6c557ff46335962e6bcf366d36ad412f257c
2020-12-02Merge #20505: [backport] build: Avoid secp256k1.h include from systemfanquake
01b647b1a20bbf1de2f5f4624c34b554ad3790f2 build: Avoid secp256k1.h include from system (Niklas Gögge) Pull request description: Backports #20469 to the 0.21 branch. ACKs for top commit: hebasto: ACK 01b647b1a20bbf1de2f5f4624c34b554ad3790f2, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: c098055b5e413be6f438d1d43e80c1943329ebb708531d8d82e72de402bddeb6f8b812303f9ae5a45abf62b3ff87fa909fbbf7fb56dca7959ecb9061febae4a1
generated by cgit v1.2.3 (git 2.26.2) at 2024-07-20 12:47:30 +0000