aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-01-09Make empty byte arrays pass CheckSignatureEncoding()Peter Todd
Makes it possible to compactly provide a delibrately invalid signature for use with CHECK(MULTI)SIG. For instance with BIP19 if m != n invalid signatures need to be provided in the scriptSig; prior to this change those invalid signatures would need to be large DER-encoded signatures. Note that we may want to further expand on this change in the future by saying that only OP_0 is a "valid" invalid signature; BIP19 even with this change is inherently malleable as the invalid signatures can be any validly encoded DER signature.
2015-01-08Merge pull request #5617Wladimir J. van der Laan
c6a5ad4 Fix tests after #5413 (Wladimir J. van der Laan)
2015-01-08Fix tests after #5413Wladimir J. van der Laan
Pull #5413 was not rebased after deterministic signing was merged (#5227), so the testcases had to be regenerated using UPDATE_JSON_TESTS.
2015-01-08Merge pull request #5589Wladimir J. van der Laan
23f3435 Rename MAX_TX_SIGOPS to MAX_STANDARD_TX_SIGOPS to match similar policy constant MAX_STANDARD_TX_SIZE (Luke Dashjr)
2015-01-08Merge pull request #5604Wladimir J. van der Laan
d58c5d6 tests: run sanity checks in tests too (Cory Fields)
2015-01-08Merge pull request #5143Wladimir J. van der Laan
da918ac Make SCRIPT_VERIFY_CLEANSTACK a standardness requirement (Pieter Wuille) b6e03cc Add SCRIPT_VERIFY_CLEANSTACK (BIP62 rule 6) (Pieter Wuille) ae4151b No semantic change: reuse stack variable in P2SH evaluation (Pieter Wuille)
2015-01-08Merge pull request #5612Wladimir J. van der Laan
84d9199 [QA] fix zapwallettxes test (Jonas Schnelli)
2015-01-08Merge pull request #5613Wladimir J. van der Laan
1eb1e65 Fix smartfees test for change to relay policy (Suhas Daftuar)
2015-01-08Merge pull request #5559Wladimir J. van der Laan
e179eb3 Make the command-line-args dialog better (Thomas Zander)
2015-01-08Merge pull request #5542Wladimir J. van der Laan
2ecd294 Bugfix: configure: Correctly detect "nothing to build" condition (Luke Dashjr) b7a4ecc Bugfix: Only check for boost when building code that requires it (Luke Dashjr) a19eeac Bugfix: configure: Check for openssl/ec.h (Luke Dashjr) fe925e2 Use EXTRA_LIBRARIES instead of noinst_LIBRARIES so we can avoid building unused code (Cory Fields)
2015-01-07Bugfix: configure: Correctly detect "nothing to build" conditionLuke Dashjr
2015-01-07Bugfix: Only check for boost when building code that requires itLuke Dashjr
2015-01-07Bugfix: configure: Check for openssl/ec.hLuke Dashjr
2015-01-07[QA] fix zapwallettxes testJonas Schnelli
- remove shell test script and add a python equivalent
2015-01-07Merge pull request #5521Wladimir J. van der Laan
0ea28ba Reject non-final txs even in testnet/regtest (Peter Todd)
2015-01-07Fix smartfees test for change to relay policySuhas Daftuar
2015-01-07Merge pull request #5611Wladimir J. van der Laan
f0b8afc tests: fix spurious windows test failures after 012598880c (Cory Fields)
2015-01-07Merge pull request #5597Wladimir J. van der Laan
e413457 Catch LevelDB errors during flush (Pieter Wuille) 02bced1 Bugfix: only track UTXO modification after lookup (Pieter Wuille)
2015-01-07Merge pull request #5535Wladimir J. van der Laan
1c52aad Require sufficent priority for relay of free transactions (Pieter Wuille)
2015-01-06tests: fix spurious windows test failures after 012598880cCory Fields
on rare occasions, rand() was returning duped values, causing duplicate transactions. BuildMerkleTree happily used these, but CPartialMerkleTree caught them and returned a null merkle root. Rather than taking changes with rand(), use the loop counter to guarantee unique values. At sipa's request, also remove the remaining uses of rand().
2015-01-06Use EXTRA_LIBRARIES instead of noinst_LIBRARIES so we can avoid building ↵Cory Fields
unused code
2015-01-06Merge pull request #5513Wladimir J. van der Laan
856e862 namespace: drop most boost namespaces and a few header cleanups (Cory Fields) 9b1ab86 namespace: drop boost::assign altogether here (Cory Fields) a324199 namespace: remove boost namespace pollution (Cory Fields)
2015-01-06Merge pull request #5520Wladimir J. van der Laan
bdb6a71 IsNull doesn't change CBlockLocator, add const hint (Pavel Janík) 1b37333 Remove no longer needed declaration of CBlockLocator (Pavel Janík)
2015-01-06Merge pull request #5598Wladimir J. van der Laan
eb0d34b Remove unused chainparam networkID (jtimon)
2015-01-06Merge pull request #5564Wladimir J. van der Laan
de236f5 clarify obscure uses of EvalScript() (Pavel Vasin)
2015-01-06Merge pull request #5532Wladimir J. van der Laan
be22b3d Update seed IPs, based on bitcoin.sipa.be crawler data (Pieter Wuille)
2015-01-06Merge pull request #5603Wladimir J. van der Laan
7268f7b Move arith_uint256 out of consensus and util (Pieter Wuille)
2015-01-05tests: run sanity checks in tests tooCory Fields
If these are going to fail in bitcoind, they should fail in the tests as well.
2015-01-06Move arith_uint256 out of consensus and utilPieter Wuille
2015-01-05Make the command-line-args dialog betterThomas Zander
Instead of using a fixed-width font in a label, which virtually guarentees a horizontal scrollbar, use a proper text-document that can re-layout based on user input.
2015-01-05Update seed IPs, based on bitcoin.sipa.be crawler dataPieter Wuille
2015-01-05Merge pull request #5490Wladimir J. van der Laan
6bd0dc2 arith_uint256: remove initialization from byte vector (Wladimir J. van der Laan) 30007fd Remove now-unused methods from arith_uint256 and base_uint (Wladimir J. van der Laan) edc7204 Remove arith_uint160 (Wladimir J. van der Laan) dba2e91 Add tests for new uint256 (Wladimir J. van der Laan) 92cdb1a Add conversion functions arith_uint256<->uint_256 (Wladimir J. van der Laan) bfc6070 uint256->arith_uint256 blob256->uint256 (Wladimir J. van der Laan) 734f85c Use arith_uint256 where necessary (Wladimir J. van der Laan) 34cdc41 String conversions uint256 -> uint256S (Wladimir J. van der Laan) 2eae315 Replace uint256(1) with static constant (Wladimir J. van der Laan) 8076585 Replace GetLow64 with GetCheapHash (Wladimir J. van der Laan) 4f15249 Replace direct use of 0 with SetNull and IsNull (Wladimir J. van der Laan) 5d3064b Temporarily add SetNull/IsNull/GetCheapHash to base_uint (Wladimir J. van der Laan)
2015-01-05arith_uint256: remove initialization from byte vectorWladimir J. van der Laan
Remove initialization from vector (as this is only used in the tests). Also implement SetHex and GetHex in terms of uint256, to avoid duplicate code as well as avoid endianness issues (as they work in term of bytes).
2015-01-05Remove now-unused methods from arith_uint256 and base_uintWladimir J. van der Laan
- Methods that access the guts of arith_uint256 are removed, as these are incompatible between endians. Use uint256 instead - Serialization is no longer needed as arith_uint256's are never read or written - GetHash is never used on arith_uint256
2015-01-05Remove arith_uint160Wladimir J. van der Laan
We never do 160-bit arithmetic.
2015-01-05Add tests for new uint256Wladimir J. van der Laan
2015-01-05Add conversion functions arith_uint256<->uint_256Wladimir J. van der Laan
2015-01-05uint256->arith_uint256 blob256->uint256Wladimir J. van der Laan
Introduce new opaque implementation of `uint256`, move old "arithmetic" implementation to `arith_uint256.
2015-01-05Use arith_uint256 where necessaryWladimir J. van der Laan
Also add conversion from/to uint256 where needed.
2015-01-05String conversions uint256 -> uint256SWladimir J. van der Laan
If uint256() constructor takes a string, uint256(0) will become dangerous when uint256 does not take integers anymore (it will go through std::string(const char*) making a NULL string, and the explicit keyword is no help).
2015-01-05Replace uint256(1) with static constantWladimir J. van der Laan
SignatureHash and its test function SignatureHashOld return uint256(1) as a special error signaling value. Return a local static constant with the same value instead.
2015-01-05Replace GetLow64 with GetCheapHashWladimir J. van der Laan
2015-01-05Replace direct use of 0 with SetNull and IsNullWladimir J. van der Laan
Replace x=0 with .SetNull(), x==0 with IsNull(), x!=0 with !IsNull(). Replace uses of uint256(0) with uint256().
2015-01-05Temporarily add SetNull/IsNull/GetCheapHash to base_uintWladimir J. van der Laan
Also add a stub for arith_uint256 and its conversion functions, for now completely based on uint256. Eases step-by-step migration to blob.
2015-01-05Merge pull request #5594Wladimir J. van der Laan
7eeeac0 Remove dead BitcoinUnits::id code and update assets-attribution for non-image unit selector (Luke Dashjr)
2015-01-04Reject non-final txs even in testnet/regtestPeter Todd
Previous behavior with IsFinalTx() being an IsStandard() rule was rather confusing and interferred with testing of protocols that depended on nLockTime.
2015-01-04Catch LevelDB errors during flushPieter Wuille
2015-01-04Bugfix: only track UTXO modification after lookupPieter Wuille
Otherwise, if CCoinsViewCache::ModifyCoins throws an exception in between setting hasModifier and constructing the CCoinsModifier, the cache ends up in an inconsistent state, resulting in an assert failure in the next modification. Bug discovered by Wladimir J. van der Laan.
2015-01-04Merge pull request #5540Pieter Wuille
12d927a RPC test for immature balance (Jonas Schnelli) 8024d67 Add immature balances to getwalletinfo. (Gregory Maxwell) d44c545 Add unconfirmedbalance field to getwalletinfo (azeteki)
2015-01-04Merge pull request #5508Pieter Wuille
146c0a7 Add RandAddSeedPerfmon to MakeNewKey (21E14)