aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-02doc: Bump manpages pre-finalv0.18.1Wladimir J. van der Laan
No changes, only the month changed from July to August. Tree-SHA512: c8f672f3a6e570ea1feda2c2f17d30da8a04b705d990bf5aec8e09da5937f3f9a608f4f50941f183c536a4158001b13d149bd0c873a24eae48ae57d96cd274c8
2019-08-02build: set CLIENT_VERSION_RC to 0 pre-finalWladimir J. van der Laan
Tree-SHA512: b74ff824278e6a4c4781c904e3f68295c76d9de79cc174a6e7127273295ef3fddb87de89143ceb76805e33b8c2dec77b3e6ae4bec97a3128d9908c065c7f95de
2019-08-02Merge #16532: [0.18] Doc: remove old release notes about systemd and riscv ↵Wladimir J. van der Laan
changes 5f5b444cc02190352312021c736d88c925731d90 Doc: remove old release notes about systemd and riscv changes (David A. Harding) Pull request description: Removes these two paragraphs that were part of the 0.18.0 release notes but which I don't think need to be repeated for the 0.18.1 release notes. The systemd release note in particular links to a section that isn't part of the document. ACKs for top commit: practicalswift: ACK 5f5b444cc02190352312021c736d88c925731d90 laanwj: ACK 5f5b444cc02190352312021c736d88c925731d90 fanquake: ACK 5f5b444cc02190352312021c736d88c925731d90 - this should be fine. Tree-SHA512: 3930b832eeed1f938cd6423dd9ac1e02ab7bb4fc218f433551fa995f40b84e8f2af5755ca4bf56caccdc742b6884bc79b381c9bdb3ad90e99ca90011d9e12665
2019-08-01Doc: remove old release notes about systemd and riscv changesDavid A. Harding
2019-07-24doc: Update release notes for rc1Wladimir J. van der Laan
Tree-SHA512: e5422eaed5339327b600bfe07e5cdb1517bf6f3d9a39d27c9c59a68ceadbef398960c69630bc727f3f8d7330353e7823905f5107dba6d8827965565157cdeca1
2019-07-19doc: Update manpages for rc1v0.18.1rc1Wladimir J. van der Laan
Tree-SHA512: 805a6931e2bd059ee2da42634f687828a50b2ccd3a1ac0071cd626e9a2f52b7afc79af3c8f3d5b013a853d5e59068314e744a4694dceef598710f0694babbd99
2019-07-19build: Bump version to 0.18.1rc1Wladimir J. van der Laan
Tree-SHA512: f746d4cfda1eb433c4c99b8d80392ac2e905c1f39591eb5579a708129e3b1b36479a2da45221594713cf20069bde78c29a31cb10d39c7bc96544694d9832cda0
2019-07-19qt: pre-rc1 translations updateWladimir J. van der Laan
Tree-SHA512: b97fd91b7ab1eb2297007a9821def31c065a2a33f12cf51fd5e5be5dff1e8afb4f5b001d220c3873d72ca5b06484ad2d1e2c8df5300770145de0dfebe56db303
2019-07-19net: Make poll in InterruptibleRecv only filter for POLLIN events.tecnovert
poll should block until there is data to be read or the timeout expires. Filtering for the POLLOUT event causes poll to return immediately which leads to high CPU usage when trying to connect to non-responding peers through tor. Removing POLLOUT matches how select is used when USE_POLL isn't defined. Github-Pull: #16412 Rebased-From: a52818cc5633494992da7d1dc8fdb04b4a1b7c29 Tree-SHA512: eaf466630ba9d2a2a7443c9679c83c2cb13e779a5948f409cddb4c48cf32126ac68f3de48e394f9302e99858efa17cdb14650751a1b55c3b79e8a7507cab352d
2019-07-18Merge #16406: 0.18: fix: tor: Call event_base_loopbreak from the event's ↵fanquake
callback b2711b98bdc0dc220500a4b3ca94dfb97c4d17f2 fix: tor: Call event_base_loopbreak from the event's callback (João Barbosa) Pull request description: Github-Pull: #16405 Rebased-From: a981e749e6553487cd48eda28e590f769e81c85c ACKs for top commit: laanwj: ACK b2711b98bdc0dc220500a4b3ca94dfb97c4d17f2, code change is the same as for master fanquake: ACK b2711b98bdc0dc220500a4b3ca94dfb97c4d17f2 Tree-SHA512: 9f225e505c0241be422ed897f56aef6ebad57e15d3bfe5154c7fe4f874df342e0df287871cd737eb777d0f45865a6d129cd5d1a4c036ea0a4e5d4f36520ab174
2019-07-17fix: tor: Call event_base_loopbreak from the event's callbackJoão Barbosa
Github-Pull: #16405 Rebased-From: a981e749e6553487cd48eda28e590f769e81c85c
2019-07-10Merge #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result"Wladimir J. van der Laan
df695db3237571c662a4e199709f9c6615ffa0c5 qt: Assert QMetaObject::invokeMethod result (João Barbosa) e2f7677bdeb15d1517520ddc3e95e42ca13f721a gui: Fix missing qRegisterMetaType(WalletModel*) (João Barbosa) Pull request description: ACKs for top commit: hebasto: ACK df695db3237571c662a4e199709f9c6615ffa0c5, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged. laanwj: ACK df695db3237571c662a4e199709f9c6615ffa0c5 Tree-SHA512: 5ce162e59331f6da8ae9ba41eff809881442fab93d65362b5f67aba19da76a72362f0daba9ad1f909478bf26f2daf53b110a0486d7b29b23b3716a7cd7177922
2019-07-09qt: Assert QMetaObject::invokeMethod resultJoão Barbosa
Github-Pull: #16348 Rebased-From: 64fee489448c62319e77941c30152084695b5a5d
2019-07-09gui: Fix missing qRegisterMetaType(WalletModel*)João Barbosa
Github-Pull: #16348 Rebased-From: f27bd96b5fdc2921d93c44bbf422bff0e979c4de
2019-07-07Merge #16342: 0.18 backport: report error when missing ↵fanquake
redeemScript/witnessScript 1dc357dab signrawtransactionwithkey: report error when missing redeemScript/witnessScript param (Anthony Towns) Pull request description: Backport of #16250 which fixes regression introduced in 0.18 in relation to signrawtransactionwithkey error handling (see #16249). Tree-SHA512: 0d75fa2aa578b886ace3bda92a02e25993f9f51d41db8c0eb3013bd77d266c45ad8b67dd0ed11c66533724f892be4e254edeb59fa70585ff762f522791fcca36
2019-07-05signrawtransactionwithkey: report error when missing ↵Anthony Towns
redeemScript/witnessScript param Github-Pull: #16250 Rebased-From: 01174596e69568c434198a86f54cb9ea6740e6c2
2019-07-04Merge #16035: 0.18.1: Backportsfanquake
bcb27d7b0 .python-version: Bump to 3.5.6 (MarcoFalke) af25a757e Add comments to Python ECDSA implementation (John Newbery) 715da91e9 Set AA_EnableHighDpiScaling attribute early (Hennadii Stepanov) 2800b3d5c gui: Fix open wallet menu initialization order (João Barbosa) e78007fc1 Make and get the multisig redeemscript and destination in one function instead of two (Andrew Chow) d9fc969e7 Pure python EC (Pieter Wuille) 23ba460c1 test: Add test that addmultisigaddress fails for watchonly addresses (MarcoFalke) 13b3bb564 test: Fixup creatmultisig documentation and whitespace (MarcoFalke) 79745d175 Replace remaining fprintf with tfm::format manually (MarcoFalke) beb09f09b scripted-diff: Replace fprintf with tfm::format (MarcoFalke) e29aa6e72 Exceptions should be caught by reference, not by value. (Kristaps Kaupe) f88959ba7 tinyformat: Add doc to Bitcoin Core specific strprintf (MarcoFalke) 0023c9789 rpc: bugfix: Properly use iswitness in converttopsbt (MarcoFalke) 832eb4ff5 Bugfix: test/functional/rpc_psbt: Correct test description comment (Luke Dashjr) 966d8d084 Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (Luke Dashjr) bb36ac82e rpc: Switch touched RPCs to IsValidNumArgs (MarcoFalke) d24d0ec05 Add example 2nd arg to signrawtransactionwithkey (Chris Moore) 592016ba1 fixup: Fix prunning test (João Barbosa) c80a498ae Fix RPC/pruneblockchain returned prune height (Jonas Schnelli) b2398240f gui: Enable open wallet menu on setWalletController (João Barbosa) d1f261150 Add test for GCC bug 90348 (Pieter Wuille) d80c558e0 gui: Set progressDialog to nullptr (João Barbosa) 7ed1a6019 gui: Enable console line edit on setClientModel (João Barbosa) b55cbe82d qt: fix opening bitcoin.conf via Preferences on macOS; see #15409 (shannon1916) b6c1f9478 Disallow extended encoding for non-witness transactions (take 3) (MarcoFalke) 86031083c Add test for superfluous witness record in deserialization (Gregory Sanders) 5a58ddb6d Fix missing input template by making minimal tx (Gregory Sanders) 206f5ee87 Disallow extended encoding for non-witness transactions (Pieter Wuille) 3dbc7def0 Show loaded wallets as disabled in open menu instead of nothing (MeshCollider) a635377b6 Install bitcoin-wallet manpage. (Daniel Kraft) eb85ee62b Doc: remove text about txes always relayed from -whitelist (David A. Harding) 890a92eba doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) 3460555f4 test: Add test for p2p_blocksonly (MarcoFalke) 8f215c7a2 test: Format predicate source as multiline on error (MarcoFalke) 9c1a607a0 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) 5935f0126 build with -fstack-reuse=none (MarcoFalke) Pull request description: Tree-SHA512: 5cd73a4319cb69c92b528239cf97c0ed5fcf2b9e8c7fe154e4679eeec95db433a0223d8dc574e4cdc96c1913cfdf160b10c42dcdbcb5bbc8fb743c07930ef9da
2019-06-26.python-version: Bump to 3.5.6MarcoFalke
See also: dddd1d05d3df06865f5e0b1442d7425c0955de4e
2019-06-26Add comments to Python ECDSA implementationJohn Newbery
Github-Pull: #15826 Rebased-From: b67978529ad02fc2665f2362418dc53db2e25e17
2019-06-24Set AA_EnableHighDpiScaling attribute earlyHennadii Stepanov
Qt docs: This attribute must be set before QGuiApplication is constructed. Github-Pull: #16254 Rebased-From: 099e4b9ad3d9967051d5c3d45c6315d1b30fea05
2019-06-23gui: Fix open wallet menu initialization orderJoão Barbosa
The menu must be created before connecting to aboutToShow signal. Github-Pull: #16231 Rebased-From: 5224be5a3354e1a22ea4d7f0e40aadfccdf67064
2019-06-21Make and get the multisig redeemscript and destination in one function ↵Andrew Chow
instead of two Instead of creating a redeemScript with CreateMultisigRedeemscript and then getting the destination with AddAndGetDestinationForScript, do both in the same function. CreateMultisigRedeemscript is changed to AddAndGetMultisigDestination. It creates the redeemScript and returns it via an output parameter. Then it calls AddAndGetDestinationForScript to add the destination to the keystore and get the proper destination. This allows us to inspect the public keys in the redeemScript before creating the destination so that the correct destination is used when uncompressed pubkeys are in the multisig. Github-Pull: #16026 Rebased-From: a49503402b6bc21e3878e151c07529941d36aed0
2019-06-21Pure python ECPieter Wuille
This removes the dependency on OpenSSL for the interaction tests, by providing a pure-Python toy implementation of secp256k1. Github-Pull: #15826 Rebased-From: 8c7b9324ca3f3ffb178bea56a96ea23f7e0383cb
2019-06-21test: Add test that addmultisigaddress fails for watchonly addressesMarcoFalke
Github-Pull: #15831 Rebased-From: fab6a0a659bb856e4598af3e0679fc37d5239478
2019-06-21test: Fixup creatmultisig documentation and whitespaceMarcoFalke
Github-Pull: #15831 Rebased-From: fad81d870aa6dd25d4fab5faad4c956ba364734a
2019-06-18Replace remaining fprintf with tfm::format manuallyMarcoFalke
Github-Pull: #16205 Rebased-From: fa8f195195945ce6258199af0461e3fbfbc1236d
2019-06-18scripted-diff: Replace fprintf with tfm::formatMarcoFalke
-BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/fprintf\(std(err|out), /tfm::format(std::c\1, /g' $(git grep -l 'fprintf(' -- ':(exclude)src/crypto' ':(exclude)src/leveldb' ':(exclude)src/univalue' ':(exclude)src/secp256k1') -END VERIFY SCRIPT- fixup! scripted-diff: Replace fprintf with tfm::format Github-Pull: #16205 Rebased-From: fac03ec43a15ad547161e37e53ea82482cc508f9
2019-06-18Exceptions should be caught by reference, not by value.Kristaps Kaupe
Github-Pull: #16095 Rebased-From: ae7faf20d5fb3e2415ccadc37100dfc44aa0cd94
2019-06-18tinyformat: Add doc to Bitcoin Core specific strprintfMarcoFalke
Github-Pull: #16205 Rebased-From: fa72a64b90dc07a80b1ca6127eb50d8244dedc3b
2019-06-18rpc: bugfix: Properly use iswitness in converttopsbtMarcoFalke
Also explain the param in all RPCs Github-Pull: #15899 Rebased-From: fa499b5f027f77c0bf13699852c8c06f78e27bef
2019-06-18Bugfix: test/functional/rpc_psbt: Correct test description commentLuke Dashjr
Github-Pull: #14818 Rebased-From: c87fc71f7e9316bcc0653cd86c50177424b5b1f9
2019-06-18Bugfix: test/functional/rpc_psbt: Remove check for specific error message ↵Luke Dashjr
that depends on uncertain assumptions When converttopsbt is called with a signed transaction, it either fails with "TX decode failed" if one or more inputs were segwit, or "Inputs must not have scriptSigs and scriptWitnesses" otherwise. Since no effort is made by the test to ensure the inputs are segwit or not, avoid checking the exact message used. The error code is still checked to ensure it is of the correct kind of failure. Github-Pull: #14818 Rebased-From: 097c4aa379f255639ce0084702693fa72a595d6b
2019-06-18rpc: Switch touched RPCs to IsValidNumArgsMarcoFalke
Github-Pull: #15899 Rebased-From: fa5c5cd141f0265a5693234690ac757b811157d8
2019-06-17Add example 2nd arg to signrawtransactionwithkeyChris Moore
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter. Github-Pull: #16210 Rebased-From: 71fd628adafdeb2a4b343e0d51d7168cdb186312
2019-06-14fixup: Fix prunning testJoão Barbosa
Github-Pull: #15991 Rebased-From: f402012ccfc596d7d94851dabbf386c278ff5335
2019-06-14Fix RPC/pruneblockchain returned prune heightJonas Schnelli
Github-Pull: #15991 Rebased-From: 97f517dd851450b1ede1eb6b20f77691883a7737
2019-06-13gui: Enable open wallet menu on setWalletControllerJoão Barbosa
Github-Pull: #16118 Rebased-From: 75485ef0962a53946f17b761c4445627b07e6eff
2019-06-13Merge #16189: 0.18: Backport "Add -ignorepartialspends to list of ignored ↵Wladimir J. van der Laan
wallet options" 106471d0d710a957280c36862df222657ace17f5 Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options (Luke Dashjr) 206c30f6d7ff9fbcdb0f0b882e8da54870f8ee73 dummywallet: Reformat ignored wallet options list (MarcoFalke) Pull request description: First run clang-format on the wallet options list (review with `--word-diff-regex=.`). This is not a backport. Then backport Github-Pull: #15913 ACKs for commit 106471: promag: ACK 106471d. laanwj: ACK 106471d0d710a957280c36862df222657ace17f5 Tree-SHA512: 3e6eb7997aa32ef7385842614bac8cac56f86b6dde949cfbbd33b4387e713bf5f65e40ee3e4228ac43dfe50829169175b80ddeaac8a714ad8a38175638123f5d
2019-06-11Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet optionsLuke Dashjr
Github-Pull: #15913 Rebased-From: 765d5890be46ed5f5557c1d2b3cb931e6b8eb3b0
2019-06-11dummywallet: Reformat ignored wallet options listMarcoFalke
2019-06-07Add test for GCC bug 90348Pieter Wuille
Github-Pull: #15985 Rebased-From: 58e291cfad12fa85af87d093acfa7b44702e3521
2019-06-07gui: Set progressDialog to nullptrJoão Barbosa
Github-Pull: #16135 Rebased-From: d2ae6be80f6a0156021bf8c9b9d17cd4966ddffc
2019-06-07gui: Enable console line edit on setClientModelJoão Barbosa
Github-Pull: #16122 Rebased-From: 2d8ad2f99710a8981e33fe2d6ce834b0076c4e80
2019-06-07qt: fix opening bitcoin.conf via Preferences on macOS; see #15409shannon1916
Github-Pull: #16044 Rebased-From: 6e6494b3fb345848025494cb7a79c5bf8f35e417
2019-05-20Disallow extended encoding for non-witness transactions (take 3)MarcoFalke
Github-Pull: #16021 Rebased-From: fa2b52af32f6a4b9c22c270f36e92960c29ef364
2019-05-20Add test for superfluous witness record in deserializationGregory Sanders
Github-Pull: #15893 Rebased-From: cc556e4a30b4a32eab6722f590489d89b2875de3
2019-05-20Fix missing input template by making minimal txGregory Sanders
Github-Pull: #15893 Rebased-From: 25b078658139c1aea58393a32ac5a79144d8d140
2019-05-20Disallow extended encoding for non-witness transactionsPieter Wuille
Github-Pull: #14039 Rebased-From: bb530efa1872ec963417f61da9a95185c7a7a7d6
2019-05-18Show loaded wallets as disabled in open menu instead of nothingMeshCollider
Github-Pull: #15957 Rebased-From: c3ef63a52f304a600fff1f9c7caa5cb804d41d43
2019-05-17Install bitcoin-wallet manpage.Daniel Kraft
This change marks the already-existing bitcoin-wallet.1 manpage file for installation together with the others. Previously, only bitcoind.1, bitcoin-cli.1, bitcoin-tx.1 and bitcoin-qt.1 would be installed. Github-Pull: #15947 Rebased-From: 00d110463aed12ecdc6e9c2bf47d9ef61d19fa9d