aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-29refactor: Make rest.cpp dependency on `*toJSON` in `blockchain.cpp` explicitWladimir J. van der Laan
2017-03-27refactor: Move RPCNotifyBlockChange out of `rpc/server.h`Wladimir J. van der Laan
2017-03-27refactor: Move GetDifficulty out of `rpc/server.h`Wladimir J. van der Laan
It has no business in `rpcserver.h`. Define it in the interface header of the implementation unit `rpcblockchain` where it is defined. Also modernize the signature to: double GetDifficulty(const CBlockIndex* blockindex = nullptr); (remove `extern`, replace `NULL` with `nullptr`)
2017-03-27Merge #10057: [init] Deduplicated sigaction() boilerplateWladimir J. van der Laan
81a3857 Deduplicated sigaction() boilerplate (Thomas Snider) Tree-SHA512: 705b73f285a3d76504ba01476e072fdce67731b65f309bb04e4bbd765556c37e127cb769b475de2d68b33f50d7737fb136aefa0fa7c725a11ad16a47b9d0365f
2017-03-27Merge #10056: [zmq] Call va_end() on va_start()ed args.Wladimir J. van der Laan
5ba61f0 [zmq] Call va_end() on va_start()ed args. (Karl-Johan Alm) Tree-SHA512: fbd3a0c29308ca9607f362f14fa7ea9c949a3f25dc09a349fe3b3ffd316b573c86778e29d3b9d55c684571eacae50aca90bb872e2e5489818d0af8310511fe79
2017-03-27Merge #10060: [Qt] Ensure an item exists on the rpcconsole stack before addingJonas Schnelli
4df76e2 Ensure an item exists on the rpcconsole stack before adding (Andrew Chow) Tree-SHA512: f3fd5e70da186949aff794f6e2ba122da2145331212dcc5e0595285bee9dc3aa6b400b15e8eeec4476099965b74f46c4ef80f8ed1e05d490580167b002b9a5e7
2017-03-27Merge #10073: Actually run assumevalid.pyWladimir J. van der Laan
717ad13 Actually run assumevalid.py. (John Newbery) Tree-SHA512: 6fd55789be43e26347f8f5456194aa5e7beeeba3db85411dc75581b98059ca3a85485494fca36848f21c0f48096004906a0409fd76309951b5f977bab9f45b91
2017-03-27Merge #10085: Docs: remove 'noconnect' optionWladimir J. van der Laan
d5690f1 remove 'noconnect' option from documentation (Jameson Lopp) Tree-SHA512: 9c61df5ee7b2b9a8188cbf44fced05c41ded3454758dbc1b1ae641cea0301a65169381f20c045027e571ebe211a42e680a66daed47090f91766403cc60147e89
2017-03-27Merge #10083: [QA] Renaming rawTx into rawtxWladimir J. van der Laan
dd5be2c [QA] Renaming rawTx into rawtx (NicolasDorier) Tree-SHA512: c999c3cbe7bbd00bf5cc9813741c485caea9925de1214c8a7ef717a7c109c1a8baf73b460db3b08f4ec138d773b46176531c48295504ed75180d4b3666b85b99
2017-03-26remove 'noconnect' option from documentationJameson Lopp
2017-03-26[QA] Renaming rawTx into rawtxNicolasDorier
2017-03-25Merge #10069: [QA] Fix typo in fundrawtransaction testMarcoFalke
803e6a3 [QA] Fix typo in fundrawtransaction test (Nicolas Dorier) Tree-SHA512: 7b88cf09d7e756f0f5535738993868287d4c7049db44072e318f48a9b08786bebb9877f787471bbf6aac58b3d709275eefa372d727f4afd6ded41494fe0024d1
2017-03-25Merge #9946: Fix build errors if spaces in path or parent directoryWladimir J. van der Laan
b1f584d fix build if spaces in src dir path (Matthew Zipkin) Tree-SHA512: 5834690c1f63b85ed04bb8ed411a94da04738534364d58bd9ee333ccff7129b2bbb710f31598c40123199e023da02c1745514294af3efdbb2c2e4c1320aded35
2017-03-25Merge #10067: [trivial] Dead code removalWladimir J. van der Laan
c59aedc [trivial] Dead code removal (Thomas Snider) Tree-SHA512: 09962c1ae36fb2f19b7e4a03abf3de6632bab984ce30040ca3f843431df33a0f8fa6a2c1d55b076b800547bb656e344d74ea085ff081b613bcdfd7d2f9826374
2017-03-25Merge #10063: add missing spaces so that markdown recognizes headlineWladimir J. van der Laan
cc995e2 add missing spaces so that markdown recognizes headline (flack) Tree-SHA512: f19afeb765f883cc95a14149b761b74549540ae6c573eeaee558b32e57999d95f5bdee9d55c3a16347967dfdc578a900f09cc1d412bdf640122049afbb4dd746
2017-03-24Ensure an item exists on the rpcconsole stack before addingAndrew Chow
Ensures that there is an item on the rpcconsole stack before adding something to the current stack so that a segmentation fault does not occur.
2017-03-24fix build if spaces in src dir pathMatthew Zipkin
2017-03-24Actually run assumevalid.py.John Newbery
assumevalid was merged as part of PR 9484, but was not added to the test_runner, so is not run even as part of the extended tests. This commit adds assumevalid to the list of tests in test_runner. It also clarifies the code in assumevalid considerably.
2017-03-24Deduplicated sigaction() boilerplateThomas Snider
2017-03-24Merge #10052: [test] Run extended tests once daily in TravisMarcoFalke
88e3aa0 Run extended tests once daily (John Newbery) Tree-SHA512: 92478ee930b60d8d90d1bf7352ff81853198391559281ce3074748b55145202984ba4150f751d25f3256e696e3fd8f25ea02ecd57b881744736adf505c275178
2017-03-24Merge #10053: [test] Allow functional test cases to be skippedMarcoFalke
0c1ade6 Skip rpcbind_test if OS/network requirements are not met. (John Newbery) 232b666 Allow test cases to be skipped (John Newbery) Tree-SHA512: d90c956ba6e27e53f422cba6267bdcc60faef9370a7e66b7f6480137f84d9a813442ac477b20fbbc540be2b4636928be910c46e221570ab3b9a5b9f0f11f7fc8
2017-03-24[QA] Fix typo in fundrawtransaction testNicolas Dorier
Ping @jnewbery introduced on https://github.com/bitcoin/bitcoin/commit/dab804c18a427901684ebe936b2069a97e04a268
2017-03-24Skip rpcbind_test if OS/network requirements are not met.John Newbery
2017-03-23[trivial] Dead code removalThomas Snider
2017-03-23add missing spaces so that markdown recognizes headlineflack
2017-03-23Merge #9701: Make bumpfee tests less fragileMarcoFalke
f85ac54 [qa] Expand bumpfee test docstring (Russell Yanofsky) 0b94e49 [qa] Rename python input variable to tx_input (Russell Yanofsky) 1dfd64f [qa] Make bumpfee.py test function order consistent (Russell Yanofsky) e6b2963 [qa] Get rid of nondeterminism in bumpfee.py (Russell Yanofsky) 94b528b [qa] Remove bumpfee.py get_change_address hack (Russell Yanofsky) Tree-SHA512: 4017d58fe73837a0dfcca69c43f804498833f946efd9bc394877be242aa40b03d60bd6c3672ed5d24db88b3318304c1f2838050ec5fa6458d1a7e1f566ccda3e
2017-03-23Merge #10047: [tests] Remove unused variables and importsMarcoFalke
3897459 [tests] Remove unused variables (practicalswift) 72163d4 [tests] Remove unused and duplicate imports (practicalswift) Tree-SHA512: 926af14b844bfca3bdd08b3cfdcb0edd3652efb4612d5571fee9abb917a6ce4e7d11d3601ff9c3d017e943ebe1e9ebdfccaf0af3db84d201b61941e9c1c9146a
2017-03-23Merge #9500: [Qt][RPC] Autocomplete commands for 'help' command in debug consoleJonas Schnelli
6d8fe35 'help' rpc commands autocomplete (Andrew Chow) Tree-SHA512: 289bc4fa16a1c0291262998caa18556f1c5aa89662c85528606dc03b596b8833a0fb2c5c9c068b6dcf2adb3a136d4f154591d4a95b8c3313638b77355aaed955
2017-03-23Merge #9558: Clarify assumptions made about when BlockCheck is calledJonas Schnelli
c4a6929 Clarify assumptions made about when BlockCheck is called (Matt Corallo) Tree-SHA512: 2eceb0c4f06c7fd6b290b93843bda11a4b63131559c5e8226bfec84596ed4e54ee6d8f5bc9cf789a80675be8b8079cf9234c96032df306258cb2260b9d8c7825
2017-03-23Merge #10029: Fix parameter naming inconsistencies between .h and .cpp filesJonas Schnelli
97b8213 Fix parameter naming inconsistencies between .h and .cpp files (practicalswift) Tree-SHA512: 4f46cc3973a898d2478bdb1b8c8d1829c3a7298b63bc47359c5dc2f135466773072d9672134ef3e7557dfc913720e49b675176b9e435b8bd1992af9ad53866e4
2017-03-22[zmq] Call va_end() on va_start()ed args.Karl-Johan Alm
2017-03-22[tests] Remove unused variablespracticalswift
2017-03-22[tests] Remove unused and duplicate importspracticalswift
2017-03-22Run extended tests once dailyJohn Newbery
2017-03-22Allow test cases to be skippedJohn Newbery
Currently, functional test cases can either pass or fail. There are occasions when it is helpful to skip tests, for example if the system they are running on does not meet the requirements for the test. The rest of the test suite can run without being marked as a failure. This commit adds framework for tests to skip if their requirements aren't met.
2017-03-22Merge #10017: combine_logs.py - aggregates log files from multiple bitcoinds ↵Wladimir J. van der Laan
during functional tests. 8317a45 Python functional tests should log in UTC (John Newbery) 61d75f5 Introduce combine_logs.py to combine log files from multiple bitcoinds. (John Newbery) Tree-SHA512: 472a00907c938cd558353086eda0fbd8746a889680d5db4900eb95496f5f6a12eeb46560a5efd4bbfee10c85307fcf50d021356c5aad64168eb5cc2ababb073a
2017-03-22Merge #10045: [trivial] Fix typos in commentsJonas Schnelli
dbf30ff [trivial] Fix typos in comments (practicalswift) Tree-SHA512: a841c96ba1a80ab57206e8ef4fa9b40ecff2244075a5539fc09f57e763bf2e92b0ed089e32a0dbac3902518dcda43d224f75a3462a560148841746560640ba70
2017-03-21Python functional tests should log in UTCJohn Newbery
bitcoind logs use UTC. Python functional tests should also log in UTC.
2017-03-21Introduce combine_logs.py to combine log files from multiple bitcoinds.John Newbery
This commit adds a tool for combining log files from multiple instances of bitcoinds as well as the test_framework.log file. This gives a combined view of what the test framework and all bitcoin instances were doing during a qa test.
2017-03-21[trivial] Fix typos in commentspracticalswift
2017-03-21[qa] Expand bumpfee test docstringRussell Yanofsky
2017-03-21Merge #10039: Fix compile errors with Qt 5.3.2 and Boost 1.55.0Wladimir J. van der Laan
b5bec4e Avoid QTimer::singleShot compile error with Qt 5.3.2 (Russell Yanofsky) d5046e7 Avoid scoped_connection compile error with boost 1.55.0 (Russell Yanofsky) Tree-SHA512: 96362b872817681b062e05c8fcb76cfc23b6e87e0371584a6aae0e17535fd34ccdba922380aa4b669a8e75ef3f9fadd25061541f77cb3198173f04249a7bcd62
2017-03-21[qa] Rename python input variable to tx_inputRussell Yanofsky
input() is actually the name of a python built in function
2017-03-21[qa] Make bumpfee.py test function order consistentRussell Yanofsky
Run bumpfee tests in top-down order, now that the test fragility is fixed, and they can actually run in order.
2017-03-21[qa] Get rid of nondeterminism in bumpfee.pyRussell Yanofsky
Change bumpfee tests to use the spend_one_input function instead of the create_fund_sign_send function. The latter function would choose transaction inputs and fees in unpredictable ways depending on the order that tests ran, which meant that adding new tests could cause old tests to fail, and in general made bumpfee.py fragile and unpleasant to work with.
2017-03-21[qa] Remove bumpfee.py get_change_address hackRussell Yanofsky
2017-03-21Merge #9956: Reorganise qa directoryMarcoFalke
63d66ba Move src/test/bitcoin-util-test.py to test/util/bitcoin-util-test.py (John Newbery) 5b0bff4 Rename --enable-extended-rpc-tests to --enable-extended-functional-tests (John Newbery) a9bd622 Rename test/pull-tester/rpc-tests.py to test/functional/test_runner.py (John Newbery) c28ee91 Rename rpc-tests directory to functional (John Newbery) 00902c4 Rename qa directory to test (John Newbery) Tree-SHA512: ee7125c0c647d81590177beef2c8852c4ef76fdcf888096d9d4d360562a01d8d3b453345c3040487b2a043935bd1e7e80018f34462d6e02262bedbe23edcc576
2017-03-20Merge #9734: Add updating of chainTxData to release processWladimir J. van der Laan
41b8821 Add updating of chainTxData to release process (Pieter Wuille) Tree-SHA512: f7d6e72b19aa83fc4851a9316d6c6a236e0e914d637525cda42c0b15a94543b8072ce67b57d6b12141332a03b64b6c715dff4d61e6e58e0197b22305b35ad65d
2017-03-20Avoid QTimer::singleShot compile error with Qt 5.3.2Russell Yanofsky
Construct QTimer object directly, instead of relying on QTimer::singleShot overloads accepting lambdas, which weren't introduced until Qt 5.4. Avoids the following compile error in debian jessie: ``` qt/test/wallettests.cpp: In function ‘void {anonymous}::ConfirmSend()’: qt/test/wallettests.cpp:34:6: error: no matching function for call to ‘QTimer::singleShot(int, Qt::TimerType, {anonymous}::ConfirmSend()::<lambda()>)’ }); ^ qt/test/wallettests.cpp:34:6: note: candidates are: In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/QTimer:1:0, from ./qt/sendcoinsdialog.h:13, from qt/test/wallettests.cpp:7: /usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:81:17: note: static void QTimer::singleShot(int, const QObject*, const char*) static void singleShot(int msec, const QObject *receiver, const char *member); ^ /usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:81:17: note: no known conversion for argument 2 from ‘Qt::TimerType’ to ‘const QObject*’ /usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:82:17: note: static void QTimer::singleShot(int, Qt::TimerType, const QObject*, const char*) static void singleShot(int msec, Qt::TimerType timerType, const QObject *receiver, const char *member); ^ /usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:82:17: note: candidate expects 4 arguments, 3 provided ``` Error reported by Pavel Janík <Pavel@Janik.cz> in https://github.com/bitcoin/bitcoin/pull/9974#issuecomment-287574436
2017-03-20Avoid scoped_connection compile error with boost 1.55.0Russell Yanofsky
Construct scoped_connection directly instead of relying on copy initialization and move constructor. Avoids the following compile error in debian jessie: ``` In file included from /usr/include/boost/signals2/signal.hpp:21:0, from ./util.h:29, from ./dbwrapper.h:11, from ./txdb.h:10, from ./test/test_bitcoin.h:11, from qt/test/wallettests.cpp:11: /usr/include/boost/signals2/connection.hpp: In function ‘uint256 {anonymous}::SendCoins(CWallet&, SendCoinsDialog&, const CBitcoinAddress&, CAmount)’: /usr/include/boost/signals2/connection.hpp:234:7: error: ‘boost::signals2::scoped_connection::scoped_connection(const boost::signals2::scoped_connection&)’ is private scoped_connection(const scoped_connection &other); ^ qt/test/wallettests.cpp:47:6: error: within this context }); ^ ``` Error reported by Pavel Janík <Pavel@Janik.cz> in https://github.com/bitcoin/bitcoin/pull/9974#issuecomment-287550034