aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-21Make verify-commits POSIX-compliantMatt Corallo
2016-05-19Merge #8070: Remove non-determinism which is breaking net_tests #8069Wladimir J. van der Laan
2a8b358 Fix typo adddrman to addrman as requested in #8070 (Ethan Heilman) f4119c6 Remove non-determinism which is breaking net_tests #8069 (EthanHeilman)
2016-05-19Merge #8033: Fix Socks5() connect failures to be less noisy and less ↵Wladimir J. van der Laan
unnecessarily scary bf9266e Use Socks5ErrorString() to decode error responses from socks proxy. (Warren Togami) 94fd1d8 Make Socks5() InterruptibleRecv() timeout/failures informative. (Warren Togami) 0d9af79 SOCKS5 connecting and connected messages with -debug=net. (Warren Togami) 00678bd Make failures to connect via Socks5() more informative and less unnecessarily scary. (Warren Togami)
2016-05-19Use Socks5ErrorString() to decode error responses from socks proxy.Warren Togami
2016-05-18Fix typo adddrman to addrman as requested in #8070Ethan Heilman
2016-05-18Remove non-determinism which is breaking net_tests #8069EthanHeilman
2016-05-18Merge #7917: Optimize reindexWladimir J. van der Laan
b4d24e1 Report reindexing progress in GUI (Pieter Wuille) d3d7547 Add -reindex-chainstate that does not rebuild block index (Pieter Wuille) fb8fad1 Optimize ActivateBestChain for long chains (Pieter Wuille) 316623f Switch reindexing to AcceptBlock in-loop and ActivateBestChain afterwards (Pieter Wuille) d253ec4 Make ProcessNewBlock dbp const and update comment (Pieter Wuille)
2016-05-18Merge #8054: net: Avoid duplicate getheaders requests.Wladimir J. van der Laan
f93c2a1 net: Avoid duplicate getheaders requests. (Daniel Kraft)
2016-05-18Merge #8048: doc: Remove outdated qt4 install information from README.mdWladimir J. van der Laan
6075bc4 doc: 32 and 64 bit packages are seperate (Wladimir J. van der Laan) e5764e6 doc: Remove outdated qt4 install information from README.md (Wladimir J. van der Laan)
2016-05-18Merge #7906: net: prerequisites for p2p encapsulation changesWladimir J. van der Laan
5d5e7a0 net: No need to export ConnectNode (Cory Fields) e9ed620 net: No need to export DumpBanlist (Cory Fields) 8b8f877 net: make Ban/Unban/ClearBan functionality consistent (Cory Fields) cca221f net: Drop CNodeRef for AttemptToEvictConnection (Cory Fields) 563f375 net: use the exposed GetNodeSignals() rather than g_signals directly (Cory Fields) 9faa490 net: remove unused set (Cory Fields) 52cbce2 net: don't import std namespace (Cory Fields)
2016-05-18Merge #7932: CAddrMan::Deserialize handle corrupt serializations better.Wladimir J. van der Laan
fb26bf0 CAddrMan::Deserialize handle corrupt serializations better. (Patrick Strateman)
2016-05-18Merge #8031: improvement to readabilityWladimir J. van der Laan
fe80102 changing "(tests are) automatically run" to correspond to the earlier instance of "run automatically (on the build server)" (Matthew English)
2016-05-18doc: 32 and 64 bit packages are seperateWladimir J. van der Laan
2016-05-18Merge #8020: Use SipHash-2-4 for various non-cryptographic hashesWladimir J. van der Laan
a68ec21 Use SipHash-2-4 for address relay selection (Pieter Wuille) 8cc9cfe Switch CTxMempool::mapTx to use a hash index for txids (Pieter Wuille) 382c871 Use SipHash-2-4 for CCoinsCache index (Pieter Wuille) 0b1295b Add SipHash-2-4 primitives to hash (Pieter Wuille)
2016-05-17Use SipHash-2-4 for address relay selectionPieter Wuille
2016-05-17Switch CTxMempool::mapTx to use a hash index for txidsPieter Wuille
2016-05-17Use SipHash-2-4 for CCoinsCache indexPieter Wuille
This is ~1.7x slower than the Lookup3-of-Xor-with-salt construct we were using before, but it is a primitive designed for exactly this.
2016-05-17Add SipHash-2-4 primitives to hashPieter Wuille
2016-05-17Merge #7696: Fix de-serialization bug where AddrMan is left corruptedPieter Wuille
1475ecf Fix de-serialization bug where AddrMan is corrupted after exception * CAddrDB modified so that when de-serialization code throws an exception Addrman is reset to a clean state * CAddrDB modified to make unit tests possible * Regression test created to ensure bug is fixed * StartNode modifed to clear adrman if CAddrDB::Read returns an error code. (EthanHeilman)
2016-05-17Make Socks5() InterruptibleRecv() timeout/failures informative.Warren Togami
Before: 2016-05-16 06:10:45 ERROR: Error reading proxy response After: 2016-05-16 06:10:45 Socks5() connect to k7s5d6jqig4ej4v4.onion:18333 failed: InterruptibleRecv() timeout or other failure
2016-05-17Merge #8038: [qa, doc] Various minor fixesMarcoFalke
fa83a5d [qa] wallet: Temporarily disable salvagewallet test (MarcoFalke) fadd048 [doc] Link to clang-format in the developer notes (MarcoFalke) fa72f7d [doc] Remove outdated line from listunspent RPC help, fix typo (MarcoFalke) ac40ed7 Increase timeout waiting for pruned blk00000.dat (error10)
2016-05-17Merge #7994: Add op csv tests to script_tests.jsonPieter Wuille
10e83d7 Adding basic tests for OP_CSV inside of script_tests.json (Chris Stewart)
2016-05-17Report reindexing progress in GUIPieter Wuille
2016-05-17Add -reindex-chainstate that does not rebuild block indexPieter Wuille
2016-05-17Optimize ActivateBestChain for long chainsPieter Wuille
2016-05-17Switch reindexing to AcceptBlock in-loop and ActivateBestChain afterwardsPieter Wuille
2016-05-17Make ProcessNewBlock dbp const and update commentPieter Wuille
2016-05-16Merge #8059: Remove unneeded feerate param from ↵Pieter Wuille
RelayTransaction/AcceptToMemoryPool. d87b198 Remove unneeded feerate param from RelayTransaction/AcceptToMemoryPool. (Gregory Maxwell)
2016-05-16Remove unneeded feerate param from RelayTransaction/AcceptToMemoryPool.Gregory Maxwell
2016-05-15net: Avoid duplicate getheaders requests.Daniel Kraft
The current logic for syncing headers may lead to lots of duplicate getheaders requests being sent: If a new block arrives while the node is in headers sync, it will send getheaders in response to the block announcement. When the headers arrive, the message will be of maximum size and so a follow-up request will be sent---all of that in addition to the existing headers syncing. This will create a second "chain" of getheaders requests. If more blocks arrive, this may even lead to arbitrarily many parallel chains of redundant requests. This patch changes the behaviour to only request more headers after a maximum-sized message when it contained at least one unknown header. This avoids sustaining parallel chains of redundant requests. Note that this patch avoids the issues raised in the discussion of https://github.com/bitcoin/bitcoin/pull/6821: There is no risk of the node being permanently blocked. At the latest when a new block arrives this will trigger a new getheaders request and restart syncing.
2016-05-12doc: Remove outdated qt4 install information from README.mdWladimir J. van der Laan
This text is aimed at users installing the binaries. Now that Qt5 is linked statically, there is no need to install Qt as a run-time dependency.
2016-05-12Merge #8046: [Qt][OSX] Fix Cmd-Q / Menu Quit shutdown on OSXJonas Schnelli
34ebceb [Qt][OSX] Fix Cmd-Q / Menu Quit shutdown on OSX (Jonas Schnelli)
2016-05-12Merge #8006: Qt: Add option to disable the system tray iconWladimir J. van der Laan
8b0e497 Qt: Add option to hide the system tray icon (Tyler Hardin)
2016-05-12Merge #8004: signal handling: fReopenDebugLog and fRequestShutdown should be ↵Wladimir J. van der Laan
type sig_atomic_t 3262316 fReopenDebugLog and fRequestShutdown should be type sig_atomic_t (Chirag Davé)
2016-05-12Merge #8041: [qa] Fix bip9-softforks blockstore issueWladimir J. van der Laan
fad60b3 [qa] Fix bip9-softforks blockstore issue (MarcoFalke)
2016-05-12[Qt][OSX] Fix Cmd-Q / Menu Quit shutdown on OSXJonas Schnelli
2016-05-11Qt: Add option to hide the system tray iconTyler Hardin
My changes leave all tray icon and menu creation/initialization logic untouched. It only shows or hides the icon according to the setting. A new checkbox was added to the OptionsDialog under the Window tab. A bool option named "hideTrayIcon" was added to OptionsModel. This checkbox was mapped like other all options to the OptionsModel. A signal was added to the OptionsModel for broadcasting changes the the hideTrayIcon option. This signal was connected to a new slot added to BitcoinGUI named setTrayIconVisible(bool). The slot simply hides or shows the trayIcon in BitcoinGUI according to the parameter recieved.
2016-05-12Merge #8039: bench: Add crypto hash benchmarksPieter Wuille
32114dd bench: Add crypto hash benchmarks (Wladimir J. van der Laan)
2016-05-11bench: Add crypto hash benchmarksWladimir J. van der Laan
Add benchmarks for the cryptographic hash algorithms: - RIPEMD160 - SHA1 - SHA256 - SHA512 Continues work on #7883.
2016-05-11[qa] Fix bip9-softforks blockstore issueMarcoFalke
2016-05-11Adding basic tests for OP_CSV inside of script_tests.jsonChris Stewart
Changing NOP3 op name to OP_CHECKSEQUENCEVERIFY, renaming instances of OP_NOP3 in script_tests.json to CHECKSEQUENCEVERIFY Cleaning up NOP3 comment Re-adding test cases that were accidentally deleted, removing dupicated test case, fixing formatting Removing re-labeling of OP_NOP3 to OP_CSV Fixing whitespace issues
2016-05-10Merge #7972: [qa] pull-tester: Run rpc test in parallelMarcoFalke
ccccc59 [qa] Add option --portseed to test_framework (MarcoFalke) fa494de [qa] pull-tester: Run rpc test in parallel (MarcoFalke)
2016-05-10net: No need to export ConnectNodeCory Fields
2016-05-10net: No need to export DumpBanlistCory Fields
2016-05-10net: make Ban/Unban/ClearBan functionality consistentCory Fields
- Ban/Unban/ClearBan call uiInterface.BannedListChanged() as necessary - Ban/Unban/ClearBan sync to disk if the operation is user-invoked - Mark node for disconnection automatically when banning - Lock cs_vNodes while setting disconnected - Don't spin in a tight loop while setting disconnected
2016-05-10[qa] wallet: Temporarily disable salvagewallet testMarcoFalke
2016-05-10[doc] Link to clang-format in the developer notesMarcoFalke
2016-05-10[doc] Remove outdated line from listunspent RPC help, fix typoMarcoFalke
2016-05-10Increase timeout waiting for pruned blk00000.daterror10
In my ever-growing list of test failures, I was seeing this one intermittently. ``` Running 2nd level testscript pruning.py... Initializing test directory /tmp/testY5ypCv Warning! This test requires 4GB of disk space and takes over 30 mins (up to 2 hours) Mining a big blockchain of 995 blocks Check that we haven't started pruning yet because we're below PruneAfterHeight Success Though we're already using more than 550MB, current usage: 587 Mining 25 more blocks should cause the first block file to be pruned Assertion failed: blk00000.dat not pruned when it should be File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/test_framework/test_framework.py", line 118, in main self.run_test() File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 272, in run_test self.test_height_min() File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 94, in test_height_min raise AssertionError("blk00000.dat not pruned when it should be") Stopping nodes Failed ``` After digging into the test, I found that the code is waiting 10 seconds for blk00000.dat to be deleted, and then throwing this failure if it still exists after 10 seconds. I increased this amount, had the script print the actual time taken, and ran the test a few more times. The time taken ranged between 8 to 12 seconds. So, I feel that this timeout is too short. After changing the timeout to 30 seconds, the test passes consistently. (cherry picked from commit 3469911c89a48dd2fefe4d1c2a0c176256e14ee0)
2016-05-10Merge #8028: Fix insanity of CWalletDB::WriteTx and CWalletTx::WriteToDiskWladimir J. van der Laan
0fd5997 Fix insanity of CWalletDB::WriteTx and CWalletTx::WriteToDisk (Patrick Strateman)