aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-19Add deserializing constructors to CTransaction and CMutableTransactionPieter Wuille
2016-11-19Add serialization for unique_ptr and shared_ptrPieter Wuille
2016-11-19Merge #9159: [qa] Wait for specific block announcement in p2p-compactblocksMarcoFalke
dfa44d1 [qa] Wait for specific block announcement in p2p-compactblocks (Russell Yanofsky)
2016-11-19Merge #9186: test: Fix use-after-free in scheduler testsWladimir J. van der Laan
12519bf test: Fix use-after-free in scheduler tests (Wladimir J. van der Laan)
2016-11-18test: Fix use-after-free in scheduler testsWladimir J. van der Laan
Make a copy of the boost time-point to wait for, otherwise the head of the queue may be deleted by another thread while this one is waiting, while the boost function still has a reference to it. Although this problem is in non-test code, this is not an actual problem outside of the tests because we use the thread scheduler with only one service thread, so there will never be threads fighting at the head of the queue. The old boost fallback escapes this problem because it passes a scalar value to wait_until instead of a const object reference. Found by running the tests in LLVM-4.0-master asan.
2016-11-17Merge #9075: Decouple peer-processing-logic from block-connection-logic (#3)Pieter Wuille
ae22357 Replace CValidationState param in ProcessNewBlock with BlockChecked (Matt Corallo) 7c98ce5 Remove pfrom parameter from ProcessNewBlock (Matt Corallo) e2e069d Revert "RPC: Give more details when "generate" fails" (Matt Corallo)
2016-11-17Merge #9156: Add compile and link options echo to configureWladimir J. van der Laan
d8274bc Add compile and link options echo to configure (Jonas Schnelli)
2016-11-17Merge #9178: Doxygen: Set PROJECT_NAME = "Bitcoin Core"Wladimir J. van der Laan
fa63ee8 Doxygen: Set PROJECT_NAME = "Bitcoin Core" (MarcoFalke)
2016-11-17Doxygen: Set PROJECT_NAME = "Bitcoin Core"MarcoFalke
2016-11-17Merge #8838: Calculate size and weight of block correctly in CreateNewBlock()Wladimir J. van der Laan
5f274a1 log block size and weight correctly. (jnewbery)
2016-11-16Add compile and link options echo to configureJonas Schnelli
2016-11-16Merge #9155: [trivial] update comments for tx weightMarcoFalke
07ede5d update comments for tx weight (Brian Deery)
2016-11-16Merge #9168: [qa] add assert_raises_message to check specific error messageMarcoFalke
307acdd [qa] add assert_raises_message to check specific error message (mrbandrews)
2016-11-16Merge #9133: Unset fImporting for loading mempoolWladimir J. van der Laan
79f755d Unset fImporting for loading mempool (Alex Morcos)
2016-11-16Merge #9131: fNetworkActive is not protected by a lock, use an atomicWladimir J. van der Laan
079142b fNetworkActive is not protected by a lock, use an atomic (Jonas Schnelli)
2016-11-16Merge #9151: [qa] proxy_test: Calculate hardcoded port numbersWladimir J. van der Laan
fa80ef8 [qa] proxy_test: Calculate hardcoded port numbers instead (MarcoFalke)
2016-11-16Merge #9169: build: fix qt5.7 build under macOSWladimir J. van der Laan
70266e9 build: fix qt5.7 build under macOS (Cory Fields)
2016-11-15build: fix qt5.7 build under macOSCory Fields
OBJCXX's std flags don't get defined by our cxx macro. Rather than hard-coding to c++11, just force OBJCXX to be the same as CXX unless the user specified otherwise.
2016-11-15[qa] add assert_raises_message to check specific error messagemrbandrews
2016-11-15Merge #9164: [trivial] credit values are CAmountPieter Wuille
20c3215 credit values are CAmount (Gregory Sanders)
2016-11-15credit values are CAmountGregory Sanders
2016-11-15Merge #9140: Bugfix: Correctly replace generated headers and fail cleanlyWladimir J. van der Laan
b74ff5c Bugfix: Correctly replace generated headers and fail cleanly (Luke Dashjr)
2016-11-15Merge #9132: Make strWalletFile constWladimir J. van der Laan
f734505 Make strWalletFile const (Jonas Schnelli)
2016-11-15Merge #9160: [trivial] Fix hungarian variable nameWladimir J. van der Laan
ec34648 [trivial] Fix hungarian variable name (Russell Yanofsky)
2016-11-14Merge #9136: sync_blocks cleanupMarcoFalke
7943b13 [qa] Avoid 2 list comprehensions in sync_blocks (Russell Yanofsky) 05e57cc [qa] Fix sync_blocks timeout argument (Russell Yanofsky) fd6bb70 [qa] Improve sync_blocks error messages. (Russell Yanofsky)
2016-11-14[trivial] Fix hungarian variable nameRussell Yanofsky
Follow up to comment https://github.com/bitcoin/bitcoin/pull/9058#discussion_r87676593
2016-11-14[qa] Wait for specific block announcement in p2p-compactblocksRussell Yanofsky
Change check_announcement_of_new_block() to wait specifically for the announcement of the newly created block, instead of waiting for any announcement at all. A difficult to reproduce failure in check_announcement_of_new_block() that happened in a travis build (https://travis-ci.org/bitcoin/bitcoin/jobs/175198367) might have happened because an older announcement was mistaken for the expected one. The error looked like: Assertion failed: Failed File ".../bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 145, in main self.run_test() File ".../bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 787, in run_test self.test_sendcmpct(self.nodes[1], self.segwit_node, 2, old_node=self.old_node) File ".../bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 201, in test_sendcmpct check_announcement_of_new_block(node, test_node, lambda p: p.last_cmpctblock is None and p.last_inv is not None) File ".../bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 194, in check_announcement_of_new_block assert(predicate(peer)) This commit also changes the assertion failed message above to include more detailed information for debug.
2016-11-14[qa] Avoid 2 list comprehensions in sync_blocksRussell Yanofsky
2016-11-14[qa] Fix sync_blocks timeout argumentRussell Yanofsky
Motivation for this change is mainly to make sync_blocks behavior easier to understand. Behavior is unchanged in the normal case when there are only 2 nodes in the rpc_connections set. When there are more than 2 nodes, the previous "timeout -= wait" statement wouldn't take into account time spent waiting for all nodes and as a result could lead to blocking for longer than the requested timeout.
2016-11-14[qa] Improve sync_blocks error messages.Russell Yanofsky
2016-11-14Merge #9145: [qt] Make network disabled icon 50% opaqueJonas Schnelli
fa42e4a [qt] Make network disabled icon 50% opaque (MarcoFalke)
2016-11-14update comments for tx weightBrian Deery
2016-11-13[qa] proxy_test: Calculate hardcoded port numbers insteadMarcoFalke
2016-11-13[qt] Make network disabled icon 50% opaqueMarcoFalke
2016-11-12Bugfix: Correctly replace generated headers and fail cleanlyLuke Dashjr
Also removes generation of headers for *.raw files in test_bitcoin (none exist anymore)
2016-11-11Unset fImporting for loading mempoolAlex Morcos
2016-11-11Make strWalletFile constJonas Schnelli
2016-11-11fNetworkActive is not protected by a lock, use an atomicJonas Schnelli
2016-11-11Merge #9124: Use better name for local variable to prevent -Wshadow compiler ↵Wladimir J. van der Laan
warning bf49f10 Use better name for local variable to prevent -Wshadow compiler warning (Pavel Janík)
2016-11-11Merge #9115: Mention reporting security issues responsiblyWladimir J. van der Laan
7d1de30 Mention reporting security issues responsibly (Pavel Janík)
2016-11-11Merge #8996: Network activity toggleJonas Schnelli
19f46f1 Qt: New network_disabled icon (Luke Dashjr) 54cf997 RPC/Net: Use boolean consistently for networkactive, and remove from getinfo (Luke Dashjr) b2b33d9 Overhaul network activity toggle (Jonas Schnelli) 32efa79 Qt: Add GUI feedback and control of network activity state. (Jon Lund Steffensen) e38993b RPC: Add "togglenetwork" method to toggle network activity temporarily (Jon Lund Steffensen) 7c9a98a Allow network activity to be temporarily suspended. (Jon Lund Steffensen)
2016-11-11Merge #9058: Fixes for p2p-compactblocks.py test timeouts on travis (#8842)Wladimir J. van der Laan
dac53b5 Modify getblocktxn handler not to drop requests for old blocks (Russell Yanofsky) 55bfddc [qa] Fix stale data bug in test_compactblocks_not_at_tip (Russell Yanofsky) 47e9659 [qa] Fix bug in compactblocks v2 merge (Russell Yanofsky)
2016-11-11Merge #9112: Avoid ugly exception in log on unknown inv typeWladimir J. van der Laan
e9f25dd Avoid ugly exception in log on unknown inv type (Wladimir J. van der Laan)
2016-11-11Merge #9114: [depends] Set OSX_MIN_VERSION to 10.8Wladimir J. van der Laan
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
2016-11-10Use better name for local variable to prevent -Wshadow compiler warningPavel Janík
2016-11-10Merge #9049: Remove duplicatable duplicate-input check from CheckTransactionWladimir J. van der Laan
e2b3fb3 Optimize vInOutPoints insertion a bit (Matt Corallo) eecffe5 Remove redundant duplicate-input check from CheckTransaction (Matt Corallo) b2e178a Add deserialize + CheckBlock benchmarks, and a full block hex (Matt Corallo)
2016-11-10Mention reporting security issues responsiblyPavel Janík
2016-11-10Merge #9097: [qa] Rework sync_* and preciousblock.pyMarcoFalke
fa97ccb [qa] util: Rework sync_*() (MarcoFalke) fac1141 [qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
2016-11-10Merge #9122: fix getnettotals RPC description about timemillis.MarcoFalke
a79f864 fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
2016-11-10Merge #9121: Initialize variable to prevent compiler warningWladimir J. van der Laan
bdcba6d Initialize variable to prevent compiler warning (Pavel Janík)