aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-05-28doc: Bump to Ubuntu Bionic 18.04 in build-windows.mdChun Kuan Lee
Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store. GitHub-Pull: #13246 Rebased-From: 9d4f942
2018-05-28build: Bump version to 0.16.1Wladimir J. van der Laan
Tree-SHA512: 3408031113febc1d9ac3734a355c832813046eb1f2eaa7f29ff0c7b330026ac1fc664ae9ea773370c9abeca0a50f0ec1bb50a6f5940f86df335f822c1f0b1a73
2018-05-28qt: Pre-rc1 transifex pullWladimir J. van der Laan
Tree-SHA512: 91372301f876e3813ebac68d466941ba488b8c74f7525ea9686945d50c2b2e29290c84722c96eebed40a246eca343981feaf2f51b836ba2b3923e4ddc15aef30
2018-05-28Merge #13319: [0.16.1] gui: Backport bech32 checkboxWladimir J. van der Laan
dcb13a0ab687b23465a046e35ca75a432427b833 qt: Update translations pre-rc1 (MarcoFalke) 0eda98d01b6fef1309cdaf8365b752fed39d39a5 GUI: Allow generating Bech32 addresses with a legacy-address default (Luke Dashjr) ea487f9f905b5971e686458b4687157c001b1119 GUI: Rephrase Bech32 checkbox text/tooltip (Luke Dashjr) Pull request description: Tree-SHA512: 1298fa92579bcbdc80537a3a5b2f8aae460c7ebcb46fbade4305d45c883e1717587e24711792b5f65fd25b7a5999d7b9c82e63f5b4d18240f9ec4a0041efdb9a
2018-05-28Merge #13317: [0.16.1] Remaining backportsWladimir J. van der Laan
08334b73be031485a41e2c0647c2df1aa13c6316 qa: Pad scriptPubKeys to get minimum sized txs (MarcoFalke) 0a000b9b73a7d7bb4086aeefc86841d0fc33e652 Policy to reject extremely small transactions (Johnson Lau) 1fffc2b346b2d2e129db5c9f5cad00e820c85c45 Add transaction tests for constant scriptCode (Johnson Lau) d353dd121be0bf2a525e4bbea2b4ada2954d2b15 Add constant scriptCode policy in non-segwit scripts (Johnson Lau) d6c3a08c482225b3742c9145a9cbfe60567f0c4f Add unit tests for signals generated by ProcessNewBlock() (Jesse Cohen) bb79aaf93af93d5f9f5097cff4fbb2791af86875 Fix concurrency-related bugs in ActivateBestChain (Jesse Cohen) 0948153ea62ff4921daef326da0fddb8425cd866 Do not unlock cs_main in ABC unless we've actually made progress. (Matt Corallo) c71e535aec5aaef04764238a94e456f2405adbb5 Bugfix: ensure consistency of m_failed_blocks after reconsiderblock (Suhas Daftuar) Pull request description: Tree-SHA512: 7466b8fcc2a1d598102028019d82c581fe985a11679d002c430287851142598c9172249aa9de511a26bd4c92dc4891b5ab597c24af4f591f2158cc2a58ff7beb
2018-05-24qt: Update translations pre-rc1MarcoFalke
2018-05-24GUI: Allow generating Bech32 addresses with a legacy-address defaultLuke Dashjr
Github-Pull: #13251 Rebased-From: 82dda6bed971c5638962442b4927845fe5eb6600
2018-05-24GUI: Rephrase Bech32 checkbox text/tooltipLuke Dashjr
- "Bech32" isn't very user-friendly - You don't spend from addresses Github-Pull: #13251 Rebased-From: 7ab1c6f6a736fc7762b8dd513d8634754319d227
2018-05-24qa: Pad scriptPubKeys to get minimum sized txsMarcoFalke
Github-Pull: #11423 Rebased-From: 364bae5f7a6b16eef63990154e48f19e7e693039
2018-05-24Policy to reject extremely small transactionsJohnson Lau
A transaction with 1 segwit input and 1 P2WPHK output has non-witness size of 82 bytes. Anything smaller than this have unnecessary malloc overhead and are not relayed/mined. Github-Pull: #11423 Rebased-From: 7485488e907e236133a016ba7064c89bf9ab6da3
2018-05-24Add transaction tests for constant scriptCodeJohnson Lau
Tests showing that CONST_SCRIPTCODE is applied only to non-segwit transactions Github-Pull: #11423 Rebased-From: 0f8719bb035187076eeac025e2c786feb0f452d7
2018-05-24Add constant scriptCode policy in non-segwit scriptsJohnson Lau
This disables OP_CODESEPARATOR in non-segwit scripts (even in an unexecuted branch), and makes a positive FindAndDelete result invalid. This ensures that the scriptCode serialized in SignatureHash() is always the same as the script passing to the EvalScript. Github-Pull: #11423 Rebased-From: 9dabfe49c066301ef75bcfcb089fd308366127c4
2018-05-24Add unit tests for signals generated by ProcessNewBlock()Jesse Cohen
After a recent bug discovered in callback ordering in MainSignals, this test checks invariants in ordering of BlockConnected / BlockDisconnected / UpdatedChainTip signals Github-Pull: #13023 Rebased-From: dd435ad40267f5c50ff17533c696f9302829a6a6
2018-05-24Fix concurrency-related bugs in ActivateBestChainJesse Cohen
If multiple threads are invoking ActivateBestChain, it was possible to have them working towards different tips, and we could arrive at a less work tip than we should. Fix this by introducing a ChainState lock which must be held for the entire duration of ActivateBestChain to enforce exclusion in ABC. Github-Pull: #13023 Rebased-From: a3ae8e68739023e5dba9e5cb190e707ed4603316
2018-05-24Do not unlock cs_main in ABC unless we've actually made progress.Matt Corallo
Technically, some internal datastructures may be in an inconsistent state if we do this, though there are no known bugs there. Still, for future safety, its much better to only unlock cs_main if we've made progress (not just tried a reorg which may make progress). Github-Pull: #13023 Rebased-From: ecc3c4a019e6db30e208b8554b1a3658dcb9a80a
2018-05-24Bugfix: ensure consistency of m_failed_blocks after reconsiderblockSuhas Daftuar
Github-Pull: #13199 Rebased-From: 11fa6bb66e8c1562305d034903a0dc6aee6eea20
2018-05-24Merge #13253: [0.16] Further BackportsWladimir J. van der Laan
acdf4338221e35d5ec7b299bb18ccd953e28c985 Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip (Jesse Cohen) 5ff571e90c9fa71e189863e9cb21d15d5991f7da [wallet] [tests] Test disallowed multiwallet params (John Newbery) 4c14e7b67cd411b501e4a77385389da0afc9dd16 [wallet] Fix zapwallettxes/multiwallet interaction. (John Newbery) 4087dd08e7df5beedc335f4518b64eeab6a382c1 RPC Docs: gettxout*: clarify bestblock and unspent counts (David A. Harding) b8aacd660eb9460b6a86d4402d886f0bb32af2b4 [qa] Handle disconnect_node race (Suhas Daftuar) Pull request description: Backports: - #13201 [qa] Handle disconnect_node race - #13184 RPC Docs: gettxout*: clarify bestblock and unspent counts - #13030 [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. - #12988 Hold cs_main while calling UpdatedBlockTip() signal to the 0.16 branch. Tree-SHA512: 8f65002bbafaf9c436f89051b2d79bf6a668fbd07bd317c64af238ed4a7c8efe776864b739a7f2869f1e3daa16f2f4366a85f41b188f9c454879d2c7b309be50
2018-05-18wallet: Exit SyncMetaData if there are no transactions to syncWladimir J. van der Laan
Instead of crash with an assertion error, simply exit the function `SyncMetaData` if there is no metadata to sync. Fixes #13110. Github-Pull: #13265 Rebased-From: b0d2ca9fb66d793e3c0f2e6ede811f1b16c33a9f Tree-SHA512: 67e446e9ced901e37003a9661b6abea268e2ea648ac3b076d91c8d996de96bed389839a09d579a6562d930bcf501a091eb67454f474aae1174108a8650502072
2018-05-18Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTipJesse Cohen
Ensures that callbacks are invoked in the order in which the chain is updated Resolves #12978 GitHub-Pull: #12988 Rebased-From: d86edd3
2018-05-18[wallet] [tests] Test disallowed multiwallet paramsJohn Newbery
Add a test to check that bitcoind fails to start when specifying -zapwallettxes, -salvagewallet and -upgradewallet when running in multiwallet mode. GitHub-Pull: #13030 Rebased-From: 1f83839
2018-05-17[wallet] Fix zapwallettxes/multiwallet interaction.John Newbery
-zapwallettxes should be disallowed when starting bitcoin in multiwallet mode. GitHub-Pull: #13030 Rebased-From: 3476e3c
2018-05-17RPC Docs: gettxout*: clarify bestblock and unspent countsDavid A. Harding
GitHub-Pull: #13184 Rebased-From: f30e9be
2018-05-17[qa] Handle disconnect_node raceSuhas Daftuar
Several tests call disconnect_nodes() on each node-pair in rapid succession, resulting in a race condition if a node disconnects a peer in-between the calculation of the nodeid's to disconnect and the invocation of the disconnectnode rpc call. Handle this. GitHub-Pull: #13201 Rebased-From: 09c6699
2018-05-16Merge #12967: [0.16] BackportsWladimir J. van der Laan
8fca086 List support for BIP173 in bips.md (Pieter Wuille) 9645aa6 Remove blockmaxsize option from init.cpp (fanquake) 7847b92 Default to defining endian-conversion DECLs in compat w/o config (Matt Corallo) 1720eb3 qt:Show the entire Window when double clicking on taskbar (Chun Kuan Lee) e055bc0 depends: Fix Qt build with XCode 9.3 (fanquake) 0684cf9 Avoid launching as admin when NSIS installer ends. (JeremyRand) e802c22 [config] Remove blockmaxsize option (John Newbery) f118a7a Fix illegal default `addProxy` and `addrSeparateProxyTor` settings. (251) f60e84d Limit the number of IPs we use from each DNS seeder (e0) Pull request description: Backports: - #12626 Limit the number of IPs addrman learns from each DNS seeder - #12650 gui: Fix issue: "default port not shown correctly in settings dialog" - #12756 [config] Remove blockmaxsize option - #12985 Windows: Avoid launching as admin when NSIS installer ends. - #12946 depends: Fix Qt build with XCode 9.3 - #12998 Default to defining endian-conversion DECLs in compat w/o config - #12999 qt: Show the Window when double clicking the taskbar icon - #13064 List support for BIP173 in bips.md to the 0.16 branch. Tree-SHA512: 3e6b47c54b2cd2bdd81fbc6176cb31e46423f6e05988984d3a09b3535e3cee101ffb071cf753a4beff3c9f0521eb5de4b7c0424a3e97da801d56b4015847ac0f
2018-05-03List support for BIP173 in bips.mdPieter Wuille
2018-05-01Remove blockmaxsize option from init.cppfanquake
2018-04-26Default to defining endian-conversion DECLs in compat w/o configMatt Corallo
While this isn't a supported build configuration, some build systems need to build without going through our autotools steps, so defaulting to something sane may make it easier to build. Specifically, this fixes the inability to build rust-bitcoinconsensus on some non-x86 platforms. It needs to build without our autotools/configure steps to ensure correct compile args are passed from the rust build system to gcc. Converting the args from the rust build system to gcc would be a lot of unmaintainable work. GitHub-Pull: #12998 Rebased-From: 150b2f0
2018-04-26qt:Show the entire Window when double clicking on taskbarChun Kuan Lee
GitHub-Pull: #12999 Rebased-From: 67bf2aa
2018-04-26depends: Fix Qt build with XCode 9.3fanquake
GitHub-Pull: #12946 Rebased-From: 5b4fc3e
2018-04-26Avoid launching as admin when NSIS installer ends.JeremyRand
The Bitcoin Core NSIS script runs with elevated privileges. Unfortunately, this means that it launches Bitcoin Core itself with elevated privileges when the user chooses to launch Bitcoin Core at the end of the installation procedure. This commit works around the issue by having explorer.exe launch Bitcoin Core. Seems to be a similar approach to what http://nsis.sourceforge.net/ShellExecAsUser_plug-in does, but without a plugin. h/t to "UK" at https://mdb-blog.blogspot.se/2013/01/nsis-lunch-program-as-user-from-uac.html?showComment=1410158039989#c2463780017054126736 for the sample code. Fixes #7990. GitHub-Pull: #12985 Rebased-From: 7d8a8cc
2018-04-26[config] Remove blockmaxsize optionJohn Newbery
The blockmaxsize option was marked as deprecated in V0.15.1, and code was added to convert provided blockmaxsize into blockmaxweight. However, this code was incorrectly implemented, and blockmaxsize was silently ignored. No users have complained about blockmaxsize being ignored, so just remove it in V0.17. GitHub-Pull: #12756 Rebased-From: 4757c04
2018-04-26Fix illegal default `addProxy` and `addrSeparateProxyTor` settings.251
GitHub-Pull: #12650 Rebased-From: 40c5886
2018-04-26Limit the number of IPs we use from each DNS seedere0
A risk exists where a malicious DNS seeder eclipses a node by returning an enormous number of IP addresses. In this commit we mitigate this risk by limiting the number of IP addresses addrman learns to 256 per DNS seeder. GitHub-Pull: #12626 Rebased-From: 46e7f80
2018-04-24Merge #13049: [0.16] qa: BackportsMarcoFalke
41c29f6d1d qa: Fix python TypeError in script.py (MarcoFalke) 7460945e0b [qa] Delete cookie file before starting node (Suhas Daftuar) 0a76ed232a qa: Cache only chain and wallet for regtest datadir (MarcoFalke) 6c26df06ad [qa] Ensure bitcoind processes are cleaned up when tests end (Suhas Daftuar) df38b130d9 [tests] Test starting bitcoind with -h and -version (John Newbery) 4bdb0ce517 [tests] Fix intermittent rpc_net.py failure. (John Newbery) 0e98f96e42 test: Use wait_until in tests where time was used for polling (Ben Woosley) 1286f3e49a test: Use wait_until to ensure ping goes out (Ben Woosley) cfebd400ef [test] Round target fee to 8 decimals in assert_fee_amount (Karl-Johan Alm) Pull request description: Similar to #12967 this contains all relevant bugfixes and improvements to the functional test suite. I didn't include fixes to make the tests run on Windows, since that is still an ongoing effort and doesn't seem worth to backport. As all of these are clean cherry-picks, I suggest reviewers redo the cherry-picks to get the same branch and then run the extended test suite. Tree-SHA512: 70e1bc28d5572f93796f1ac4d97d77e8146869c15dcc1e3b65a730fa2641283050f769cefd9791d800c758e0a92f11fd55ed0797ccec87b897c7e701d0187f34
2018-04-20qa: Fix python TypeError in script.pyMarcoFalke
Github-Pull: #12475 Rebased-From: fa41d68a2e3f2148c3539a11b61ff835e3141c0d
2018-04-20[qa] Delete cookie file before starting nodeSuhas Daftuar
If a cookie file exists in a datadir prior to node startup, it must have been leftover from a prior unclean shutdown. As bitcoind will overwrite it anyway, delete it before starting up to prevent the test framework from inadvertently trying to connect using stale credentials. Github-Pull: #12902 Rebased-From: 75d0e4c5444249f0cf81ed0494e2c2717170b695
2018-04-20qa: Cache only chain and wallet for regtest datadirMarcoFalke
Github-Pull: #12638 Rebased-From: fa2310572f4cfcd3322409ce7e37dde155fc4bc9
2018-04-20[qa] Ensure bitcoind processes are cleaned up when tests endSuhas Daftuar
Github-Pull: #12904 Rebased-From: e36a0c08529bccc695ec71a7ec1df89367cc1628
2018-04-20[tests] Test starting bitcoind with -h and -versionJohn Newbery
Github-Pull: #12843 Rebased-From: 63048ec73d790ecbcfe3186f2520dac4460f56e3
2018-04-20[tests] Fix intermittent rpc_net.py failure.John Newbery
rpc_net.py would intermittently fail on Travis, probably due to assuming that two consecutive RPC calls were atomic. Fix this by only testing that amounts are bounded above and below rather than equal. Github-Pull: #12804 Rebased-From: 5a67c0524e5dc98d0e387f189545bc99863916d4
2018-04-20test: Use wait_until in tests where time was used for pollingBen Woosley
Github-Pull: #12553 Rebased-From: 81b0822772169cb697b5994f49398e619d61a12d
2018-04-20test: Use wait_until to ensure ping goes outBen Woosley
Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180 Github-Pull: #12545 Rebased-From: 0eb84f30d80847b7392ad42b2d916eaf5923a63c
2018-04-20[test] Round target fee to 8 decimals in assert_fee_amountKarl-Johan Alm
The output would produce arbitrary number of decimal points, sometimes resulting in 9 decimals: AssertionError: Fee of 0.00000415 BTC too low! (Should be 0.000006175 BTC) The above looks like the expected fee is 6175 sats when in reality it's 618. Github-Pull: #12486 Rebased-From: 42e1b5d9797b65d3ce13a7cbace15fbedbcd4018
2018-03-14Merge #12636: backport: #11995 Fix Qt build with Xcode 9Wladimir J. van der Laan
f3b8d85 devtools: Exclude patches from lint-whitespace GitHub-Pull: #12442 Rebased-From: fafbf7f (MarcoFalke) 686cb86 [Depends] Fix Qt build with Xcode 9.2 (fanquake) Pull request description: GitHub-Pull: #11995 Rebased-From: 2b1f794 Tree-SHA512: 73d1c0a87fd135f3ad8bb737b97037ef047e582c41a7473833e82776957caf372fcd0caa764fc4eed792e9998e214ae829bad5535db6d589827085a74b0fa6f4
2018-03-14devtools: Exclude patches from lint-whitespaceMarcoFalke
GitHub-Pull: #12442 Rebased-From: fafbf7f
2018-03-13Merge #12648: [0.16] test: Update trusted git rootWladimir J. van der Laan
faf316a43 test: Update trust git root (Wladimir J. van der Laan) Pull request description: Marco Falke's old key expired, causing a travis error while verifying commits 36afd4db4442c45d4078b1a7ad16a1872b5bee0d and before: gpg: Good signature from "Marco Falke <marco.falke@tum.de>" [unknown] gpg: aka "Marco Falke <falke.marco@gmail.com>" [unknown] gpg: Note: This key has expired! Primary key fingerprint: B8B3 F1C0 E58C 15DB 6A81 D30C 3648 A882 F431 6B9B Subkey fingerprint: FE09 B823 E6D8 3A3B C798 3EAA 2D7F 2372 E50F E137 Update the trusted root commit to the commit after that, to fix this issue. (cherry picked from commit 7deba93bdc76616011a9f493cbc203d60084416f) Tree-SHA512: c86cc23d087af54a1448545c122fc67a0c556b5eac8ac7d16eeec8c42d8d0d81b7b5041f9a175787604aa47883b68403cfa01c10a52db64e35be52e559b20ec8
2018-03-12[Depends] Fix Qt build with Xcode 9.2fanquake
GitHub-Pull: #11995 Rebased-From: 2b1f794
2018-03-08test: Update trust git rootWladimir J. van der Laan
Marco Falke's old key expired, causing a travis error while verifying commits 36afd4db4442c45d4078b1a7ad16a1872b5bee0d and before: gpg: Good signature from "Marco Falke <marco.falke@tum.de>" [unknown] gpg: aka "Marco Falke <falke.marco@gmail.com>" [unknown] gpg: Note: This key has expired! Primary key fingerprint: B8B3 F1C0 E58C 15DB 6A81 D30C 3648 A882 F431 6B9B Subkey fingerprint: FE09 B823 E6D8 3A3B C798 3EAA 2D7F 2372 E50F E137 Update the trusted root commit to the commit after that, to fix this issue. (cherry picked from commit 7deba93bdc76616011a9f493cbc203d60084416f)
2018-03-07Merge #12637: backport: #12556 fix version typo in getpeerinfo RPC call helpMarcoFalke
e730b82b07 fix version typo (Tamas Blummer) Pull request description: GitHub-Pull: #12556 Rebased-From: d16bfaa Tree-SHA512: b6626fabdd5f493016334ada0182565c7f834a22dc08dc846c71a190e61193dd4e28754e67b20086d9afeab9a58e38c3621c614eadf368b2d35b9c08a843356a
2018-03-07fix version typoTamas Blummer
GitHub-Pull: #12556 Rebased-From: d16bfaa