aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-13Fix csBestBlock/cvBlockChange waiting in rpc/miningPieter Wuille
Github-Pull: #12743 Rebased-From: 45dd13503918e75a45ce33eb5c934b998790fdc8
2018-07-13Consensus: Fix bug when compiler do not support __builtin_clz*532479301
#ifdef is not correct since defination is defined to 0 or 1. Should change to #if Github-Pull: #12573 Rebased-From: 18307849b405f9e2067eaa8091b105838f413707
2018-07-13[qa] Add a test for merkle proof malleationSuhas Daftuar
Github-Pull: #13452 Rebased-From: d280617bf569f84457eaea546541dc74c67cd1e4
2018-07-13have verifytxoutproof check the number of txns in proof structureGregory Sanders
Github-Pull: #13452 Rebased-From: ed82f1700006830b6fe34572b66245c1487ccd29
2018-07-13wallet: Erase wtxOrderd wtx pointer on removeprunedfundsMarcoFalke
Github-Pull: #13437 Rebased-From: faa18ca046e9043b2cf68cb1bd17cc8c60fe26d9
2018-07-13Remove boost dependency (boost/assign/std/vector.hpp)practicalswift
Github-Pull: #13545 Rebased-From: 962d8eed5bdbe62b9926f01cb85bdce9d435d3d6
2018-07-13Fix incorrect testspracticalswift
Github-Pull: #13545 Rebased-From: c6fd0df4efcd9f75c43ff527fd57fe43bc47a474
2018-07-12Make tests pass after 2020Bernhard M. Wiedemann
also test that 64 bit integers are properly handled Github-Pull: #13061 Rebased-From: 3ee4be10500710fc8e9b03acf974fd81224c05c4
2018-07-12[rpcwallet] Clamp walletpassphrase value at 100M secondsSuhas Daftuar
Larger values seem to trigger a bug on macos+libevent (resulting in the rpc server stopping). Github-Pull: #12905 Rebased-From: 662d19ff7217d0e6c7975ca311933f640955a53e
2018-07-12rpc: fix type mistmatch in listreceivedbyaddressjoemphilips
Github-Pull: #12837 Rebased-From: 05c03d1249c6fe30dbfcea9f3f3a3bd02106035b
2018-07-12[trivial] Add newlines to end of log messages.John Newbery
Log messages should terminate with a '\n', or the following log will be written to the same line without a timestamp. Fix a couple of cases where the message is not terminated with a \n. Github-Pull: #12887 Rebased-From: 5b10ab0116245ee73b493e2248ad2f8bb8e34f21
2018-07-12qt: Avoid resetting on resetguisettigs=0MarcoFalke
Github-Pull: #12793 Rebased-From: 342fb8034640d4393771899dc132c9e3b170b369
2018-07-12qa: Fix wallet_listreceivedby raceMarcoFalke
Github-Pull: #13304 Rebased-From: fa865efa4a21ae08be8b4c390b7661182e0b415b
2018-07-12[tests] Fixed intermittent failure in p2p_sendheaders.py.lmanners
Added handling for the case where headers are announced over more than one message. refs #12453 Github-Pull: #13192 Rebased-From: 12d1b77f7eb2ca274890d9fb45d6c19a40ba8f74
2018-07-12Remove useless mapRequest tracking that just effects Qt display.Matt Corallo
I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Github-Pull: #13622 Rebased-From: beef7ec4be725beea870a2da510d2817487601ec
2018-07-09Merge #13455: [0.16.2] BackportsWladimir J. van der Laan
9fd3e0001fc20eecbfa823e12f66da4054a072a7 depends: Update Qt download url (fanquake) f7401c86b9c9c58cfe57c2a49d3b4e00f80ded4a Fix parameter count check for importpubkey. (Kristaps Kaupe) cbd2f70b75016bbadeb212c823b5c1ece95d5241 expose CBlockIndex::nTx in getblock(header) (Gregory Sanders) ce8aa5491f35c2cca03ba1877cd4c926b506a961 Add Windows shutdown handler (Chun Kuan Lee) 18b0c69e2fc9f9d5cd56659abab467c2c6826be2 Bugfix: Include <memory> for std::unique_ptr (Luke Dashjr) Pull request description: Backports: * #12859 Bugfix: Include <memory> for std::unique_ptr * #13131 Add Windows shutdown handler * #13451 rpc: expose CBlockIndex::nTx in getblock(header) * #13507 RPC: Fix parameter count check for importpubkey * #13544 depends: Update Qt download url to the 0.16 branch. Tree-SHA512: eeaec52d001d5c81e67dda3a2d3fee7a9445e569366e597b18e81d802c1b7f89e545afd53d094740c37c1714050304979398b9860144454d3a5cb5abc9e9eaca
2018-06-30depends: Update Qt download urlfanquake
GitHub-Pull: #13544 Rebased-From: 2fca656
2018-06-26Fix parameter count check for importpubkey.Kristaps Kaupe
Github-Pull: #13507 Rebased-From: 3f72d04
2018-06-15expose CBlockIndex::nTx in getblock(header)Gregory Sanders
GitHub-Pull: #13451 Rebased-From: 86edf4a
2018-06-13doc: Last-minute edits to 0.16.1 release notesv0.16.1Wladimir J. van der Laan
Tree-SHA512: 951cdf2b27ddb702906303d1bc07bac204323baf0ac4513ccb5da44cb2cb29ce74a62c75fe6531cfddc9059130890fe11929ea4ac545a17190d57e5163c7cc06
2018-06-13Add Windows shutdown handlerChun Kuan Lee
GitHub-Pull: #13131 Rebased-From: ddebde7
2018-06-13Bugfix: Include <memory> for std::unique_ptrLuke Dashjr
GitHub-Pull: #12859 Rebased-From: a5bca13
2018-06-01qt: Periodic translations updatev0.16.1rc2Wladimir J. van der Laan
Tree-SHA512: eb84c69adcf1547f6bfcfd2d54ef7201c7147c26aa95e07a67be9ac12eeb31b173c847bd5f27b973c911c287ef3654413bdb201d70e4b9414f784e2d58a0071a
2018-05-30doc: Add commits and authors to release notes for rc1Wladimir J. van der Laan
Tree-SHA512: e6779d21616eec04168b5726d1fe8a1b8356c3de7f5bad30a94848a0db7c0f84fcc0d6f965424b4f7a2a9a8daba1a11fc53b148b918230b39d8095fa215be6f4
2018-05-28Merge #13336: [0.16.1] doc: Bump to Ubuntu Bionic 18.04 in build-windows.mdv0.16.1rc1Wladimir J. van der Laan
6de754306e81dd37a887c4940f2bce0e99c3fc62 doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (Chun Kuan Lee) Pull request description: Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store. GitHub-Pull: #13246 Rebased-From: 9d4f942 Tree-SHA512: f72b97637fcedee4b21316ecafd43c5889111fedbc6522f805df40241558fdfe7579ad4b6bce1940890b3bc352fd64d428f13fb40e97f913031e7eccdc0f7ddf
2018-05-28doc: Bump to Ubuntu Bionic 18.04 in build-windows.mdChun Kuan Lee
Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store. GitHub-Pull: #13246 Rebased-From: 9d4f942
2018-05-28build: Bump version to 0.16.1Wladimir J. van der Laan
Tree-SHA512: 3408031113febc1d9ac3734a355c832813046eb1f2eaa7f29ff0c7b330026ac1fc664ae9ea773370c9abeca0a50f0ec1bb50a6f5940f86df335f822c1f0b1a73
2018-05-28qt: Pre-rc1 transifex pullWladimir J. van der Laan
Tree-SHA512: 91372301f876e3813ebac68d466941ba488b8c74f7525ea9686945d50c2b2e29290c84722c96eebed40a246eca343981feaf2f51b836ba2b3923e4ddc15aef30
2018-05-28Merge #13319: [0.16.1] gui: Backport bech32 checkboxWladimir J. van der Laan
dcb13a0ab687b23465a046e35ca75a432427b833 qt: Update translations pre-rc1 (MarcoFalke) 0eda98d01b6fef1309cdaf8365b752fed39d39a5 GUI: Allow generating Bech32 addresses with a legacy-address default (Luke Dashjr) ea487f9f905b5971e686458b4687157c001b1119 GUI: Rephrase Bech32 checkbox text/tooltip (Luke Dashjr) Pull request description: Tree-SHA512: 1298fa92579bcbdc80537a3a5b2f8aae460c7ebcb46fbade4305d45c883e1717587e24711792b5f65fd25b7a5999d7b9c82e63f5b4d18240f9ec4a0041efdb9a
2018-05-28Merge #13317: [0.16.1] Remaining backportsWladimir J. van der Laan
08334b73be031485a41e2c0647c2df1aa13c6316 qa: Pad scriptPubKeys to get minimum sized txs (MarcoFalke) 0a000b9b73a7d7bb4086aeefc86841d0fc33e652 Policy to reject extremely small transactions (Johnson Lau) 1fffc2b346b2d2e129db5c9f5cad00e820c85c45 Add transaction tests for constant scriptCode (Johnson Lau) d353dd121be0bf2a525e4bbea2b4ada2954d2b15 Add constant scriptCode policy in non-segwit scripts (Johnson Lau) d6c3a08c482225b3742c9145a9cbfe60567f0c4f Add unit tests for signals generated by ProcessNewBlock() (Jesse Cohen) bb79aaf93af93d5f9f5097cff4fbb2791af86875 Fix concurrency-related bugs in ActivateBestChain (Jesse Cohen) 0948153ea62ff4921daef326da0fddb8425cd866 Do not unlock cs_main in ABC unless we've actually made progress. (Matt Corallo) c71e535aec5aaef04764238a94e456f2405adbb5 Bugfix: ensure consistency of m_failed_blocks after reconsiderblock (Suhas Daftuar) Pull request description: Tree-SHA512: 7466b8fcc2a1d598102028019d82c581fe985a11679d002c430287851142598c9172249aa9de511a26bd4c92dc4891b5ab597c24af4f591f2158cc2a58ff7beb
2018-05-24qt: Update translations pre-rc1MarcoFalke
2018-05-24GUI: Allow generating Bech32 addresses with a legacy-address defaultLuke Dashjr
Github-Pull: #13251 Rebased-From: 82dda6bed971c5638962442b4927845fe5eb6600
2018-05-24GUI: Rephrase Bech32 checkbox text/tooltipLuke Dashjr
- "Bech32" isn't very user-friendly - You don't spend from addresses Github-Pull: #13251 Rebased-From: 7ab1c6f6a736fc7762b8dd513d8634754319d227
2018-05-24qa: Pad scriptPubKeys to get minimum sized txsMarcoFalke
Github-Pull: #11423 Rebased-From: 364bae5f7a6b16eef63990154e48f19e7e693039
2018-05-24Policy to reject extremely small transactionsJohnson Lau
A transaction with 1 segwit input and 1 P2WPHK output has non-witness size of 82 bytes. Anything smaller than this have unnecessary malloc overhead and are not relayed/mined. Github-Pull: #11423 Rebased-From: 7485488e907e236133a016ba7064c89bf9ab6da3
2018-05-24Add transaction tests for constant scriptCodeJohnson Lau
Tests showing that CONST_SCRIPTCODE is applied only to non-segwit transactions Github-Pull: #11423 Rebased-From: 0f8719bb035187076eeac025e2c786feb0f452d7
2018-05-24Add constant scriptCode policy in non-segwit scriptsJohnson Lau
This disables OP_CODESEPARATOR in non-segwit scripts (even in an unexecuted branch), and makes a positive FindAndDelete result invalid. This ensures that the scriptCode serialized in SignatureHash() is always the same as the script passing to the EvalScript. Github-Pull: #11423 Rebased-From: 9dabfe49c066301ef75bcfcb089fd308366127c4
2018-05-24Add unit tests for signals generated by ProcessNewBlock()Jesse Cohen
After a recent bug discovered in callback ordering in MainSignals, this test checks invariants in ordering of BlockConnected / BlockDisconnected / UpdatedChainTip signals Github-Pull: #13023 Rebased-From: dd435ad40267f5c50ff17533c696f9302829a6a6
2018-05-24Fix concurrency-related bugs in ActivateBestChainJesse Cohen
If multiple threads are invoking ActivateBestChain, it was possible to have them working towards different tips, and we could arrive at a less work tip than we should. Fix this by introducing a ChainState lock which must be held for the entire duration of ActivateBestChain to enforce exclusion in ABC. Github-Pull: #13023 Rebased-From: a3ae8e68739023e5dba9e5cb190e707ed4603316
2018-05-24Do not unlock cs_main in ABC unless we've actually made progress.Matt Corallo
Technically, some internal datastructures may be in an inconsistent state if we do this, though there are no known bugs there. Still, for future safety, its much better to only unlock cs_main if we've made progress (not just tried a reorg which may make progress). Github-Pull: #13023 Rebased-From: ecc3c4a019e6db30e208b8554b1a3658dcb9a80a
2018-05-24Bugfix: ensure consistency of m_failed_blocks after reconsiderblockSuhas Daftuar
Github-Pull: #13199 Rebased-From: 11fa6bb66e8c1562305d034903a0dc6aee6eea20
2018-05-24Merge #13253: [0.16] Further BackportsWladimir J. van der Laan
acdf4338221e35d5ec7b299bb18ccd953e28c985 Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip (Jesse Cohen) 5ff571e90c9fa71e189863e9cb21d15d5991f7da [wallet] [tests] Test disallowed multiwallet params (John Newbery) 4c14e7b67cd411b501e4a77385389da0afc9dd16 [wallet] Fix zapwallettxes/multiwallet interaction. (John Newbery) 4087dd08e7df5beedc335f4518b64eeab6a382c1 RPC Docs: gettxout*: clarify bestblock and unspent counts (David A. Harding) b8aacd660eb9460b6a86d4402d886f0bb32af2b4 [qa] Handle disconnect_node race (Suhas Daftuar) Pull request description: Backports: - #13201 [qa] Handle disconnect_node race - #13184 RPC Docs: gettxout*: clarify bestblock and unspent counts - #13030 [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. - #12988 Hold cs_main while calling UpdatedBlockTip() signal to the 0.16 branch. Tree-SHA512: 8f65002bbafaf9c436f89051b2d79bf6a668fbd07bd317c64af238ed4a7c8efe776864b739a7f2869f1e3daa16f2f4366a85f41b188f9c454879d2c7b309be50
2018-05-18wallet: Exit SyncMetaData if there are no transactions to syncWladimir J. van der Laan
Instead of crash with an assertion error, simply exit the function `SyncMetaData` if there is no metadata to sync. Fixes #13110. Github-Pull: #13265 Rebased-From: b0d2ca9fb66d793e3c0f2e6ede811f1b16c33a9f Tree-SHA512: 67e446e9ced901e37003a9661b6abea268e2ea648ac3b076d91c8d996de96bed389839a09d579a6562d930bcf501a091eb67454f474aae1174108a8650502072
2018-05-18Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTipJesse Cohen
Ensures that callbacks are invoked in the order in which the chain is updated Resolves #12978 GitHub-Pull: #12988 Rebased-From: d86edd3
2018-05-18[wallet] [tests] Test disallowed multiwallet paramsJohn Newbery
Add a test to check that bitcoind fails to start when specifying -zapwallettxes, -salvagewallet and -upgradewallet when running in multiwallet mode. GitHub-Pull: #13030 Rebased-From: 1f83839
2018-05-17[wallet] Fix zapwallettxes/multiwallet interaction.John Newbery
-zapwallettxes should be disallowed when starting bitcoin in multiwallet mode. GitHub-Pull: #13030 Rebased-From: 3476e3c
2018-05-17RPC Docs: gettxout*: clarify bestblock and unspent countsDavid A. Harding
GitHub-Pull: #13184 Rebased-From: f30e9be
2018-05-17[qa] Handle disconnect_node raceSuhas Daftuar
Several tests call disconnect_nodes() on each node-pair in rapid succession, resulting in a race condition if a node disconnects a peer in-between the calculation of the nodeid's to disconnect and the invocation of the disconnectnode rpc call. Handle this. GitHub-Pull: #13201 Rebased-From: 09c6699
2018-05-16Merge #12967: [0.16] BackportsWladimir J. van der Laan
8fca086 List support for BIP173 in bips.md (Pieter Wuille) 9645aa6 Remove blockmaxsize option from init.cpp (fanquake) 7847b92 Default to defining endian-conversion DECLs in compat w/o config (Matt Corallo) 1720eb3 qt:Show the entire Window when double clicking on taskbar (Chun Kuan Lee) e055bc0 depends: Fix Qt build with XCode 9.3 (fanquake) 0684cf9 Avoid launching as admin when NSIS installer ends. (JeremyRand) e802c22 [config] Remove blockmaxsize option (John Newbery) f118a7a Fix illegal default `addProxy` and `addrSeparateProxyTor` settings. (251) f60e84d Limit the number of IPs we use from each DNS seeder (e0) Pull request description: Backports: - #12626 Limit the number of IPs addrman learns from each DNS seeder - #12650 gui: Fix issue: "default port not shown correctly in settings dialog" - #12756 [config] Remove blockmaxsize option - #12985 Windows: Avoid launching as admin when NSIS installer ends. - #12946 depends: Fix Qt build with XCode 9.3 - #12998 Default to defining endian-conversion DECLs in compat w/o config - #12999 qt: Show the Window when double clicking the taskbar icon - #13064 List support for BIP173 in bips.md to the 0.16 branch. Tree-SHA512: 3e6b47c54b2cd2bdd81fbc6176cb31e46423f6e05988984d3a09b3535e3cee101ffb071cf753a4beff3c9f0521eb5de4b7c0424a3e97da801d56b4015847ac0f
2018-05-03List support for BIP173 in bips.mdPieter Wuille